eldbus: Check return value and error out if necessary

Coverity reports that we do not check the return value of
_eldbus_model_proxy_load here. We likely should be checking that in
case the model proxy fails to load so we can return proper values here.

Fixes Coverity CID1355233

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
This commit is contained in:
Chris Michael 2016-07-21 12:50:19 -04:00
parent 4555f5d594
commit fb09df7977
1 changed files with 5 additions and 1 deletions

View File

@ -98,9 +98,13 @@ static Eina_Array const *
_eldbus_model_proxy_efl_model_properties_get(Eo *obj EINA_UNUSED,
Eldbus_Model_Proxy_Data *pd)
{
Eina_Bool ret;
EINA_SAFETY_ON_NULL_RETURN_VAL(pd, NULL);
_eldbus_model_proxy_load(pd);
ret = _eldbus_model_proxy_load(pd);
if (!ret) return NULL;
return pd->properties_array;
}