Commit Graph

71 Commits

Author SHA1 Message Date
Elyes HAOUAS 47b71d898e Get rid of trailing whitespaces (13 / 14)
Remove trailing whitespaces
Differential Revision: https://phab.enlightenment.org/D12012
2020-06-23 10:31:36 +02:00
Marcel Hollerbach 44a33c2dad meson: support unified suffixes for modules
A long story in a few words: sometimes on macos modules will be compiled
into .dylib, sometimes, into .so suffix. We did not set the suffix
everywhere in our meson build instructions, hence our suffixes have been
differently, which resulted in random load fails on different maschines.

With this commit, we ensure that we suffix all modules the same way.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11650
2020-04-07 10:58:17 +02:00
Marcel Hollerbach f5063b8733 meson: add xkbcommon to the build deps
Summary: fix T8064

Reviewers: cedric, zmike, devilhorns

Reviewed By: devilhorns

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8064

Differential Revision: https://phab.enlightenment.org/D9573
2019-08-15 15:36:29 -04:00
Jihoon Kim f5ee2e3bb8 ecore_imf: remove code to use deprecated API in wayland immodule
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
2019-07-15 11:37:53 +09:00
Carsten Haitzler c18d45816d ecore imf - wl - fill all stgruct fields with something... 2018-11-09 11:44:00 +00:00
Marcel Hollerbach 46d464e5bf here comes meson
a new shiny buildtool that currently completes in the total of ~ 4 min..
1 min. conf time
2:30 min. build time
Where autotools takes:
1:50 min. conf time
3:40 min. build time.

meson was taken because it went quite good for enlightenment, and is a traction gaining system that is also used by other mayor projects. Additionally, the DSL that is defined my meson makes the configuration of the builds a lot easier to read.

Further informations can be gathered from the README.meson

Right now, bindings & windows support are missing.

It is highly recommented to use meson 0.48 due to optimizations in meson
that reduced the time the meson call would need.

Co-authored-by: Mike Blumenkrantz <zmike@samsung.com>

Differential Revision: https://phab.enlightenment.org/D7012
Depends on D7011
2018-10-02 17:22:50 +02:00
Derek Foreman 0fe553cf06 ecore_wl2: Remove ecore_wl2_display_window_find
Summary:
This is now totally trivial and needs not exist.
Depends on D6522

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6523
2018-07-06 10:16:36 -04:00
Derek Foreman 78f27a3eff ecore_wl2: Replace window ids with pointers
Summary:
There's no benefit to generating ids instead of just using the
Ecore_Wl2_Window pointer in events.

This has the added benefit of working around a really nasty hash collision
bug when multiple ecore_evas engines are used at once.

ref T7053
ref T6222

@beta_break
Depends on D6521

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #committers, zmike

Tags: #efl

Maniphest Tasks: T7053, T6222

Differential Revision: https://phab.enlightenment.org/D6522
2018-07-06 10:16:21 -04:00
Derek Foreman 38d8ae0217 wayland_imf: Clear hide timer when deleting context
Otherwise the callback can fire after the module is unloaded leading to some
very entertaining to debug crashes at shutdown.
2018-02-09 11:12:07 -06:00
Ross Vandegrift 71e5c74eb6 efl: drop deprecated Encoding key from desktop files
Summary:
The Encoding key is no longer required, all desktop files are assumed to
be UTF-8 encoded.  See details at:
https://standards.freedesktop.org/desktop-entry-spec/1.1/apc.html

Fix various typos and misspellings

lintian, Debian's package checker, uses strings to check for common typos
in compiled binaries.  This change fixes the ones it identified in 1.20.6.

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5584

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2017-12-13 10:27:48 -08:00
Jihoon Kim 723dfaebd1 ecore_imf/wayland: Check the return value of memory allocation function 2017-08-12 10:24:36 +09:00
Bryce Harrington e0a6eaeaa3 ecore-imf-wayland: Check xkb_keysym_to_utf8
Summary:
Coverity reports an error "Calling "xkb_keysym_to_utf8" without checking
return value (as is done elsewhere 4 out of 5 times)."

fixes: cid1375673

Reviewers: zmike

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D4936
2017-06-02 19:06:31 -04:00
Mike Blumenkrantz 2fe7878235 wayland: move pointer-related functions to ecore_wl2_input namespace
windows do not have pointers or cursors under wayland, seats do. due to
lack of multiseat support, most components simply use the "default" seat
with these functions, but this should make the corresponding code more
easily adaptable
2017-05-19 12:41:17 -04:00
Chris Michael e6b26d2279 ecore-imf-wayland: Reduce calls to set_cursor_rectangle
Avoid calls to zwp_text_input_v1_set_cursor_rectangle if we do not
need to. Previous code here would always call this function even if
the cursor rectangle was in the same position. Now we set a flag on
the cursor_location field to let us know that it needs updating.

ref T5226

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2017-02-28 10:22:58 -05:00
Chris Michael f877c46ad8 ecore-imf-wayland: Remove duplicate header include
wayland_imcontext.h already includes this header, so no need to
re-include. Also add missing (void) to function declaration

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2017-02-28 09:28:24 -05:00
Chris Michael 6d4357d943 ecore-imf-wayland: Formatting fixes
NB: No functional changes

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2017-02-28 09:16:22 -05:00
Jihoon Kim a1da126220 ecore_imf/wayland: Fix memory leak in immodule
==1321== 156 bytes in 1 blocks are definitely lost in loss record 7,687 of 9,703
==1321==    at 0x4847E64: calloc (vg_replace_malloc.c:623)
==1321==    by 0x92EA7E9: wayland_im_context_new (wayland_imcontext.c:1094)
==1321==    by 0x92E66DD: im_module_create (wayland_module.c:132)
==1321==    by 0x4D521E7: ecore_imf_module_context_create (ecore_imf_module.c:152)
==1321==    by 0x4D51EF7: ecore_imf_context_add (ecore_imf_context.c:141)
2017-02-27 21:31:07 +09:00
Derek Foreman 05124250c5 ecore_imf/wayland: Auto generate wayland text-input protocol
Needed to do some fairly invasive changes because naming conventions
changed since we checked in the header.

Also, since I'm done converting protocol, change the gitignore to
use wildcards for wayland protocol.

This fixes a long standing bug in text-input binding and restores
previous OSK behaviour.
2017-01-18 13:21:01 -06:00
Jihoon Kim 5bb9294966 ecore_imf: remove unnecessary exported symbols in immodules
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
2017-01-09 10:22:58 +09:00
Jihoon Kim 2b8d93a5d1 ecore_imf: Add multiline hint in input hint
@feature
2016-05-18 15:21:12 +09:00
Jihoon Kim 988fe37232 ecore_imf/wayland: Change sequence to call preedit changed and end callback
preedit changed and end callback should be called before commit callback
2016-05-17 08:34:17 +09:00
Jihoon Kim 8c1776d177 ecore_imf/wayland: Fix bug language changed event is always called 2016-04-18 14:51:46 +09:00
Li Zhang 7ad6c34a2c Add ECORE_IMF_CALLBACK_DELETE_SURROUNDING
Change-Id: I0e1ab14736a3d3849becb7cbeea81fe7b61053b7
2016-03-29 20:17:13 +09:00
Jihoon Kim 161883291c ecore_imf/wayland: fix IME flickering issue when input_panel_hide and show is called sequentially
Change-Id: Ieafa9cd921cc8d68c64af6b72404ef52e7bbf724
2016-03-24 20:46:15 +09:00
Jihoon Kim ce17d5d987 ecore_imf/wayland: use default preedit style
Change-Id: Iffb2d450923bbde191c4928253f133b13608a8e8
2016-03-21 19:51:31 +09:00
Jihoon Kim 662389f39b ecore_imf/wayland: send cursor position before requesting to show 2016-02-12 10:18:05 +09:00
Jihoon Kim af8bf0ddbc ecore_imf/wayland: Fix not to show IME in touching entry after hiding IME 2016-02-12 09:36:41 +09:00
Haifeng Deng 4b777ec184 ecore_imf/wayland: Fix IME hide -> show issue in case of focus-out and then focus-in
Change-Id: I1d3d7023dbd10b78f510380ff3c46087228f9180
2016-02-04 14:28:29 +09:00
Jihoon Kim a57d301f2a ecore_imf/wayland: do not check input panel enable in show or hide
Input panel enable is already being checked in ecore_imf API.
2016-02-04 13:59:09 +09:00
Jihoon Kim 584a5a32a2 ecore_imf/wayland: support to set prediction allow mode 2016-02-04 12:00:45 +09:00
Jihoon Kim b1336a27c1 ecore_imf/wayland: notify language changed 2016-02-04 11:58:03 +09:00
Jihoon Kim 7564d49a83 ecore_imf/wayland: Add support to get input panel language locale 2016-02-04 11:56:13 +09:00
Chris Michael 1b12e8598a ecore-imf-wayland: Remove trailing whitespace
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-12-03 12:02:40 -05:00
Chris Michael bc7a45ffe2 ecore-imf-wayland: Use ecore_wl2_display_window_find API function
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-12-03 12:02:40 -05:00
Chris Michael cc29eb432e ecore-imf-wayland: Disconnect display when we close the module
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-12-03 12:02:40 -05:00
Chris Michael da260bd5a5 ecore-imf-wayland: Port ecore_imf_wayland to use Ecore_Wl2
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-12-03 12:02:40 -05:00
Carsten Haitzler 14d5fde2d7 ecore imf - fix modules that are x11 based to only load in x11 and in wl
use env vars to determine module init for ecore-imf so you don't have
things like e locking up trying to init scim when running in wl mode.
do the same for ibus and xim modules too. do the inverse for wayland
imf module but here add also the check for ELM_DISPLAY that wasn't
there (like it is now in the other modules) so it is only initted on
wayland.

@fix
2015-10-31 11:40:05 +09:00
Seunghun Lee 261f083c4e ecore_imf/wayland: Add NULL check for text_input_manager.
Summary: this patch fixes crash caused by accessing the text_input_manager in wayland_im_context_add().

Test Plan: N/A

Reviewers: jihoon

Reviewed By: jihoon

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D3176
2015-10-15 14:16:56 +09:00
Jihoon Kim bae1c701ba ecore_imf/wayland: Add NULL check before accessing 2015-06-16 16:28:16 +09:00
Jihoon Kim b8bcc35f7a ecore_imf/wayland: support on-demand show mode
In on-demand show mode, input panel will be shown in case of only an user's explicit Mouse Up event.
It doesn't request to show the input panel even though the Input Method Context has focus.
2015-06-09 14:30:07 +09:00
Jihoon Kim 15814ccccb ecore_imf/wayland: support input language mode in wayland text input
@feature
2015-05-28 13:13:25 +09:00
Jihoon Kim 7240a71d33 ecore_imf/wayland: support input hint in wayland text input
@feature
2015-05-28 11:35:05 +09:00
Jihoon Kim 85166a0c73 ecore_imf/wayland: support password mode in wayland text input
@feature
2015-05-28 10:05:11 +09:00
Jihoon Kim c5f0eea83d ecore_imf/wayland: support autocapital mode in wayland text input
@feature
2015-05-27 14:39:37 +09:00
Jihoon Kim 21106fd5f0 ecore_imf/wayland: support feature to change layout of virtual keyboard 2015-05-20 18:47:58 +09:00
Jihoon Kim 82bb9c9c1e ecore_imf/wayland: hide input panel explicitly in focus-out handler 2015-05-19 19:19:54 +09:00
Marcel Hollerbach c77812d8b0 ecore_imf: init wayland before using wayland calls.
Summary:
ecore_imf: init wayland if wayland env var exists

Otherwise ecore-wl functions could return some invalid values. The env var check to avoid error messages.

@fix

Reviewers: Sergeant_Whitespace, devilhorns

Reviewed By: Sergeant_Whitespace

Subscribers: Sergeant_Whitespace, cedric

Differential Revision: https://phab.enlightenment.org/D2253
2015-04-21 10:06:39 -04:00
Jean-Philippe ANDRE 0ef41604e8 Ecore: Use calloc() to initialize Ecore_Event_Key fully
Some fields (eg. data) may not be properly initialized.
Use calloc() instead of malloc() will ensure proper initialization
even if we add more fields.

These fields (data) would even be passed down to Evas as
Evas_Event_Key_Down for instance.
2015-03-25 15:34:23 -07:00
Jihoon Kim 83d57bc6f8 ecore_imf/wayland: Use simple code to fix infinite loop bug related to ibus-hangul 2014-10-10 10:01:53 +09:00
Jihoon Kim d56c2654f3 ecore_imf/wayland: fix infinite loop bug when ibus-hangul is used
When korean language was typed with ibus-hangul,
wayland immodule falled into the infinite loop.
2014-10-08 14:24:14 +09:00