I just ran my script (email to follow) to migrate all of the EFL
automatically. This commit is *only* the automatic conversion, so it can
be easily reverted and re-run.
this was previously disabled for internal list objects, and now
it is disabled for all subobjects of ctxpopup. applying focus here
invokes every possible focus bug in elementary and prevents the application
from being useful in any way
ref 974c8b05a4c97367b636593f5420ff01e8364aac
ref T3088
@fix
conceptually, ctxpopup won't give any geometry information of the container.
this event is a way for returning the information of the container for user scenarios.
@feature.
fix @T2042
Summary:
The use of elm_widget_type_get here is pretty harmfull, for the usecase
of inheriting a widget elm_widget_type_get is something else than
before. But the key binding should still work.
@fix T2891
Reviewers: tasn
Reviewed By: tasn
Maniphest Tasks: T2891
Differential Revision: https://phab.enlightenment.org/D3470
When the focus is moved, it uses focus_direction instead of
focus_origin.
It can get the focus by using the geometry of previous focused object or item
@feature
Add elm_object_focus_next_item_set/get,
elm_object_item_focus_next_object_set/get and
elm_object_item_focus_next_item_set/get.
If the item and object is set at the same time,
the item is preference to object when the focus moves.
This feature is implemented about gengrid.
It will be implemented about ohter widgets.
@feature
i found that the focus doesnt auto-show when focusing things inside
scrollers and so on. i had to add more points to trigger auto show.
this fixes that
@fix
Summary:
Since this patch ctxpopup is able to report its size which is equal to 1 element of list.
This can be treated as another bug (list visibility implementation must be so list will be counting its size dynamic on every item add)
Might be also ignored.
Test Plan:
1. Use application provided in T2042 (should have coordinates greater then 0).
2. Using atspi check is accessible element is visible. (with patch ctxpopup will be visible, without ctxpopup and its children will have status visible and showing set to FALSE)
Reviewers: raster, seoz, Hermet
Subscribers: m.jagiello
Projects: #elementary
Maniphest Tasks: T2042
Differential Revision: https://phab.enlightenment.org/D2045
This change is not simple because Elementary has not been built from the
first day to work with Eo. Code had to be adapted to fit the new design.
The del_pre that have not been replaced yet can return FALSE and
prevent deletion. For these classes, code modification has to be deeper
and will be done later.
Summary:
Change requested by TAsn. Previuosly AT-SPI headers were kept private
and included directly into elementary source code. From now on,
AT-SPI headers can be included from Elementary.h public header, however
will be marked as beta APIs.
Commit includes following changes:
* include all atspi headers into new elm_interfaces.h header.
* marking all at-spi interfaces methods/properties as @protected.
* wrap all common headers with EFL_BETA_API_SUPPORT.
* make some common APIs visible in lib, by adding EAPI attribute
(if someone decides to use beta APIs).
Test Plan: out-off tree build with gcc, g++
Reviewers: tasn
Reviewed By: tasn
Subscribers: seoz, q66, kuuko
Maniphest Tasks: T1721
Differential Revision: https://phab.enlightenment.org/D1528
Summary:
In case, when ctxpopup content have larger size than parent object, (by height, width or both) was resized popup at the full width or height of parent object size.
@fix
Reviewers: raster, seoz, cedric, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D1266
Summary:
Main purpose of exposing widget actions and keyboard shortcuts
is to allow accessibility clients to implement alternative methods
of GUI navigation.
Reviewers: z.kosinski
Reviewed By: z.kosinski
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1227
Summary: API to get list of ctxpopup items and give the possibility to iterate the ctxpopup items
Reviewers: stanluk, z.kosinski, Hermet, seoz, raster
CC: Hermet, seoz
Differential Revision: https://phab.enlightenment.org/D1055
Summary:
The original code was missing
- null check of sd->box
- event_flag value set
for previous and next focus move.
@fix
Test Plan: None
Reviewers: raster, seoz, Hermet
Differential Revision: https://phab.enlightenment.org/D753
we can prevent to handle the widget events from the widget infra,
if the object is disabled.
conceptually, disabled object should not be interacted to user input(key, mouse)
As the comment in the code explains, when ctxpopup is shown, it's giving
focus to the inner list, which immediately decides to select the first
of its items, calling, in the process, its selection callback. This has
the very unfortunate, annoying and uselessly broken effect of making the
popup never showing up, and instead triggering the first action in it.
Since this behavior of "select first item on focus" seems to be the path
taken in other places, I'm letting the people that know what they want
to do about that figure out how to fix it properly.
Summary:
Developer can use this API for the case when he/she wants ctxpopup not to hide
automatically when parent of ctxpopup is resized or language is changed.
Default value of "disabled" is EINA_FALSE. So if user sets "disabled" EINA_TRUE
and parent size changes, ctxpopup recalculates its size and position.
Since size of bg is set when setting parent only, it should be resized again.
Reviewers: Hermet, seoz, thiepha, raster
CC: c
Differential Revision: https://phab.enlightenment.org/D510
Some widgets override the widget translation but it didn't inherit the base widget's function.
Becuase of it,The language changed won't be properly called in the widget tree.
Now it fixed it.
Call the smart callback in the widget infra so that each widget don't need to hook the smart_translate only for the smart call.
This makes reducing duplicated code and supporting language,chagned from all widgets.
Tom Hacohen
Mike Blumenkrantz
Hermet Park
Marcel Hollerbach
Daniel Juyung Seo
Jaehwan Kim
Carsten Haitzler
Lukasz Stanislawski
Avi Levin
Amitesh Singh
Daniel Zaoui
Daniel Kolesa
Mykyta Biliavskyi
Michal Jagiello
Zbigniew Kosinski
Ryuan Choi
zmike
Jaeun Choi
Iván Briano
Chris Michael
Bora Hwang
WooHyun Jung