Commit Graph

559 Commits

Author SHA1 Message Date
woochan lee 4033c8f587 widget: Add a case that elm_layout is an item view object.
Summary:
The internal API "_elm_widget_item_highlight_in_theme()" look like for list item highlight.
but it can use in another widget which has item view as elm_layout.
In that case, ERR log will be printed.

Reviewers: singh.amitesh, Hermet, woohyun

Differential Revision: https://phab.enlightenment.org/D2736
2015-06-23 08:30:22 +09:00
Thiep Ha 8677ef1add widget: Add null check
Summary: Adding NULL checking when allocate memory.

Reviewers: Hermet, seoz, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D2663

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-11 15:15:35 +02:00
Lukasz Stanislawski 166d8c2db8 atspi: fix popup role and signal emission 2015-06-05 16:00:30 +02:00
Daniel Zaoui 9ab2ab73fe Focus: add and fix comments 2015-06-02 08:46:55 +03:00
WooHyun Jung 98060bd8da elm_focus: added new focus move policy and elm_object_focus_move_policy_set/get
New focus move policy, ELM_FOCUS_MOVE_POLICY_KEY_ONLY, is added.
If you set this policy as base focus move policy, objects cannot steal
focus by using mouse click or mouse in. Only keyboard input (such as Left,
Right, Up, Down, ...) can make focus be moved.
Additaionally, an object can have its own focus move policy by using
elm_object_focus_move_policy_set API.

@feature
2015-06-02 13:42:00 +09:00
Tom Hacohen c56d494f2f Fix usage of the now removed eo_error_set().
This API has been removed from Eo.
2015-05-20 16:31:42 +01:00
Tom Hacohen 27b72840c8 Adjust usage of eo_constructor() according to recent changes. 2015-05-20 13:03:28 +01:00
Lukasz Stanislawski 8062db6ab1 atspi: improve way of setting ATSPI SHOWING state
After this patch calculation of the atspi SHOWING state takes into
account also viewport of any parent implementing ELM_INTERFACE_SCROLLABLE.
2015-05-20 12:01:27 +02:00
ChunEon Park 74f0424f3e widget: more fix wrt item data.
widget item data is no more used.
use eo item data instead.

@fix.
2015-05-18 17:15:09 +09:00
Jee-Yong Um a522fa1b99 elm_object_item: fix the issue that del_cb doens't get item data as its parameter
Summary:
elm_object_item_del_cb_set() can set delete callback that is called on item deletion.
Del_cb, Evas_Smart_Cb, has void pointer for item data as its first parameter.
However, getting item data is broken.

@fix

Reviewers: Hermet

Reviewed By: Hermet

Subscribers: Hermet

Differential Revision: https://phab.enlightenment.org/D2524
2015-05-18 17:10:09 +09:00
Lukasz Stanislawski 31545f69f8 atspi: set FOCUSABLE state only when widget has no focusable children
AT-SPI2 specification states that active window can have only one widget
with FOCUSED state. This differs from elementary design which assumes
that whole elementary widget tree branch is focused.
Patch assumes that if a widget have no focusable children and can have
focus it can be marked as FOCUSABLE on atspi bus.
2015-05-13 15:39:24 +02:00
Lukasz Stanislawski 06f97cd1af atspi: do not return ELM_ATSPI_STATE_ACTIVE when widget is enabled.
According to atspi specification ATSPI_STATE_ACTIVE is reserved
only for windows having keyboard focus.
2015-05-13 15:39:24 +02:00
Lukasz Stanislawski c306271bc3 atspi: handle state change notifications in on_focus function 2015-05-13 15:39:24 +02:00
Lukasz Stanislawski 5d61fe27d4 atspi: add component interface to elm_widget_item objects. 2015-05-12 15:31:20 +02:00
Lukasz Stanislawski 9e970814d5 atspi: changed del event broadcast. Fix genlist & gengrid tests 2015-04-06 10:25:02 +02:00
Lukasz Stanislawski 53afc0f2ca atspi: fix mem leaks spotted in valgrind. 2015-04-06 10:25:02 +02:00
Lukasz Stanislawski ea1f1d9c36 atspi: delay registration of atspi object until its shown 2015-04-06 10:25:01 +02:00
Lukasz Stanislawski 33ea156e8b atspi: allow to override default Elementary objects hierarchy 2015-04-06 10:25:01 +02:00
Lukasz Stanislawski c272f9b084 widget: use ATSPI protected functions. 2015-04-06 10:24:59 +02:00
Lukasz Stanislawski f7686dfd0e atspi: add text tags filtering 2015-04-06 10:24:59 +02:00
Lukasz Stanislawski e663ee3167 atspi: improva child add/del broadcasting.
This commit enables generic broadcasting of changes in widget hierarcies.
Previously this kind of broadcasting had to be implemented inside widget.
This solution is using elm_widget sub_obj_add/sub_obj_del functions.
2015-04-06 10:24:59 +02:00
Lukasz Stanislawski 18bd62002b atspi: remove elm_interface_atspi_widget implementation.
elm_interface_atspi_widget object was previously used to implement
atspi features on top of elm_widget object. However such inheritance
obfuscates a design, so atspi features implementation was moved directly
into elm_widget code.
2015-04-06 10:24:58 +02:00
Lukasz Stanislawski 64374b68e8 atspi: improve atspi support for elm_list
Now elm_list_items are normal atspi objects and provide information
about it label and 'start' and 'end' internal objects.
2015-04-06 10:24:57 +02:00
Lukasz Stanislawski 7a7cc2094c atspi: implement add/del callbacks. Add genlist item tests 2015-04-06 10:24:57 +02:00
Lukasz Stanislawski 08549d134e atspi: make eo_widget_item accessible object 2015-04-06 10:24:56 +02:00
Jaehwan Kim 9c26cdf25a elm_widget: fix wrong parmeter.
The parameter what the application gets should Elm_Object_Item.

@fix
2015-03-19 16:47:24 +09:00
ChunEon Park dc01331903 Revert "widget: fix the abi break."
This reverts commit 841fcdfb18a414a7381910bcbb0b0ef4807bc5c2.

It's been too much passed.
we have more dependencies to the change (ie, key bindings)
so conclude to have the abi break in this case.
2015-03-17 15:46:19 +09:00
ChunEon Park 622fe4c5da widget: fix the abi break.
Widget type string should be all lower-cases!

This acutally was caused in 7b10fdb8f39c3b36f575dd22d26a1efe6ecd28ec

@fix
2015-03-13 17:46:00 +09:00
Carsten Haitzler 17ffbd6448 elm - focus feature - add config option to automatically show/hide focus
this adds logic in elm widget and elm win to figure out how to
automatically show a focus hilight when switching focus, or to hide
it. this really should be the default mode, thus in all default
profiles (default, standard, mobile) it's turned on. this means if you
tab or shif+tab or use arrow keys to switch focus, the focus hilight
will magicallly appear. click with a mouse to change focus and it'll
disappear assuming you want to use the mouse to do things. If focus is
explicitly turned on in config or in the window by api, then this has
no effect and focus will remain on all the time. this adds apis to
change these config values and options in the default elm config tool
to swizzle them as well as config upgrade handling for existing configs.

@feature
2015-03-04 17:47:54 +09:00
kabeer khan 2d7cb99e9b elm_widget: added evas smart callback descriptions
Summary:
Resolved FIXME filled all smart callbacks and also set it in the constructor

Signed-off-by: kabeer khan <kabeer.khan@samsung.com>

Reviewers: seoz

Differential Revision: https://phab.enlightenment.org/D1876
2015-02-09 10:40:29 +09:00
WooHyun Jung c8f6d47e0f widget: elm_win can be unfocused only when its ecore_evas loses focus. 2015-01-17 16:29:46 +09:00
ChunEon Park 52e7a6b97f widget: set missing elm_widget_item_magic 2015-01-14 19:50:15 +09:00
shilpa.singh 92deae574a elm_widget: elm_object_disabled_set API fix
Summary:
When elm_object_disabled_set API is called on any widget, All the
subobjects of the widget also has to be disabled issue fix.
@fix

Test Plan:
Call the API elm_object_disabled_set on any container widget like box,
layout etc:-, fix can be tested with test_box.c and test_layout.c test
codes.

Reviewers: Hermet, seoz, raster

Subscribers: govi, rajeshps

Differential Revision: https://phab.enlightenment.org/D1778
2015-01-08 16:06:35 +09:00
Jaehyun Cho a51561c999 elm_widget: Pass Elm_Object_Item *item as *event_info in item->del_func.
Summary:
Pass Elm_Object_Item *item instead of Elm_Widget_Item_Data *item as
         *event_info in item->del_func to let *event_info be used.
         @fix

Reviewers: Hermet

Differential Revision: https://phab.enlightenment.org/D1788
2014-12-18 14:42:45 +09:00
Sanjeev BA 00cbb2a2e2 Multibutton entry - handle parent object null case.
Reviewers: seoz, Hermet

Subscribers: Hermet, seoz

Maniphest Tasks: T1379

Differential Revision: https://phab.enlightenment.org/D1254
2014-12-15 17:47:06 +09:00
Daniel Juyung Seo 726c17b399 widget: Add error message when the parent parameter was set wrongly.
This helps application developers debug their apps easier.
2014-11-25 22:09:58 +09:00
zmike 0c933506a8 widget tooltip creation should also pass the eo item to the callback
ref T1859
2014-11-23 11:30:30 -05:00
Daniel Juyung Seo 4406302421 elm: Modify document for APIs.
Retrieve -> Get as the API says.
This is not a critical change but was done due to the consistency.
2014-11-19 19:51:57 +09:00
Daniel Zaoui 05225b162e Object Items: remove data variable from widget item.
Now, data is stored in Eo layer via eo_key_data_set/get.

Two macros have been added to facilitate access.
2014-11-12 12:03:58 +02:00
Daniel Zaoui 9d50d391a0 Object Items: Adapt del callback to Eo.
Because of widget item design, it is hard to make it fit to Eo as it
should be:
- _eo_del_cb should have the callback pointer as data but pre_notify
function forces its storage into the item data because we need to be
able to call the cb before del is really triggered.
- only one cb is supported for an item, meaning replacing it would mean
we have to save the function pointer inside the item, delete the
callback with the previous function as data and then add the new
callback. Instead of it, we just add our own wrapper as Eo callback that
will invoke the function pointer stored in the item data.
2014-11-12 12:03:58 +02:00
Daniel Zaoui b01d01528a Object Items: remove casts that are no more needed.
It includes casts to Eo, Elm_Object_Item and to specific items data.
This belongs to the cleaning phase of the object items porting to Eo.
2014-11-12 12:03:57 +02:00
Daniel Zaoui 4618dab968 Object Items: remove old inheritance mechanism. 2014-11-12 12:03:57 +02:00
Daniel Zaoui a9b13f7633 Elm Widget Item: Migrate to Eo
Since we want to support legacy inheritance mechanism, code is not
finished and will have to be cleaned when all the items are ported.
2014-11-12 11:52:10 +02:00
Amitesh Singh 08237a1000 widget: fix the typo. Use win object instead.
Summary: @fix

Reviewers: seoz, raster

Subscribers: seoz

Differential Revision: https://phab.enlightenment.org/D1645
2014-11-07 02:23:30 +09:00
artem.popov 341160133b elm_widget: fix segfaults for _elm_widget_item_style_set/get
Summary:
Changing of styles for widget items isn't realized yet. This fix should
be presented to avoid segfaults when elm_object_item_style_set/get is calling
@fix

Reviewers: seoz, raster, cedric, Hermet

Reviewed By: Hermet

Subscribers: bluezery

Differential Revision: https://phab.enlightenment.org/D1595
2014-10-31 15:24:43 +09:00
Amitesh Singh 797e75bb4f widget: fix seg fault when ts is NULL.
Summary:
if translatable is FALSE and _translate_string_data_get returns NULL, ts
would be NULL which results into crash.

@fix

Reviewers: seoz, raster, Hermet

Reviewed By: Hermet

Subscribers: seoz

Differential Revision: https://phab.enlightenment.org/D1543
2014-10-19 14:56:15 +09:00
Lukasz Stanislawski 2ca1f8a75a atspi: properly include at-spi headers.
Summary:
Change requested by TAsn. Previuosly AT-SPI headers were kept private
and included directly into elementary source code. From now on,
AT-SPI headers can be included from Elementary.h public header, however
will be marked as beta APIs.

Commit includes following changes:
* include all atspi headers into new elm_interfaces.h header.
* marking all at-spi interfaces methods/properties as @protected.
* wrap all common headers with EFL_BETA_API_SUPPORT.
* make some common APIs visible in lib, by adding EAPI attribute
  (if someone decides to use beta APIs).

Test Plan: out-off tree build with gcc, g++

Reviewers: tasn

Reviewed By: tasn

Subscribers: seoz, q66, kuuko

Maniphest Tasks: T1721

Differential Revision: https://phab.enlightenment.org/D1528
2014-10-17 16:57:26 +01:00
Amitesh Singh d6f308d1d6 focus: Added internal widget APIs of focus highlight object of elm window.
Summary: This is required to support the animation of focus highlight object in case of item looping (genlist/gengrid/list).

Reviewers: seoz, woohyun, raster

Reviewed By: raster

Subscribers: anand.km, seoz

Differential Revision: https://phab.enlightenment.org/D1136
2014-07-21 19:04:27 +09:00
Amitesh Singh 6de233cfdb widget item: replaced eo_class_name_get call with eo_isa.
Reviewers: seoz, raster, Hermet

Reviewed By: Hermet

Subscribers: seoz

Differential Revision: https://phab.enlightenment.org/D1170
2014-07-15 12:11:51 +09:00
Cedric BAIL 81cff04884 widget: move some callback infrastructure tu use Eo directly.
This save some serious amount of memory quite easily.
2014-07-06 19:08:56 +02:00