Summary:
When the scroller size changes by dragging the
corners, the calculations will miss the condition "x+w == x1 + w1".
This is because of format specific computer calculations. So,
improvisation is made in comparisons.
@ fix
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
Test Plan:
elementary_test -> scroller -> scroll to the extreme right (right arrow brightness changes).
Now, drag the lower right corner to increase the width of scroller. Drag the corner slowly to see the issue clearly.
The arrow brightness changes alternatively, instead the hbar is positioned to the extreme right.
Reviewers: Hermet, cedric, raster
Subscribers: singh.amitesh, eagleeye, SanghyeonLee, sachin.dev
Differential Revision: https://phab.enlightenment.org/D2796
Summary:
Currently, hoversel shows all items at the same time, but to limit
the size of contents and make it scrollable is neccesary to some users.
elm_hoversel_scroll_enabled_set/get() API makes the contents of hoversel
scrollable or not.
Test Plan:
The newly added scroll function is enabled for the second hoversel
in "hoversel" sample of elementary_test.
Reviewers: Hermet, raster, herdsman, cedric, tasn
Subscribers: JackDanielZ, cedric, Hermet
Differential Revision: https://phab.enlightenment.org/D2603
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
There is no way to give padding between each items, previously.
So i added horizontal, vertical padding here.
I will add APIs for set, get padding size set, get.
@feature
Test Plan:
Change the horizontal, vertical paddidng value in multibuttonentry.edc
Run elementary_test
Execute multibuttonentry sample.
Add items.
Check the padding between items.
Reviewers: woohyun, seoz, Hermet, raster
Reviewed By: Hermet, raster
Subscribers: raster
Differential Revision: https://phab.enlightenment.org/D2534
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Even user sets empty string here for text, label still packed in box with min size(finger size).
label_set internal logic is not clear before.
ex: object min set, resize check the string length then sending signal, min set again.
so i deleted the signal emit code here, we can handle label show, hide status in code and it's more clear.
Besides "sd->label" is always true all of the case. we need to check whether it's packed or not.
The label will be added to parent's sub object when it's packed into box.
label_set as empty string in adding time also meaningless.
@fix
Test Plan:
Run multibuttonentry sample.
Set a text somthing for it then set an empty string here.
Reviewers: Hermet, woohyun
Differential Revision: https://phab.enlightenment.org/D2841
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
* convert opaque region theme part to SPACER
- add rels for shaded/maximized state
* namespace opaque region theme part
* update opaque region only on pre-render
- fixes race condition between render size and opaque size
ref T2575
Summary: This fix adjusts the shadow spacer elementary when we
maximize/unmaximize a window. When in a maximized state, we do not
have to reserve space for the window shadow. This partially fixes
T2578. I say partially because there is still a little bit of blank
space around a maximized window.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: This patch fixes opaque region setting under wayland in a
more proper/accurate way. This now sets the opaque region to be Just
what is visible (ie: only the dialog).
NB: This does not actually fix T2575 as that problem is inside E itself.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: Elementary does not support toggling of shadows on windows,
but Enlightenment does so we need to use the proper program signal for
that.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: This fix addresses the issue of Elementary's Wayland border
theme not match close enough to E's. Now they are very much identical
with the exception of the program and signal names.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: This adjusts the focus frame of Elementary applications to
more closely match what is done in X11. T2575 says that the focus
rectangle was larger than expected by a few pixels, so this slight
adjustment compensates for that.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary:
Show days of previous and next month on the blank area of calendar.
@feature
Test Plan: See calendar widget on elementary_test.
Reviewers: raster, seoz, woohyun, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2728
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
nearly everything in e is square except for this, which was a holdover from the
b&w theme. the new image looks more coherent with the rest of the square look
image created by me, licensing to match rest of theme images
@feature
someone.. somewhere along the way.. likely a long time ago.. broke
compress mode. likely the addition of the ellipsis value as an
ellipsis position or something related to that broke compatibility,
as this used to work. be that as it may... finding out just where is
virtually impossible, so fix it the simpler way - add elipsis values
the paper with earmarked corner and dir in it just doesn't stand out.
too plain and so you can't tell dirs from other files easily at all.
replace with a more normal foler icon that now stands out.
Summary: The "closed_height" is not using in code.
Reviewers: raster, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2535
Summary:
When popup has a content which is larger than window size, popup is to be larger than window.
so, scroller is added into popup content area.
Test Plan:
1. Making "elementary_test - popup" window smaller than popup content size.
2. Excute "popup-center-title + genlist content + 1 button" in "elementary_test popup"
After applying this patch.
3. popup content shows with scroller.
Reviewers: Hermet, seoz, woohyun, raster
Subscribers: raster
Differential Revision: https://phab.enlightenment.org/D2216
Summary:
Checkbox should support a third state "indeterminate" along with "Checked" and "Unchecked"
This third state is a state of checkbox which is shown when checkbox is neither Checked nor Unchecked.
- Added this new feature on the basis of a boolean variable's value.
- By default this boolean variable is disabled and checkbox will treat like old way.
- While adding this, I kept in mind, that applications which are already using checkbox, should not be affected, so I used 0=False=Unchecked, 1=True=Checked, and 2=Indeterminate
- Also added an example check_example_o2.c, which is using checkbox with both ways, using boolean, and using enum.
- Now also values can be set using boolean values, but it will give a type casting warning. As a boolean doen't support third state, so I used an enum int like.
- Added APIs to enable disable third state mode. elm_check_three_state_mode_set(check_obj, bool_val), and elm_check_three_state_mode_get(check_obj)
- Modified old APIs which were setting or getting states of checkbox.
- Added a state in theme of checkbox, with third state image.
Reviewers: seoz, raster, Sergeant_Whitespace, Hermet
Subscribers: Hermet, Sergeant_Whitespace, sachin.dev
Differential Revision: https://phab.enlightenment.org/D2249
Flipselector has some random whitespaces that do not belong.
Additionally there are a few hidden non-blocking spaces that prevent
edje_cc to compile the default.edc on arm. Appearantly on x86/amd64 this
works normally.
This patch works around T2285 while the issue should remain open as the
real issue, edje_cc treating nbsp as a whitespace on arm, is not fixed
through this patch.
ref T2285
Signed-off-by: Olliver Schinagl <o.schinagl@ultimaker.com>
Summary:
Issue: Mirroring of elm_panel not working correctly.
Solution: Handle mirroring appropriately for animations.
@fix
Test Plan:
Case: 1
1. Open elementary_test
2. Mirror on
3. Open scrollable panel, click on toggle button.
Case: 2
1. Keep the scroller panel opened
2. Turn off Mirror
Case: 3
1. Turn on mirror
2. Check direction button in non-scrollable panel.
Reviewers: shilpasingh, raster, Hermet, Princekrdubey
Reviewed By: shilpasingh
Subscribers: poornima.srinivasan, subodh6129
Differential Revision: https://phab.enlightenment.org/D2237
NO! this breaks compiling anything against elementary UNLESS you
enable eo beta api support. NO NO NO NO.
This reverts commit cad6de2a8ef93d994f9dedb8e980efe5fbf6d77e.
Umesh Tanwar
Jee-Yong Um
Woochan Lee
Mike Blumenkrantz
Chris Michael
Amitesh Singh
Carsten Haitzler
Youngbok Shin
Andrii Kroitor
taehyub
Cedric BAIL
ChunEon Park
Shobhit
Olliver Schinagl
kumar navneet
Tom Hacohen