Hi all,
I found few memory related issues in elementary package when performed static analysis on it.
These issues include:
Array indices getting out of bounds, freed memory address being passed to a function as parameter, memory not getting cleaned up because of earlier return statement.
Issues details:
1. In elm_widget.c inside function elm_widget_signal_callback_del(), it is possible that freed memory address esd is passed to the sd->callback_del_func(). I think it should be data, not esd.
Moreover what if the callback frees memory for data, then the other problem is that the return value is data from the function elm_widget_signal_callback_del() which in my opinion can be a problem.
2. Inside directory src/edje_externals for files elm_genlist.c, elm_notify.c, elm_list.c, elm_thumb.c and elm_map.c, array indices can go beyound bounary.
sizeof() operator for an array of character pointers will return [number of elements in the array * size of (char*)], basically 4 times the number of elements which has been taken care in assertion inside src/edje_extenarnals
while performing assertion but has been missed in the next statement in the loop condition.
3. In file src/lib/elm_config.c inside function _elm_config_profiles_list, freeing of file iterator has been missed out.
Please review the attached patch and let me know your opinion.
Thanks.
Regards,
Rajeev
SVN revision: 63550
From: Kim Yunhan <spbear@gmail.com>
When you test elm_map with mouse wheel, it worked abnormally because of some bug.
So I made some more patch for fixing it.
This patch file also includes a previous patch (zoom-out issue).
SVN revision: 63510
I wrote a patch that handles a bug while zooming-out in elm_map.
When I try to zoom out, some tiles are broken.
But it is hard to notice because broken frame disappears quickly.
I investigated in a few days.
And I realize that there are something wrong.
When map is zoomed out, a tile is shrunk by evas_object_resize().
But evas_map handles its texture by just its origin image size not a shrunk size.
If evas_object's width & height is shrunk, I have to handle for its texture.
SVN revision: 63509
Since the users have no idea about elm_object_item content/text parts names which are available,
added those part names in doc here.
SVN revision: 63485
<benjamin.t.drucker@alum.mit.edu>. Thanks a lot!
On Wed, Aug 31, 2011 at 1:52 PM, Benjamin Drucker
<benjamin.t.drucker@alum.mit.edu> wrote:
> Earlier this month, there was a svn commit
> (http://trac.enlightenment.org/e/changeset/62496) which added a few
> page-related APIs to the elm scroller. These should probably also be
> added to gengrid, genlist and maybe even grid and list. Right now,
> though, I need them for gengrid. So I propose this patch, based
> entirely on the change that went in before. I've built it and I'm
> using these new gengrid APIs in my code now.
On Fri, Sep 9, 2011 at 4:45 PM, Benjamin Drucker
<benjamin.t.drucker@alum.mit.edu> wrote:
> Slowly but surely....
>
> This version of the gengrid page APIs patch has the following changes:
> 1. fixed spacing issues
> 2. add const where needed
> 3. submitted a gengrid longpressed change in a separate patch
>
> I really want to try to squeak this in the upcoming release if at all
> possible. If I have an extra space in some file, I promise I'll not do
> it again for the next patch!
>
> Thanks!!
> Ben
SVN revision: 63403
Subject: [E-devel] [Patch] elm_diskselector (ticket #853)
Date: Thu, 8 Sep 2011 12:41:27 +0900
Dear All, Hello~
The attached patch for resolving the ticket #853.
(http://trac.enlightenment.org/e/ticket/853)
There is an issue when it comes to rounded item.
Anyhow, I will fix it also.
Sincerely,
Shinwoo Kim
SVN revision: 63386
On Tue, Sep 13, 2011 at 10:47 PM, Jihoon Kim <imfine98@gmail.com> wrote:
> Hello, EFL developers.
>
> At this moment, the title format of elementary calendar widget is "%B %Y".
> However, it should be displayed as "%Y년 %B" in Korea.
> This patch is implemented for supporting this feature.
>
> Would you please apply this patch?
SVN revision: 63360
On Fri, Sep 9, 2011 at 4:18 PM, Benjamin Drucker <benjamin.t.drucker@alum.mit.edu> wrote:
> gengrid already emits "longpressed" signals, but it is not currently
> documented nor demonstrated in the examples. See the attached patch,
> please.
SVN revision: 63323
TODO: Clean code (added this version to have easy way of review), and maybe add pref-var of enabling disabline continues gestures
Signed-off-by: Aharon Hillel <a.hillel@partner.samsung.com>
SVN revision: 63285
On Wed, Sep 7, 2011 at 6:51 PM, Hyoyoung Chang <hyoyoung.chang@samsung.com> wrote:
> Dear developers.
>
> This patch is fixing - hangs after using elm_diskselector_item_selected_set.
> Elm_diskselector add a idler and remove in _move_scroller with checking
> wd->idler
> But in elm_diskselector_item_selected_set, it's not use wd->idler.
> So idler is called infinite.
>
> It also registered in ticket ( http://trac.enlightenment.org/e/ticket/854 )
>
> Thank you
On Wed, Sep 7, 2011 at 7:00 PM, Hyoyoung Chang <hyoyoung.chang@samsung.com> wrote:
> I omitted about credit.
> With cnook, I can easily find this bug.
> Thanks to cnook
SVN revision: 63269
Subject: [E-devel] [PATCH] Add new API elm_diskfileselector_item_num_get()
Kindly review and provide your comments on this patch, that adds new API
elm_diskfileselector_item_num_get().
Add elm_diskselector_display_item_num_get() API.
Added required documentation in docx and Elementary.h.in files.
Updated test programs to print number of items set - as a verification.
Make input param as const. Thanks SeoZ.
SVN revision: 63107
It was very hackish/broken and it broke when gustavo fixed some stuff in
edje. I merged all the different padding items to one padding frame,
and corrected some of the things that were wrong, and tada, now everything
works.
SVN revision: 62983
WooHyun Jung
Daniel Juyung Seo
ChunEon Park
Cedric BAIL
Tom Hacohen
Kim Yunhan
Sangho Park
Vincent Torri
cnook
Mike Blumenkrantz
Michael BOUCHAUD
Aharon Hillel
Carsten Haitzler
Rui Seabra
Nicolas Aguirre
Sanjeev BA