Cedric BAIL
0eacebfec8
elementary: fix elm_list items lifecycle.
...
Elm.List.Item lifecycle where an exception in Efl. They were trying to prevent the death of
there parent, to avoid dealing with safely walking on items list. This has been on the todo
list for years and is now fixed by this patch.
2018-05-24 16:02:21 -07:00
Cedric BAIL
40af4fe94b
elementary: refactor filesector target cleanup to not leave function handler behind.
2018-05-24 16:02:21 -07:00
Cedric BAIL
85598a8a40
elementary: make sure to use the model that generated the event to fetch information from.
2018-05-24 16:02:21 -07:00
Cedric BAIL
228ecdeb51
elementary: make sure fileselector button model has a parent and self destruct properly.
2018-05-24 16:02:21 -07:00
Cedric BAIL
a5f9ee5ab3
elementary: fix configuration destruction by actually calling the proper way of destruction.
2018-05-24 16:02:20 -07:00
Cedric Bail
13ae5b1f0c
elementary: the config subsystem expect a stringshare.
2018-05-24 16:02:20 -07:00
Cedric BAIL
3d94f477d4
elementary: properly destroy block events object during destruction.
2018-05-24 16:02:20 -07:00
Cedric BAIL
5f5af596e0
elementary: cleanup genlist destructor to order content destruction correctly.
2018-05-24 16:02:20 -07:00
Cedric BAIL
b5b9f72f57
elementary: when there is no file listed yet, no need to request them.
2018-05-24 16:02:19 -07:00
Cedric BAIL
e4a6aaa4c1
elementary: enforce walk to protect the object existence by using eo refcounting.
2018-05-24 16:02:19 -07:00
Cedric BAIL
048a93e6e3
elementary: reorder operation to only call efl_parent_set when the object still has a chance to exist.
2018-05-24 16:02:19 -07:00
Cedric Bail
f44511d0f9
elementary: refactor by using elm_legacy_add.
2018-05-24 16:02:19 -07:00
Cedric BAIL
f29e1db94b
elementary: make toolbar 'more_item' properly self destruct.
2018-05-24 16:02:19 -07:00
Cedric BAIL
2ce788063a
elementary: no need to recalculate the layout during invalidate.
2018-05-24 16:02:19 -07:00
Cedric BAIL
9e0f9539dd
elementary: the pan object of the map object was created with efl_add, adjust accordingly.
2018-05-24 16:02:19 -07:00
Cedric BAIL
0fe3b7962d
elementary: due to lifecycle difference between legacy object and unified object, we need to track their lifecycle more explicitely.
...
It is my understanding that some items view are created with efl_add directly
and manipulate VIEW directly with Eo new API. This clash with the inconsistent
behavior that evas_object_del expect. To work around this, we track object life
by explictely relying on efl_wref_add while holding the pointer to the object.
2018-05-24 16:02:19 -07:00
Cedric BAIL
0239099d01
eo: efl_del should not be something anyone can override this can break so many things.
...
Allowing override of efl_del allow for messing with object life cycle which can create
problem for binding where an object was expected to be invalidated, but isn't really.
2018-05-24 16:02:19 -07:00
Cedric BAIL
590304d597
eio: properly handle Eio.Model lifecycle inside Elm.Fileselector.
...
Differential Revision: https://phab.enlightenment.org/D6107
2018-05-24 16:02:18 -07:00
Cedric BAIL
c753fc793b
elementary: dayselector use efl_add to create the object, calling efl_del during destructor make no sense.
...
Differential Revision: https://phab.enlightenment.org/D6106
2018-05-24 16:02:18 -07:00
Cedric BAIL
1991900fd6
elementary: no need to check for part during destruction.
...
Differential Revision: https://phab.enlightenment.org/D6105
2018-05-24 16:02:18 -07:00
Cedric BAIL
6476896ec5
elementary: no need for resize an object during destruction.
...
Differential Revision: https://phab.enlightenment.org/D6104
2018-05-24 16:02:18 -07:00
Cedric BAIL
2508c1a3ae
elementary: colorselector item are created with efl_add, so they are dead when they reach the destructor.
...
Differential Revision: https://phab.enlightenment.org/D6103
2018-05-24 16:02:18 -07:00
Cedric BAIL
dbbcfa4a59
elementary: small correction in the API of Efl.Access.Object to have proper lifecycle.
...
This API require more review, I have just fixed API that return type that are
inconsistent over time and fail to allow for proper lifecycle of event, which
lead to crash when those event trigger at unexpected point.
Differential Revision: https://phab.enlightenment.org/D6102
2018-05-24 16:02:18 -07:00
Cedric BAIL
fe14abd929
evas: refactor efl_input_event and remove some of the lifecycle hack.
...
Differential Revision: https://phab.enlightenment.org/D6101
2018-05-24 16:02:18 -07:00
Cedric BAIL
8a513a522e
efl: major rewrite of efl_part.
...
The interface efl_part_get should not be directly called from C, but the efl_part
wrapper should. It rely on efl_noref to properly destroy the object. Binding can
control the lifecycle of the reference the way they want by either calling the
wrapper or efl_part_get directly. It also means that the ugly ___efl_auto_unref_set
doesn't need to be exposed outside of EFL anymore.
Differential Revision: https://phab.enlightenment.org/D6098
2018-05-24 16:02:18 -07:00
Cedric Bail
c1cef1e74b
elementary: object created with efl_add should be destroyed with efl_del.
...
Differential Revision: https://phab.enlightenment.org/D6094
2018-05-24 16:02:18 -07:00
Cedric Bail
0135b23e45
elementary: object allocated with efl_add should be destroyed with efl_del.
...
Differential Revision: https://phab.enlightenment.org/D6093
2018-05-24 16:02:18 -07:00
Cedric BAIL
0ac6e47697
elementary: use invalidate instead of overriding del for widget items.
...
Differential Revision: https://phab.enlightenment.org/D6073
2018-05-24 16:02:18 -07:00
Cedric BAIL
95f8bf2ebd
elementary: rely on inheritance instead of faking efl_del behavior.
...
Differential Revision: https://phab.enlightenment.org/D6072
2018-05-24 16:02:18 -07:00
Cedric BAIL
b265c5c887
elementary: make del_pre not return a bool and force rely on Eo ref counting.
...
Differential Revision: https://phab.enlightenment.org/D6071
2018-05-24 16:02:18 -07:00
Cedric BAIL
a669fb820a
elementary: prevent death of list item using Eo ref counting.
...
Differential Revision: https://phab.enlightenment.org/D6070
2018-05-24 16:02:18 -07:00
Cedric BAIL
ad009667b5
elementary: remove now useless walking in item.
...
Differential Revision: https://phab.enlightenment.org/D6069
2018-05-24 16:02:18 -07:00
Cedric BAIL
4b30a7df8e
elementary: use Eo ref counting to prevent death of genlist items.
...
Differential Revision: https://phab.enlightenment.org/D6068
2018-05-24 16:02:18 -07:00
Cedric BAIL
2a51465593
elementary: use Eo ref counting to prevent death of gengrid items.
...
Differential Revision: https://phab.enlightenment.org/D6067
2018-05-24 16:02:18 -07:00
Mike Blumenkrantz
6932f0fdd6
elm_list: prevent list item operations during item deletion
...
ref T6880
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Differential Revision: https://phab.enlightenment.org/D6066
2018-05-24 16:02:17 -07:00
Mike Blumenkrantz
499beb9162
elm_list: fix crash in item deletion
...
this is still broken
ref T6881
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Differential Revision: https://phab.enlightenment.org/D6065
2018-05-24 16:02:17 -07:00
Cedric BAIL
ccb5642eb9
Revert "efl_add_ref - fis to use efl_add properly with a parent."
...
This reverts commit 2fb5cc3ad0
.
Most of this change where wrong as they didn't affect the destruction
of the object. efl_add_ref allow for manual handling of the lifecycle
of the object and make sure it is still alive during destructor. efl_add
will not allow you to access an object after invalidate also efl.parent.get
will always return NULL once the object is invalidated.
Differential Revision: https://phab.enlightenment.org/D6062
2018-05-24 16:02:17 -07:00
Marcel Hollerbach
0090384ef5
elm_ctxpopup: prevent a giant load of errors
...
Summary:
i) There have been 2 sorts of errors, first the items have been deleted
after the list was deleted, thus the list items have already been
destructed. which lead to the error as the popup items destroyed the list
items on destruction as well.
ii) sd->box was attached to the ctxpopup when getting into group_del the
box has already been destroyed by the cleanup logic.
Subscribers: cedric, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6166
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-05-24 16:02:17 -07:00
WooHyun Jung
ea1760380e
elm_main: call _elm_config_shutdown() after loop_iterate()
...
In _elm_config_shutdown(), _elm_config is freed.
So, if some ecore events call efl_ui_xxx API which refers _elm_config,
there can be crashes.
@fix
2018-05-24 15:30:29 +09:00
Marcel Hollerbach
d5fd76c190
efl_ui_focus_composition: track the deletion state of child objects
...
Reviewers: cedric, zmike
Reviewed By: cedric
Subscribers: #committers, cedric, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6186
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-05-23 21:16:01 -07:00
Xavi Artigas
61b409015e
efl: rename Efl.Ui.Widget.Orientation_Mode -> Efl.Ui.Widget_Orientation_Mode
2018-05-23 17:33:47 +02:00
Xavi Artigas
e31b3213ec
efl: rename Efl.Ui.Text.Change_Info -> Efl.Ui.Text_Change_Info
2018-05-23 17:33:47 +02:00
Xavi Artigas
4ab7e3fda0
efl: rename Efl.Ui.Tab_Page.* -> Efl.Ui.Tab_Page_*
2018-05-23 17:33:47 +02:00
Xavi Artigas
a7d29f7185
efl: rename Efl.Ui.Stack.Event_* -> Efl.Ui.Stack_Event_*
2018-05-23 17:33:47 +02:00
Xavi Artigas
ee27519432
efl: rename Efl.Ui.Slider.Indicator_Visible_Mode -> Efl.Ui.Slider_Indicator_Visible_Mode
2018-05-23 17:33:47 +02:00
Xavi Artigas
a0d4d3b140
efl: rename Efl.Ui.Pager.Loop -> Efl.Ui.Pager_Loop
2018-05-23 17:33:47 +02:00
Xavi Artigas
1e8b7cc405
efl: rename Efl.Ui.Focus.Composition.Adapter -> Efl.Ui.Focus.Composition_Adapter
2018-05-23 17:33:47 +02:00
Xavi Artigas
761aaa269d
efl: rename Efl.Ui.*_Legacy.Part -> Efl.Ui.*_Legacy_Part
2018-05-23 17:33:47 +02:00
Xavi Artigas
0e848ccf2d
efl: rename Efl.Selection.* -> Efl.Selection_*
2018-05-23 17:33:47 +02:00
Xavi Artigas
029f0769a5
efl: rename Efl.Event.Description -> Efl.Event_Description
2018-05-23 17:33:47 +02:00