If classes A and B are stored in a same file, when A inherits from B,
and A needs to be generated, the generator, even if B is parsed, will
not search the class in the database but will look for some b.eo.
This patch fixes that issue by checking the existence of the classes
into the database before looking for a corresponding file.
Summary:
text_props.len indicates visual length from harfbuzz logic when it is available.
But, input pram "idx" is logical length. So, ellipsis works abnormally in some case.
@fix
Test Plan: D870
Reviewers: tasn, woohyun
CC: cedric, herdsman
Differential Revision: https://phab.enlightenment.org/D871
Match function names when the API pointer is out of range.
Reviewed by TAsn and modified according to his comments :)
Differential Revision: https://phab.enlightenment.org/D876
Summary:
the draggable.event field (in edje) is pointing on the id of the part it is assigned to.
The main problem is about deleting parts.
After part being deleted, all other parts (that are below the deleted part) have their id shifted,
but event doesnt shift.
For example,
1) draggable.event at some part pointing at part with id=7,
2) some other part is being deleted
3) part with id=7 have new id now (id=6)
4) draggable.event DOESN'T change it's pointer and still points at part with id=7 (which is now has id=6)
5) if there is no parts with id=7 anymore, then it could give you SEGFAULT someday (or not, depending on luck).
This commit contains next changes:
1) after deleting part, draggable.event also shifts (if required)
2) after deleting part that is being pointed with event by someone, it will remove all event points at it
@fix
Reviewers: cedric, raster, seoz
CC: reutskiy.v.v, cedric
Differential Revision: https://phab.enlightenment.org/D878
Signed-off-by: Cedric Bail <cedric.bail@free.fr>
Engines are stored in a lib/ folder, while the main DLL files
are in the bin/ folder, so the engine would never be found.
A solution was to add the proper checkme file in the share
folder, but since this is necessary only for Windows, we
can simply use ../lib instead of using the full eina_prefix
detector.
Thanks vtorri for the review.
Fixes a mistake in commit 78c9a82a14
The authority part would get placed in the struct member "path",
and vice versa.
Lesson learned: Don't rewrite your patch late at night after
arc has messed it up.
The syntax to define a parameter of a property as const is as following:
set {
data: const;
}
When no space was present between ':' and "const", a syntax error was
occurring.
We check _current_table for NULL, and then populate it (it's a global)
through another function, but we don't really check it's not NULL before
using it, we just assume because of an indirect other variable.
This confused coveritiy, can confuse humans too, and in general risky
(if something changes).
CID 1039419
Coverity found the issue, but it's an issue we've already fixed in the
past. I don't know how it got lost, but it seems like someone did a bad
merge. Probably when migrating to Eo2.
This reverts commit 831c20464d.
In particular, ellipsis is -1 by default in Evas, but at this
point (first layout calc), the parameters used for recalc are
incomplete and ellipsis would then be 0 by default (calloc).
As a consequence, Edje will call ellipsis_set(0) enabling
ellipsis even on objects that force "ellipsis: -1".
Solution: set all the parameters before entering text/tb calc.
I believe the other changes are only color and image padding
and should not affect recalc_single.
Summary:
To correcly display the added pats using the edje edit api, update
init the filds of Edje_Real_Part. Initialize the next filds: type and
typedata. It filds initialized accordingly to Edje_Part_Type value.
@fix
Reviewers: raster, cedric, seoz, Hermet
CC: cedric
Differential Revision: https://phab.enlightenment.org/D854
Signed-off-by: Cedric Bail <cedric.bail@free.fr>
Text objects declared in Edje will see their padding added twice,
as the Evas_Object_Text itself contains the padding already.
This WILL break some EDC files. It's a bug nonetheless.
Should this be backported?
erroneous variable.
@bugfix: Since later functions which process the ecore key event will
end up subtracting X's broken keycode values from This original
keycode value, we had better send the proper code with the offset
already added.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
I am concerned that we do duplicate the color format of a texture insteed
of reusing the colorspace enum from Evas (that already exist). I believe
this is a side effect of not using Evas_GL_Image for texture.
This let me think that I wont allow this API out of BETA until we reduce
duplication by using Evas_GL_Image as it seems it will also impact the
public API of Evas_3D.
Summary: This patch gets rid of a "defect" pointed out by Coverty Scan -- as per jackdanielz request.
CID 1211985.
Reviewers: cedric, smohanty, JackDanielZ
CC: felipealmeida, cedric
Differential Revision: https://phab.enlightenment.org/D840
Signed-off-by: Cedric Bail <cedric.bail@free.fr>
Daniel Zaoui
Youngbok Shin
Jean-Philippe Andre
Vorobiov Vitalii
ChunEon Park
Kai Huuhko
Tom Hacohen
Stefan Schmidt
Carsten Haitzler
Vyacheslav Reutskiy
Mike Blumenkrantz
Chris Michael
Cedric Bail
Savio Sena