Being annoyed by different types of eina critical macros - CRI, CRIT,
CRITICAL -, I concluded to unify them to one. Discussed on IRC and
finally, CRI was chosen to meet the consistency with other macros -
ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
Summary: Add one more argument, 'Eina_Bool sub_object' to elm_widget_resize_object_set. If the argument, 'sub_object' is set as EINA_TRUE, the new resize object is added to the sub object and the previous resize object is deleted from the sub object.
Reviewers: Hermet, seoz
CC: Jaehyun_Cho, seoz, raster
Differential Revision: https://phab.enlightenment.org/D265
Because _timer_init() can be called multiple times,
sd->timer should be cleard if we will not add new timer
This fixes https://phab.enlightenment.org/T178
Thanks brian.lovin for the report.
I splited ELM_SAFE_FREE refactoring patches. One commit per each file as recommended.
For the detail, please refer 3072dab12f12fe83fb5a628d15efd5cded11787f.
1. Do not need to print the same error message from all the widget codes.
2. Even though elm_widget_sub_object_add() can be used internally, there should be no error message at all.
Elm devs should fix it beforehand.
So it looks ok to print the error message in elm_widget_sub_object_add() to force elm devs to fix it.
3. Got additional code cleanups.
I attached new patch.
The old patch's default position and mirroring problem has been fixed.
I added new 2 APIs for supporting various notify's postion.
EAPI void elm_notify_align_set(Evas_Object *obj, double horizontal, double vertical); EAPI void elm_notify_align_get(const Evas_Object *obj, double *horizontal, double *vertical);
And below 2 APIs will be deprecated.
EINA_DEPRECATED EAPI void elm_notify_orient_set(Evas_Object *obj, Elm_Notify_Orient orient); EINA_DEPRECATED EAPI Elm_Notify_Orient elm_notify_orient_get(const Evas_Object *obj);
Please review this patch.
Thanks:)
Signed-Off-By: Seunggyun Kim<sgyun.kim@samsung.com>
SVN revision: 78655
I attached new patch.
The old patch's default position and mirroring problem has been fixed.
I added new 2 APIs for supporting various notify's postion.
EAPI void elm_notify_align_set(Evas_Object *obj, double horizontal, double vertical); EAPI void elm_notify_align_get(const Evas_Object *obj, double *horizontal, double *vertical);
And below 2 APIs will be deprecated.
EINA_DEPRECATED EAPI void elm_notify_orient_set(Evas_Object *obj, Elm_Notify_Orient orient); EINA_DEPRECATED EAPI Elm_Notify_Orient elm_notify_orient_get(const Evas_Object *obj);
Please review this patch.
Thanks:)
Signed-Off-By: Seunggyun Kim<sgyun.kim@samsung.com>
SVN revision: 78653
parent is deleted.
On Tue, May 22, 2012 at 4:46 PM, Sohyun Kim <anna1014.kim@samsung.com>
wrote:
>
> Hi all.
> When I use elm_notify, I got a crash in the deleting routine. (you
can test it in elementary_test > Video)
>
> When parent window of elm_notify is deleted, elm_notify set its
parent to NULL.
> However, it doesn't delete event callbacks of the parent window.
>
> In the smart_del callback of elm_notify, it tries to delete event
callbacks of parent window.
> However, its parent is already set to NULL, the deleting is skipped.
> Then the widget data gets freed.
> In this case, when other objects in the window are deleted, they can
create the parent window's event (e.g. CHANGED_SIZE_HINTS,,)
>
> Please find a patch to delete event callbacks when parent window is
deleted.
>
> Regards, Sohyun
SVN revision: 71307
There is no swallow area for the parent In the notify.edc also.
Even if the removed line is necessary, then it will cause an improper result.
So it should be removed definitely and absolutely!
Please review this and give any feedbacks. Thank you.
Sincerely,
Shinwoo Kim.
SVN revision: 67012
Previous part names are just the swallow part names
but in modified version, the part names chaned to simpler meaning names to use.
i.e for button
elm_object_content_part_set(button, "elm.swallow.icon", icon);
-> elm_object_content_part_set(button, "icon", icon);
SVN revision: 65295
Daniel Juyung Seo
Tom Hacohen
Jaehyun Cho
Cedric Bail
ChunEon Park
Daniel Juyung Seo
Thiep Ha
Carsten Haitzler
Daniel Juyung Seo
Ryuan Choi
Gustavo Lima Chaves
Daniel Zaoui
WooHyun Jung
Yakov Goldberg
Rafael Antognolli
Seunggyun Kimsgyun.kim
Jihoon Kim
Mike Blumenkrantz
Jiyoun Park
Jaehwan Kim