Subject: [E-devel] [patch][elementary] diskselector - bug fix
diskselector has two bugs.
1. on round enable mode
elm_diskselector_item_append(); does not call elm_box_pack_*() for
over_items and under_items which are added when the display item is
bigger
than 3.
because over_items and under_items is not added, the diskselector shows
just 4 items + half item(NOT 5 items), in case of display item number
is 5
- elm_diskselector_display_item_num(obj, 5); -.
this bug could be found only if u use as following sequence.
a. elm_diskselector_round_enabled_set(obj, EINA_TRUE);
b. elm_diskselector_item_append();
2. on the round disable mode + bigger than 3 display item
even though display item is bigger than 3 on the round disable
mode, only
two blank items are added - left_blank, right_blank.
because of this, the first item could not be selected. means.. the first
item cannot be located in the middle of diskselector.
if u scroll the diskselector to the left-most, then the second item is
selected as below.
[blank] [ 1st ] [ 2nd ] [ 3rd ] [ 4th ]
so if the display item is bigger than 3, more blank items would be
necessary.
include lines to resolve above 1st bug, the patch would resolve
this issue
also.
SVN revision: 77740
Subject: [E-devel] [patch][elementary] multibuttonentry - access feature
i have attached a patch which has access feature for the multibuttonentry.
it was hard time to implement access feature on the multibuttonentry than
others.
SVN revision: 77738
Subject: [E-devel] [elementary] size value checking in elm config
This patch contains size value checks for some functions in elm_config
file.
I think that calling these function with negative size values has no
sense.
SVN revision: 77734
It was always increasing quicklaunch count on init, but
only reducing on shutdown when _elm_init_count is zeroed,
i.e., the quicklaunc_shutdown rountine wasn't being executed.
SVN revision: 77378
With ELM_POLICY_EXIT it's possible to request elementary
to delete all the windows before shutdown instead of just
quitting the main loop.
SVN revision: 77328
It's weird, but looks like wrap mode of the spinner is broken at least
since the move of elm to trunk.
The current code:
if (sd->wrap)
{
while (new_val < sd->val_min)
new_val = sd->val_max + new_val + 1 - sd->val_min;
while (new_val > sd->val_max)
new_val = sd->val_min + new_val - sd->val_max - 1;
}
doesn't seems correct. Since even the documented example would fails:
* E.g.:
* @li min value = 10
* @li max value = 50
* @li step value = 20
* @li displayed value = 20
*
* When the user decrement value (using left or bottom arrow), it will
* displays @c 40, because max - (min - (displayed - step)) is
* @c 50 - (@c 10 - (@c 20 - @c 20)) = @c 40.
With the current code the value will be 41.
It also could lead to values above min, like happens on the first spinner test,
when you could go to -50.5 because new value will become:
250 + (-50.5) + 1 - (-50) in the first while() and later since these value
is bigger then 250, would go back to -50.5 ...
So, a reasonable algorithm would be
if (sd->wrap)
{
if (new_val < sd->val_min)
new_val = sd->val_max + new_val - sd->val_min;
else if (new_val > sd->val_max)
new_val = sd->val_min + new_val - sd->val_max;
}
But it doesn't works fine for cases like the months spinners test, when you
have min = 1, max = 12, step = 1 and each option should be displayed with
wrap. This algorithm would wraps from 1 to 11, so would skip December...
So, I think just going to the max value when min is reached is the better
choice.
if (sd->wrap)
{
if (new_val < sd->val_min)
new_val = sd->val_max;
else if (new_val > sd->val_max)
new_val = sd->val_min;
}
SVN revision: 77278
On Fri, Sep 28, 2012 at 10:04 PM, Bluezery <ohpowel@gmail.com> wrote:
> Dear EFL developers,
>
> In current genlist reorder mode, reordering is not moved when
> reordering item is on top or in bottom of within genlist objec because
> of scroller's hold mode.
> After mouse point is moved out of genlist object, then reordering item
> can be moved.
> But in mobile, mouse point can not be moved out of window (if genlist
> item is expanded in window).
> So I add some tweaks to reordering item can be moved when reordering
> item is moved on top item or bottom item.
>
> Please review this patch.
>
> BRs
> Kim.
SVN revision: 77255
Since all the spinners have wrap set we don't test if min / max
are working fine without it.
Also, using EINA_TRUE instead of ELM_WRAP_CHAR makes more sense.
Anyway I couldn't reproduce the bug Ricardo reported to me =/
SVN revision: 77213
I know some guys insinuated it's useless, since if you want to
put a image in your theme you can just place a image part.
But there are some cool things:
- You can add a background that fits the theme (default bg theme)
- You can use background options (tile, stretch...)
SVN revision: 77212
This can happen on window deletion scenario:
the parent object is elm_widget_sub_object_del()ed BEFORE it gets
evas_object_del()ed, so its children won't reach the window anymore.
SVN revision: 77206
Subject: [E-devel] [Patch] multibuttonentry - data corruption issue of
the box list
here is a problem in the data corruption of the box list in
_box_layout_cb() of the multibuttonentry.
EINA_LIST_FOREACH is used to move and resize the objects.
but if box unpack/pack is called in the EINA_LIST_FOREACH loop,
the data of the box list will be corrupted.
This problem can not be solved immediately due to the structural
problems of
the MBE.
So the attached patch, a workaround, avoids calling unpack/pack in the
EINA_LIST_FOREACH loop.
I am in the process of refactoring MBE but in the mean time,
this patch will resolve the above issue.
SVN revision: 77192
Subject: [E-devel] [patch][elementary] diskselector - checking middle
item
the diskselector object x-coordinate would not be 0.
but the _scroll_animate_stop_cb() calculates selected item with assumption
that the diskselector object x-coordinate is 0.
so different item which is not in middle of diskselector is selected.
SVN revision: 77182
Adding the follow functions if the part is a BOX:
- elm_layout_box_append
- elm_layout_box_prepend
- elm_layout_box_insert_before
- elm_layout_box_insert_at
- elm_layout_box_remove
- elm_layout_box_remove_all
or if the part is a TABLE:
- elm_layout_table_pack
- elm_layout_table_unpack
- elm_layout_table_clear
SVN revision: 77039
Hi All,
Please find attached patch for naviframe animation optimization.
This patch makes sure animation happens smoothly even if content is heavy.
i.e, this patch makes sure animation is deferred so that it is visible(showing full transition time)
even if content takes more time in creation.
Change description:
Naviframe Animation optimization for smoother animation.
Signed-off by: Shilpa Singh<shilpa.singh@samsung.com>
Thanks & Regards
Shilpa Singh
SVN revision: 76929
Subject: [E-devel] [patch][access] bubble - access feature
the attached has access feature for bubble widget.
please review it and give some feedback. thanks.
SVN revision: 76798
Subject: [E-devel] [patch][elementary] access - activate widget
Subject: [E-devel] [Patch][elementary] scroller, slider - access
activate feature
the previous activate function just get object only. to activate scroller
or slider etc.. it needs more information. so the patch changed previous
activate(Evas_Object *obj) to activate(Evas_Object *obj, Elm_Activate act);
the Elm_Activate can be one of ELM_ACTIVATE_DEFAULT, UP, DOWN, RIGHT, and
LEFT.. you can add more if it is necessary.
I have attached two patches. one is for the slider and the other is for the
scoller.
this patch would support those who wants change value of slider or content
position of scroller on remote side.
this would be useful to the access side or voice control side also.
SVN revision: 76717
Subject: [E-devel] [patch][elementary] bubble - text set does not
display info text part
current bubble dose not display 'info' which is TEXT part.
i have learned that the following commit would be reverted.
http://trac.enlightenment.org/e/changeset/71516/trunk/elementary/src/lib/elm_bubble.c
or remove 'else' from 'else if' on current
_elm_bubble_smart_text_set();.
anyhow i made a diff and attached. please find it and give feedback.
thanks.
SVN revision: 76669
Subject: [E-devel] [patch] Add APIs for floating mode
I added APIs for supporting the floating mode -
elm_win_floating_mode_set, elm_win_floating_mode_get.
The floating mode will be used on mobile environment. For example, if
the video-player window set the floating mode, then e (enlightenment
window manager) changes it's geometry and handles it like a popup.
Please check these APIs and give an advice for me.
SVN revision: 76667
Parsing the parts and programs of the specified group and generating
the header/source. Usage:
elementary_codegen --prefix myapp_myobj input.edj a_group source.c header.h
SVN revision: 76614
Subject: [E-devel] [Patch] [Elementary] Support for circular effect in
elm_diskselector, in case scroller's bounce effect is disabled.
Can someone please review the attached patch created by Sumanth.
[Issue Details] :
elm_diskselector_round_enable_set() API is not working, if
elm_scroller's bounce effect is disabled.
[Root cause] :
For diskselector circular effect, the boundary checking is done based
on scroller's geometry.
If bouncing effect is disabled in elm_scroller, its geometry can lie
between 0 on left and CHILD_SIZE on right but it can never go beyond
that point.
Unless the scroller's geometry goes beyond its child (here, elm_box)
size, diskselector cann't trigger the circular effect.
[Change Description] :
For diskselector items circular effect, the boundary checking is
performed at the left/right edges of its child, elm_box.
Once the scroller reaches to the left/right edge of box or goes beyond
that point, circular effect will be triggered.
SVN revision: 76606
using this, we can establish indicator service.
I'll implement more indicator service feature using elm_plug and elm_compoment.
after finishing all indicator and compoment feature I will add change log and news
SVN revision: 76533
Subject: [E-devel] [patch][elementary] index - add access feature
the attachment has access features for the index. and this patch is
depends
on the previous patch which has
_elm_access_edje_object_part_object_unregister();
to find the previous patch, please refer to the following
http://sourceforge.net/mailarchive/forum.php?thread_name=CAP-c0nG8NkMx3J-YkSJnWdB23cWOPrtk1Rx10Lae0Zwxst1eeQ%40mail.gmail.com&forum_name=enlightenment-devel
the index could have two levels, one is level 0, the other is level 1.
the
patch supports only level 0 because we have no style for the level 1..
(just a cowardly excuse, i will keep up with this.. and update..)
SVN revision: 76532
Subject: [E-devel] [patch][elementary] diskselector - text align issue
by default diskselector item has space for icon even though the item does
not have icon.
so in some cases, the text is not located in the center of item and
diskselector.
the attachment would resolve this issue. please look into it and give
feedback. thanks.
SVN revision: 76507
Subject: [E-devel] [Patch] [Elementary] ctxpopup - correct position
and size of ctxpopup
With ctxpopup, if it has many items and user uses -1 as parameter in
set direction priority function,
the ctxpopup position and size are calculated incorrectly.
Ex:
elm_ctxpopup_direction_priority_set(ctxpopup,
ELM_CTXPOPUP_DIRECTION_DOWN, ELM_CTXPOPUP_DIRECTION_UP, -1, -1);
SVN revision: 76505
Subject: [E-devel] [patch][elementary] calendar - add access feature,
access - add _elm_access_edje_object_part_object_unregister();
the attachment has accessibility feature which is for the
elm_calendar. and
moreover..
it would be better to keep one more api for the access which name is
_elm_access_edje_object_part_object_unregister();
in the case of calendar item, its text part could be set with empty
value
in run time(dynamically), even though it had a value (1~31) previously.
so if there is an empty field(item), then previously registered item
should
be unregistered. the api would be useful not only this case but also
others.
then, please review the patch and give feedback. thanks.
SVN revision: 76502
This is already handled in elm_widget_type_check, and there it actually
prints an error message, like it should.
Patch by Daniel Zaoui.
SVN revision: 76461
Dear all,
With ctxpopup, if it has many items and user uses -1 as parameter in set direction priority function,
the ctxpopup position and size are calculated incorrectly.
Ex:
elm_ctxpopup_direction_priority_set(ctxpopup, ELM_CTXPOPUP_DIRECTION_DOWN, ELM_CTXPOPUP_DIRECTION_UP, -1, -1);
I would like to send a small patch to fix this issue.
Please take a look on it.
Thanks & Regards,
Thiep Ha
Signed-Off-By: Thiep ha<thiep.ha@samsung.com>
SVN revision: 76452
All the interaction in this tests are 'pure edje', no c code involved at all.
NOTE: 2 little external bugs are hilighted in the tests, didn't found the time to look for fixes :(
SVN revision: 76322
have to use a manually added rectangle to receive events. This
rectangle needs to account for framespace, else it does not receieve
events for the whole area which the bg occupies.
SVN revision: 76004
Michael BOUCHAUD
Jihoon Kim
Carsten Haitzler
Cedric BAIL
Kim Shinwoo
KoziarekBeata
Bruno Dilly
Daniel Juyung Seo
Sebastian Dransfeld
Massimo Maiurana
Flavio Vinicius Alvares Ceolin
Stefan Schmidt
ChunEon Park
Vincent Torri
Gustavo Lima Chaves
Jihyeon Seol
Jaehwan Kim
Mike McCormack
Aharon Hillel
Leandro Pereira
Doyoun Kang
PRINCE KUMAR DUBEY
Jiyoun Park
Davide Andreoli
Tom Hacohen
thiep ha
WooHyun Jung
Rui Seabra
Mike Blumenkrantz
Christopher Michael