kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
62,107 Commits 487 Branches 154 Tags 426 MiB
Commit Graph

62107 Commits

Author SHA1 Message Date
Mike Blumenkrantz c0e9a62efe elm/code: check for cursor layout existence before emitting signals to it 
Summary:
non-editable widgets do not have this object and will trigger errors

@fix
Depends on D8988

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8989
 2019-05-30 10:24:30 -04:00
Mike Blumenkrantz ad201122dd elm/popup: remove del callback for internal table object during destruction 
Summary:
the table object's destruction is no longer relevant after this point and
its callback can trigger unnecessary errors

@fix
Depends on D8986

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8988
 2019-05-30 10:24:27 -04:00
Mike Blumenkrantz 10fda3410b elm/fileselector: return early in theme_apply during construction 
Summary:
the remainder of this function is used to setup styles for subobjects
which don't yet exist at this point

@fix
Depends on D8984

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8985
 2019-05-30 10:24:23 -04:00
Mike Blumenkrantz 1feb4e2911 efl_ui/widget: skip updating access info during parent_set(NULL) if dead 
Summary:
no need to update access info for dead objects

@fix
Depends on D8983

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8984
 2019-05-30 10:24:20 -04:00
Mike Blumenkrantz f011e8e59a efl_ui/video: do not set 0x0 aspect hint 
Summary:
this is an error

@fix
Depends on D8982

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8983
 2019-05-30 10:24:18 -04:00
Mike Blumenkrantz f8ce1c0578 efl_ui/progressbar: check for part existence before using parts 
Summary:
some progressbar styles do not have certain parts, so it's necessary to
check part existence on theme load to avoid triggering unnecessary
errors

@fix

Depends on D8981

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8982
 2019-05-30 10:24:16 -04:00
Mike Blumenkrantz af2613a3dc efl_ui/layout: only freeze internal layout during delete if it exists 
Summary:
if the layout object does not exist here then there is nothing to freeze

@fix
Depends on D8980

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8981
 2019-05-30 10:24:14 -04:00
Mike Blumenkrantz 5498f65275 efl_ui/layout: do not trigger sizing eval on subobj delete if layout is dead 
Summary: @fix

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8980
 2019-05-30 10:24:12 -04:00
Mike Blumenkrantz 43b781ea4b efl_ui/layout: do not trigger sizing eval on hint change if object is dead 
Summary:
this fixes a huge number of errors during object deletion

@fix
Depends on D8979

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8987
 2019-05-30 10:24:09 -04:00
Mike Blumenkrantz 742dbc50f9 efl_ui/check: check icon swallow existence before getting its content 
Summary:
some check styles do not have this part

@fix
Depends on D8977

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8978
 2019-05-30 10:21:46 -04:00
Mike Blumenkrantz 97f8c738ef eldbus: don't print warnings for user-canceled calls 
Summary:
these are intentionally canceled and not something to be concerned with

@fix
Depends on D8974

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8976
 2019-05-30 10:21:44 -04:00
Mike Blumenkrantz a4ca457314 efl/io_model: check for parent object existence before removing wref 
Summary:
if the wref automatically removes this pointer then there's no need to
remove the wref on the pointer

@fix
Depends on D8973

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8974
 2019-05-30 10:21:38 -04:00
Mike Blumenkrantz 846ea9373a ecore-x: protect ecore_x_shutdown from creating a negative init count 
Summary:
@fix
Depends on D8972

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8973
 2019-05-30 10:21:35 -04:00
Mike Blumenkrantz d0e60d9edd ecore-evas: check for internal evas presence before using it during free 
Summary:
some engines do not have an evas

@fix
Depends on D8971

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8972
 2019-05-30 10:21:33 -04:00
Mike Blumenkrantz ff1dfde419 efl_ui/button: check icon swallow existence before getting its content 
Summary:
some button styles do not have this part

@fix
Depends on D8970

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8971
 2019-05-30 10:21:30 -04:00
Mike Blumenkrantz 2cc5f8f9aa elm/slider: check for interval/range state before using that functionality 
Summary:
the part elm.dragable2.slider only exists when the slider is set to range
mode, so verify that this mode is active before attempting to use that part

@fix

Depends on D8968

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8969
 2019-05-30 10:20:57 -04:00
Mike Blumenkrantz 66e28c89a6 elm/slider: avoid emitting double events when range slider value changes 
Summary:
in range mode, there are two slider endpoints, but only one event should be
emitted if a change is detected during update

@fix
Depends on D8967

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8968
 2019-05-30 10:20:17 -04:00
Mike Blumenkrantz 25f3766f32 elm/map: ignore zoom events during construction which cannot be handled 
Summary:
sd->obj is null until after the object is finalized, so this codepath
cannot be processed until then

@fix
Depends on D8966

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8967
 2019-05-30 10:20:11 -04:00
Mike Blumenkrantz 67e9e1cad4 elm: fix value of datadir when running in tree 
Summary:
this makes it possible to successfully run elm_test out of the tree
without installing

@fix
Depends on D8965

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8966
 2019-05-30 10:20:09 -04:00
Mike Blumenkrantz b792bd83b6 elm: don't attempt to load clouseau when running in tree 
Summary:
clouseau doesn't work anyway
Depends on D8964

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8965
 2019-05-30 10:20:07 -04:00
Mike Blumenkrantz 9f4adbfda8 elm/hovers: don't trigger more errors when setting null hover parent 
Summary:
null is not a valid subobject, do not attempt to add it

@fix
Depends on D8963

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: devilhorns, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8964
 2019-05-30 10:20:05 -04:00
Mike Blumenkrantz 6f1d16330a elm/gengrid: handle focus events when no previous focus item was set 
Summary:
this triggers fewer error messages

@fix
Depends on D8962

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8963
 2019-05-30 10:20:02 -04:00
Mike Blumenkrantz 38194d9816 elm/gengrid: more null checks for setting mirrored state during construction 
Summary:
sd->obj is only non-null later in construction, so add even more checks for it
here

@fix
Depends on D8961

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8962
 2019-05-30 10:19:59 -04:00
Mike Blumenkrantz 1dfe25e659 elm/gengrid: handle cache item deletion without errors 
Summary:
@fix
Depends on D8959

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8960
 2019-05-30 10:19:57 -04:00
Mike Blumenkrantz 50134d81ec elm/entry: use edje functions directly for interacting with edje objects 
Summary:
this eliminates a number of errors triggered when processing class hierarchy
to reach the desired subobject with these edje functions

@fix
Depends on D8958

Reviewers: bu5hm4n

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8959
 2019-05-30 10:19:54 -04:00
Mike Blumenkrantz 0aa266467e elm/diskselector: trigger sizing eval during theme set only if finalized 
Summary:
this can't be successfully completed until the object has been fully constructed

@fix
Depends on D8957

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8958
 2019-05-30 10:19:50 -04:00
Mike Blumenkrantz 1eaccf7932 elm/diskselector: fix handling in theme data setup 
Summary:
the previous code checked for the object which was required to execute
the remainder of the function, then returned if that object existed instead
of continuing with the function. hello?

@fix
Depends on D8956

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8957
 2019-05-30 10:19:49 -04:00
Mike Blumenkrantz 47f86fe2b5 elm/colorselector: return early from theme apply if object is not yet finalized 
Summary:
the remainder of this function cannot be handled until objects are set up
later in construction

@fix
Depends on D8955

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: devilhorns, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8956
 2019-05-30 10:19:47 -04:00
Mike Blumenkrantz e25b4e25e0 elm/layout: do not trigger sizing eval at end of canvas_group_add 
Summary:
this can never succeed as there will never be an object to successfully
size with at this point

@fix
Depends on D8954

Reviewers: bu5hm4n

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8955
 2019-05-30 10:19:47 -04:00
Mike Blumenkrantz 94656d0e01 elm/layout: do not trigger sizing eval on subobj deletion if no resize_obj set 
Summary:
this has no effect since the resize_obj is what determines sizing

@fix
Depends on D8953

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8954
 2019-05-30 10:19:45 -04:00
Mike Blumenkrantz 1eccc02cfd efl_ui_focus_manager/calc: handle redirect setting if no previous redirect set 
Summary:
use same pointer for conditional to improve readability, avoid passing null to
efl_ui_focus_manager_reset_history() which cannot be passed null

@fix

Depends on D8952

Reviewers: bu5hm4n

Reviewed By: bu5hm4n

Subscribers: bu5hm4n, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8953
 2019-05-30 10:19:43 -04:00
Mike Blumenkrantz d88d5f67e0 eina/prefix: ignore magic files when running in tree 
Summary:
this just can't work.

@fix
Depends on D8951

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8952
 2019-05-30 10:19:37 -04:00
Mike Blumenkrantz 3ad96c110a eina/file: use INFO log level when eina_file_open fails 
Summary:
this function is commonly used to detect the existence of files using
its return value. for this purpose, printing warnings any time the file
cannot be opened is spammy and not very helpful in the context of detecting
actual errors.
Depends on D8950

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8951
 2019-05-30 10:19:35 -04:00
Mike Blumenkrantz 99150febbf efl_canvas_layout: permit part_type_get on invalid parts 
Summary:
this is the only way to determine whether a part is invalid, so it should
be usable without triggering errors

@fix
Depends on D8948

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8949
 2019-05-30 10:19:33 -04:00
Mike Blumenkrantz 40c8c1736e edje/load: (more) correctly handle part updates after changing edje group 
Summary:
if a part changes its type, verify that the new type is compatible AND
exists before attempting to re-set the previous state, otherwise take
action and print warning

@fix
Depends on D8947

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8948
 2019-05-30 10:19:30 -04:00
Mike Blumenkrantz c494cb3e74 ecore/timer: fix handling of timer freeze during construction 
Summary:
timer has no loop pointer until it is finalized

@fix
Depends on D8918

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8947
 2019-05-30 10:19:26 -04:00
Mike Blumenkrantz 705096d017 gl_generic: handle image orientation setting when texture has not been created 
Summary:
this occurs when orientation is set during image construction

@fix

Reviewers: segfaultxavi, cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl_rendering

Differential Revision: https://phab.enlightenment.org/D8916
 2019-05-30 10:19:23 -04:00
Mike Blumenkrantz ab4c08126e edje/calc: correctly handle swallow/group objects as clippers for state clips 
Summary:
in the case where the clipper being set was an indirect object, it's necessary
to resolve the lookup for that part and use the actual part object to avoid
setting a placeholder rect as the clipper

@fix
Depends on D8850

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8851
 2019-05-30 10:19:15 -04:00
Xavi Artigas 4e8dc270f9 Efl.Ui.Flip: Silence warning 
The Efl.Ui.Orientation enum is actually made of flags, which we can OR
together, and it includes bitmasks for easier manipulation.
gcc expects switch() statemenets to include all enum values and nothing
but the valid enum values, which is abit too restrictive for flags.
Casting to int removes the warning.
 2019-05-30 10:19:12 -04:00
Yeongjong Lee ce49884b16 efl_ui_relative_layout: prevent infinite loop in chain calculation 
Test Plan:
test code
```
EAPI_MAIN int
elm_main(int argc, char **argv)
{
   Eo *win, *layout, *btn1, *btn2, *btn3;

   win =  efl_add(EFL_UI_WIN_CLASS, efl_main_loop_get());
   layout = efl_add(EFL_UI_RELATIVE_LAYOUT_CLASS, win,
                    efl_content_set(win, efl_added));

   btn1 = efl_add(EFL_UI_BUTTON_CLASS, layout);
   btn2 = efl_add(EFL_UI_BUTTON_CLASS, layout);

   efl_ui_relative_layout_relation_right_set(layout, btn1, btn2, 0.0);
   efl_ui_relative_layout_relation_right_set(layout, btn2, btn1, 0.0);

   efl_ui_relative_layout_relation_left_set(layout, btn2, btn1, 1.0);
   efl_ui_relative_layout_relation_left_set(layout, btn1, btn2, 1.0);

   elm_run();
   return 0;
}
ELM_MAIN()
```

Reviewers: Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9032
 2019-05-30 10:19:04 -04:00
Marcel Hollerbach fd2defe9b2 efl_ui_suite: fix errors in focus tests 
Summary:
there have been a few cases where things were just wrong. Like missing
regular nodes in a focus manager that received focus, and stuff like
this. This now fixes all those cases.

Reviewers: zmike, cedric, segfaultxavi

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9021
 2019-05-30 10:18:44 -04:00
Jaehyun Cho 70d23591d1 efl_ui_stack: fix not to keep final state of push/pop animations 
It is just required to show pushed content and hide popped content after
the push/pop animations.
Therefore, it is not required to keep the final state of the push/pop
animations after finishing the push/pop animations.
 2019-05-30 10:18:02 -04:00
Vincent Torri 2e7df123e3 ecore_evas win32: fix warning reported by clang 
Test Plan: compilation

Reviewers: zmike, raster, cedric, Hermet

Reviewed By: Hermet

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9025
 2019-05-30 10:17:56 -04:00
Hermet Park 680ab7b377 efl_ui_textpath: redraw text properly. 
It needs redraw since text draw depends on the obj' size.
 2019-05-30 10:17:41 -04:00
Mike Blumenkrantz 18614bcd30 elm_widget_item_static_focus: mark param as used 
Summary: Depends on D8935

Reviewers: bu5hm4n, devilhorns

Reviewed By: bu5hm4n, devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8936
 2019-05-30 10:16:56 -04:00
Mike Blumenkrantz 30af2c5637 efl_ui_focus_manager_sub: handle manager change when tree is set to unfocusable 
Summary:
in this case, the event is emitted and no manager exists because the objects
are not focusable

@fix

Reviewers: bu5hm4n

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8935
 2019-05-30 10:16:53 -04:00
Mike Blumenkrantz be4590ee41 elm_color_class: use legacy event for genlist selection 
Summary:
this fixes the selection callback and makes the widget work again

@fix

Reviewers: bu5hm4n

Reviewed By: bu5hm4n

Subscribers: bu5hm4n, cedric, #reviewers, #committers

Tags: #efl_widgets

Differential Revision: https://phab.enlightenment.org/D8913
 2019-05-30 10:16:47 -04:00
Mike Blumenkrantz d159c7880f evas/render: fix proxy clipping when source_clip is disabled 
Summary:
when source_clip is disabled, the clipper used should be the one used by
the proxy object. previously this would never be the case, meaning that
disabling source_clip had no effect

@fix
Depends on D8879

Reviewers: Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8880
 2019-05-30 10:16:11 -04:00
Mike Blumenkrantz 1e83977742 evas_render: deduplicate mapped mask render code 
Summary:
this code block was repeated multiple times throughout the function

no functional changes

Reviewers: cedric, kimcinoo

Reviewed By: kimcinoo

Subscribers: kimcinoo, #reviewers, #committers

Tags: #efl_rendering

Differential Revision: https://phab.enlightenment.org/D8837
 2019-05-30 10:15:59 -04:00
Christopher Michael 4d2c25456c benchmarks: Fix copy-paste error 
Coverity reports this as a copy-paste error, and checking the code it
certainly looks that way, so lets call the proper hash function here

Fixes CID1401052

@fix
 2019-05-30 10:14:01 -04:00