Elementary based programs composed of widgets and containers. This means
that every widget will be inside a container, or will be the base
container, usually set as a resize object of the window.
Taking advantage of this structure, we can leave the frame area
calculation be done by elementary, not relying anymore on the framespace
available from Evas.
This commit fixes the problems related to the wayland framespace on
Elementary, while the final implementation of the said framespace is not
done yet on Ecore and Evas. Later it can be easily changed to use the
available infrastructure.
SVN revision: 79491
*note: this commit - callback behavior - would be disputable as genlist becuase list has
"clicked,double", "selected" and "activated" signal and smart callback also.
but the access acitvate callback works as the item is selected.
SVN revision: 79451
*note: this commit - callback behavior - would be disputable, becuase genlist has
"clicked,double", "selected" and "activated" signal and smart callback also.
but the access acitvate callback works as the item is selected.
SVN revision: 79369
because target object could have different gesture callback with different gesture object.
after _callbacks_unregister() is called, only one callback remains.
SVN revision: 79317
Subject: [E-devel] [E-Devel][Patch][Elementary]Map: Remove delayed job
This patch removes delayed jobs in elm_map.
Previously delayed job is used for queuing the zooming & zoom mode
changing & overlay_showing API requests. Queued jobs are all executed
when pan is calculated.
But actually queued jobs are not needed to be executed. Just last
jobs are needed to be executed per pan calculation.
So I removed delayed jobs and fill calc job functions to be executed
while calculation is executed.
SVN revision: 79269
1. add smart_activate(); to access object.
2. add an API _elm_access_activate_callback_set();
- this callback is called when user wants to activate access object
which would represent widget item or edje part object.
3. add owner referece to the Elm_Access_Info for access object.
4. clock: use _elm_access_activate_callback_set();
SVN revision: 79199
Hi all,
I had prepare some doc fix for elm_fileselector_entry_inwin_mode_set.
By mistake docs said it returns EINA TRUE in both cases.
Please verify attached file.
Regards,
Patrick
Signed-Off-By: Patryk Kaczmarek<patryk.k@samsung.com>
SVN revision: 79089
i would like to add access enhancement to the toolbar.
please review the attached. if there are no objections, I will commit it.
cordially,
shinwoo kim.
SVN revision: 78995
On Thu, Nov 8, 2012 at 12:42 PM, Rajeev Ranjan <rajeev.r@samsung.com> wrote:
Hi,
Attached is a patch to update documentation for gengrid related to changing longpress_timeout value in gengrid.
Signed-off by: Rajeev Ranjan <rajeev.r@samsung.com>
Thank you.
Regards,
Rajeev
SVN revision: 78990
I attached new patch.
The old patch's default position and mirroring problem has been fixed.
I added new 2 APIs for supporting various notify's postion.
EAPI void elm_notify_align_set(Evas_Object *obj, double horizontal, double vertical); EAPI void elm_notify_align_get(const Evas_Object *obj, double *horizontal, double *vertical);
And below 2 APIs will be deprecated.
EINA_DEPRECATED EAPI void elm_notify_orient_set(Evas_Object *obj, Elm_Notify_Orient orient); EINA_DEPRECATED EAPI Elm_Notify_Orient elm_notify_orient_get(const Evas_Object *obj);
Please review this patch.
Thanks:)
Signed-Off-By: Seunggyun Kim<sgyun.kim@samsung.com>
SVN revision: 78655
I attached new patch.
The old patch's default position and mirroring problem has been fixed.
I added new 2 APIs for supporting various notify's postion.
EAPI void elm_notify_align_set(Evas_Object *obj, double horizontal, double vertical); EAPI void elm_notify_align_get(const Evas_Object *obj, double *horizontal, double *vertical);
And below 2 APIs will be deprecated.
EINA_DEPRECATED EAPI void elm_notify_orient_set(Evas_Object *obj, Elm_Notify_Orient orient); EINA_DEPRECATED EAPI Elm_Notify_Orient elm_notify_orient_get(const Evas_Object *obj);
Please review this patch.
Thanks:)
Signed-Off-By: Seunggyun Kim<sgyun.kim@samsung.com>
SVN revision: 78653
WARNING: I don't believe this is the proper bug fix for an uninitialized
memory access, but I really don't know this code enough. Tasn if you could
look at it when you have time.
SVN revision: 78511
i would like to add access feature to the panel.
please review the attached. if there are no objections, I will commit it.
cordially,
shinwoo kim.
SVN revision: 78428
genlist could have LOTS of items. so it would be better to use only displayed items for the focus chain.
please check the attachment and give feedback. thanks.
cordially,
shinwoo kim.
SVN revision: 78378
Subject: [E-devel] [E-Devel][Patch][Elementary]Genlist - Edje Item
Cache Refactoring
This is patch for reconstructing genlist's item cache.
Each item cache functions do harsh jobs so just push,pop by
Elm_Gen_Item * now.
Before, cache is disabled by comments. But I enabled item cache again
(even for the case which tree_effect_enabled is on).
I changed some functions:
_item_cache_find() --> _item_cache_pop()
_item_cache_add() --> _item_cache_push()
_item_cache_zero() -->_item_cache_all_free()
And I removed _item_cache_clean() function because I made
_item_cache_push() to don't exceed the item_cache_max. So clean-up of
cache is not needed anymore.
Breaks "genlist 2" test and clouseau. Just open genlist 2, press the "X"
button, and then the "+" button.
This reverts commit 77944.
SVN revision: 78336
On Fri, Oct 19, 2012 at 12:30 PM, Bluezery <ohpowel@gmail.com> wrote:
> Dear all,
>
> There is a bug, invalid data assign into ecore_job.
> Trivial whilte space removal is included also. it's automated in my editor :D.
>
> Please review this patch.
>
> --
> BRs,
> Kim.
SVN revision: 78221
If the sum of item's min is larger than the viewport size in ELM_TOOLBAR_SHRINK_EXPAND mode,
it can be scroll. And the end of the item is fitted on the end of the viewport.
SVN revision: 78156
Subject: [E-devel] [PATCH][ELEMENTARY][BUG Fix] Current Reordering
item is not resizing on genlist resize (e.g On roation)
Please review the attached patch created to fix the current reordering
item
resizing issue.
[ISSUE] Current genlist reordering item is not resizing on genlist
resize
(e.g. On rotation).
Change Description:
In _calc_job call back, the width of reordering item is corrected.
SVN revision: 77992
Subject: [E-devel] [patch][elementary] diskselector - blank item
should be added on round disabled mode
blank item should be added on the round disabled mode.
current diskselector adds blank item even though the round mode is enabled.
so please check the patch and give feedback. thanks.
SVN revision: 77990
Subject: [E-devel] [patch][elementary] toolbar - highlighting item on
access
the current toolbar does not show highlight effect on accessibility mode.
the attached would give the highlight to toolbar item.
please review the patch and give feedback. thanks.
SVN revision: 77972
Subject: [E-devel] [patch][elementary] conformant - use layout focus
next, direction
um.. there would be a reason to not use focus next and direction stuff..
please let me know why the conform does not use those..
if there is no reason, please keep the patch. thanks.
SVN revision: 77947
Subject: [E-devel] [E-Devel][Patch][Elementary]Genlist - Edje Item
Cache Refactoring
This is patch for reconstructing genlist's item cache.
Each item cache functions do harsh jobs so just push,pop by
Elm_Gen_Item * now.
Before, cache is disabled by comments. But I enabled item cache again
(even for the case which tree_effect_enabled is on).
I changed some functions:
_item_cache_find() --> _item_cache_pop()
_item_cache_add() --> _item_cache_push()
_item_cache_zero() -->_item_cache_all_free()
And I removed _item_cache_clean() function because I made
_item_cache_push() to don't exceed the item_cache_max. So clean-up of
cache is not needed anymore.
SVN revision: 77944
Subject: [E-devel] [patch][elementary] diskselector - bug fix
diskselector has two bugs.
1. on round enable mode
elm_diskselector_item_append(); does not call elm_box_pack_*() for
over_items and under_items which are added when the display item is
bigger
than 3.
because over_items and under_items is not added, the diskselector shows
just 4 items + half item(NOT 5 items), in case of display item number
is 5
- elm_diskselector_display_item_num(obj, 5); -.
this bug could be found only if u use as following sequence.
a. elm_diskselector_round_enabled_set(obj, EINA_TRUE);
b. elm_diskselector_item_append();
2. on the round disable mode + bigger than 3 display item
even though display item is bigger than 3 on the round disable
mode, only
two blank items are added - left_blank, right_blank.
because of this, the first item could not be selected. means.. the first
item cannot be located in the middle of diskselector.
if u scroll the diskselector to the left-most, then the second item is
selected as below.
[blank] [ 1st ] [ 2nd ] [ 3rd ] [ 4th ]
so if the display item is bigger than 3, more blank items would be
necessary.
include lines to resolve above 1st bug, the patch would resolve
this issue
also.
SVN revision: 77740
Subject: [E-devel] [patch][elementary] multibuttonentry - access feature
i have attached a patch which has access feature for the multibuttonentry.
it was hard time to implement access feature on the multibuttonentry than
others.
SVN revision: 77738
Subject: [E-devel] [elementary] size value checking in elm config
This patch contains size value checks for some functions in elm_config
file.
I think that calling these function with negative size values has no
sense.
SVN revision: 77734
It was always increasing quicklaunch count on init, but
only reducing on shutdown when _elm_init_count is zeroed,
i.e., the quicklaunc_shutdown rountine wasn't being executed.
SVN revision: 77378
With ELM_POLICY_EXIT it's possible to request elementary
to delete all the windows before shutdown instead of just
quitting the main loop.
SVN revision: 77328
It's weird, but looks like wrap mode of the spinner is broken at least
since the move of elm to trunk.
The current code:
if (sd->wrap)
{
while (new_val < sd->val_min)
new_val = sd->val_max + new_val + 1 - sd->val_min;
while (new_val > sd->val_max)
new_val = sd->val_min + new_val - sd->val_max - 1;
}
doesn't seems correct. Since even the documented example would fails:
* E.g.:
* @li min value = 10
* @li max value = 50
* @li step value = 20
* @li displayed value = 20
*
* When the user decrement value (using left or bottom arrow), it will
* displays @c 40, because max - (min - (displayed - step)) is
* @c 50 - (@c 10 - (@c 20 - @c 20)) = @c 40.
With the current code the value will be 41.
It also could lead to values above min, like happens on the first spinner test,
when you could go to -50.5 because new value will become:
250 + (-50.5) + 1 - (-50) in the first while() and later since these value
is bigger then 250, would go back to -50.5 ...
So, a reasonable algorithm would be
if (sd->wrap)
{
if (new_val < sd->val_min)
new_val = sd->val_max + new_val - sd->val_min;
else if (new_val > sd->val_max)
new_val = sd->val_min + new_val - sd->val_max;
}
But it doesn't works fine for cases like the months spinners test, when you
have min = 1, max = 12, step = 1 and each option should be displayed with
wrap. This algorithm would wraps from 1 to 11, so would skip December...
So, I think just going to the max value when min is reached is the better
choice.
if (sd->wrap)
{
if (new_val < sd->val_min)
new_val = sd->val_max;
else if (new_val > sd->val_max)
new_val = sd->val_min;
}
SVN revision: 77278
On Fri, Sep 28, 2012 at 10:04 PM, Bluezery <ohpowel@gmail.com> wrote:
> Dear EFL developers,
>
> In current genlist reorder mode, reordering is not moved when
> reordering item is on top or in bottom of within genlist objec because
> of scroller's hold mode.
> After mouse point is moved out of genlist object, then reordering item
> can be moved.
> But in mobile, mouse point can not be moved out of window (if genlist
> item is expanded in window).
> So I add some tweaks to reordering item can be moved when reordering
> item is moved on top item or bottom item.
>
> Please review this patch.
>
> BRs
> Kim.
SVN revision: 77255
This can happen on window deletion scenario:
the parent object is elm_widget_sub_object_del()ed BEFORE it gets
evas_object_del()ed, so its children won't reach the window anymore.
SVN revision: 77206
Subject: [E-devel] [Patch] multibuttonentry - data corruption issue of
the box list
here is a problem in the data corruption of the box list in
_box_layout_cb() of the multibuttonentry.
EINA_LIST_FOREACH is used to move and resize the objects.
but if box unpack/pack is called in the EINA_LIST_FOREACH loop,
the data of the box list will be corrupted.
This problem can not be solved immediately due to the structural
problems of
the MBE.
So the attached patch, a workaround, avoids calling unpack/pack in the
EINA_LIST_FOREACH loop.
I am in the process of refactoring MBE but in the mean time,
this patch will resolve the above issue.
SVN revision: 77192
Subject: [E-devel] [patch][elementary] diskselector - checking middle
item
the diskselector object x-coordinate would not be 0.
but the _scroll_animate_stop_cb() calculates selected item with assumption
that the diskselector object x-coordinate is 0.
so different item which is not in middle of diskselector is selected.
SVN revision: 77182
Hi All,
Please find attached patch for naviframe animation optimization.
This patch makes sure animation happens smoothly even if content is heavy.
i.e, this patch makes sure animation is deferred so that it is visible(showing full transition time)
even if content takes more time in creation.
Change description:
Naviframe Animation optimization for smoother animation.
Signed-off by: Shilpa Singh<shilpa.singh@samsung.com>
Thanks & Regards
Shilpa Singh
SVN revision: 76929
Subject: [E-devel] [patch][access] bubble - access feature
the attached has access feature for bubble widget.
please review it and give some feedback. thanks.
SVN revision: 76798
Subject: [E-devel] [patch][elementary] access - activate widget
Subject: [E-devel] [Patch][elementary] scroller, slider - access
activate feature
the previous activate function just get object only. to activate scroller
or slider etc.. it needs more information. so the patch changed previous
activate(Evas_Object *obj) to activate(Evas_Object *obj, Elm_Activate act);
the Elm_Activate can be one of ELM_ACTIVATE_DEFAULT, UP, DOWN, RIGHT, and
LEFT.. you can add more if it is necessary.
I have attached two patches. one is for the slider and the other is for the
scoller.
this patch would support those who wants change value of slider or content
position of scroller on remote side.
this would be useful to the access side or voice control side also.
SVN revision: 76717
Subject: [E-devel] [patch][elementary] bubble - text set does not
display info text part
current bubble dose not display 'info' which is TEXT part.
i have learned that the following commit would be reverted.
http://trac.enlightenment.org/e/changeset/71516/trunk/elementary/src/lib/elm_bubble.c
or remove 'else' from 'else if' on current
_elm_bubble_smart_text_set();.
anyhow i made a diff and attached. please find it and give feedback.
thanks.
SVN revision: 76669
Subject: [E-devel] [patch] Add APIs for floating mode
I added APIs for supporting the floating mode -
elm_win_floating_mode_set, elm_win_floating_mode_get.
The floating mode will be used on mobile environment. For example, if
the video-player window set the floating mode, then e (enlightenment
window manager) changes it's geometry and handles it like a popup.
Please check these APIs and give an advice for me.
SVN revision: 76667
Subject: [E-devel] [Patch] [Elementary] Support for circular effect in
elm_diskselector, in case scroller's bounce effect is disabled.
Can someone please review the attached patch created by Sumanth.
[Issue Details] :
elm_diskselector_round_enable_set() API is not working, if
elm_scroller's bounce effect is disabled.
[Root cause] :
For diskselector circular effect, the boundary checking is done based
on scroller's geometry.
If bouncing effect is disabled in elm_scroller, its geometry can lie
between 0 on left and CHILD_SIZE on right but it can never go beyond
that point.
Unless the scroller's geometry goes beyond its child (here, elm_box)
size, diskselector cann't trigger the circular effect.
[Change Description] :
For diskselector items circular effect, the boundary checking is
performed at the left/right edges of its child, elm_box.
Once the scroller reaches to the left/right edge of box or goes beyond
that point, circular effect will be triggered.
SVN revision: 76606
using this, we can establish indicator service.
I'll implement more indicator service feature using elm_plug and elm_compoment.
after finishing all indicator and compoment feature I will add change log and news
SVN revision: 76533
Subject: [E-devel] [patch][elementary] index - add access feature
the attachment has access features for the index. and this patch is
depends
on the previous patch which has
_elm_access_edje_object_part_object_unregister();
to find the previous patch, please refer to the following
http://sourceforge.net/mailarchive/forum.php?thread_name=CAP-c0nG8NkMx3J-YkSJnWdB23cWOPrtk1Rx10Lae0Zwxst1eeQ%40mail.gmail.com&forum_name=enlightenment-devel
the index could have two levels, one is level 0, the other is level 1.
the
patch supports only level 0 because we have no style for the level 1..
(just a cowardly excuse, i will keep up with this.. and update..)
SVN revision: 76532
Subject: [E-devel] [patch][elementary] diskselector - text align issue
by default diskselector item has space for icon even though the item does
not have icon.
so in some cases, the text is not located in the center of item and
diskselector.
the attachment would resolve this issue. please look into it and give
feedback. thanks.
SVN revision: 76507
Subject: [E-devel] [Patch] [Elementary] ctxpopup - correct position
and size of ctxpopup
With ctxpopup, if it has many items and user uses -1 as parameter in
set direction priority function,
the ctxpopup position and size are calculated incorrectly.
Ex:
elm_ctxpopup_direction_priority_set(ctxpopup,
ELM_CTXPOPUP_DIRECTION_DOWN, ELM_CTXPOPUP_DIRECTION_UP, -1, -1);
SVN revision: 76505
Subject: [E-devel] [patch][elementary] calendar - add access feature,
access - add _elm_access_edje_object_part_object_unregister();
the attachment has accessibility feature which is for the
elm_calendar. and
moreover..
it would be better to keep one more api for the access which name is
_elm_access_edje_object_part_object_unregister();
in the case of calendar item, its text part could be set with empty
value
in run time(dynamically), even though it had a value (1~31) previously.
so if there is an empty field(item), then previously registered item
should
be unregistered. the api would be useful not only this case but also
others.
then, please review the patch and give feedback. thanks.
SVN revision: 76502
This is already handled in elm_widget_type_check, and there it actually
prints an error message, like it should.
Patch by Daniel Zaoui.
SVN revision: 76461
Dear all,
With ctxpopup, if it has many items and user uses -1 as parameter in set direction priority function,
the ctxpopup position and size are calculated incorrectly.
Ex:
elm_ctxpopup_direction_priority_set(ctxpopup, ELM_CTXPOPUP_DIRECTION_DOWN, ELM_CTXPOPUP_DIRECTION_UP, -1, -1);
I would like to send a small patch to fix this issue.
Please take a look on it.
Thanks & Regards,
Thiep Ha
Signed-Off-By: Thiep ha<thiep.ha@samsung.com>
SVN revision: 76452
Subject: [E-devel] [patch][elementary] popup - smart theme
popup have used notify its internal widget. but popup does not take care
the notify theme in its smart_theme()
the attachment just add a line to set style to the notify and test code
also. please review and give feedback. thanks.
SVN revision: 75987
Subject: [E-devel] [patch][elementary] access - add activate callback
till now, accessibility has used ecore_x_mouse_*_send(). the patch has
activate callback which takes place of the ecore_x_mouse_*_send() stuff.
if the access module is enabled and 'double tap' is detected, elm_win
will
receive ECORE_X_ATOM_E_ILLUME_ACCESS_CONTROL message with
ECORE_X_ATOME_E_ILLUME_ACCESS_ACTION_ACTIVATE and call the activate
callback for the accessibility. that's it.
SVN revision: 75978
Subject: [E-devel] [patch] change plug-in loading behavior in elm_map
Elm_map have 3 modules (Tile, Route, Name) for plug-in loading
When elm_map is added, each 3 modules search plug-ins
(elm_map does use eina_module, not elm_module because elm_map loads
several modules. )
Previously, Each modules in elm_map search modules separately.
So module init /shutdown function in each plug-in is called 3times.
This can cause problems.
I fixed that module init is called at one time and module never be
unloaded (in process life-cycle).
SVN revision: 75974
Subject: [E-devel] [Patch] [Elementary] elm_datetime widget bug fix:
elm_datetime_field_limit_set() API is not working for min/max boundary
conditions
Hi,
Please review the attached patch for fixing issue in API
elm_datetime_field_limit_set() for boundary values.
It has been created by Sumanth for datetime widget.
[Issue Details]:
elm_datetime_field_limit_set() API is not working well for boundary
values.
[ex: for date, we can't set max limit as 31 and for minute, we can't
set 60 etc..
- it fails at boundary conditions of Min/Max limit for all
datetime fields.]
[Root cause]:
Boundary condition checking has not been done in a proper way.
[Change Description]:
Boundary checking condition is corrected and the min/max limit
boundary values are included as API input.
Signed-Off-By: Sumanth Krishna (sumanth.m@samsung.com)
Signed-Off-By: Rajeev Ranjan (rajeev.r@samsung.com)
SVN revision: 75958
On Fri, Aug 31, 2012 at 8:50 PM, Bluezery <ohpowel@gmail.com> wrote:
> Hello,
>
> Sometimes reorder animation ended incorrectly
> You can test & see the problem when background color is black and
> genlist item color is white.
> I made the added value for animation as difference between old item
> position and new item position if difference is below predefined dy.
> (y = diff, if diff < dy) So item position can be finally new item
> position at last.
> Please review this patch.
>
> Thanks
SVN revision: 75950
hooks.
The former is now issued for all scrollables, with the behavior it had
before, and the latter is a new virtual base function, with a default
implementation leading to values matching the old case where one
didn't implement the hook.
Please help me test if everything is OK -- it seems so, here.
SVN revision: 75904
That needs to be done in other way.
Revert "From: Kim Shinwoo <kimcinoo.efl@gmail.com>"
This reverts commit 9d6e461366a0eb208d75b0a1fb5c0c822b761c71.
SVN revision: 75836
Subject: [E-devel] [patch][elementary] diskselector - select option,
disabling auto selection. datetime - show even number of items
by default, an diskselector item which is right in the center of
diskselector is selected automatically.
and if the item style emit elm,action,click signal, the item is selected
also.
so there would be a case that item select callback is called by two
ways.
one is clicking the item,
the other is locating item right in the center of diskselector (if
number
of displayed item is odd, then after scrolling the selected callback is
called always).
because of this reason, datetime module always set number of displayed
item
to even number.
to resolve this issue, i add a api to enable or disable default
behavior -
the auto selection - that can be found on the attachment.
moreover the second attachment is for datetime module, now the
datetime can
show even number of items.
SVN revision: 75820
Wayland windows.
Remove x11, wayland, and local bits from cnp init.
Fix up elm_cnp_init to not need an object anymore.
Add missing function prototypes for the wl functions.
Add an init counter for the wl cnp init function so we don't end up
with multiple event handlers.
SVN revision: 75816
Hi All,
Please find attached elc_naviframe bug fix patch.
Change description:
Generic text parts and content parts signals not sent hence UI not coming properly issue fixed.
Thanks & Regards
Shilpa Singh
Signed-Off-By: ShilpaOnkar Singh<shilpa.singh@samsung.com>
SVN revision: 75803
Hello all,
In elm_index.c, _item_del_pre_hook calls _item_free, where it->letter
is not set to NULL after eina_stringshare_del.
This will cause invalid access later on. The attached patch fixes the
problem, which is reproducible in my code before the fix.
Please check if this makes sense.
I am sorry that I was unable come up with a simple test app to
demonstrate the problem.
Thanks in advance.
Brian
Signed-Off-By:Brian Wang<brian.wang.0721@gmail.com>
SVN revision: 75723
Hi,
Attachment to the mail is elm_segment_control patch.
Change Log:
1. Generic Text support to segment items.
2. Generic Content support to segment items.
Signed-Off-By: PRINCE KUMAR DUBEY <prince.dubey>@samsung.com>
Thank you,
Prince
SVN revision: 75719
the wayland engines).
The focus handler which traps key events needs to listen for
ISO_Left_Tab also (which is what xkb reports for Shift+Tab).
SVN revision: 75618
NB: This is done because of the way slider handles the popup (indicator).
It is not getting trapped in the evas functions (or rather, the popup
falls through the traps there) so framespace is not accounted on the
popup, resulting in improper popup position when run in wayland.
NB: This is the only widget known to need this.
SVN revision: 75546
evas_object_resize call.
Not sure if this was a fat-finger c/p issue, or just plain
blindness/stupidity. How this remained in code for so long
without anybody seeing it is beyond me.
SVN revision: 75544
impl that manages copy & paste within a single process... this is an
example of how to implement cnp for another system and as well covers
fb cnp.. so terminology in fb has cnp work now :)
SVN revision: 75533
Subject: [E-devel] [Patch] elc_multibuttonentry resize patch.
Currently, there is a problem in the logic of getting the size in the
MBE's
box.
For each line, the height of the line is calculated according to the
biggest
item's height
and is applied to the box size, but problem occurs when the newly added
item's height is larger than the one before.
For example, when the entry is located in the front of the last line,
the line's height is determined by the entry.
When the button is added by the user's input at this state,
because button's height is larger than the entry's height
I have modified each line to have the equal height.
SVN revision: 75453
Dear, all
I've attached a patch that fixed the memory leak.
There is not a free() in _del_hook().
Please review this patch.
Sincerely yours,
Jihyeon Seol
Signed-Off-By: JiHyeon Seol<jiheyon.seol@samsung.com>
SVN revision: 75439
Subject: [E-devel] [patch][elementary] * access *
Series of of pathes from kim shinwoo. looked good to me - so in they
go, finishing off some more access mode to be more complete.
SVN revision: 75415
- swallow: do not use magic constant '12' and assume it was prefixed
with 'elm.swallow.';
- text: use part name and now always 'text'
SVN revision: 75338
the case of resetting the wayland cursor image. Fixes ticket #1293.
Increase the size of the event rects on the border theme to allow for
easier resizing.
SVN revision: 75313
Basically, we will remove the frame when going into fullscreen, and
readd when we leave fullscreen. When we remove the frame, then during
window redraw the appropriate fullscreen size will be calculated.
This allows proper fullscreening.
SVN revision: 75294
set it all the time themselves for read-only use outside. :) if uw ant
this u have to accomplish this another way. eg table with genlist PLUS
invisible rect obj at the same cell spot (0, 0, 1x1). and make the
invisible rect have a min size hint. table takes care of using the
"constraints" of both rect and gnelist then for sizing. :)
SVN revision: 75044
next/prev item - needed to add a feature to scrolelr (and accidentally
also to scrolled interface too :)) to make this work. now works.
SVN revision: 74969
1. on shutdown it calls lots of selected callbacks as it delets items
- wrong.
2. segv waiting to hapen due to list management (brian wang report).
SVN revision: 74956
Delete requests where not being called when the frame close button was
pressed. I know this is not the 'ideal' fix (which is why I left
myself a FIXME here), HOWEVER the Ideal fix would mean breaking the
Feature Freeze (and potentially API), so I will wait until freeze is
over for that. For now, this fixes the 'bugger' in a non-instrusive way.
SVN revision: 74946
resizing.
Previously, we only changed the mouse cursor when the border frame was
actually clicked. Now we can change it when the mouse moves over the
border/frame areas (like in X11). This adds a callback from the edc to
know when and where the mouse moves (with respect to the frame border
only). (IE: When the user moves the mouse over the bottom portion of
the border, the edc will let us know and we can change pointer
accordingly).
SVN revision: 74925
and "focus-out"."
This reverts commit 1bb12050b9785d47e102b4a3633210316d408f0d.
Conflicts:
ChangeLog
NEWS
Cedric, this is just wrong. The *on_focus* smart function of the base
widget is now the central place to handle focus in/out events.
I'll fix the spinner in sequence.
SVN revision: 74853
Widgets having internal panning objects won't have so fancy inheriting
schemas for those very objects, but they should be fine with
re-defining their own, if they want/need and overwriting it in their
smart_add()s.
SVN revision: 74682
Subject: [E-devel] [patch][elementary] ctxpopup, focus-chain
i'd like to raise an issue about focus chain on the ctxpopup. the focus
would go around only in the ctxpopup. (IMHO, raster keep the previous
popup
patch. so definitely!!)
but.. first of all, current ctxpopup does not have focus_next(). even
though there is focus_next(), it is not work properly,
because the parent of ctxpopup would be a widget which does not take
care
of sub objects in the focus_next(); such as elm_list.
(every widget can be a parent of ctxpopup, if the widget is enough
size to
display ctxpopup. thus the elm_list can be a parent of ctxpopup also).
anyhow, to resolve this issue, the patch uses event() of
elm_widget_event_hook_set().
the ctxpopup item is equal to the elm_list item. but the focus chain of
elm_list does not work properly.
generally, we use 'Tab' key to move focus, but elm_list uses the
(up,down)
arrow key moreover it is not a focus.
if you want to check this patch, it would be better to use
ELM_ACCESS_MODE=1.
SVN revision: 74650
Subject: [E-devel] [patch][elementary] dayselector - focus chain, and
about accessibility policy.
dayselector does not work in focus cycle because there is no
focus_chain().
because dayselctor is a child of Elm_Layout_Smart_Class, so it is
enough to
use focus_chain() of layout.
and.. very carefully..
i'd like to raise an issue that currently visually impaired person
should
be obliged to click(tap) quickly two times to activate widget such as
button, check.
the implementation to check 2nd click in elm_access is great. but one
single click is enough to activate button or change state of elm_check.
moreover some widgets like dayselector which has customized style for
elm_check does not work properly, because they do something at signal
'mouse,down,1'.
SVN revision: 74649
Subject: [E-devel] [patch][elementary] naviframe - focus chain, access
i have attached a patch to fix focus chin issue when the item title is not
visible. and to add accessibility feature.
SVN revision: 74646
NOTE: This improve calendar performance quite a lot, but a better improvement
would be to populate the object when we really need it. I don't know how to
do that in current Elementary source code. Reason for another expected massive
improvement is that every time you set a property on an Elm_Calendar trigger
a populate and that one is costly (Around 6 populates call per Elm_Calendar in
our code example, meaning doing it could give us a 6 times boost...).
SVN revision: 74553
Subject: [E-devel] [patch][elementary] popup - focus chain,
accessibility
you would be in rush because of freezing.. but there is still hot. -_-;
i'd like to raise an issue about focus chain on the popup. The focus would
go around only in the popup. (IMHO)
but current popup gives a chance to get the focus to other widget which is
not in the popup.
please check the attachment which has accessibility feature also and give
your opinion. thanks.
SVN revision: 74467
initializing text parts first. Patch by Bluezery <ohpowel@gmail.com>
On Thu, Jul 26, 2012 at 2:29 PM, Bluezery <ohpowel@gmail.com> wrote:
> Hello,
>
> This patch make genlist free their text parts when each item is
unrealized.
> Before this patch, the item is just cached when an item is unrealized
> and the text part is freed and set by other text when the cached item
> is realized.
> This improves scrolling performance with very long text because this
> can reduce needless edje size recalculation time.
> Please review this patch.
>
SVN revision: 74413
This fixes "elm - genlist decorate all mode on and scroll - garbage
items left around."
Note: Do not manipulate swallowed items. Unswallow it first then
manipulate it.
SVN revision: 74412
Subject: [E-devel] [patch][elementary] popup - getting proper geometry value]
current popup does not give proper geometry value,
evas_object_geometry_get(popup, &x, &y, &w, &h) gives 0, 0, 0, 0.
the patch resolves it, but it would be not a good way to get geometry
value. which is the best way to set obj->cur.geometry.x(y,w,h)?
please enlighten me. thanks.
SVN revision: 74409
- fixed theme to look less like an arse:
- overlap theme is translucent
- naviframe title visibility toggle is now animated
- item pop/push animation now applies to title area as well
- icon without title label is now centered (see Naviframe 2 test)
- title label and subtitle are now centered among the free space, should not overlap buttons anymore.
- title will use a font-size range, trying to not overlap buttons anymore.
- title will use ellipsis, trying to not overlap buttons anymore.
- prev/next buttons do not have a fixed min/max size anymore
- emit signals elm,state,title_label,show and elm,state,title_label,hide
- by default the previous button label is the title of the previous page
however by using a regular elm_button with an icon and long label
exposes a bug with button theme. And there is a conceptual issue: if
the previous button label is too big, it will look horrible. We should
have a maximum size that, if reached, should have ellipsis. This
should be a different elm_button style, with
elm/button/base/naviframe/back_btn/default being an alias to it.
SVN revision: 74403
back button now uses standard icon "arrow_left", and provides a "Back"
text that should be translated with the application.
Then we can define the elm/button/base/naviframe/back_btn/default as
an alias to the default button. If a theme wants it could still
provide an alternative button. IOW no breaks.
SVN revision: 74399
In real world it's very likely you're flipping to something, back or
front, not randomly flipping around based on one button.
I'd say we should deprecate the elm_flip_go().
SVN revision: 74360
whenever we "go" flip while flipping, we'll enter an inconsitent
state. We should detect where to flip and flip back if required.
Test: go to "Flip" test, click "1" button twice, before the first
animation ends.
SVN revision: 74359
Please review this patch I don't know the intention why did someone add this flags on mouse up in scroller.
Anyhow I tested and works fine.
SVN revision: 74334
ChunEon Park
Daniel Juyung Seo
Rafael Antognolli
Jiyoun Park
Shinwoo Kim
Jihoon Kim
Jaehwan Kim
Michael BOUCHAUD
Jonas M. Gastal
Bluezery
Sebastian Dransfeld
Gustavo Lima Chaves
Vincent Torri
Mikael SANS
WooHyun Jung
Seunggyun Kimsgyun.kim
Cedric BAIL
Sanjeev BA
Bruno Dilly
Eduardo Lima (Etrunko)
DUBEYPRINCE KUMAR
Mike McCormack
Carsten Haitzler
KoziarekBeata
Stefan Schmidt
Jihyeon Seol
Aharon Hillel
Doyoun Kang
thiep ha
Tom Hacohen
Rui Seabra
Mike Blumenkrantz
Christopher Michael
Rajeev Ranjan
Eduardo de Barros Lima
Leandro Pereira
Gustavo Sverzut Barbieri
