Commit Graph

19847 Commits

Author SHA1 Message Date
Xavi Artigas 8c09c1cae8 docs: Move property docs to property level instead of set/get
Eolian @properties should be documented at the property level, and
documentation at the setter or getter level should be left to setter-
or getter-specific comments. There is usually no need at all to have
setter- or getter- specific comments.
Also, a property is not a method so descriptions should match that.

This patch removes lots of duplicated text, and will allow enabling
by default the eolian check that ensures that properties have proper
property-level docs.

No functional changes.
2019-09-13 12:30:03 +02:00
Vincent Torri 1f24762fc4 eio: fix warning
Test Plan: compillation

Reviewers: raster, cedric, zmike

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9925
2019-09-12 14:45:58 -04:00
Vincent Torri c00d70982f Evil: fix mmap() and define HAVE_MMAP
Summary: add size of file mapping to fix invalid parameter

Test Plan: compilation (edje succeeds) and elm_test

Reviewers: zmike, cedric, raster

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9913
2019-09-12 10:01:33 -04:00
Marcel Hollerbach 3307e55874 efl_ui_calendar_item: document this class a little bit more
Summary: Depends on D9923

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9924
2019-09-12 13:30:53 +02:00
Marcel Hollerbach 429b6c9c7e efl_ui_image: insert @ to link docs proberly
Summary: Depends on D9922

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9923
2019-09-12 13:26:39 +02:00
Marcel Hollerbach 7c1508cb43 efl_gfx_path: insert @ to link docs proberly
Summary: Depends on D9921

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9922
2019-09-12 13:26:33 +02:00
Marcel Hollerbach e18bce720d efl_ui_scrollable: insert @ to link docs proberly
Summary: Depends on D9920

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9921
2019-09-12 13:26:28 +02:00
Marcel Hollerbach 84487d8257 efl_object: insert @ to link docs proberly
Summary: Depends on D9919

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9920
2019-09-12 13:26:24 +02:00
Marcel Hollerbach 1f96530a1c efl_part: insert @ to link docs proberly
Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9919
2019-09-12 13:26:20 +02:00
Mike Blumenkrantz 7d727bbb26 efl/arrangement: improve docs
Summary:
this adds full docs for the class and properties

ref T7717
ref T7864

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7864, T7717

Differential Revision: https://phab.enlightenment.org/D9912
2019-09-12 11:02:29 +02:00
Mike Blumenkrantz 0dad9503c7 efl/hint: fix hint_align docs
Summary:
the docs should not assume that the current language is LTR and should
instead specify that the horizontal direction depends on the language
reading direction

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9911
2019-09-12 10:57:01 +02:00
WooHyun Jung 31d197b85b efl_ui_timepicker/datepicker : change event name properly
Summary:
This changes the event name from "changed" to "date(or time),changed"

@ref T7869 T7901

Reviewers: segfaultxavi, zmike, bu5hm4n

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7901, T7869

Differential Revision: https://phab.enlightenment.org/D9905
2019-09-12 10:33:12 +02:00
Marcel Hollerbach 5d5128b226 efl_ui_collection: fix the insertion of the first element with pack_at
Summary:
before pack_at with no element failed because the list element has been
NULL.
This fixes the insertion, the codepath also works without the error.
Depends on D9871

Reviewers: zmike, cedric

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9890
2019-09-11 13:38:48 -04:00
Mike Blumenkrantz ad6300aa48 efl_ui/scrollable_content: handle null cases for scrollable_*_get
Summary: these are valid calls and should be handled correctly

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9880
2019-09-11 13:38:41 -04:00
Mike Blumenkrantz 5489482484 efl: check file's mtime in efl.file::file_set to determine if file is the same
Summary:
historically, if the mtime of an edj file changes after being loaded,
the edje file should be reloaded. this needs to occur in a single call
with the previous user definitions intact, so verify that the mtime is
the same in efl.file::file_set when using the same file name

@fix

Reviewers: cedric

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9877
2019-09-11 13:38:21 -04:00
Marcel Hollerbach d5bf69ff53 efl_ui_group_item: fix insertion of item at the end
Summary:
in this case here, eina list count already returns the count *including*
the subobject, the case in pack_at below (where also +1 is added) is
different to that, as count is the value *before* the list add.
Depends on D9870

Reviewers: segfaultxavi, zmike, cedric

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9871
2019-09-11 13:38:13 -04:00
Ali Alzyod c9399b2154 evas_textblock: fix warning
Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9903
2019-09-11 11:07:51 -04:00
Marcel Hollerbach 6028952894 evas_callbacks: make the callback protection a little bit safer
the problem here is that we might subscribe to an event before
evas_object_callbacks_init has happened. This sounds like something
which might not happen. However, with the interfaces project this
definitly will start to happen because someone will some day overwrite
the evas object and do something before the constructor, which will not
raise a error or something but will simply just not work.

With this commit we are not listening to the event callbacks via event
emission but rather via inheritance. With this there is no "earlier than
we listend" point, and the issue in the task is solved by itself.

fix T8202

Reviewed-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D9841
2019-09-11 10:37:21 +02:00
Hermet Park f684e85453 evas vg: optimize memory in layer blending.
Same method to 321035d1e7

By far, with previous memory optimization,

The memory usage is reduced to half of composition buffer size.
2019-09-11 15:15:32 +09:00
Hermet Park 27498629ed canvas vg: optimize memory usage in composition.
Ector buffer allocates memory in default,
We don't need to allocate buffer memory additionally to handle over outside.
We can map/unmap ector buffer for reusing this.
2019-09-11 14:30:16 +09:00
Hermet Park dc0056ca93 ector: removed cairo backend.
For reducing maintainability burden,
We drop supporting cairo backend.

The default backend is to software implementation from now.
It's well maintained so far and works good.x
2019-09-11 13:14:56 +09:00
Hermet Park 3d50083f41 ector: don't alloc memory if the size is 0. 2019-09-11 12:01:25 +09:00
Hermet Park 20abcba3b0 ector: code refactoring.
more neat and clean code, no logical changes.
2019-09-11 12:01:19 +09:00
Marcel Hollerbach 63fd44ef16 efl_ui_widget: refactor constructor
Summary:
first of all, in efl-ui we should probebly ensure that a widget is
always created in a window object. Otherwise we are looking for trouble.

Additionally, calling efl_ui_win_shared_data_get on anything else than a
window object will result in a returned NULL value.
If we are not having a widget parent, there is also not much point in
calling a API that is only defined on the widget base class, so we also
move that away

Reviewers: kimcinoo, raster

Reviewed By: kimcinoo

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9762
2019-09-11 10:43:08 +09:00
Lauro Moura dfb856158c csharp: Skip non-public members from interfaces
Summary:
Eolian allows non-public members in interfaces and mixins (usually
@protected). As both kinds are converted to C# interfaces, this
causes problem as non-public members are forbidden in C# interfaces.

This commit changes eolian_mono by removing those members from the C#
interfaces. If a generated class implements the interface, the method is
generated as if it were a protected member of the class directly.

For mixed properties like `Efl.Io.Reader.CanRead { get; set @protected; }`,
the interface has only the public getter and the the implementing class has both
the public getter and the protected setter.

With this, C# devs won't be able to directly implement protected Eo
methods from interfaces. (But this really does not make sense from the
C# point of view).

ref T7494

Reviewers: segfaultxavi, felipealmeida, YOhoho

Reviewed By: YOhoho

Subscribers: cedric, brunobelo, Jaehyun_Cho, #reviewers, woohyun, #committers

Tags: #efl

Maniphest Tasks: T7494

Differential Revision: https://phab.enlightenment.org/D9800
2019-09-10 19:30:47 -03:00
Carsten Haitzler d1890f5eca efl task - change exit method to use normal event for multiple listeners
we couldn't have multilpe listeners before. now we can. better this
way. have to do this now because i can't mark efl task as @beta
without taking out massive wads of efl with it.
2019-09-10 23:09:30 +01:00
Mike Blumenkrantz 2cb5dc33a1 build: unbreak destructors
Summary:
the following commits did not correctly add super calls to the destructor,
resulting in a massive number of build errors as well as some unit test failures

ref e51699afbc
ref 38be95b0b6

Reviewers: raster, lauromoura

Reviewed By: lauromoura

Subscribers: lauromoura, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9902
2019-09-10 15:11:24 -03:00
Carsten Haitzler 93b4571d69 efl task - go back to non beta... this breaks the world 2019-09-10 17:53:59 +01:00
Carsten Haitzler 5455a2dcf7 eo beta - mark task, io classes as beta because they are... 2019-09-10 17:44:51 +01:00
Carsten Haitzler e51699afbc efl core cmommand line - implement destructor and thus fix leak 2019-09-10 17:44:51 +01:00
Carsten Haitzler 38be95b0b6 efl gfx path - implement destructor and thus fix leak 2019-09-10 17:44:51 +01:00
Xavi Artigas e0ad216aee efl_ui/alert_popup: More documentation nitpicks 2019-09-10 17:14:33 +02:00
Mike Blumenkrantz 6d49eb7cc2 efl_ui/alert_popup: improve docs
Summary:
class and property docs

ref T7717

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl_docs

Maniphest Tasks: T7717

Differential Revision: https://phab.enlightenment.org/D9883
2019-09-10 17:10:29 +02:00
Xavi Artigas 96d8b9bc3e docs: nicer formatting of the NULL keyword, everywhere 2019-09-10 16:05:44 +02:00
Mike Blumenkrantz 08e5b09d0a efl_ui/popup: improve docs
Summary:
this provides full documentation for the class and all properties

ref T7717

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl_docs

Maniphest Tasks: T7717

Differential Revision: https://phab.enlightenment.org/D9882
2019-09-10 15:47:38 +02:00
Yeongjong Lee 37a63fb1ee efl_ui_widget: make Efl_Ui_Scrollable_On_Show_Region legacy
Summary:
`Efl_Ui_Scrollable_On_Show_Region` is only used for legacy EAPI. it moved to
elm_widget.h from eo file. also, it renamed `Elm_Widget_On_Show_Region_Cb`.

Reviewers: Jaehyun_Cho, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9896
2019-09-10 09:16:48 -04:00
Daniel Kolesa afc011d893 eolian: hard ban usage of ptr() in stable API 2019-09-10 14:35:41 +02:00
Daniel Kolesa 31658e6e14 efl: replace usage of ptr() in all stable APIs 2019-09-10 14:29:06 +02:00
Daniel Kolesa b6815a2f99 eolian: account for @by_ref when serializing return types
This fixes cases such as missing const when having a @by_ref
return type. The const should not be avoided there because it
is not returning the whole type as const, just what the pointer
dereferences to.
2019-09-10 14:17:53 +02:00
Daniel Kolesa 5cd851ea25 eolian: consider @by_ref marked elements ownable 2019-09-10 14:10:49 +02:00
Daniel Kolesa b880a1c7e8 eolian: add an optional warning for ptr() usage in stable API 2019-09-10 14:06:46 +02:00
junsu choi 6d465b0b1f evas_vg_cache: Hashkey in cache uses evas
Summary:
Vg_entry is shared by different child windows.
When two or more objects load the same file
When resizing, cache_vg_entry_render can delete an active entry
while creating a new entry and deleting an existing entry.
Therefore, use cache data added evas

Test Plan:
[enable json loader]
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -203,7 +203,7 @@ option('evas-loaders-disabler',
   type : 'array',
   description : 'List of modular image/vector load  .....
   choices : ['gst', 'pdf', 'ps', 'raw', 'svg', 'rs  .....
-  value : ['webp', 'json']
+  value : ['webp']

[Test]
elementary_test -> Animation View click -> play -> Animation View click again -> ...

Reviewers: Hermet, smohanty, kimcinoo

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9740
2019-09-10 20:06:18 +09:00
Xavi Artigas f78b4861af efl_task/exe: Further update docs 2019-09-10 12:26:03 +02:00
Wonki Kim bc0eeeb1ec efl_exe: Enhance class description
Summary: This patch ehnance the description of efl_exe, regarding task T7717.

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9889
2019-09-10 12:13:40 +02:00
Xavi Artigas 5ebc5f53e7 efl_ui/box_flow: Improve docs a bit further 2019-09-10 11:34:50 +02:00
Mike Blumenkrantz 42abe377b5 efl_ui/flox_box: improve docs
Summary:
expand the description for the class a bit

ref T7717

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl_docs

Maniphest Tasks: T7717

Differential Revision: https://phab.enlightenment.org/D9885
2019-09-10 11:26:48 +02:00
Mike Blumenkrantz 0867b51a1d efl_ui/popup: improve backwall docs
Summary: ref T7717

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl_docs

Maniphest Tasks: T7717

Differential Revision: https://phab.enlightenment.org/D9884
2019-09-10 11:23:44 +02:00
Mike Blumenkrantz c10c9b21cc efl_ui/scrollable_content: improve docs
Summary:
this describes more behaviors of the mixin, various internal properties
used, and removes some incorrect references

ref T7717

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl_docs

Maniphest Tasks: T7717

Differential Revision: https://phab.enlightenment.org/D9881
2019-09-10 10:11:43 +02:00
Marcel Hollerbach 6e23dfba62 efl_ui_position_manager: only fill as many items as we need
prior to this commit, we just passed the start_id and the end_id the
end_id was the start_id plus the size of the memory buffer. However,
making this depending on the size of the memory buffer is a bad idea, as
changing it based on our needs is rather painfull.

With this commit we have explicit passing of the start_id, end_id and
memory len. This is kind of redundant, however, its very convenient, and
easy to write. The buffer will be filled with the maximum size that is
possible with length of the buffer, however, the end_id will not be
filled anymore.

Differential Revision: https://phab.enlightenment.org/D9756
2019-09-10 09:10:11 +02:00
Marcel Hollerbach 7024e6f03f efl_ui_collection: update theme name
item_container was the wrong name here. this fixes this to use the
correct name in the theme. Additionally the file name in the file is
adjusted.

Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D9849
2019-09-10 09:10:11 +02:00
Marcel Hollerbach 389dbd2524 efl_ui_position_manager_list: support odd even styles
this was simply forgotten, but was part of the previous widget, so this
fixes the missing widget.

Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D9846
2019-09-10 09:10:10 +02:00
Daniel Kolesa 267c57d0f1 eolian: remove second parameter for eolian_type_c_type_get
This has been replaced by newer APIs.
2019-09-09 18:26:49 +02:00
Lauro Moura 165921ec04 eolian_cxx: Add support for @by_ref
Summary:
It will coexist with `eolian_type_is_ptr` while we phase out the latter.

Fixes: T8211

Depends on D9866

Reviewers: q66, felipealmeida

Reviewed By: q66

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9867
2019-09-09 18:10:02 +02:00
Mike Blumenkrantz 1148ab3393 docs: fix invalid $class reference to use @class
Summary: ref T7717

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl_docs

Maniphest Tasks: T7717

Differential Revision: https://phab.enlightenment.org/D9876
2019-09-09 16:03:05 +02:00
Marcel Hollerbach 3d03d4031d build: fix disabling of audio
Summary: this supports disabling audio building in efl.

Reviewers: tasn, zmike

Reviewed By: zmike

Subscribers: zmike, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9873
2019-09-09 09:17:30 -04:00
Daniel Kolesa 4ec5760771 evas_filter_parser: add a workaround for in-tree runs
Without this, the prefix would get pointed to something like
/path/to/efl/build/share/evas, which is not a valid path when
building. That would cause the docs build to fail.
2019-09-09 15:12:47 +02:00
Marcel Hollerbach e25a56077c efl_ui_position_manager_list: fix return on viewport changes
Summary:
we also need to return here when the position is not the same, or we are
going to place items in the wrong spot.

Reviewers: segfaultxavi, zmike, cedric

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9869
2019-09-09 09:03:33 -04:00
Jaehyun Cho 1ecaf6fa02 efl_ui_spotlight: fix warning of implicit conversion of floating point
The result of integral division is converted into floating point.
To fix the warning by assigning the result to integer variable, type
cast is done.
2019-09-09 14:43:32 +09:00
Lauro Moura f6747d6822 eolian_cxx: Remove last usage of type_is_owned
Reviewers: q66, felipealmeida

Reviewed By: q66

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9866
2019-09-07 00:57:14 +02:00
Mike Blumenkrantz acd9eb2466 efl_ui/box: restore previous behavior for passing null reference objects
Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9865
2019-09-06 12:43:32 -04:00
Daniel Kolesa 3b540fc9f9 eolian: remove @owned keyword 2019-09-06 17:07:01 +02:00
Daniel Kolesa 4f4b58bf4c efl: change all occurences of @owned to @move 2019-09-06 17:01:05 +02:00
Daniel Kolesa 67c2a4f5f1 eolian: disallow duplicate entries in requires/composite sections 2019-09-06 16:58:49 +02:00
Marcel Hollerbach a0bd73f2e0 efl_ui_tab_*: enhance documentation
Summary: just a commit bringing more information.

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9864
2019-09-06 16:32:56 +02:00
Marcel Hollerbach c963239086 efl_ui_tab_bar: do not perform insertion if existing is not added
same as the previous commit, just for efl_ui_tab_bar.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9862
2019-09-06 16:20:36 +02:00
Marcel Hollerbach fcd3d82c10 efl_ui_spotlight: do not perform insertion if existing is not added
same as the previous commit, just for spotlight.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9861
2019-09-06 16:20:35 +02:00
Marcel Hollerbach 9284418bea efl_ui_box: do not perform insertion if existing is not added
this was brought up recently and it is true that this should be fixed.
If existing is not registered in the container, then we should not
perform the operation at all.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9860
2019-09-06 16:20:23 +02:00
Marcel Hollerbach 588745e995 efl_ui_spotlight: migrate from active_index to active_element
after playing arround with the widget, we found out that it feels quite
weird to have a index, where most of the time you work with widgets.

We might want to add syntax suger in the future to make it easier to
just jump to the next element, or to the previous, but that still is to
be decided.

The event and the communication to the spotlight manager are still left
to be used with the index, reason for this is, that we might need to
fill there an invalid pointer, if a deletion is triggering an animation,
which seems quite weird. That needs further discussing.

Docx have been updated, the sitemarks about the shifting of the
active_index can be removed, as the element is not subject of change
during content adds/deletes.

ref T7991

Reviewed-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
Differential Revision: https://phab.enlightenment.org/D9813
2019-09-06 16:10:40 +02:00
Daniel Kolesa eb25e92770 eolian: change composite syntax from block to inheritance section
This makes more sense as these are related to inheritance tree.
Therefore, change while we still can.

Fixes T8183
2019-09-06 15:14:20 +02:00
Hermet Park 690dd5d33a ector: code refactoring.
Current vector drawing requires several methods for compositing,
it's shouldnt have only masking but other blending functions
such as matte in lottie, porter&duff in android, etc.

Previously we didn't specify this method name,
just reserved the options and now we started to define the methods
with ector_renderer_composite_method() with Efl.Gfx.VG_Composite_Method
instead of mask_set().
2019-09-06 17:56:02 +09:00
Yeongjong Lee ae29408b86 efl_ui_table: respect col,row span in last_position calculation
Summary:
col,row spen is needed to get correct last_position.

Thanks to segfaultxavi for refporting.

ref T8182

Test Plan:
https://git.enlightenment.org/tools/examples.git/tree/reference/c/ui/src/ui_container.c

Check that long button and small button are not overlapped.

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8182

Differential Revision: https://phab.enlightenment.org/D9854
2019-09-06 09:38:40 +02:00
Yeongjong Lee 0c801b0d12 efl_ui_table: update recalc boolean in child delete callback
Test Plan:
1. elementary_test -to 'efl.ui.table (linear api)'
2. Click `Append` button 3 times.
3. Click `appended 6` button to delete
4. Click `Append` button.
5. Check that `appended 7` button position (1,1).

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9856
2019-09-06 09:28:55 +02:00
junsu choi 65be14db24 eldbus_proxy: Prevent dangling pointer. 2019-09-06 11:25:22 +09:00
junsu choi 35f188239a edje_edit: Prevent dangling pointer. 2019-09-06 11:08:59 +09:00
Lauro Moura 1e85548214 eolian_cxx: Replace type_is_owned with is_move
Summary:
is_owned is being replaced with the is_move family of functions.

This commit changes only the libeolian usage inside libeolian_cxx,
keeping the has_own naming in the generators for a simpler patch
during this freeze period.

Fixes T8199

Reviewers: q66, felipealmeida

Reviewed By: q66

Subscribers: cedric, #reviewers, brunobelo, #committers

Tags: #efl

Maniphest Tasks: T8199

Differential Revision: https://phab.enlightenment.org/D9843
2019-09-05 20:05:19 +02:00
Vincent Torri 2225e05f78 evil: add newline at end of meson.build
Reviewers: cedric, raster, zmike, bu5hm4n

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9848
2019-09-05 12:32:17 -04:00
Xavi Artigas 88948eeab4 docs: minor tweaks to efl_io_model
This file's docs are far from complete but this idea had to be
written down before it was forgotten.
Also, TABS.
2019-09-05 17:01:02 +02:00
Carsten Haitzler e6d9ea7539 fix more edje file set breaks
if group does change unloaidng first is bad because of the same
reasons - losing swallowed etc. content. so disable entirely.
2019-09-05 14:33:00 +01:00
Carsten Haitzler a70808fb96 fix a bunch of breaks that having a blind file unload has brought
We can't blindly unload here - this loses swallowed content (in swallows,
boxes, tables etc.) ... this here along with an actual implementation of file
unload broke the pager in E for starters as shading then unshading (double
click titlebar) a window would lose the mini preview image obj swallowed in.
also fullscreening would do it. this also broke gadget bar, the xkb gadget in
it too and more... so this is a particularly bad thing break.

@fix
2019-09-05 14:24:21 +01:00
Christopher Michael ee0023055f ecore-wl2: Update doxygen for various functions
Small patch to update some missing doxygen parameter information.

ref T8014
2019-09-05 08:22:56 -04:00
Christopher Michael 1e7c079048 ecore-wl2: Fix formatting and remove duplicate EAPI
Fix some doxygen formatting issues and remove a duplicated EAPI in
front of function.

NB: No functional changes
2019-09-05 07:57:41 -04:00
Vincent Torri 9736541957 Evil: remove installation of header and pc files, remove from git Evil.h
this patch finishes to remove Evil public headers

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9847
2019-09-05 13:20:36 +02:00
Ali Alzyod f293701891 evas_textblock: apply coding convention
Reviewed-by: Tom Hacohen <tom@stosb.com>
Differential Revision: https://phab.enlightenment.org/D9819
2019-09-05 11:21:09 +02:00
abdulleh Ghujeh dd440c9f68 efl_ui_text: EFL_UI_EVENT_SELECTION_CLEARED not called
-Add a callback to ui_text for event EFL_UI_EVENT_SELECTION_CLEARED
-Select any text in the ui_text
-Clear selection by clicking any area by mouse or pressing arrows in keyboard
-The selection get cleared but the callback will never be called.

Reviewed-by: Tom Hacohen <tom@stosb.com>
Differential Revision: https://phab.enlightenment.org/D9771
2019-09-05 11:17:06 +02:00
abdulleh Ghujeh ab2132f8de efl_ui_text : Clear selection after past on selected text
{F3752242}Select part of a text and past a smaller text on it the selection will still there.

Reviewed-by: Tom Hacohen <tom@stosb.com>
Differential Revision: https://phab.enlightenment.org/D9766
2019-09-05 11:17:05 +02:00
Marcel Hollerbach 605d04a302 efl_ui_collection: use the correct min size hint
there are not enough size hints, we should add more!
I mixed up which size hints i should have used here, after some back and
forth it turns out that i should use the combined. This fixes the list
example.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9779
2019-09-05 11:17:04 +02:00
Hermet Park 7915aafedd canvas 3d: remove potential dangling pointer. 2019-09-05 18:09:36 +09:00
Hermet Park c703fba143 ethumb: fixed a potential dangling pointer.
fixed by null handling.
2019-09-05 18:08:12 +09:00
Mike Blumenkrantz 05b7e2b730 efl/widget: un-@protected style property set
this is needed for some cases and there isn't a specific reason to keep
it proected

fix T8100

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9803
2019-09-05 10:53:13 +02:00
Ali Alzyod 155f2f98af evas_textblock: fix compilation without harfbuzz
Differential Revision: https://phab.enlightenment.org/D9845
2019-09-05 10:33:24 +02:00
Ali Alzyod 7a05d8d769 elm_entry: handle cursor delete/backspace with clusters consist of one or multible glyphs
Summary:
Cluster consist of one glyph, expected to be removed on backspace or delete key.
Cluster consist of multible glyph, expectd to remove part of on backspace or delete key.

This is behaviour founded in Android. (our current way of handling similar to Qt)

**New Behaviour**
{F3750386}

**Old Behaviour**
{F3750387}

Test Plan:
Auto Testing is challenging because there are no easy way to emulate keyboard down on elm_entry
```
#include <Elementary.h>

EAPI_MAIN int
elm_main(int argc, char **argv)
{
   Evas_Object *win,*box,*entry;

   elm_policy_set(ELM_POLICY_QUIT, ELM_POLICY_QUIT_LAST_WINDOW_CLOSED);

   win = elm_win_util_standard_add("", "");
   elm_win_autodel_set(win, EINA_TRUE);

   box = elm_box_add(win);
   entry = elm_entry_add(box);

   evas_object_size_hint_weight_set(box,EVAS_HINT_EXPAND,EVAS_HINT_EXPAND);
   evas_object_size_hint_align_set(box,EVAS_HINT_FILL,EVAS_HINT_FILL);

   elm_entry_entry_set(entry,"<font=NotoColorEmoji wrap=mixed >🇧🇬อั🇧🇬อั&#x1F600;&#x1F600;&#x1F600;&#x1F600;&#x1F600;อั</font>");
   evas_object_size_hint_weight_set(entry,EVAS_HINT_EXPAND,0.9);
   evas_object_size_hint_align_set(entry,EVAS_HINT_FILL,EVAS_HINT_FILL);
   evas_object_show(entry);
   evas_object_show(box);

   elm_box_pack_end(box,entry);
   elm_win_resize_object_add(win,box);
   evas_object_resize(win,320,480);

   evas_object_size_hint_weight_set(entry,EVAS_HINT_EXPAND,0.1);
   evas_object_size_hint_align_set(entry,EVAS_HINT_FILL,EVAS_HINT_FILL);

   evas_object_show(win);
   elm_run();

   return 0;
}
ELM_MAIN()

```

Reviewers: tasn, woohyun, bowonryu

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9628
2019-09-05 14:52:51 +09:00
Vincent Torri 8dcd638829 Efreet_Uri: fix URI decoding when a Windows path (letter followed by :) is passed to efreet_uri_decode()
Summary: uri decoding returned a wrong URI when a Windows path is given

Test Plan: rage, which is using efreet_uri  is now playing files on Windows

Reviewers: raster, cedric, zmike, stefan_schmidt

Reviewed By: raster

Subscribers: stefan_schmidt, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9839
2019-09-04 20:09:44 +01:00
Marcel Hollerbach d794a0d3d9 efl_io_model: remove custom counting logic
Summary:
this logic brings a few problems:

- When files are annonced here, without the monitor having the context
of the files, immidiat actions like deletion of the file are resulting
in no deletion event. Which is definitly a bug, so we need to wait here
for the monitor.

- When a new count is annonced before the files are there from the
monitor, we are heading towards the same issue - additionally, we might
already have files available, due to the custom counting that are not
annoncned through the monitor, which means, at a later pointer we are
annoncing a new file which is already available via the API.

Right now i do not see a way to continue with this code, it caused major
issues with our CI and the POLL backend, for now things do work again.
Depends on D9624

Reviewers: zmike, stefan_schmidt, cedric, felipealmeida

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9625
2019-09-04 13:39:43 -04:00
Daniel Kolesa 917b5feb27 eolian: make sure to include by_ref in validation of expressions 2019-09-04 18:26:13 +02:00
Daniel Kolesa 6751f011c1 eolian: remove the expression eval_type API
This is unnecessary because for all contexts where type is
relevant the validator already makes sure the type and expression
match correctly, so you don't ever need to re-validate it. If you
are doing a generic case and are not sure, just use MASK_ALL.
2019-09-04 18:02:47 +02:00
Vincent Torri 0021d1386d fix parsing module path on Windows
Summary: only '/' path separator is used while on Windows it can also be '\\'. Fix rage and emotion_test play of videos

Test Plan: emotion_test plays videos while it didn't before this patch

Reviewers: raster, cedric, zmike

Reviewed By: raster

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9837
2019-09-04 16:44:56 +01:00
SangHyeon Jade Lee 4e379f5db4 Efl_Ui: Move elementary and change namespace Ui for ui related models
Summary:
Select and View is ui characteristic features,
so Efl_Select_Model and Efl_View_Model move to elementary from ecore
seems more natural.

namespace also should changed to Efl.Ui as it's right place.

Test Plan: run the test while building it

Reviewers: cedric, felipealmeida, bu5hm4n, zmike, lauromoura

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9820
2019-09-04 11:07:37 -04:00
Daniel Kolesa d7397aca4d eolian: proper error message for @by_ref on pointer types 2019-09-04 16:27:54 +02:00
Daniel Kolesa 0275ef0f33 eolian: add APIs to get full C types of parameters/returns/fields
These are needed because the type itself does not carry all the
information it needs to carry (particularly by_ref).
2019-09-04 16:27:54 +02:00
Hermet Park c5b88ca745 ector: add FIXME for coming issues.
We have no any test resouce but it seems very weird code...
Leave a comment for future task.
2019-09-04 20:03:05 +09:00
Hermet Park f90c8b8910 ector: fix a wrong target buffer size.
the target buffer is allocated by backend engine,
The buffer size must be specified with the stride, not the width.
It's real dimension can be different with the our request.
2019-09-04 20:03:05 +09:00
WooHyun Jung d61cf9df73 efl_ui_timepicker: change a property name (ampm -> is_24hour)
Summary:
For better understanding of the property, "is_24hour" looks
better than "ampm".

@ref T7901

Reviewers: zmike, segfaultxavi, bu5hm4n, kimcinoo

Reviewed By: segfaultxavi, kimcinoo

Subscribers: kimcinoo, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7901

Differential Revision: https://phab.enlightenment.org/D9811
2019-09-04 14:06:23 +09:00
Xavi Artigas a2f846bffc docs: Update focus documentation
Lots of improvements to the focus-related classes.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9828
2019-09-03 18:41:34 +02:00
Marcel Hollerbach a26efaeb57 efl_ui_position_manager_grid: honor NULL objects
its sometimes possible that there is a NULL object returned by the batch
call. We should not just access the NULL element. Additionally, if NULL
was returned during visibility setting, we need to set visibility here.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9827
2019-09-03 18:36:25 +02:00
Marcel Hollerbach 36eff7ed82 efl_ui_grid_position_manager: recalculate max min size correctly
we are walking all the items anyways, so we can recalc the minsize here
anyways. Additionally, this pm was never tested with code that just
passes a set of items at data-access init time, without calling
item_added for each item. (Which is perfectly fine). With this commit
this is now perfectly possible,

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9826
2019-09-03 18:36:24 +02:00
Marcel Hollerbach d73190a0bf efl_ui_position_manager_list: skip cache calculation for not finalized
if we are not finalized yet, there is no reason to calculate the caches,
as this will be redone later on anyways.

Co-authored-by: Mike Blumenkrantz <zmike@samsung.com>

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9825
2019-09-03 18:36:23 +02:00
Marcel Hollerbach b3aba63616 efl_ui_positon_manager_list: skip viewport size setting if its the same
this can be skipped.

Co-authored-by: Mike Blumenkrantz <zmike@samsung.com>

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9824
2019-09-03 18:36:22 +02:00
Marcel Hollerbach 018ae84bbe efl_ui_position_manager_list: require cache here
the cache need to be required here, as we are going to access it later
on.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9823
2019-09-03 18:36:21 +02:00
Marcel Hollerbach 1511470127 efl_ui_position_manager_list: set visibilitly more often
it is possible that the object returned by the batching call is NULL.
That is valid, however, if the batching call for the visibility is
getting the NULL element, but the placement is getting the none NULL
element, then the item on screen will not be visible. This commit
ensures that those items will be visible.

Co-authored-by: Mike Blumenkrantz <zmike@samsung.com>

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9822
2019-09-03 18:36:20 +02:00
Marcel Hollerbach 4617e5dcfb efl_ui_position_manager_list: error when we detect that sizes are wrong
when sizes are different to the cached size, then the displayed items
are out of order, or do not fill the whole viewport. This should not
happen. In case that this is detected, print an error.

Co-authored-by: Mike Blumenkrantz <zmike@samsung.com>

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9821
2019-09-03 18:36:19 +02:00
Daniel Kolesa 99754341e7 eolian: add support for function pointers in utility APIs 2019-09-03 16:51:58 +02:00
Daniel Kolesa d9551af6e1 eolian: fix typos in function_return_is_by_ref 2019-09-03 16:51:58 +02:00
Taehyub Kim 10a5d83e83 elm_popup: calculate the label min size of popup before the popup group calculation
Summary:
consider the label min width size before the popup group calculation
@fix

Test Plan: 1. run elementary_test popup

Reviewers: Jaehyun_Cho, woohyun

Reviewed By: Jaehyun_Cho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9818
2019-09-03 19:47:02 +09:00
Xavi Artigas d1dbb791e8 docs: Update focus documentation 2019-09-03 11:46:52 +02:00
Mike Blumenkrantz 98da00cfd2 efl_ui/scroll_manager: make scroll direction changes more responsive with wheel
Summary:
if the wheel event being processed is in a different direction than the
existing scroll animation, drop the previous animation and immediately
begin scrolling in the opposite direciton

fix T8052

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8052

Differential Revision: https://phab.enlightenment.org/D9806
2019-09-03 09:35:36 +02:00
Xavi Artigas 6771ef63a2 Whitespace 2019-09-03 09:17:43 +02:00
Mike Blumenkrantz 121a437c4d api: remove Efl.Ui.Scroll_Block
Summary:
this now uses layout orient enum everywhere

fix T7921

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7921

Differential Revision: https://phab.enlightenment.org/D9804
2019-09-03 09:15:31 +02:00
Xavi Artigas dc05cbbee8 docs: Fix typos and wrap EO files to 120 chars
As per our style guide:
https://www.enlightenment.org/contrib/docs/eo-guide.md
2019-09-02 16:24:26 +02:00
Daniel Kolesa 0b6e8f71f1 eolian: move all tests to use the new @move syntax and API 2019-09-02 15:24:14 +02:00
Yeongjong Lee 48851138d7 efl_canvas_animation_player: delete previous target event callback
Summary:
When target is changed, its event callback related `animation_player` should be
deleted.

Reviewers: Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9814
2019-09-02 20:55:51 +09:00
Pankaj Kumar 333d5f081d evas_vg: fix alpha animation bug in case of partial update
Summary:
Prerequisite: Partial rendering ON + Evas VG content set in elm_layout + color/alpha animation of layout

It seems that expected clip rects were not merged when color change was taking place on vg object.

@fix
2019-09-02 19:38:48 +09:00
Xavi Artigas c7c535cee8 docs: Switch remaining #doxygen-style refs to @eo-style 2019-09-02 11:57:27 +02:00
Daniel Kolesa bf58531dba eolian: fix validation of ownability with hashes 2019-08-31 14:11:48 +02:00
Daniel Kolesa fdc85f895d eolian: properly handle non-beta restriction of __undefined_type 2019-08-31 14:02:20 +02:00
Daniel Kolesa 3e22ac3e1c eolian: always validate inner types of complex types for @move 2019-08-31 02:14:04 +02:00
Daniel Kolesa 242bad209b eolian: add API to check if an inner type of complex type is @move
This complements the equivalent APIs of parameters and so on.
It is not the same as the older type_is_owned API, which applied
to everything.
2019-08-31 02:13:59 +02:00
Daniel Kolesa 5e5bfc70e5 eolian: refactor ownability validation to accommodate new syntax
This refactors ownability checks so that they're only performed
in contexts where @move can be specified, which both helps
with performance and enables later removal of ownability info
from types themselves.
2019-08-31 01:58:19 +02:00
Daniel Kolesa b1d147abf4 eolian: validate @by_ref correctness
The @by_ref qualifier can only be used with value types, to
guarantee exactly one level of pointers.
2019-08-31 01:58:19 +02:00
Marcel Hollerbach 333a070915 efl_ui_collection: prevent the invalid insertion of items.
Summary:
the group hirachy that you can build up with group items is flattend
down in the collection, as a linear list. Based on that a user might be
able to insert items at invalid positions, like between groups, without
having set the proper group item, which ... is a problem.

This commit ensures that no new item ever destroys the neightboor hood
between two items of the same group or a item with a group and its group
leader.

Reviewers: stefan_schmidt, zmike, segfaultxavi, SanghyeonLee

Reviewed By: SanghyeonLee

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9778
2019-08-30 14:50:32 -04:00
Mike Blumenkrantz 6f68e32737 efl_ui/pan: remove pan,viewport,changed event
Summary:
this is just a duplicate of entity geometry changed events, users of
pan should just use those instead

ref T7708
Depends on D9791

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl_widgets

Maniphest Tasks: T7708

Differential Revision: https://phab.enlightenment.org/D9792
2019-08-30 14:48:14 -04:00
Mike Blumenkrantz 25a9a91eb2 efl_ui/pan: only emit size change event on pan content size change
Summary:
changing the size of the pan content does not require that the pan
position also changes, so let users of pan sort this out using the correct
events

ref T7708
Depends on D9790

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl_widgets

Maniphest Tasks: T7708

Differential Revision: https://phab.enlightenment.org/D9791
2019-08-30 14:48:09 -04:00
Mike Blumenkrantz 7142acd19c efl_ui/pan: add position info to pan,content_position,changed event
Summary:
changed events should always send the related data when possible

ref T7708
Depends on D9789

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl_widgets

Maniphest Tasks: T7708

Differential Revision: https://phab.enlightenment.org/D9790
2019-08-30 14:48:04 -04:00
Mike Blumenkrantz e50cf9b2a2 efl_ui/pan: add pan,content_size,changed event
Summary:
this is a shortcut so pan users don't have to manually hook the content
resize event
Depends on D9788

Reviewers: bu5hm4n

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl_widgets

Differential Revision: https://phab.enlightenment.org/D9789
2019-08-30 14:47:58 -04:00
Mike Blumenkrantz ba0cd5d23d efl_ui/pan: rename pan,position,changed -> pan,content_position,changed
Summary:
the pan object is not changing its position, it's moving the content

ref T7708
Depends on D9787

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl_widgets

Maniphest Tasks: T7708

Differential Revision: https://phab.enlightenment.org/D9788
2019-08-30 14:47:52 -04:00
Mike Blumenkrantz 23220764e2 efl_ui/pan: remove pan content,changed event
Summary:
this was being emitted as a catch-all for pan changes, where something else
should have been monitored/used instead

ref T7708

Reviewers: bu5hm4n

Reviewed By: bu5hm4n

Subscribers: bu5hm4n, cedric, #reviewers, #committers

Tags: #efl_widgets

Maniphest Tasks: T7708

Differential Revision: https://phab.enlightenment.org/D9787
2019-08-30 14:47:46 -04:00
Shinwoo Kim 228bed4c8c evas_filter_parser: remove dereferenced NULL
Summary:
This is detected by static analysis tool.
The variable last could be NULL when it is dereferenced.

Reviewers: Hermet, zmike, bu5hm4n

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9796
2019-08-30 14:47:22 -04:00
Carsten Haitzler 41a9ce67a9 elm sel mgr - remove event handlers when no drop targets are left
case left over that this didnt handle right and this breaks e's dnd
once a file preview popup appears.

@fix
2019-08-30 18:19:15 +01:00
Mike Blumenkrantz 1ca07b72da efl_ui/popup: timeout -> closing_timeout
simple property rename

ref T7902

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9801
2019-08-30 19:15:10 +02:00
Xavi Artigas 2ce877d914 docs: Proper documentation for Collection and Item classes
Reviewers: bu5hm4n

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl, #documentation

Differential Revision: https://phab.enlightenment.org/D9798
2019-08-30 18:39:06 +02:00
Daniel Kolesa 7dc7cbf076 eolian: add API to expose the new @move and @by_ref tags 2019-08-30 17:09:31 +02:00
Daniel Kolesa fbcad90fec eolian: add parsing for @move and @by_ref
The @by_ref qualifier is now allowed on parameters, returns and
struct fields in the usual qualifier section. It will mean that
this type is passed around by reference, and will only be allowed
on types that are not already pointer-like.

The @move qualifier will replace @owned as one with a clearer
meaning. It means "transfer of ownership". It has the same semantics
as the current @owned, i.e. on return values it transfers ownership
of the value to the caller, on parameters it transfers ownership
to the callee (the inverse is the default when not specified).
On struct fields, it means the field will transfer together with
the struct that contains it.
2019-08-30 16:22:20 +02:00
Bowon Ryu bbd213bcfb elm_entry: add null check logic on elm_entry_text_set API
Summary: If current_text is NULL, a segmentation fault is occured.

Test Plan: N/A

Reviewers: cedric, Hermet, Jaehyun_Cho, zmike

Reviewed By: zmike

Subscribers: zmike, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9780
2019-08-30 08:47:19 -04:00
Carsten Haitzler d6156d23d8 eio - don't call cb's after a cancel
i saw a segv in e/efm .. an eio call was called after it had been
canceled. this should never happen. ever. so ensure it does not once
an eio file has been canceled.

@fix
2019-08-30 12:43:24 +01:00
WooHyun Jung 0e82fa3f40 efl_ui_datetime: change min/max to date_min/date_max
Summary:
To keep consistency with other classes, change the property name
properly.

@ref T7869

Reviewers: zmike, segfaultxavi, bu5hm4n

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7869

Differential Revision: https://phab.enlightenment.org/D9797
2019-08-30 12:10:44 +02:00
Hermet Park 9a4b6728d5 ector gradient: ++ optmization.
we know what size will be used for every span,
this graident buffer will be overwritten with new one,

So it doesn't need to clear every spans.
2019-08-30 17:15:06 +09:00
Hermet Park e4b9807ee3 ector: remove unnecessary blending processing.
gradient buffer in masking doesn't need to apply anti-aliasing
since it would be taken by masking buffer.

This also fixes memory overflow case if the tbuffer is lack of size.
2019-08-30 13:44:56 +09:00
Hermet Park 17320a1318 ector: code refactoring.
just renamed internal variables, no logical changes.
2019-08-30 13:44:56 +09:00
subhransu mohanty 5370c2e795 edje/optimization: refactor edje_color_class_set() api.
Summary:
During _elm_config_color_overlay_apply() application can call this api
100's of time depending on how many overlay it wants add . As each color_class
set triggers the global color class apply chain 3 times (for color , outline and shadow)
just club them once and emit single color_class,set event.

Reviewers: Hermet, ali.alzyod, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9784
2019-08-29 14:31:52 -04:00
subhransu mohanty 35e385a1ec edje/style: append file prefix to textblock_style api that affects on file level
Summary:
All those api's are working on the Edje_file level so by appending the file prefix
and changing the argument to Edje_File leads to easy maintainability.

Depends on D9776

Reviewers: Hermet, ali.alzyod, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9777
2019-08-29 13:21:11 -04:00
Marcel Hollerbach f442bdb3ee elm_systray: add back beta constructor
Summary:
1/2 year  ago we have removed the automatic generation of legacy
headers. In this go we also removed the installation of legacy eo beta
APIs, as they definitly should not be used. However, there is the legacy
systray API which does not depend directly on eo. Apps could use this
before due to specifying the BETA define, now they only can call the
API, but cannot construct the object they need. This adds this back
under the beta tag, so those apps can continue working.

I am not sure myself if i like the commit or not, its a beta thing, why
should we fix it. However, Its quite a easy thing to add such a
constructor method for us, and enables app to continue working.

Reviewers: zmike, segfaultxavi

Reviewed By: zmike

Subscribers: jf_simon, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9757
2019-08-29 13:21:11 -04:00