Commit Graph

154 Commits

Author SHA1 Message Date
Srivardhan Hebbar 71e68dcca6 eet: handling memory leak on realloc fail.
Summary: Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>

Reviewers: cedric

Differential Revision: https://phab.enlightenment.org/D3208

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-10-22 12:25:39 -07:00
Srivardhan Hebbar 80ccf755a6 eet: handling memory leak on realloc fail.
Summary: Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>

Reviewers: cedric

Differential Revision: https://phab.enlightenment.org/D3207

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-10-21 13:51:34 -07:00
Carsten Haitzler a5747f1ab3 eet - be robust about garbage at the end that looks like an idenity
if there is an identity signaure at the end, ONLY check it if it looks
like a real one (correct magic number, cert and sig size fields are
sane etc.). this means eet opens dont fail for files that may have
trailing garbage or padding that is not an eet identity signature.
2015-10-07 17:50:18 +09:00
Carsten Haitzler 7b018a9740 eet - fix signature alignment and position 2015-10-07 15:47:59 +09:00
Amitesh Singh 26eecda458 eet: fix typo in documentation 2015-09-28 21:50:51 +05:30
Carsten Haitzler 0a77262524 eet - improve eet file storage when encoding by aligning data
this forces data when written to be aligned to 8 bytes. this makes
mapping keys directly far better as from now on you can assume all
data is aligned to 8 bytes allowing you, if you want, to use eet files
as caches for raw binary data you mmap directly and just use (not
portable though).

@feat
2015-08-28 12:56:18 +09:00
Cedric BAIL 7b52ecc9b9 eet: remove the need to order the header correctly for Windows. 2015-05-07 09:53:10 +02:00
Cedric BAIL 02bfb82da0 eet: fix interger overflow
CID 1256196
2015-04-25 20:14:26 +02:00
Carsten Haitzler 555f09009a eet - fix emile changes to not leak in eet_cipher/deciper()
coverity spotted a missing binbuf free for the in binbuf created in
CID 1288921 and CID 1288920. this fixes both of these. leak. new.
2015-04-21 11:01:54 +09:00
Jean-Philippe Andre 258dc999ee Emile: Fix memory leak
The binbuf wrappers were never freed.
2015-04-13 14:00:46 +09:00
Cedric BAIL 0e5686de73 eet: remove use of deprecated Eina_Binbuf functions. 2015-03-17 09:58:21 +01:00
Cedric BAIL 90d8932a03 emile: remove binbuf from emile compression functions. 2015-03-17 09:58:20 +01:00
Cedric BAIL a2385e2ebc emile: follow convention for Emile_Compressor_Level. 2015-03-17 09:58:20 +01:00
Cedric BAIL 8f3ec959b9 emile: change the API to allow supporting other cipher in the future. 2015-03-17 09:58:19 +01:00
Cedric BAIL 9e2333d408 eet: use Emile type for encoding. 2015-03-17 09:58:19 +01:00
Cedric BAIL 4095519d65 emile: fix crash when cspaces is left unchanged. 2015-03-17 09:58:19 +01:00
Cedric BAIL 0e7452a9e1 eet: encode lossy image with AGRY88 or GRY8 whenever possible. 2015-03-17 09:58:19 +01:00
Cedric BAIL 580a893d2e eet: refactoring jpeg encoding. 2015-03-17 09:58:19 +01:00
Cedric BAIL 182568f103 eet: handle AGRY88 encoding for JPEG encoded image.
The alpha and the grey being encoded in two separated grey JPEG.
2015-03-17 09:58:19 +01:00
Cedric BAIL ce340ce2fb eet: fix error handling when decoding TGV file format. 2015-03-17 09:58:19 +01:00
Cedric BAIL c221f33428 eet: use Emile to decode jpeg. 2015-03-17 09:58:19 +01:00
Cedric BAIL f9125499f9 eet: use Emile to decode TGV image section. 2015-03-17 09:58:18 +01:00
Cedric BAIL 65248db8d8 eet: use eina_binbuf and emile to manipulate TGV compressed data. 2015-03-17 09:58:18 +01:00
Cedric BAIL 97c703cdaf eet: initialize emile on demand. 2015-03-17 09:58:17 +01:00
Cedric BAIL f9dd639a92 eet: use Emile instead of Zlib and LZ4 directly. 2015-03-17 09:58:17 +01:00
Cedric BAIL a7d7cae0c4 eet: move to use emile for ciphering logic. 2015-03-17 09:58:17 +01:00
Cedric BAIL 2d342c2814 emile: move GNUTLS and OpenSSL initialization logic from Eet to Emile. 2015-03-17 09:58:17 +01:00
Carsten Haitzler b86579bed6 eet - fix endianess break added by cedric a year ago in image decoding
@fix

this fixes T1987 - the commit that broke it was:

commit 18d494489c
Author: Cedric BAIL <cedric.bail@samsung.com>
Date:   Fri Jan 3 16:20:53 2014 +0900

    eet: use eina_swap*() function instead of custom slower one.
2015-02-04 18:04:55 +09:00
Cedric BAIL 686b10df55 eet: add warning about security to be sure people don't use this function in the wrong context. 2015-01-26 15:29:12 +01:00
Cedric BAIL d2b766a51d eet: properly handle failure and success case by not leaking memory.
CID 1265601.
2015-01-21 16:07:07 +01:00
Cedric BAIL b9db9ca2e3 Revert "eet: fix memory leak in eet_cipher"
This reverts commit d25d56758c.

That patch was leading to double. Thanks ami for finding it.
2015-01-19 14:44:13 +01:00
Carsten Haitzler f4ec47522f eet - one place endianess check wasn't explicit - cleaner code if it is
this MAY be a bugfix, but i can't see how after checking the code, but
to keep it conistent and less likely to grow a bug... do this.
2015-01-14 18:17:19 +09:00
Carsten Haitzler 7532dee7bb eet - boyscouting - clean up whitespaces 2015-01-14 18:13:57 +09:00
Carsten Haitzler 7a8f7047ac eet - image decode - fix robustness of image decode from eet file
there are possible security implications by not checking values of
size fields to see if they are within the data range AND are not 0 or
negative. so do this.

@fix
2015-01-14 18:12:42 +09:00
Tom Hacohen 565f2af60f Eee image: fix macros to be surrounded with do while().
Macros should be surrounded with do {} while() statements,
otherwise there can be issues, like the macro not requiring a semicolon
after the statement or etc.

@fix
2015-01-14 08:55:30 +00:00
Chris Michael db53875e0a eet: Remove unused variable
Summary: This just removes an unused variable spotted during compile.

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-01-06 09:05:37 -05:00
Cedric BAIL b61e9525d1 eet: refactoring jpeg encoding. 2015-01-06 11:51:58 +01:00
Cedric BAIL 6724bbf8bd eet: refactorize handling of endian. 2015-01-06 11:49:28 +01:00
Cedric BAIL 18d494489c eet: use eina_swap*() function instead of custom slower one. 2015-01-06 11:48:25 +01:00
kabeer khan d25d56758c eet: fix memory leak in eet_cipher
Summary: Signed-off-by: kabeer khan <kabeer.khan@samsung.com>

@fix

Reviewers: devilhorns

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1799

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-12-22 11:55:48 +01:00
Stefan Schmidt 6b27d7add2 eet: Switch from obsolete LZ4_uncompress function to LZ4_decompress_fast
The function is declared as obsolete and in some newer headers it is no
longer defined. The new function is the same besides the name change.
2014-12-10 14:52:58 +01:00
Carsten Haitzler 8669ab8a98 eet - add new api to verify eet file against stored cert
this api makes it far more obvious as to how to verify an eet file via
the eet identify mechanisms that use x509 certificates to sign files.
this is consistent with the api used to generate the key for sigining
thus you can use the same certificate file to compare against for
identify.

@feature
2014-11-28 17:56:27 +09:00
Cedric BAIL fb8087b0a7 eet: shutup stupid compiler warning. 2014-10-22 22:30:29 +02:00
Jean-Philippe Andre a3caed8012 Eet: Fix eet jpeg image load
Commit 101dee79b0 introduced critical errors, as standard
error callbacks now fail.

Apparently, these error callbacks depend on the installed version
of libjpeg (8 vs. 9).

I couldn't start E without this commit.
2014-10-21 15:59:50 +09:00
Vincent Torri 101dee79b0 eet: enhance error messages with libjpeg
@fix
2014-10-20 18:40:20 +02:00
Chidambar Zinnoury b473a56733 eet: add some more documentation. 2014-10-20 18:32:28 +02:00
Philippe Caseiro c03569e6a7 eet: update callback API documentation
Adding some documentation on callbacks typedefs for :
- Eet_Node_Walk
2014-10-20 18:20:58 +02:00
Philippe Caseiro 5bb7034774 eet: update callback API documentation.
Adding some documentation on callbacks typedefs for :
- Eet_Descriptor
- Eet_Dump
2014-10-20 18:19:42 +02:00
Jérémy Zurcher 2e5a5d6656 eet: call LOCK_CACHE before altering Eet_File
even if not necessary in this particular case,
do as in eet_mmap() and eet_open(),
lock the cache before altering Eet_File struct.

fix CID 1039366 1039367 1039368 1039369
2014-09-08 22:37:09 +02:00
Stefan Schmidt a65c531429 eet_dictionary: Remove now unused variable
Since 123bdc4342 found is now longer used here.
Remove it.
2014-08-27 16:40:16 +02:00