Commit Graph

324 Commits

Author SHA1 Message Date
Cedric BAIL 5593964ead embryo: force the insertion of a '/' in the path to be sure that file path make sense. 2014-01-24 08:19:47 +09:00
Carsten Haitzler 1c2da046dc embryo_cc - remove trainling / from path for windows stat so it works 2014-01-23 08:45:44 +09:00
Jean Guyomarc'h 1e287bde2b edje_cc: factorize two strlen()s
Reviewers: cedric, raster

Reviewed By: raster

CC: cedric

Differential Revision: https://phab.enlightenment.org/D454
2014-01-20 12:47:46 +09:00
Jean-Philippe Andre 137383b532 Evas/cserve2: Add some safety checks when reading socket messages
Fixes CID 1039571 and 1039572.
2014-01-15 16:06:08 +09:00
Jean-Philippe Andre debbba4758 Evas/cserve2: Fix potential crash in image_free
Don't try to free an object that was already freed.
Basically, allow image_free(NULL).
2014-01-14 14:23:05 +09:00
Jean-Philippe Andre 99efaf4ad1 Evas/cserve2: Clear up File_Data when opening a new image
After a file changed, the "changed" flag was not reset in the
File_Data structure, although it was supposed to represent a
new entry altogether.
2014-01-14 14:23:05 +09:00
Jean-Philippe Andre 73670beba3 Evas/cserve2: Rename "invalid" field to "changed"
This flag indicates that a file changed, not that the entry
is invalid. There is another "valid" flag already.
2014-01-14 14:23:05 +09:00
Jean-Philippe Andre 1d99c82381 Evas/cserve2: Improve error messages a bit 2014-01-14 14:23:04 +09:00
Jean-Philippe Andre 038f4b4fcf Evas/cserve2: Reduce error logs on invalid glyph load
Change message level from ERR to WRN, when a glyph is not
loadable because FT fails to load it or it contains 0 pixel.

cserve2 used to complain about invalid glyph 3, on a few fonts
2014-01-14 14:23:04 +09:00
Jean-Philippe Andre 6a4c84a6a4 Evas/cserve2: Fix crash in server on file change
An inotify callback is triggered when an image file changes,
and it is supposed to cleanup all references to this image.

Unfortunately, it was doing it in a very unsafe way as pointers
could become invalid, because of hash free callbacks in the
referenced image list. Add some list safety and always assume
the pointer might be dead after free operations.

TBH, this _file_changed_cb function looks very confused to me
(as it tries to bypass eina_hash_del).
2014-01-14 14:23:04 +09:00
Jean-Philippe Andre 00417fe256 Evas/cserve2: Fix memleak during shutdown
Don't reset the dead slave callback, as it is used to free the
slave worker's resources.
2014-01-14 14:23:04 +09:00
Jean-Philippe Andre f1aa32a4a4 Evas/cserve2: Use calloc instead of malloc
This will silence some warnings from valgrind (and add some
safety as well...)
2014-01-14 14:23:04 +09:00
Carsten Haitzler 86a97efeea evas - fonts - move to using 4bit and rel 4 bit compressed font glyphs
this changes the internal encoding of font glyphs in evas to use 4bit
uncompressed if small, or 4bit rle (run length encoded) if larger.
this caves at least 50% of memory on fonts - and more if bigger. with
large fonts (40-80pixel size) we can save in the region of 80% of
memory used for glyphs. this also happesn to allow speedups in
rendering too.
2014-01-13 05:15:32 +09:00
Carsten Haitzler 10d9adfc46 evas cserv2 - remove logical dead code
fixes CID 1113441
2014-01-10 20:16:09 +09:00
Carsten Haitzler 6017b803a9 edje_cc - remove dead code
fixes CID 1132639
2014-01-10 18:45:01 +09:00
Carsten Haitzler 796b84e6ec cserve2 - debug bin - fix theoretical leak of socket fd
fixes CID 1039286
2014-01-10 18:40:52 +09:00
Jean-Philippe Andre 3b06d11fdf Evas cserve2: Fix crash in cserve2 when slaves die
If a slave dies (eg. killed) when it's idle, then cserve2 will crash
miserably at the next request. Indeed, the dead slave's corpse was
removed from the working slaves' list but not from the lazy idle
slaves list.

Also, set read buffer to NULL after free. Just in case. We never know :)
2014-01-09 16:12:54 +09:00
Carsten Haitzler 43725e960a ethumbd - stop using an idler that spins at 100% cpu while generating queues 2013-12-28 11:15:26 +09:00
Carsten Haitzler b4411c90bf ethumbd - if thumb gen takes too long don't just quit ethumbd, but skip thumb 2013-12-28 11:07:30 +09:00
Carsten Haitzler 332a54d1c6 ethumbd - drop priority to 19 like efreetd so it lurks in bg as much as it can 2013-12-28 10:28:57 +09:00
Carsten Haitzler 0aa4de9f1d efreet - minor formatting and move set prirority to very start 2013-12-28 10:22:23 +09:00
Daniel Juyung Seo 76d8532b54 efl: Unified eina critical manro to CRI.
Being annoyed by different types of eina critical macros - CRI, CRIT,
 CRITICAL -, I concluded to unify them to one. Discussed on IRC and
 finally, CRI was chosen to meet the consistency with other macros -
 ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
2013-12-26 12:27:13 +09:00
Andrii Kroitor 574c5c1ba7 edje: edje_decc - added -output flag (save to specified dir)
Reviewers: cedric, seoz

Reviewed By: cedric

CC: reutskiy.v.v, cedric

Differential Revision: https://phab.enlightenment.org/D402

Signed-off-by: Cedric BAIL <cedric.bail@samsung.com>
2013-12-23 10:48:13 +09:00
Andrii Kroitor 7a3cd879d2 edje: edje_edit - fix .edc file generation
Reviewers: cedric, seoz

Reviewed By: cedric

CC: reutskiy.v.v, cedric

Differential Revision: https://phab.enlightenment.org/D401

Signed-off-by: Cedric BAIL <cedric.bail@samsung.com>
2013-12-23 09:49:53 +09:00
Andrii Kroitor b556df55af edje: edje_cc - note for future image_id changes added
Reviewers: cedric

Reviewed By: cedric

CC: reutskiy.v.v, cedric

Differential Revision: https://phab.enlightenment.org/D396

Signed-off-by: Cedric BAIL <cedric.bail@samsung.com>
2013-12-20 14:43:24 +09:00
Vyacheslav Reutskiy f358520483 edje: edc ref - update the information about fill type values
Reviewers: cedric, raster, seoz

Reviewed By: cedric

CC: cedric

Differential Revision: https://phab.enlightenment.org/D395
2013-12-20 14:43:24 +09:00
discomfitor d45eb7a9cf bugfix: eldbus code generator struct members named "proxy" should not be passed to eina_value_free.
come on.
2013-12-15 00:08:50 -05:00
Carsten Haitzler 5dfe3789f2 evas - fb engine - fix mem leak if ioctl fails on fb mode
this fixes CID 1137852
2013-12-15 11:25:56 +09:00
discomfitor 1fa7d3070b bugfix: make eldbus generated code not crash on every single generated event
this is pretty depressing to find after it's been in git for over a year
2013-12-14 19:54:35 -05:00
Vorobiov Vitalii 0640b7f341 edje: adding Alias API into edje_edit module
Summary:
This commit will add some API for working with aliases.
There are four functions will be added:
1. edje_edit_group_aliases_get - this function will return the list of aliases of certain group.
2. edje_edit_group_is_alias - this function will check if the given group name is actually an alias.
3. edje_edit_group_aliased_get - return the main real group that is being aliased.
4. edje_edit_group_alias_add - add new alias name.

Also the function "edje_edit_group_del" was modified because of wrong behaviour.
Now if the given group is alias, it will successfully delete it,
but if the given group is main group, it will also delete all it's aliases.

This commit also modify EDJ file by adding new field for detecting if the group is alias or not.

Reviewers: cedric, seoz, raster

Reviewed By: raster

CC: reutskiy.v.v, cedric

Differential Revision: https://phab.enlightenment.org/D376
2013-12-14 18:40:26 +09:00
Carsten Haitzler 83615efe6a ethumbd - fix possible out of bounds access to work table
this should fix CID 1039314 in case an unsused table slot cannot be
found. this should actualyl never happen because table expands/allocs
zero out new entires so they are "unused".
2013-12-13 21:26:05 +09:00
Carsten Haitzler abb780bf5f edje - epp - fix possible array access by negative
this should fix CID 1039357
2013-12-13 21:26:05 +09:00
Carsten Haitzler f745ac2591 eeze - fix uninitialised sigation struct content
should fix CID 1039552
2013-12-13 21:26:05 +09:00
Carsten Haitzler e8c8f0b876 edje_decc - fix possible use of uninitialized string
this should fix CID 1039553
2013-12-13 21:26:05 +09:00
Carsten Haitzler 6991785df9 embryo - embryo_cc - argv parsing MIGHT leave str buf not nul terminated
should fix CID 1039726
2013-12-11 22:50:34 +09:00
Carsten Haitzler b0e7df47b5 edje - edje_pick - fix coverty access-after-unref issue
fixes CID 1039916
2013-12-11 19:24:42 +09:00
Carsten Haitzler 0b641196c6 edje - edje_cc - fix coverty issue of not exiting loop for box items name
this shoul fix CID 1039918
2013-12-11 19:13:16 +09:00
Carsten Haitzler a42407c7b3 evas - cserve2 - fix uninitialized member "image_id".
fixes CID 1042303.
2013-12-11 18:47:39 +09:00
Carsten Haitzler f779c49c89 edje - edje_cc - try and make coverty ignore the leak (invalid)
hope that this does not reappear in future if changes happen in src.
CID 1132627
2013-12-11 18:20:13 +09:00
Sebastian Dransfeld 494e75eb0e eldbus: print error when fwrite fails
Return value of fwrite should be checked.

Fixes 1039715
2013-12-07 21:11:33 +01:00
Sebastian Dransfeld 63f824c659 eldbus: create object when needed
We allocate the strbuf at the beginning of the function, but do several
return checks after this which does not free the strbuf before return,
and we don't use the strbuf.

So create the strbuf object after checks, just before we need it.

Fixes CID 1039287
2013-12-07 21:11:32 +01:00
Sebastian Dransfeld 4413b3a311 efreet: propagate scan error to caller
Current code ignored return from recursive calls, so if cache_add failed
during recursion, the parent call would still succeed.
2013-12-05 12:15:07 +01:00
Carsten Haitzler 931d02378b efreet - fix recusrion checks need to pop as well as push.
stable release - cherry-pick me!

this fixes a lack of popping the efret recursion stack handler. this
wasn't done in 1.8 and is a bug.
2013-12-05 20:04:25 +09:00
Carsten Haitzler f6f28bf75a efreet - protect efreetd from recursing too far to save overhead and mem
an errant path made its way into my efreet cache. this had a
side-effect of causing efreetd to scan my entire $HOME recursively
to monitor everything. while the original cause was $HOME getting in,
we shouldn't have efreetd sit and consume scan all of $HOME when this
is far from a normal situation. the recursive scanning is there ot
handle some minimal levels of subdirs in app directories, but not an
entire filesystem, so this mitigates the effects of errant cache data
by limiting the amount of recursion allows for icon dirs and desktop
dirs to 8 and 3 levels respectively.
2013-12-04 20:25:57 +09:00
Sebastian Dransfeld 70474a4bc5 efreet: Create stack at start of recursion
No need to check for NULL stack, we know where we start our recursive
scan, so create the stack there.

Also fixes CID1132751 and CID1132752
2013-12-04 09:12:31 +01:00
Sebastian Dransfeld 8bc17db6fa efreet: Create stack at start of recursion
No need to check for NULL stack, we know where we start our recursive
scan, so create the stack there.
2013-12-04 09:12:31 +01:00
Otavio Pontes afd8a238d1 Adding the cubic-bezier curve to edje transitions
Summary: Adding an option to use a cubic-bezier curve in edje transitions.

Reviewers: Sachiel, cedric, raster

Reviewed By: raster

CC: raster

Differential Revision: https://phab.enlightenment.org/D319
2013-12-02 15:02:40 +09:00
Cedric Bail 18632bc8c7 edje: make sure there is an initial value to avoid garbage out.
Detected by clang static analyzer.
2013-11-28 16:55:24 +09:00
Carsten Haitzler c69cf48746 recursive monitoring and scanning fix for icons and desktop files
this fixes T580 ... or SHOULD fix it. there is recursion detection
code now and it properly follows symlinks and dirs. it also properly
updates the file monitor tree for both icons and desktops and it only
monitors dirs, not files (as a dir picks up changes to child data).
tested and it seems not to recurse into self-referencing symlinks
(once it detects the loop) and detects changes nicely in all my tests.
2013-11-27 19:50:24 +09:00
Jean-Philippe Andre 7aa577c774 evas/cserve2: Update image loaders list
evas_image_load.c's list was updated to match the generic
loaders, in 38dd405712.

The list used by cserve should be the same. Actually, there
should be a common function instead of code duplication here.
2013-11-27 13:22:25 +09:00