Commit Graph

4921 Commits

Author SHA1 Message Date
WooHyun Jung 247331363a eolian: fix eolian errors with EOLIAN_ENFORCE_SINCE=1
Summary:
This is not the end of fixing eolian errors. I need to keep fixing
more.

Test Plan:
1. export EOLIAN_ENFORCE_SINCE=1
2. ninja

Reviewers: q66, segfaultxavi, zmike, bu5hm4n, Jaehyun_Cho

Reviewed By: segfaultxavi, Jaehyun_Cho

Subscribers: Jaehyun_Cho, stefan_schmidt, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10370
2019-10-14 16:55:52 +09:00
Lauro Moura 8686e14dc9 elm: Fix potential leak in cv request add
Summary: CID 1405809

Reviewers: zmike, cedric, bu5hm4n

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10174
2019-10-13 23:34:35 -03:00
Jaehyun Cho 338e92e8d2 efl_ui_panes: fix not to consider content min size for legacy panes
Summary:
Since legacy panes did not consider its content's min size, the
content's min size calculation logic is not done for legacy panes.

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10372
2019-10-11 10:03:17 -04:00
Marcel Hollerbach b7432f690f efl_ui_focus_object: do not emit focus_geometry_changed when not needed
Summary:
this is emitted a lot of times, which costs time. Most of the time they
are however not needed. With this commit, these events are not emitted
anymore.

ref T8321

Reviewers: zmike, cedric

Reviewed By: zmike, cedric

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8321

Differential Revision: https://phab.enlightenment.org/D10348
2019-10-11 10:03:17 -04:00
Lauro Moura 470c6516fe cv: Switch to safe 32/64 bits printf masks
This should silence 32-bit warnings about long long stuff

Reviewers: vtorri, cedric, bu5hm4n

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10214
2019-10-11 10:03:17 -04:00
SangHyeon Jade Lee 57652c12f6 elm: fix legacy callback names.
Summary:
this patch is fix of D10240.
there are few mischanges on callback names,
so fix it orginal legacy names,

SCROLL_CHANGED = "scroll"
SCROLL_ANIM_START = "scroll,anim,start"
SCROLL_ANIM_STOP = "scroll,anim,stop"
SCROLL_DRAG_START = "scroll,drag,start"
SCROLL_DRAG_STOP = "scroll,drag,stop"

Reviewers: bu5hm4n, eagleeye, akanad

Reviewed By: eagleeye

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10332
2019-10-10 16:54:40 +09:00
Mike Blumenkrantz b8fab9b8dd efl_ui/selection_manager: be explicit with sizeof() usage
Summary:
ensure we don't have issues with portability and type sizes

CID 1385141

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10201
2019-10-09 13:19:36 -04:00
Mike Blumenkrantz f09a3b5ca3 efl_ui/container: remove erroneous negative value checks for uint params
Summary:
../src/lib/elementary/efl_ui_box.c: In function ‘_efl_ui_box_efl_gfx_arrangement_content_padding_set’:
../src/lib/elementary/efl_ui_box.c:411:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limit ]
  411 |    if (h < 0) h = 0;
      |          ^
../src/lib/elementary/efl_ui_box.c:412:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limit ]
  412 |    if (v < 0) v = 0;
      |          ^
../src/lib/elementary/efl_ui_table.c: In function ‘_efl_ui_table_efl_gfx_arrangement_content_padding_set’:
../src/lib/elementary/efl_ui_table.c:272:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
  272 |    if (h < 0) h = 0;
      |          ^
../src/lib/elementary/efl_ui_table.c:273:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
  273 |    if (v < 0) v = 0;
      |          ^

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10304
2019-10-08 16:49:41 +02:00
Mike Blumenkrantz 4f947925a1 efl_ui/win: initialize max size hints to -1 during constructor
Summary:
this is just a cosmetic change for ease of debugging since it will already
be clamped to max size during eval if it remains unchanged

for max size hints a value of -1 means that the hint is unset but a value
of 0 is technically valid depending on the implementation
Depends on D10296

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10297
2019-10-07 18:49:19 +02:00
Mike Blumenkrantz eff717eb26 efl_ui/win: fix max size hint eval
Summary:
win objects should never permit the max size on any axis to be 0, otherwise
the window will be clamped to 1px on the given axis

fixes T8304
@fix
Depends on D10272

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8304

Differential Revision: https://phab.enlightenment.org/D10296
2019-10-07 18:40:10 +02:00
Xavi Artigas 5a447ed327 docs: Remove redundant documentation
Lots of EO files had the same information at the property and set/get level.
Removed the redundant bits, and moved to the property level the common ones.
Set and Get documentation should be used only to clarify setter-only or
getter-only behavior.
2019-10-07 16:40:50 +02:00
WooHyun Jung 5a684e0855 efl_ui_image: fix backward compatibility issue
Summary:
Previously, "anim" property was saved before checking
evas-image's "animated" stated. This patch just corrects
the issue.

Reviewers: zmike, bu5hm4n, segfaultxavi

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10293
2019-10-07 10:03:48 -04:00
Marcel Hollerbach d52e77dcb7 efl_ui_datepicker: no need to delete the manager here
Summary:
it is already picked up when datetime is invalidated, due to the correct
parent beeing set.

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10291
2019-10-07 10:03:48 -04:00
Bruno da Silva Belo f18a5b4389 c: coverity: resource leaked when using realloc.
Summary:
from https://en.cppreference.com/w/c/memory/realloc
```
On success, returns the pointer to the beginning of newly allocated memory.
To avoid a memory leak, the returned pointer must be deallocated with free()
or realloc(). The original pointer ptr is invalidated and any access to it
is undefined behavior (even if reallocation was in-place).

On failure, returns a null pointer. The original pointer ptr remains valid
and may need to be deallocated with free() or realloc(). ```
So a temporary to test if `realloc` failed
then use the original pointer to use `free`.
`CID1404749`
`CID1404741`

Reviewers: lauromoura, felipealmeida, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10284
2019-10-07 09:02:10 -04:00
Stefan Schmidt 15696f5e7c efl_ui_video: bring back Elm_video doxygen group for docs
This group got lost at some point and resulted in broken link in our
doxygen documentation.

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D10273
2019-10-04 10:44:09 +02:00
junsu choi 94733b4926 efl_ui_animation_view : Put @beta on Efl.Ui.Animation_View_State
Summary: Efl.Ui.Animation_View class still in beta state.

Test Plan: N/A

Reviewers: Hermet, kimcinoo, smohanty

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10268
2019-10-04 10:05:45 +09:00
Mike Blumenkrantz 9e113d0f2f efl_ui/bg: unset finger_size multiplier during construction
Summary:
this is not a clickable widget, so it shouldn't use finger size

ref T8304

@fix

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8304

Differential Revision: https://phab.enlightenment.org/D10274
2019-10-02 18:02:35 +02:00
Yeongjong Lee fa90880055 efl_gfx_arrangement: change content_padding param type and remove scalable
Summary:
This change `content_padding` parameter type to int from double for consistency
of size properties.

`scalable` should be handled in more common size API.

Co-authored-by: Mike Blumenkrantz <zmike@samsung.com>

ref T7864

Test Plan: ninja test

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7864

Differential Revision: https://phab.enlightenment.org/D10154
2019-10-02 12:11:15 +02:00
Xavi Artigas f53583a5c9 docs: Fix problems with monospaced text
Eolian recently added support for $[...] which allows highlighting
more than one word in monospaced text.
2019-10-02 11:31:19 +02:00
Felipe Magno de Almeida be2e0bef07 elementary: Add documentatio to efl_ui_layout_factory.eo
Summary:
Documentation was very sparse and actually empty in some places. Add proper documentation

Related to T7717

Reviewers: woohyun, cedric, SanghyeonLee, lauromoura, brunobelo, myoungwoon, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10267
2019-10-02 10:14:45 +02:00
junsu choi 779bd0539e vg_common_json: Override value_provider list
Summary:
If value_provider is applied to Efl.Ui.Animation_View, it is passed as vector object.
The passed value_provider list passes to Vg_File_Data.
If there is a value_Provider list in Vg_File_Data,
it apply the property to Lottie_Animation using lottie_animation_property_override api.

Depends on D9874

Test Plan:
...

Eo *vp = efl_add(EFL_GFX_VG_VALUE_PROVIDER_CLASS, p);
efl_gfx_vg_value_provider_keypath_set(vp, "**");
efl_gfx_vg_value_provider_fill_color_set(vp, 100, 0 ,0 ,255);
efl_ui_animation_view_value_provider_override(anim_view, vp);

vp = efl_add(EFL_GFX_VG_VALUE_PROVIDER_CLASS, p);
efl_gfx_vg_value_provider_keypath_set(vp, "**");
efl_gfx_vg_value_provider_stroke_width_set(vp, 50.0);
efl_gfx_vg_value_provider_stroke_color_set(vp, 0, 255, 0, 100);
efl_ui_animation_view_value_provider_override(anim_view, vp);
...

Reviewers: Hermet, kimcinoo, smohanty

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9897
2019-10-02 14:30:06 +09:00
junsu choi 6deb21f9f9 Efl.Gfx.Vg.Value_Provider: Introduce property change feature of Efl.Ui.Animation_View
Summary:
Efl.Gfx.Vg.Value_Provider is an object for integrating and managing the properties of vector objects.
These values are dependent on the keypath.
Keypath is the target a specific content or a set of contents that will be updated.
It can include the specific name of the contents, wildcard(*) or Globstar(**).

The valueProvider is borrowed from another library that uses a vector object of type json, such as Efl.Ui.Animation_View
(5fc0e59e0c/lottie-swift/src/Public/iOS/AnimatedControl.swift (L50))

This feature should be used with some patches that apply to the vg json loader and Efl.Canvas.Vg.Object.

Test Plan: N/A

Reviewers: Hermet, kimcinoo, smohanty

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9874
2019-10-02 14:19:30 +09:00
Daniel Kolesa 71c83d2005 efl: add code to enforce presence of @since tags
This is not yet enabled because there's too many instances where
this is broken.

Ref T7704
2019-09-30 20:12:35 +02:00
Marcel Hollerbach 8de8f059c9 elm_code_widget: when the position is updated, set new geom to cursor
in order to do that, we need to ensure that the internal box is
calculated, otherwise the position is still not updated correctly.
This fixes wrong cursor positions in edi.

fixes T8214

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D10225
2019-09-30 10:46:40 +02:00
Marcel Hollerbach 9bc9eff716 elm_code_widget: initialize these vars correctly
otherwise we are setting a cursor from time to time at a uninitialized
position. Which causes disappeared cursors

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D10224
2019-09-30 10:46:38 +02:00
Mike Blumenkrantz 52d04bc524 efl_ui: remove legacy component includes, include Efl_Layout.h and Efl_Canvas.h
this header shouldn't include any legacy headers whatsoever

fix T8274

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10236
2019-09-30 10:33:35 +02:00
Mike Blumenkrantz 96be3cd83d efl_ui: remove efl_ui_text headers from Efl_Ui.h for now
these require legacy types and headers, which should not be brought into
this header

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10235
2019-09-30 10:33:34 +02:00
Mike Blumenkrantz 26035da7b0 efl_ui: explicitly include eo headers for a couple types
the general headers here pull in legacy headers, which is bad

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10231
2019-09-30 10:33:29 +02:00
Marcel Hollerbach a864d62ecf elm_*: make scrolling correct again
in revision D9859 the scroll events have been renamed. However this also
renamed the legacy widgets, which also renamed the evas smart events,
which is a bug. With this commit we are back to plain old
evas_smart_callback_call calls, as these just take the string, and do
not need the bypassing through the eo events.

This fixes:
- elm_test gengrid,toolbar,panel (the events are now shown correctly
again)
- scrolling in elm_code_widget
- elm_map in a touchscreen

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10240
2019-09-28 18:42:45 +02:00
Xavi Artigas 18ea5fd118 themes: Rename "dragable" to "draggable"
Summary:
"Dragable" is a misspelling:
https://en.wiktionary.org/wiki/dragable

We have it EVERYWHERE in EFL, even with jokes:
./src/lib/efl/interfaces/efl_ui_drag.eo:1

This patch only fixes the theme API so it does not get carved in stone for this release.

Depends on D10217

Test Plan: No functional changes.

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10218
2019-09-27 08:42:27 -04:00
Jaehyun Cho b5a917c120 theme: replace hbar and vbar to horizontal_bar and vertical_bar
Summary:
To make clear the meaning, hbar and vbar are replaced to horizontal_bar
and vertical_bar.

Reviewers: zmike, woohyun, segfaultxavi

Reviewed By: zmike, segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10217
2019-09-27 08:40:35 -04:00
Mike Blumenkrantz a50bd311ab efl_ui/image fix null derefs
Summary:
CID 1405781, 1405780
Depends on D10209

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10210
2019-09-26 17:59:54 -04:00
Mike Blumenkrantz 4a3b4e3b4a efl_ui/scroll_manager: fix null derefs
Summary:
CID 1405811, 1405804
Depends on D10208

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10209
2019-09-26 17:59:49 -04:00
Mike Blumenkrantz f7befea043 efl_ui/table: handle case where table has no items
Summary:
CID 1399086
Depends on D10207

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10208
2019-09-26 17:59:43 -04:00
Mike Blumenkrantz 68b1cfe5d6 efl_ui/item_clickable: mark beta again
Summary:
this isn't strictly necessary at the moment

Depends on D10197

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10199
2019-09-26 18:00:32 +02:00
Mike Blumenkrantz 5256b9476d efl_ui/layout: improve error message when theme version parsing fails
Summary:
be very explicit here so that users can immediately know how to resolve
the issue
Depends on D10193

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10194
2019-09-26 18:00:32 +02:00
Mike Blumenkrantz 6f6407729e efl_ui/layout: fix shadow warning
Summary:
a variable with the same name is declared above
Depends on D10192

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10193
2019-09-26 18:00:31 +02:00
Mike Blumenkrantz a21dacbad6 efl_ui/layout: use better check for determining whether to defer signals
Summary:
a layout (not layout_base) should not defer signals. theme groups loaded
by a layout widget can be anything, and are not subject to the versioning
requirements that efl widgets have
Depends on D10055

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10192
2019-09-26 18:00:31 +02:00
Daniel Kolesa 6d93dc4cbf eolian: rename event_prefix to event_c_prefix for consistency 2019-09-26 16:47:22 +02:00
Mike Blumenkrantz f5a4fd89d9 efl_ui/item_clickable: fix event info for press events
this is just a button and not the full clickable struct

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10198
2019-09-26 16:30:32 +02:00
WooHyun Jung 23bbf2bf3a efl_ui_image: fix a wrong return value of legacy API
Summary:
elm_image_animated_play_get needs to return opposite
value of animated_PAUSED_get.

Reviewers: zmike, segfaultxavi, bu5hm4n

Reviewed By: zmike, segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10186
2019-09-26 09:00:09 -04:00
WooHyun Jung ddb28ccdf1 efl_ui_win: add validation check to return legacy default value
Summary:
elm_win_type_get needs to return ELM_WIN_UNKNOWN when
invalid object comes.

Reviewers: zmike, bu5hm4n, segfaultxavi

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10187
2019-09-26 08:59:28 -04:00
Marcel Hollerbach 8197fee189 efl: mark selectable stable
Summary:
fixes T7871
fixes T7852

This also works arround a eolian issue where composites do not mark the
inherited API from the composites as implemented.

Reviewers: SanghyeonLee, cedric, segfaultxavi, zmike

Reviewed By: segfaultxavi

Subscribers: SanghyeonLee, cedric

Tags: #efl

Maniphest Tasks: T7871, T7852

Differential Revision: https://phab.enlightenment.org/D10184
2019-09-26 13:06:24 +02:00
Marcel Hollerbach 1df17abba5 efl_ui_*selectable: unify these APIs with the same c_prefix
Summary:
with this commit that api for single and multi selectable shares the
same prefix, which makes sense in c as we do not really differ between
those two types there anyway.

ref T7871

Reviewers: SanghyeonLee, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7871

Differential Revision: https://phab.enlightenment.org/D10183
2019-09-26 18:32:58 +09:00
SangHyeon Jade Lee a4f5da0fb2 efl_ui : add document comment on efl_ui_item_clickable event data
Summary: Add document comment on Efl_Ui_Item_Clickable.Clickable_Clicked.

Reviewers: cedric, zmike, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10181
2019-09-26 10:46:17 +02:00
Cedric Bail 41d0ead833 elementary: stabilize Efl.Ui.Item_Clickable.
Summary: Depends on D10177

Reviewers: zmike, bu5hm4n, segfaultxavi, lauromoura, SanghyeonLee, felipealmeida

Reviewed By: zmike, SanghyeonLee

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8266

Differential Revision: https://phab.enlightenment.org/D10173
2019-09-25 21:59:29 -04:00
Cedric Bail 26d5b7366e elementary: forward Efl.Input.Clickable event to Efl.Ui.Collection* event.
Summary: Depends on D10176

Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8266

Differential Revision: https://phab.enlightenment.org/D10177
2019-09-25 21:59:25 -04:00
Cedric Bail b8af6c17fc elementary: temporary workaround include issue that prevent acces to Evas_Eo.h
Summary: Depends on D10175

Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8266

Differential Revision: https://phab.enlightenment.org/D10176
2019-09-25 21:59:20 -04:00
Cedric Bail 7cf364f270 elementary: rename Efl.Ui.Collection_Event to Efl.Ui.Item_Clickable
Summary: Depends on D10171

Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida

Reviewed By: zmike, SanghyeonLee

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8266

Differential Revision: https://phab.enlightenment.org/D10175
2019-09-25 21:59:14 -04:00
Cedric Bail 4c3dce94eb elementary: stabilize Efl.Ui.Collection_View.
Reviewers: zmike, bu5hm4n, segfaultxavi, lauromoura, SanghyeonLee, felipealmeida

Reviewed By: zmike, SanghyeonLee

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8261

Differential Revision: https://phab.enlightenment.org/D10171
2019-09-25 21:59:09 -04:00