Summary:
x and y position variable assumes values ranging from min to max.
cw, the content width is larger than max in x axis. Beacause of this
the scroller is not able to loop in rigth/bottom direction. For looping
comparision min and max values should be used instead of content width.
@fix
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
Reviewers: raster, seoz, cedric, Hermet
Reviewed By: Hermet
Subscribers: eagleeye, SanghyeonLee, singh.amitesh, sachin.dev
Differential Revision: https://phab.enlightenment.org/D2731
Summary:
This Patch is regarding D2553, but funtionally independent patch.
D2557 is also related with this patch, so to test working fine,
need to install those all three patches.
1. _elm_interface_scrollable_content_region_show store wx
into scroll_interface_data without coverting mirrored_x.
fix to store wx to mirror-converted x if is_mirrored.
2. _elm_scroll_x_mirrored_get return mirroed_x after compare zero not minx.
so current mirrored_x couldn't be less then 0.
fix to check min not 0 for set return value.
3. _elm_scroll_x_mirrored_get calculation need to consider start position of scroller.
some scroller(e.g. gengrid) start from non-zero position, so calculation need to change
like below.
ret = (cw - (x + w - min));
@fix
Test Plan: You can test this after merge D2553 patch and D2557 and test gengrid2.
Reviewers: raster, Hermet, seoz, jaehwan, tanwar.umesh07, cedric
Subscribers: tanwar.umesh07, Jaehyun, anand.km, eagleeye, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D2558
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary: Even if scroller is not scrolled, EVAS_EVENT_FLAG_ON_HOLD is set. So clicked event is canceled in Edje.
Test Plan:
On the button in the vertical scroller, click button and move mouse horizontal.
Mouse up on the button, so now button is not clicked
Reviewers: Hermet, CHAN, seoz, jaehwan, woohyun, SanghyeonLee
Differential Revision: https://phab.enlightenment.org/D2550
Summary:
change the 'sid->loop_v' condition to '!sid->loop_v' to delete momentum animator
when the vertical scroller reached the end of the content
@fix
Reviewers: raster, Hermet, woohyun
Subscribers: CHAN
Differential Revision: https://phab.enlightenment.org/D2609
Summary:
When content is resized, scrollbar's position is not updated.
Add bar position update after bar size is changed.
Test Plan: elementary_test -> scroller3
Reviewers: seoz, jaehwan, woohyun, cedric, raster, kimcinoo, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2419
Summary:
In case of mirror enabled, wanted x should come from _elm_scroll_x_mirrored_get().
This defect is visible in case of some fancy effects on scroller (map).
@Fix
Reviewers: raster, Hermet
Subscribers: herdsman, sachin.dev, kimcinoo, eagleeye, seoz
Differential Revision: https://phab.enlightenment.org/D2363
This feature works the infinite loop horizontally or vertically.
If the content is set, it will be shown repeatedly.
@feature
Change-Id: I1f20b794ae44bc8e5d120901222c7cccadca96b7
Conflicts:
src/lib/elm_scroller.c
src/lib/elm_scroller_legacy.h
now when a whele event comes in, 1. the amount we scroll accelerates
based on time between wheel events (the faster wheel events come out,
the more accel), and 2. we animate to the new position providing a
smooth transition to the new spot rather than a jump. very visually
nice.
@feature
Summary:
When first page is last page, elm_scroller_last_page_get need to return 0.
But if pagesize is bigger then current content height or width, value will be returned -1.
So fix this cases to return 0.
Test Plan: If set elm_scroller_page_set bigger then current content size, then issue is occurred.
Reviewers: seoz, jaehwan, raster
Reviewed By: raster
Subscribers: eagleeye
Differential Revision: https://phab.enlightenment.org/D1860
Summary: First page's number is 0. So I changed '+' to '-'.
Reviewers: seoz, jaehwan, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D1530
Summary:
boundary check of _elm_scroll_wanted_coordinates_update() is wrong.
boundary was checked with assumption that 0, 0 is top, left
however, 0, 0 could be different according to usages, in case of gengrid, 0, 0 was center left not top left)
Do not assume the min/max value, but use pan min/max value for boundary check
Fixes T1092
Test Plan: elementary_test -> grid -> uncheck multi select mode -> select first item -> click bring in -> resize window
Reviewers: raster, woohyun, seoz, zmike
CC: seoz
Maniphest Tasks: T1092
Differential Revision: https://phab.enlightenment.org/D720
Summary:
after I drag by using scrollbar, if I resize window, the scroller position was moved to coordication before dragging.
invoke _elm_scroll_wanted_coordinates_update() after position setting in _elm_scroll_scroll_bar_read_and_update();
@fix
Test Plan: elementary_test -> drag scroller to center -> resize window -> scroller shouldn't go back to top
Reviewers: raster, woohyun, seoz
CC: seoz, Hermet
Differential Revision: https://phab.enlightenment.org/D722
Summary:
Issue: As entire scroller edje co-ordinates was being taken instead of the actual viewport value,
if in scroller edje more parts are added apart from just "elm.swallow.content", then the viewport value
set will be wrong. hence the selection handlers will not hide when they have to hide.
solution: Instead of taking scroller edje's geometry, get the actual viewport values.
To get viewport x,y a new scrollable interface is also added.
signed-off by: Shilpa Singh <shilpa.singh@samsung.com>
@fix
Test Plan: Selection handlers have to hide correctly when the text is scrolled in a scrolled entry, if the scroller edc of entry has more parts added other than elm.swallow.content, then when we scroll the selection handlers are not hidden correctly.
Reviewers: jaehwan, woohyun, seoz, Hermet, raster
CC: govi, rajeshps, thiepha
Differential Revision: https://phab.enlightenment.org/D674
ecore_animator_del, and ecore_job_del.
As all efl public free apis get null as valid parameter, we do not need
to check null. I also removed some null check for other free apis which
were right next to timer/animator/job del. After this job code got
cleaner.
Summary:
scroller is moved page by page if scroller's paging is enable
1. default is move to vertical.
2. move to horizontal with Shift key
Reviewers: seoz, Hermet, jaehwan, woohyun, raster, cedric
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D453
Summary: called scroller bring in API in "scroll,anim,stop" callback, so occured infinite loop
Reviewers: seoz, jaehwan, raster, woohyun, cedric
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D445
Being annoyed by different types of eina critical macros - CRI, CRIT,
CRITICAL -, I concluded to unify them to one. Discussed on IRC and
finally, CRI was chosen to meet the consistency with other macros -
ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
When the offset is not bigger than 0 && abs(offset) is not smaller than dx(or dy), round up routine could have mis-calculation bug.
It should substract one value more to get a proper round up result.
For example, when x = 1440, offset = -2160, dx = 360, x should become 720 but round up routine made it 1440.
Because it was rounded up from 1080 to 1440. It should be rounded down from 1079 to 720.
Special thanks to Hosang Kim for the help.
Signed-off-by: Daniel Juyung Seo <juyung.seo@samsung.com>
Signed-off-by: Hosang Kim <hosang12.kim@samsung.com>
Amitesh Singh
Daniel Kolesa
Carsten Haitzler
Avi Levin
Umesh Tanwar
SangHyeon Lee
Hosang Kim
taehyub
Tom Hacohen
Jaehwan Kim
VBS
Daniel Kolesa
wonguk.jeong
Daniel Zaoui
Daniel Juyung Seo
Daniel Juyung Seo