Commit Graph

67 Commits

Author SHA1 Message Date
Jean-Philippe Andre 37625fca91 Evas/Edje/Elm: Use combined_min instead of min everywhere
This allows apps to set the objects min size with hint_min,
while letting the rest of EFL define the minimum size with
rstricted_min.

I don't like the property names much...
2016-06-09 16:37:49 +09:00
Ji-Youn Park 8cf9ee67bd efl_ui_win: rename elm_win to efl_ui_win 2016-06-07 23:11:48 +08:30
Hermet Park b49785c6c4 Revert "Revert "Revert "Revert "elm ctxpopup: fix auto_hide mode to work correctly""""
This reverts commit 95620c6b60.

Revert again, because this obviously fixes a bug...
2016-06-07 19:50:50 +09:00
Hermet Park 95620c6b60 Revert "Revert "Revert "elm ctxpopup: fix auto_hide mode to work correctly"""
This reverts commit 0907217be5.

append comment there.
2016-06-07 19:39:00 +09:00
Hermet Park 0907217be5 Revert "Revert "elm ctxpopup: fix auto_hide mode to work correctly""
This reverts commit 5ddc7c36f9.
2016-06-07 19:33:36 +09:00
Hermet Park 5ddc7c36f9 Revert "elm ctxpopup: fix auto_hide mode to work correctly"
This reverts commit a428e1e712.

please don't accept patches if the discussion hasn't been finalizied between a submitter and the reviewers.
2016-06-07 19:10:50 +09:00
Taehyub Kim a428e1e712 elm ctxpopup: fix auto_hide mode to work correctly
@fix

Summary: fixx auto_hide mode to work correctly

Test Plan:
1. launch elementary_test - ctxpopup
2. click normal ctxpopup and auto_hide ctxpopup sample
3. check the auto_hide function whether it is work well or not

Reviewers: Jaehyun_Cho, raster, jpeg, cedric, singh.amitesh, DaveMDS, Hermet

Reviewed By: DaveMDS

Differential Revision: https://phab.enlightenment.org/D3967
2016-06-07 17:19:15 +09:00
Tom Hacohen a6a2338962 Revert "Eo: Remove eo_del() and make eo_unref() the replacement."
This reverts commit 546ff7bbba.

It seems that eo_del() is useful and removing it was creating bugs.
The issue is that the way we defined parents in eo, both the parent and
the programmer share a reference to the object. When we eo_unref() that
reference as the programmer, eo has no way to know it's this specific
reference we are freeing, and not a general one, so in some
circumstances, for example:
eo_ref(child);
eo_unref(child); // trying to delete here
eo_unref(container); // container is deleted here
eo_unref(child); // child already has 0 refs before this point.

We would have an issue with references and objects being freed too soon
and in general, issue with the references.

Having eo_del() solves that, because this one explicitly unparents if
there is a parent, meaning the reference ownership is explicitly taken
by the programmer.

eo_del() is essentially a convenience function around "check if has
parent, and if so unparent, otherwise, unref". Which should be used when
you want to delete an object although it has a parent, and is equivalent
to eo_unref() when it doesn't have one.
2016-06-01 13:33:21 +01:00
Jean-Philippe Andre 99924852ab Efl: Remove part name in Efl.Container (use Efl.Part)
This touches Edje and also Elementary where part names are used.
This commit blew up in size since now all content part APIs
(get, set, unset) require to use Efl.Part instead.

This is a big refactoring commit, but no logic should
have been changed. Fingers crossed.
2016-05-26 19:55:50 +09:00
Tom Hacohen 546ff7bbba Eo: Remove eo_del() and make eo_unref() the replacement.
We used to have eo_del() as the mirrored action to eo_add(). No longer,
now you just always eo_unref() to delete an object. This change makes it
so the reference of the parent is shared with the reference the
programmer has. So eo_parent_set(obj, NULL) can free an object, and so
does eo_unref() (even if there is a parent).

This means Eo no longer complains if you have a parent during deletion.
2016-05-17 16:23:23 +01:00
Jean-Philippe Andre 902950018b Efl: Introduce Efl.Container and unify APIs
This removes Efl.Pack_Named which had a terrible name,
removes Elm.Container which should have been renamed
Efl.Ui.Container anyway, and introduces an interface
Efl.Container instead.

The hierarchy tree is now changed as objects don't inherit
from Efl.Container (it's an interface, not a regular class)
but only implement it. Obviously it is very easy to
reintroduce an Efl.Ui.Container parent class if we need it,
but I guess it should have some actual logic. It's basically
part of what Elm.Widget already does.

Some function names have been modified to look better in C
with the efl_content prefix.

@feature
2016-04-26 11:36:23 +09:00
Tom Hacohen aff4171e73 Elm widget: rename parent to widget_parent and mark as protected.
This removes the conflicts between the different parents and also
indicates that this is to be used internally by widgets and should
not be confused with the normal user visible parent.

It is an internal attribute that should not be used by people
not implementing widgets. Marking it as protected signifies it
as such.
2016-04-18 10:10:23 +01:00
Tom Hacohen 6d135944be Elm ctxpopup: Remove useless implementation of sub_object_add.
Was just calling super and nothing more.
2016-04-15 13:45:41 +01:00
Amitesh Singh bc9bde253a ctxpopup: pass const object ptr as argument in horizontal_get() 2016-04-13 16:11:19 +05:30
Amitesh Singh 736fb9d498 ctxpopup: implement Efl.Orientation interface functions
Also move horizontal_set/get as legacy APIs.
2016-04-12 17:51:45 +05:30
Daniel Zaoui 9936b92ce3 CtxPopup: fix auto-hide property setting
Set and get functions are inconsistent one with the other. When set
function is used with a certain value, one expects the get function
to return this value.
2016-04-10 15:23:13 +03:00
Cedric BAIL c2a1c49ab2 elementary: move all legacy files to their expected new location. 2016-03-23 13:24:41 -07:00