Summary:
When context,open signal is sent from elm_entry before showing context
menu, dynamic addition of context menu items to entry becomes easier.
@feature
Test Plan:
Run elementary_test
Launch Entry Scrolled test
Right Click on Multiline Markup entry
Reviewers: tasn
Reviewed By: tasn
Subscribers: subodh6129, poornima.srinivasan
Differential Revision: https://phab.enlightenment.org/D2580
Summary:
When entry is resized, selection handlers are not updated,
it causes selection handlers to be placed in wrong position.
This patch fixes it.
@fix
Reviewers: woohyun, seoz, herdsman, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2487
NO! this breaks compiling anything against elementary UNLESS you
enable eo beta api support. NO NO NO NO.
This reverts commit cad6de2a8ef93d994f9dedb8e980efe5fbf6d77e.
Summary:
Added to Entry new signal "validate", this signal called from entry every
time when the text inputed to entry.
The regex validation add as elm_helper.
The styles of Entries scrollers are changed to allow highlightion that
is needed by regex processing.
For use regex with entry need register the regex helper as callback
to event: ELM_ENTRY_EVENT_VALIDATE
@feature
Test Plan:
See elementary_test "Entry Regex" test.
Note: when the string matches to regex the highlighting (green) is reset on unfocusing.
Reviewers: herdsman, raster, cedric, tasn
Reviewed By: cedric, tasn
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D2043
Summary:
Setting focus to entry object when text is being selected
@fix
Test Plan:
1. open "elementary_test entry3"
2. click on the big entry
3. mouse down on singleline entry to start selection
4. move mouse out of window
5. mouse up. text in that entry seems to be selected
6. press del or type any text
expected result: selected text in singleline entry is deleted/replaced
result without this patch: singleline entry is not focused and all edit actions are affecting the big one
Reviewers: cedric, Hermet, seoz
Subscribers: poornima.srinivasan, subodh6129, raster, reutskiy.v.v, herdsman
Differential Revision: https://phab.enlightenment.org/D1476
Previously, entry set handlers' style as default when they are created
and changed style on theme_apply function. But in usual scenario, users create
entry and set style before handlers are created, so when they are created
the style is set as default regardless of the style users already set.
This patch fixes it.
@fix
Fixes bad drag&drop into entry widgets, since the drop callback
assumed that the dropped text ends with a NULL character.
How to reproduce:
1. Open 'elementary_test -to Entry'
2. Open some application (e.g. Firefox)
3. Select some (preferably short) text, and drag&drop it to the entry
widget. This sometimes pastes additional corrupted text (better try
with a 1-3 characters text).
@fix
Summary:
Change requested by TAsn. Previuosly AT-SPI headers were kept private
and included directly into elementary source code. From now on,
AT-SPI headers can be included from Elementary.h public header, however
will be marked as beta APIs.
Commit includes following changes:
* include all atspi headers into new elm_interfaces.h header.
* marking all at-spi interfaces methods/properties as @protected.
* wrap all common headers with EFL_BETA_API_SUPPORT.
* make some common APIs visible in lib, by adding EAPI attribute
(if someone decides to use beta APIs).
Test Plan: out-off tree build with gcc, g++
Reviewers: tasn
Reviewed By: tasn
Subscribers: seoz, q66, kuuko
Maniphest Tasks: T1721
Differential Revision: https://phab.enlightenment.org/D1528
if entry has selection, it would be cleared if selection region set is requested again.
because entry cancel the selection area after it reset the selection area.
unfortunately, the selection area is new selection so selection area is gone.
this patch prevent clearing selection and keep the new selection.
@fix
Summary:
Selection handlers' visibility should be updated when entry is hidden or shown
When entry has selection and hidden, the selection handlers should be hidden also.
This fix T1175.
@fix
Reviewers: seoz, woohyun, raster
Reviewed By: raster
Maniphest Tasks: T1175
Differential Revision: https://phab.enlightenment.org/D877
Summary:
Even if a entry is not editable, user can select text in the entry.
When the entry has selection, we have to support "copy" option.
@fix
Test Plan:
Precondition: Apply D852 patch for fixing a bug in elementary_test
1. elementary_test -to entry7
2. Select some text in the non-editable entry.
3. Press mouse right button.
Note: You can test it in Desktop profile.
Reviewers: tasn, woohyun, seoz
Differential Revision: https://phab.enlightenment.org/D848
Unified the local variable name to ret if the ret is a return value of
another content_unset calls.
- Evas_Object *int_ret --> Evas_Object *ret
- Evas_Object *int_content --> Evas_Object *ret
- Evas_Object *content --> Evas_Object *ret
I don't know why this was added, but it breaks the ability to set focus on any widgets at all under some circumstances. it also is nonsensical since you should never need to set focus while selecting because:
* you are selecting with the mouse button, thereby having previously triggered focus from the mouse click
* you are selecting using api, in which case there's a config option to allow retaining selection which is also conceptually broken by this behavior
@fix
Summary:
Moved the construction of selection handles to _update_selection_handler in order to
reduce the cost of construction of elm_entry little bit.
Reviewers: thiepha, Hermet, seoz, raster
CC: seoz, raster
Differential Revision: https://phab.enlightenment.org/D756
Summary:
Issue: As entire scroller edje co-ordinates was being taken instead of the actual viewport value,
if in scroller edje more parts are added apart from just "elm.swallow.content", then the viewport value
set will be wrong. hence the selection handlers will not hide when they have to hide.
solution: Instead of taking scroller edje's geometry, get the actual viewport values.
To get viewport x,y a new scrollable interface is also added.
signed-off by: Shilpa Singh <shilpa.singh@samsung.com>
@fix
Test Plan: Selection handlers have to hide correctly when the text is scrolled in a scrolled entry, if the scroller edc of entry has more parts added other than elm.swallow.content, then when we scroll the selection handlers are not hidden correctly.
Reviewers: jaehwan, woohyun, seoz, Hermet, raster
CC: govi, rajeshps, thiepha
Differential Revision: https://phab.enlightenment.org/D674
Summary:
Selection handlers' position are not updated when entry is scrolled.
You can check on elementary_test -> Entry 3 (or Entry 4 which is scrollable) -> Select some text -> Scroll entry and see.
This patch is submitted to fix this bug. It update selection handlers' position when entry is scrolled and hide them if needed.
@fix
Reviewers: raster
Differential Revision: https://phab.enlightenment.org/D640
This deferred recalc job is considered for wrap mode.
if the wrap mode is disabled, this job should be discarded.
since the wrap mode is enabled in default.
the job would be performed even the wrap mode was changed later.
@fix.
Summary:
In elm entry, cursor handlers are placed and moved incorrectly if we do selection from bottom to top.
Ex: In elementary_test -> Entry -> Right click -> choose Select -> do selection from bottom to top (or press Shift + <- keys to do selection).
Look at selection handlers: they are incorrectly placed.
Try to move selection handlers: They suddenly move to near each other.
Minor: Remove unused variable.
@fix
Reviewers: seoz
Differential Revision: https://phab.enlightenment.org/D583
Summary:
Magnifier is displayed incorrectly when mouse down on selection handler
Reproduce way: Right click on entry (eg Entry), choose Select, select some text, press left mouse
on selection handler (do not move the mouse), take a look at magnifier position.
Reason: Magnifier position is set to mouse down position in entry.
Fix: Check mouse down status and place correct position for magnifier.
Reviewers: seoz, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D573
Summary:
Issue 1: If you drop text to elm_entry, text is inserted twice.
Reason: Drop callbacks are registered multiple times in elm_entry.
Resolve: Register only one drop callback at entry side.
Issue 2: Even thought entry is disabled, non-editable, you still can drop text, image file. (Example, run Entry Scrolled and drop text, image file to disabled or non-editable entries).
Reason: Drop callback are registered but not remove when entry is set to disabled, non-editable mode.
Resolve: Correct registering and removing drop callbacks in entry.
Reviewers: JackDanielZ, raster
Reviewed By: raster
CC: woohyun
Differential Revision: https://phab.enlightenment.org/D565