Summary:
A static analysis tool detects return value of malloc could be NULL and its
following lines could have derefernece of NULL case.
Reviewers: bu5hm4n, zmike, Hermet
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9812
Get your seatbelt fastend! It is happening! AUTOTOOLS IS GONE NOW!
All praise to meson!
This time the final version, ci has been adjusted, and now does not try
anymore to build a removed buildsystem. However, the scripts in there
need cleaning up.
Differential Revision: https://phab.enlightenment.org/D9027
Coverity reports this as a copy-paste error, and checking the code it
certainly looks that way, so lets call the proper hash function here
Fixes CID1401052
@fix
unit tests automatically abort with info after 60s, and tests should be run with
an appropriate timeout to avoid conflict with the test runner's default 30s timeout
set explicit timeout in eio test for now because there's still frequent bugs here
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8894
Summary:
Coverity reports that we leak the return from eina_counter_dump here,
so store the result, print it out, then we can free it.
Fixes CID1400975
@fix
Depends on D8767
Reviewers: raster, cedric, zmike, bu5hm4n, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8768
Summary: long is always a 32 bits type on Windows
Test Plan: compilation
Reviewers: raster, zmike, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8482
Had to add a pragma around CityHash64 to make it work with
-f-visibility=hidden
Reviewed-by: Marcel Hollerbach <marcel-hollerbach@t-online.de>
Differential Revision: https://phab.enlightenment.org/D7466
a new shiny buildtool that currently completes in the total of ~ 4 min..
1 min. conf time
2:30 min. build time
Where autotools takes:
1:50 min. conf time
3:40 min. build time.
meson was taken because it went quite good for enlightenment, and is a traction gaining system that is also used by other mayor projects. Additionally, the DSL that is defined my meson makes the configuration of the builds a lot easier to read.
Further informations can be gathered from the README.meson
Right now, bindings & windows support are missing.
It is highly recommented to use meson 0.48 due to optimizations in meson
that reduced the time the meson call would need.
Co-authored-by: Mike Blumenkrantz <zmike@samsung.com>
Differential Revision: https://phab.enlightenment.org/D7012
Depends on D7011
../src/benchmarks/eina/eina_bench_sort.c: In function ‘eina_bench_sort_eina’:
../src/benchmarks/eina/eina_bench_sort.c:52:10: warning: implicit declaration of function ‘time’ [-Wimplicit-function-declaration]
srand(time(NULL));
Found due to the nice quite build output in our meson feature branch.
Now when dealing with pointer types, we will not get pointer to
pointer semantics in callbacks and eina_promise_owner_value_set
for Eina_Promise.
It will work as expected:
Eina_Promise_Owner* promise = eina_promise_add();
void* p = malloc(sizeof(T));
eina_promise_owner_value_set(promise, p, &free);
Summary:
When trying to compile eina_bench.c we get an error that say we didnt
defined the variables that EINA_ARRAY_ITER_NEXT. I defined them.
@fix
Reviewers: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1952
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
I observed that eina_init() was called twice in this function and eina_shutdown() once. So thought this might be a mistake, and so have cleaned it.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: devilhorns, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1748
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
ecore_hash_destroy function return nothing, still in the documentation of the function, it was mentioned that it would return true or false. So corrected the documentation.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: devilhorns, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1738
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
As mentioned in TODO in eina_bench.c I added the code to loop through _modules array and delete each item.:
Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: cedric, raster
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1446
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Note: Eina_Hash benchmark is not really matching all our usecase.
We need a better tests that would expand the bench with a wider range
of key size. Basically giving a 3d dimension to our gnuplot. Don't know
if it is doable.
Tests are disabled by default, but they should be mandatory for
distcheck. So should be examples, we should have them to at least
compile.
As there is no way to force "make distcheck" to run "make examples",
I've created --enable-always-build-examples to make examples regular
noinst_PROGRAMS, being always compiled. distcheck will use that
option.
SVN revision: 82276
- remove EFL_LIBS and EFL_CFLAGS, use per-lib values that inherit
from EFL (general)
- add NAME_LDFLAGS and EFL_LDFLAGS for linker flags.
- LDADD (binaries) now use NAME_LDFLAGS instead of NAME_LIBS, as they
link to libname.la and that will pull in the libtool dependencies
SVN revision: 81915
saddly eina_bench stills segv and as I can't find any install target for
it, and I'm not a kung-auto-foo warrior, I can't gdb it.
could someone provide a benchmark-install target or point me to the
direction I missed?
Patch by: Jérémy Zurcher <jeremy@asynk.ch>
SVN revision: 79448
Introduced --with-profile={dev,release} that will simplify how to set
build options of EFL.
NOTE-1: specific e17 benchmark is now gone, it will always be built
and is the default benchmark for eina. If we want to have a faster
benchmark in the future, just add a command line option for
eina_suite.
NOTE-2: valgrind build is broken as it needs -fPIC. Will get to it
later. Likely someone needs to revisit the eina mempools for valgrind
and other basic tools (eo? likely evas).
SVN revision: 77771
I can't be sure that distcheck is fixed as the check of eet is failing.
I've disable the run of the eina test for now as it is *very* long. I'll
re-enable it once eet check is running flawlessly
SVN revision: 76772
Shinwoo Kim
Marcel Hollerbach
Christopher Michael
Mike Blumenkrantz
Vincent Torri
Lauro Moura
Carsten Haitzler
Stefan Schmidt
Cedric BAIL
Felipe Magno de Almeida
Vincent Torri
vivek
Avi Levin
Srivardhan Hebbar
kabeer khan
Daniel Juyung Seo
Savio Sena
Cedric Bail
Igor Murzov
Gustavo Sverzut Barbieri
Cedric BAIL
Jérémy Zurcher