Summary:
Also using the second optional string parameter of efl_file_set as the
text format specifier.
Added string constants to represent the possible values.
Address the issue:
- Elm entry and the file interface clash on file_set.
Specified in the page:
https://phab.enlightenment.org/w/efl_interfaces/
Reviewers: felipealmeida, tasn
Reviewed By: tasn
Subscribers: thiepha, raster
Differential Revision: https://phab.enlightenment.org/D2353
Summary:
Add the "autohide" property to elm_win. This property, when set to
EINA_TRUE, automatically hides the window upon a "delete,request" signal.
Create ELM_POLICY_QUIT_LAST_WINDOW_HIDDEN, a new quit policy that
automatically exit from the elm_run loop when all windows are hidden.
It is an alternative to autodel to conciliates the memory management
framework of Eo with any other memory management model the program may
be using (e.g. RAII principles of C++).
Create the auxiliary function "_elm_win_policy_quit_triggered" to check
triggering of quit policies.
The check in "smart_hide" is now necessary, since
ELM_POLICY_QUIT_LAST_WINDOW_HIDDEN can be triggered when a window
is hidden.
Create the auxiliary function "_elm_win_flush_cache_and_exit" to avoid
code repetition for exiting the elm_run loop.
Make a small update on documentation in elm_win.h to mention the new
autohide property.
@feature
Reviewers: raster, felipealmeida, cedric, tasn
Reviewed By: felipealmeida
Differential Revision: https://phab.enlightenment.org/D2751
In case of naviframe, resize_obj is not edje.
Steps to reproduce:
1. elementary_test
2. Open "Genlist 7" sample.
3. Switch focus between windows ("elementary_test" <---> "Genlist 7").
Eo Errors:
ERR<8720>:eo lib/eo/eo.c:678 _eo_call_resolve() in lib/edje/edje_object.eo.c:430: func 'edje_obj_message_signal_process' (733) could not be resolved for class 'Elm_Layout'.
@fix
Resolves: T2534
Summary:
While going through the test_focus(focus 2-> give focus to layout "entry") code found
focus should move to layout's entry instead of entry outside the layout.
Just change the entry object in callback ;)
Test Plan: elementry_test-->focus2-->give focus to layout "entry".
Reviewers: cedric, Hermet
Differential Revision: https://phab.enlightenment.org/D2611
Summary:
x and y position variable assumes values ranging from min to max.
cw, the content width is larger than max in x axis. Beacause of this
the scroller is not able to loop in rigth/bottom direction. For looping
comparision min and max values should be used instead of content width.
@fix
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
Reviewers: raster, seoz, cedric, Hermet
Reviewed By: Hermet
Subscribers: eagleeye, SanghyeonLee, singh.amitesh, sachin.dev
Differential Revision: https://phab.enlightenment.org/D2731
Summary:
In elm_datetime, ctxpopup does not resize
@fix
Test Plan:
1) Change the scale value in elementary_config to 2.0 (so that a better size change in the ctxpopup's can be observed)
2) Open elementary_test and then the datetime
3) Click on the first datetime field and observe the ctxpopup's arrow position and then close it
4) Click on the same datetime field again, now observe that the ctxpopup's arrow has concided with the diskselector as it wasn't resized properly.
Reviewers: raster, Hermet, shilpasingh, subodh6129, seoz
Reviewed By: shilpasingh, subodh6129
Subscribers: rajeshps, govi, poornima.srinivasan
Differential Revision: https://phab.enlightenment.org/D2628
Summary:
The mbe items has to get own min size to calc each items locate, box size etc...
but when first time box resize it will ignored.
It makes item wrong size issue when mbe located at some part of layout in runtime.
Reviewers: Hermet, seoz, woohyun
Differential Revision: https://phab.enlightenment.org/D2657
Patch adds connected/disconnected elm_atspi_bridge events to avoid
races between window getting focus and AT-SPI2 bus initialization.
When bridge gets connected windows will reemit all "Created",
"Activated" and "Deactivated" events with regard to window focus.
Replacing calls of evas_object_smart_callback_add/del/call
with eo_callback_add/del/call.
This will reduce the use of legacy events and callbacks lists in
smart_object which in turn will improve performance and reduce memory
use.
This reverts commit 76004dfbec84664e253babc5bf576398a5901395.
We need to change other code also to accommodate this change.
_elm_theme_set should return an enum which tells what failed.
enum {
THEME_APPLY_FAILED,
THEME_DEFAULT_SUCCESS.
THEME_APPLY_SUCCESS
};
Based on that, we decide what needs to be done.
The above code will break the layout theme if incorrect theme are passed.
It should be backported to Elm 1.14.
@fix
Summary:
If the transition scale flag is enable in edje,
this value affect the transition scale for edje.
@feature
Test Plan: test elementary_config with enventor tool
Reviewers: raster, Hermet
Subscribers: raster
Differential Revision: https://phab.enlightenment.org/D2288
Summary: This is a patch to fix T2453 where elm apps in weston/E did
not display the icon on the border. This is just preliminary support
because it only tries to find the efreet desktop file based on
_elm_appname. This support Could be extended to allow efreet to search
based on window title, etc, etc.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary:
This Patch is regarding D2553, but funtionally independent patch.
D2557 is also related with this patch, so to test working fine,
need to install those all three patches.
1. _elm_interface_scrollable_content_region_show store wx
into scroll_interface_data without coverting mirrored_x.
fix to store wx to mirror-converted x if is_mirrored.
2. _elm_scroll_x_mirrored_get return mirroed_x after compare zero not minx.
so current mirrored_x couldn't be less then 0.
fix to check min not 0 for set return value.
3. _elm_scroll_x_mirrored_get calculation need to consider start position of scroller.
some scroller(e.g. gengrid) start from non-zero position, so calculation need to change
like below.
ret = (cw - (x + w - min));
@fix
Test Plan: You can test this after merge D2553 patch and D2557 and test gengrid2.
Reviewers: raster, Hermet, seoz, jaehwan, tanwar.umesh07, cedric
Subscribers: tanwar.umesh07, Jaehyun, anand.km, eagleeye, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D2558
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary: Issue: Gengrid item comes over group item on click.
Test Plan:
Run elementary test.
Open GenGrid Group. Click on any item which slightly overlap with group item.
Item comes over group item.
Reviewers: raster, cedric
Reviewed By: cedric
Subscribers: rajeshps, govi, poornima.srinivasan, shilpasingh
Differential Revision: https://phab.enlightenment.org/D2589
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
elm_gengrid_item_update perform item_unrealize/item_realize/item_place itself.
But when gengrid items are added and not calculated yet,
caller want to get item's index after execute elm_gengrid_item_update,
return value is wrong because item_place update it's position in not-updated item's x and y.
to prevent this,
if item position is already updated,
do not updates position in item place.
additionally,
I fixed gengrid item prepend wrong posiiton update.
gengrid item position start from 1 not 0, so item_position_update also must be started from 1.
@fix
Test Plan:
To test this scenario,
need to fix src/bin/test_gengrid.c first.
1. add below codes in bottom of _after_bt_clicked(line 703).
```
Elm_Object_Item *it = elm_gengrid_item_next_get(id->item);
printf("before update efl item[%p], index [%d]\n",id->item,elm_gengrid_item_index_get(it));
elm_gengrid_item_update(it);
printf("after update efl item[%p], index [%d]\n",id->item,elm_gengrid_item_index_get(it));
```
2. execute elementary_test and go to gengrid2 test.
3. add 3 items and select 2nd item then add new item by insert after.
4. you can see index is changed wrong value after item_update executed.
after add fallback code in item_update,
index is returned same value even after item_update execusion.
Reviewers: raster, Hermet, seoz, jaehwan
Subscribers: anand.km, eagleeye, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D2616
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Elementary widgets have different behavior of using the mouse, they need to be unified.
- swipe : without checking on hold, just checking drag state.
- longpress : after longpress, _item_unhighlight(), _item_unselect() are called.
- select : when the mouse pointer leaves item area, _item_unhighlight(), _item_unselect() are called.
First, apply this commit https://phab.enlightenment.org/D2550
Test Plan: elementary_test -> list
Reviewers: seoz, Hermet, CHAN, woohyun, kimcinoo, jaehwan, SanghyeonLee, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2622
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
item_unselect check it->select status, so when item highlighted but not selected,
item highlight is remaining even after unselect_cb is called.
And item_select and item_highlight are separated, but item_unselect and item_unhighlight are mixed.
so divide them, too.
This patch will solve upon problem.
Reviewers: seoz, woohyun, Hermet, CHAN, raster, SanghyeonLee, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2653
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
gengrid realize/unrealize items each smart calculation if their posiiton is updated.
This concept will be occurred useless view object creation and deletion.
So instead of delete items in unrealize function, push item cache into cache list,
and pop item cache from cache list in realize function to reuse item view object
more efficiently.
the cache concept is already implemented in genlist widget and this patch is improved
item cache of genlist cache.
@feature
```
NOTICE: This patch is written under the D2561 Patch which add elm_gengrid_item_fields_update.
So it must submitted after D2561.
```
Test Plan:
I've tested below three cases,
1. tested ith this patch in elementary_test and checked all gengrid features are working properly.
2. tested with changing CACHE_MAX to another value which is set 40 in default
and checked all gengrid features are working properly.
3. tested with set it->item->nocache true, and checked cache is never generated
and checked all gengrid features are working properly.
Reviewers: raster, Hermet, seoz, jaehwan, singh.amitesh
Subscribers: eagleeye, singh.amitesh, Jaehyun
Differential Revision: https://phab.enlightenment.org/D2641
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Currently the values in spinner change while dragging only based on
the amount of pixels dragged, this patch will enable Spinner to change value
based on the speed of dragging so that it will be more user friendly. This
will help users to alter drag values by big amounts if dragged in a good speed.
Test Plan: test_spinner.c in elementary_test
Reviewers: raster, prince.dubey, shilpasingh, cedric
Reviewed By: cedric
Subscribers: poornima.srinivasan, rajeshps, govi
Differential Revision: https://phab.enlightenment.org/D2659
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Show days of previous and next month on the blank area of calendar.
@feature
Test Plan: See calendar widget on elementary_test.
Reviewers: raster, seoz, woohyun, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2728
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Looking at the base array of pixels,
the real middle of taken picture
is actually number 8 from array of 17 pixels (which starts from 0).
@fix
Reviewers: reutskiy.v.v, raster, NikaWhite, cedric
Reviewed By: NikaWhite, cedric
Differential Revision: https://phab.enlightenment.org/D2749
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
SEG_FAULT happens when the object which has selection is deleted,
and new selection is done at another object.
Reason: loss_cb is not removed when the object which has selection is deleted.
When new selection is set for new object, the loss_cb is called for deleted
object. As result, SEG_FAULT happens.
Test Plan:
Run elementary test, open Entry, do selection,
close Entry window, open Entry one more time, do selection.
Reviewers: JackDanielZ
Differential Revision: https://phab.enlightenment.org/D2763
When elm_config_all_flush is called, another processes should get
the config of current process instead of saved base.cfg.
so current process save the config to flush.cfg and another processes
read it when it is changed.
@fix
Vitor Sousa
Lukasz Stanislawski
Amitesh Singh
Anand
Umesh Tanwar
divyesh purohit
woochan lee
Lukasz Stanislawski
Daniel Zaoui
Avi Levin
Tom Hacohen
jiin.moon
Daniel Juyung Seo
Chris Michael
SangHyeon Lee
Prince Kr Dubey
Hosang Kim
godly.talias
Youngbok Shin
Vitalii Vorobiov
Vaibhav Gupta
Daniel Kolesa
Thiep Ha
Jaehwan Kim