Commit Graph

33 Commits

Author SHA1 Message Date
Daniel Juyung Seo 0e0f79c6f2 ecore ibus_imcontext: print the value of cursor_pos only when cursor_pos
is not null.

This fixes coverity CID 1132624.
2013-11-27 01:52:21 +09:00
Daniel Juyung Seo 9314b15add ecore scim_imcontext: do not check null for ic. it was already checked
by EINA_SAFETY_ON_NULL_RETURN.

This fixes coverity CID 1132628.
2013-11-27 01:48:58 +09:00
Chris Michael 0e4b25747f Don't call input panel show/hide methods unless input_panel_enabled is
true.

Fixes Phab Ticket T501

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-11-15 08:44:19 +00:00
Rafael Antognolli 18ef47c173 ecore/wayland: Use eina_inlist instead of wl_list for globals.
Since we are allocating this list and returning it, let's make it more
EFL-like.
2013-11-04 13:50:04 -02:00
Rafael Antognolli b77ac9b57e ecore/wayland: Add ecore_wl_window_keyboard_get().
Instead of use direct access to the Ecore_Wl_Window structure, just use
the getter, so we can hide the internals.
2013-11-01 15:51:38 -02:00
Rafael Antognolli dd18206d86 ecore/wayland: Do not use win->id directly.
Use a getter for it instead, so we don't need to expose the
Ecore_Wl_Window struct just because of it.
2013-10-31 21:35:13 -02:00
Rafael Antognolli e56428f4ad ecore/wayland: Make Ecore_Wl_Input private.
It's mostly only used inside ecore_wayland library anyway.

The only bit needed outside of the library is the "seat" pointer, but a
new function was added to retrieve such pointer from Ecore_Wl_Input.
2013-10-31 21:35:13 -02:00
Rafael Antognolli 35d2f195de ecore/wayland: Hide Ecore_Wl_Display.
This struct is only used inside ecore_wayland itself, so there's no real
reason to expose it. Apparently, hiding it doesn't break anything,
except for the ecore_imf wayland module, which was easily fixed.

If anyone notices a breakage, please let me know.
2013-10-31 21:35:13 -02:00
Jihoon Kim 6ff49dbc70 ecore_imf: Fix memory leak in scim immodule 2013-09-12 11:49:06 +09:00
Chris Michael 4d54c97864 Remove calls to ecore_wl_init and ecore_wl_shutdown.
NB: These calls are NOT needed here (they setup and tear down the
actual wayland display fd connections, and are not necessary in order
to use ecore_wl functions).

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-08-01 12:50:41 +01:00
Chris Michael a48c4cd064 Check for valid text_input object before trying to call wayland
functions on it.

NB: Wayland (internal) functions typically do not do Any object
validity checking, so lets be proactive and do it here first.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-24 09:15:43 +01:00
Chris Michael 47a7f74453 Fix indentation of some if statements
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-24 09:10:42 +01:00
Chris Michael 345351d736 Fix formatting so I can actually read this code in 80 columns ;)
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-24 09:08:50 +01:00
Chris Michael 449c0c72b0 Check for valid returns of ecore_wl_registry_get and
ecore_wl_globals_get before trying to use them.
After we have bound a text input manager, there is no need to keep
looping the globals, so break out.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-24 07:23:58 +01:00
Chris Michael 1832bf5c03 Fixup formatting.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-24 07:11:32 +01:00
Chris Michael 9103b7e2e3 Check the return of ecore_x_init and error out if that fails.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 09:21:33 +01:00
Eduardo Lima (Etrunko) 2d84a8a8fb WIP
Signed-off-by: Eduardo Lima (Etrunko) <eduardo.lima@intel.com>
2013-06-26 10:58:36 -03:00
Chris Michael abf8a3b7bf Format for EFL style
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-06-25 14:14:04 +01:00
Chris Michael 0615dfe4ee Add missing safety checks for valid proxy objects before trying to
call functions on the object

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-06-25 14:14:04 +01:00
Chris Michael aa54fcf059 Check that ecore_wl_init succeeds before trying to make calls into it.
Fix formatting.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-06-25 09:31:52 +01:00
Jan Arne Petersen f656aa397f ecore_imf: Add support for wayland
Add an input method module supporting the Wayland input method protocol.

In v2:
 - Missing call to ecore_wl_shutdown() in im_module_shutdown()
 - Access the already stored 'wayland globals' with ecore_wl_globals_get()
 - Fixed compilation by adding -I(top_srcdir)/src/efl to CFLAGS
 - EFL formatting fixes

Signed-off-by: Eduardo Lima (Etrunko) <eduardo.lima@intel.com>
2013-06-24 16:14:14 -03:00
Jihoon Kim 373fb30096 ecore_imf/scim: remove unused function declaration 2013-04-13 15:25:00 +09:00
Henrique Dante de Almeida ca8fc827a3 efl: Fixes to support compiling with CFLAGS=-Werror
This allows compiling with gcc 4.7.2 without errors (using the
default configuration).
2013-02-26 10:55:04 -03:00
Stefan Schmidt b9d18d770b efl: Switch from deprecated eina_unicode_utf8_get_next to eina_unicode_utf8_next_get
SVN revision: 83130
2013-01-23 09:09:57 +00:00
Jihoon Kim ae19344fc8 efl/ecore_imf/ibus: fix indentation
SVN revision: 82707
2013-01-12 16:09:56 +00:00
Jihoon Kim 505a88f3f2 efl/ecore_imf/ibus: fix wrong function definition
SVN revision: 82706
2013-01-12 16:07:40 +00:00
Jihoon Kim 8412b59c4b efl/ecore_imf/scim: remove unused code
SVN revision: 82705
2013-01-12 15:51:57 +00:00
Jihoon Kim 95fc2dcc4e efl/ecore_imf/scim: use EINA_SAFETY macro for checking NULL
SVN revision: 82703
2013-01-12 15:44:59 +00:00
Jihoon Kim 5fbfaf9e10 efl/ecore_imf/scim: remove unused variable
SVN revision: 82642
2013-01-11 16:05:55 +00:00
Jihoon Kim d964b7efc0 efl/ecore_imf/scim: remove unused code
SVN revision: 82641
2013-01-11 16:01:16 +00:00
Jihoon Kim 01af3144d4 efl/ecore_imf/ibus: use EINA_SAFETY_ON_NULL_RETURN for checking NULL parameter
SVN revision: 82503
2013-01-10 04:26:59 +00:00
Jihoon Kim bd0ce8260a efl/ecore_imf: change namespace to all functions
SVN revision: 82497
2013-01-10 01:43:52 +00:00
Lucas De Marchi f0a7a2a751 efl: move ecore/immodules to ecore_imf
Move both the source tree and the install directory.



SVN revision: 82474
2013-01-09 16:46:58 +00:00