Commit Graph

127 Commits

Author SHA1 Message Date
ami afa4398ce2 [elm_object_item] - Added elm_object_item_style_set/elm_object_item_style_get().
Reviewers: seoz, raster

CC: aryarockstar, nirajkr, chinmaya061

Differential Revision: https://phab.enlightenment.org/D373
2013-12-27 20:00:04 +09:00
Daniel Juyung Seo 6d71a23c3a elm lib: removed all the unnecessary empty lines.
being pedantic.
2013-12-15 06:18:35 +09:00
ami 7dbda5f2d3 [hoversel] - Removed focus_direction since focus_cycle is applied on sd->hover.
Summary: removed focus_direction

Test Plan: elementary_test -> hoversel

Reviewers: seoz, raster

CC: nirajkr

Differential Revision: https://phab.enlightenment.org/D359
2013-11-30 15:34:55 +09:00
Tom Hacohen 28fee48f35 Hoversel: Fix access to already deleted object.
Thank you eo pointer indirection for detecting this.
The issue is a mix of design choices (will discuss on the ML) and
a bug in hoversel which was probably caused because of the confusing design
choices.
The problem is that while widget_item->view is set by whoever created
the item, it's automatically deleted by elm_widget_item_del. This means
that objects that decided to delete their views, but were too sloppy to
update the widget_item->view pointer to NULL, would trigger an attempt
to deleted an already deleted object. This does not happen in 1.7
because widget_item->view was introduced in 1.8.
The automatic view deletion is problematic, as smart subobjects are
already deleted when the parent subobject (the widget) is deleted. So
clearing the views is redundant. However if the widget item is manually
deleted, the view should be deleted. This causes this mixture of cases
that are problematic at best.

Indication error:
Error:
 ERR<5394>:eo lib/eo/eo_ptr_indirection.x:275 eo_obj_pointer_get()
    obj_id 0x8000002900000149 is not pointing to a valid object. Maybe
    it has already been freed.

This fixes T500.
2013-11-19 17:13:31 +00:00
Daniel Juyung Seo c70405bdde elc_hoversel.c: use int_ret instead of ret because ret can be null.
This fixes coverity CID 1129609 and 1129610.
2013-11-18 22:33:37 +09:00
Amitesh Singh 08936d7f38 [hoversel] - Added focus support on hoversel items.
Summary: Focus support on hoversel items.

Test Plan: elementary_test->hoversel2

Reviewers: seoz, raster, Hermet

CC: nirajkr

Differential Revision: https://phab.enlightenment.org/D316
2013-11-13 20:39:48 +09:00
Tom Hacohen 2f1e1554e5 Changed Eo class names to be consistent.
All the class names are now of the format: Elm_Type_Subtype_Extra
2013-11-07 11:44:22 +00:00
Daniel Juyung Seo 07136563ea elc_hoversel: Support elm_object_item_signal_emit() in hoversel.
This works only when the item is actually created by clicking the hover button.
2013-10-14 13:56:27 +09:00
Daniel Juyung Seo 5788a3583c elc_hoversel.c: adopted ELM_WIDGET_DATA_GET_OR_RETURN macro. 2013-10-05 17:12:44 +09:00
Cedric Bail 29af5e1e43 elementary: update to new eo_parent_get/set API. 2013-09-25 13:34:27 +09:00
Daniel Juyung Seo 3e8e2b2abd hoversel: flurish hoversel source/example/documentation a little bit more.
1. fixed documentation to be more descriptive.
2. added hoversel smart callback examples.
3. added internal callback description.
2013-08-30 18:31:29 +09:00
ChunEon Park fe0f0a445e elementary/widgets - set parents before widget constructs their body.
This avoids unnecessary setups again when obj <-> sub has connected.
2013-08-27 00:29:45 +09:00
Cedric Bail c929b33052 elementary: properly sanitize headers order. 2013-05-03 16:07:06 +09:00
Daniel Zaoui 187d6bf8de Elementary: replace eo_data_get for objects data referencing. 2013-05-01 11:04:09 +03:00
ChunEon Park ff10726141 elementary/ctxpopup, hoversel, naviframe, multibuttonentry, popup, diskselector, list, menu, segment_control, toolbar - support widget item language change 2013-04-23 20:30:15 +09:00
Daniel Juyung Seo bd5246c512 elc_hoversel.c: hide hover object when hoversel is hidden. 2013-04-09 13:14:21 +09:00
Daniel Juyung Seo 2a68a17fe6 elc_hoversel.c: Do not add hover as a hoversel's smart member. Handle show/hide manually.
Hover is a *HOVER* object so do not add hover to another object's smart member.
It will restrict the layer of hover object.
Manually handle show/hide instead.
2013-04-03 14:46:14 +09:00
Daniel Juyung Seo 3aa8d2a7fa elc_hoversel.c: add hover as a smart member of hoversel to fix hover child handle bug. 2013-04-03 13:19:07 +09:00
Daniel Juyung Seo 74b3eed5fd elm: print the error message inside elm_widget_sub_object_add().
1. Do not need to print the same error message from all the widget codes.
2. Even though elm_widget_sub_object_add() can be used internally, there should be no error message at all.
   Elm devs should fix it beforehand.
   So it looks ok to print the error message in elm_widget_sub_object_add() to force elm devs to fix it.
3. Got additional code cleanups.
2013-04-03 11:28:53 +09:00
Daniel Juyung Seo f2b514f26b elc_hoversel.c: Fixed wrong sub object handling.
hover should be a sub object of hoversel.
2013-04-03 03:12:33 +09:00
Tom Hacohen d75cb616da Change usage of eo_do_super to the new prototype. 2013-03-18 16:15:12 +00:00
Daniel Juyung Seo 78c042cdbe elm *.c: fixed formatting with EINA_LIST_FREE.
EINA_LIST_FREE (xxx) -> EINA_LIST_FREE(xxx)
2013-03-09 13:23:42 +09:00
Daniel Zaoui cdd1eea853 Replace supported_types
Signed-off-by: Daniel Zaoui <daniel.zaoui@samsung.com>

SVN revision: 83803
2013-02-10 07:52:31 +00:00
Daniel Juyung Seo ffa9c1e793 elm: Refactoring.
Smart data is already initialized so we do not need to re-initialize them if the value equals to 0, NULL, or EINA_FALSE.
Sometimes re-initializing smart data explicitly is needed for readability. So there are left overs.

SVN revision: 82228
2013-01-04 19:10:19 +00:00
Daniel Zaoui 0c915e9023 Cleaning: removed include Eo.h in widgets because it was indirectly included by Elementary.h
Signed-off-by: Daniel Zaoui <daniel.zaoui@samsung.com>

SVN revision: 79682
2012-11-26 09:29:01 +00:00
Yakov Goldberg 5c98343198 We have ported to Eo all the widgets of elementary. We didn't change the inheritance itself, only the mechanism, as done previously in Evas, Ecore and Edje. We removed totally the previous inheritance mechanism.
Signed-off-by: Yakov Goldberg <yakov.g@samsung.com>
Signed-off-by: Daniel Zaoui <daniel.zaoui@samsung.com>

SVN revision: 79668
2012-11-26 06:32:53 +00:00
Daniel Juyung Seo 30dba54610 elm: Fixed indentations for EINA_LIST/INLIST_FOREACH(_SAFE).
SVN revision: 77244
2012-10-01 07:36:27 +00:00
Gustavo Lima Chaves 8fdf284468 [elm] Hoversel now inheritable.
SVN revision: 74761
2012-08-01 21:04:20 +00:00
Gustavo Lima Chaves 584c53c1be [elm] New elm_widget_add() usage spread.
SVN revision: 74148
2012-07-18 21:03:39 +00:00
Gustavo Lima Chaves bbf0a4345e [elm] And now remove deprecated calls usage (WRT
icon/image thing).



SVN revision: 71473
2012-05-28 21:50:11 +00:00
Hyoyoung Chang 26c943b3de elementary/hoversel: remove useless void ptr cast
SVN revision: 71412
2012-05-24 14:08:18 +00:00
Hyoyoung Chang 59718a93c7 elementary/hoversel: fix indent
SVN revision: 71377
2012-05-24 02:38:59 +00:00
Hyoyoung Chang 7d9c0dc403 elementary/hoversel: set hover's parent when hover's smart data deleted
SVN revision: 71376
2012-05-24 02:26:55 +00:00
Tom Hacohen 96a8fd040c Elm hoversel: remove stupid printfs.
I'm glad to see someone is excited about hovers being created and deleted.
I'm not.

SVN revision: 71002
2012-05-14 14:20:18 +00:00
Gustavo Lima Chaves 2313f6cc0a [Elm] Hoversel is now a button.
SVN revision: 70725
2012-05-03 22:43:00 +00:00
Carsten Haitzler c0f2f4be91 REVERT!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
this breaks theme api. so NO! come back with a version that doesn't
break it.



SVN revision: 70679
2012-05-03 01:19:05 +00:00
Gustavo Lima Chaves 3298ff9c7a [Elm] Hoversel is now a button.
SVN revision: 70648
2012-05-02 16:59:40 +00:00
Daniel Juyung Seo 4801d7f5c1 elm elm_object: Fixed part content set hooks.
1. delete old content object
 2. check whether new content object is same as old content object
 3. added some doxygen description.

SVN revision: 69743
2012-03-29 11:09:40 +00:00
Daniel Juyung Seo 480c61f20a elm: Formatting. No spacing after casting.
Signed-off-by: Daniel Juyung Seo <juyung.seo@samsung.com>

SVN revision: 68807
2012-03-06 11:51:42 +00:00
Jiyoun Park f1ef54cc87 remove deprecated code related elm_hoversel_item_XXX
SVN revision: 68769
2012-03-06 04:49:59 +00:00
WooHyun Jung 6009652735 [elementary] change API name from _scale_set to _resizable_set in
elm_image + elm_icon.


SVN revision: 68719
2012-03-05 13:36:01 +00:00
Jiyoun Park 6920a5c1ab modify code related elm_hoversel_label and icon(deprecated function)
SVN revision: 68689
2012-03-05 10:04:53 +00:00
ChunEon Park c5232c4741 elementary - removed unnecessary checkings
SVN revision: 68393
2012-02-24 08:53:01 +00:00
ChunEon Park fcc6192848 elementary - modified item_del_pre_hook function prototype.
Now it returns the bool value to free the widget item.

Some widget items(i,e genlist) should not be deleted directly when elm_object_item_del is called.
So, if the pre_hook function returns EINA_FALSE, then the widget item will not be deleted.



SVN revision: 67565
2012-01-27 11:56:14 +00:00
ChunEon Park 56a881bd35 elementary/menu, ctxpopup, index, segment_control, diskselector, multibuttonentry, toolbar, naviframe, slideshow, hoversel, filpselector - deprecated xxxx_item_del() APIs.
But instead,  made to use the elm_object_item_del() APIs
for this, elm_widget_item needed to provide elm_widget_item_del_pre_hook.




SVN revision: 67010
2012-01-10 05:02:11 +00:00
ChunEon Park 3d40877da4 elementary/hover - deprecated elm_hover_content_set/get/unset
SVN revision: 66989
2012-01-09 08:37:29 +00:00
ChunEon Park 569e56e904 elementary - Added 1 more API elm_object_item_del_cb_set()
also deprecated below APIs  

   elm_hoversel_item_del_cb_set()
   elm_diskselector_item_del_cb_set()
   elm_toolbar_item_del_cb_set()
   elm_index_item_del_cb_set()
   elm_menu_item_del_cb_set()                  



SVN revision: 66748
2012-01-02 11:46:32 +00:00
Daniel Juyung Seo a2d5107e60 elm hoversel: Fixed icon_get/icon_unset API.
SVN revision: 66356
2011-12-20 04:51:44 +00:00
ChunEon Park b62129c878 elemenatry/hoversel - updated doc. deprecated APIs
elm_hoversel_icon_set
elm_hoversel_icon_get
elm_hoversel_icon_unset
elm_hoversel_item_data_get
elm_hoversel_item_label_get



SVN revision: 66350
2011-12-20 02:44:46 +00:00
ChunEon Park 49fa96affe elementary/hoversel - Elm_Hoversel_Item -> Elm_Object_Item
**This may break your application compilation**



SVN revision: 66343
2011-12-20 01:03:17 +00:00