_elm_entry_smart_signali calls edje_object_message_signal_process for processing the pending messages.
Because Edje can’t changes size or position of parts immediately when it receive a signal without this.
Multiple popups (anchor hover and hoversel) are showing in following cases:
- Run elementary_test with Mobile profile --> Entry Anchor
+ click on anchor to show hover, then press menu key
+ right click on anchor
and vice versa. Avoids some warnings in clang and it helps see that
these are actually different types.
Signed-off-by: Daniel Willmann <d.willmann@samsung.com>
I splited ELM_SAFE_FREE refactoring patches. One commit per each file as recommended.
For the detail, please refer 3072dab12f12fe83fb5a628d15efd5cded11787f.
There are pros and cons but this
1. reduces human mistakes.
2. enhances readability.
3. enhances code quality.
4. removes future bug.
5. was adopted from enlightenment.
This is not all. I will work on enhancing elementary more and more.
When we call elm_entry_markup_filter_remove() with internally defined filter callbacks,
it doesn't work. So we need a one of pointer for saving the address of data.
10 Elm_Entry_Filter_Limit_Size lim;
11 lim.max_char_count = 20;
12 lim.max_byte_count = 0;
13 elm_entry_markup_filter_append(en, elm_entry_filter_limit_size,
&lim);
14
15 elm_entry_markup_filter_remove(en, elm_entry_filter_limit_size,
&lim);
16 lim.max_char_count = 50;
17 lim.max_byte_count = 0;
18 elm_entry_markup_filter_append(en, elm_entry_filter_limit_size,
&lim);
In this code, we expect to see the filter of entry will be renewed.
But elm_entry_markup_filter_remove() doesn't work.
Because, markup_filter does not hold the address of data when we use
the filter callback which is defined in elm_entry.c
_filter_new() in elm_entry.c
You can see that _filter_new allocates new pointer and names as lim2.
lim2 is saved in data of _Elm_Entry_Markup_Filter. So the address of
data doesn't equal to the input data.
item click.
This patch adds callback for copy/cut context menu item click,
so that application developers can add their own processing for
copy/cut item click event.
1. Do not need to print the same error message from all the widget codes.
2. Even though elm_widget_sub_object_add() can be used internally, there should be no error message at all.
Elm devs should fix it beforehand.
So it looks ok to print the error message in elm_widget_sub_object_add() to force elm devs to fix it.
3. Got additional code cleanups.
Issue: Currently There is no possibility in entry to get currently
selected context menu items contents i.e., Label, icon etc:- due
to this issue a separate callback has to be added per item or the
item's contents has to be sent in data.
Fix: This patch fixes this problem by sending item pointer as
event_info and providing APIs to access the item pointer. This fix is
very useful for applications which add their own context menu items to
entry's context menu.
Signed-off by: Shilpa Singh(shilpa.singh@samsung.com)