Commit Graph

533 Commits

Author SHA1 Message Date
Mike Blumenkrantz 47dc963983 fix case where user can specify item block size < 1; this also reveals an api error since the param here should obviously be a uint.
SVN revision: 71498
2012-05-29 09:04:42 +00:00
Mike Blumenkrantz e89088bde6 simplify item block deletion merging
SVN revision: 71496
2012-05-29 09:04:16 +00:00
Hyoyoung Chang 1a13829c1d elementary/genlist: fix indent
SVN revision: 71385
2012-05-24 04:59:52 +00:00
Carsten Haitzler 8839f523c2 remove goto and use if () instead
SVN revision: 71383
2012-05-24 04:44:44 +00:00
Hyoyoung Chang 6b28932fbf elementary/genlist: add short cut in item bring in calc.
fix compress_mode documentation.


SVN revision: 71349
2012-05-23 07:31:03 +00:00
Carsten Haitzler 5948ae4fba Fix genlist ELM_LIST_LIMIT mode to do what it originally did.
Documentation was wrong too and code had a slight bug stopping
genlist from contracting to min size.
Optimize the case of COMPRESS + homogeneous mode to avoid
queue entirely and use existing known item sizes.
        


SVN revision: 71140
2012-05-16 05:28:40 +00:00
Hyoyoung Chang 87e7198049 elementary/genlist: pan calculate if blocks changed at _item_block_del
SVN revision: 70903
2012-05-10 06:30:49 +00:00
Hyoyoung Chang b52e855c5a elementary/genlist: add to check items at focus_hook
SVN revision: 70893
2012-05-09 10:43:35 +00:00
ChunEon Park cd2202140d elementary/genlist - genlist patch
Please find attached updated patch. 

Change log: Genlist - crash fix (if itc parameter is passed as NULL ) 

Signed-off by: Shilpa Singh<shilpa.singh@samsung.com>

Thanks & Regards 

Shilpa 



SVN revision: 70833
2012-05-07 02:05:35 +00:00
Daniel Juyung Seo 9686b496c6 elm genlist: Realize move items during tree effect only when the item is not in the queue.
SVN revision: 70517
2012-04-27 11:08:53 +00:00
Daniel Juyung Seo 2d418589b0 elm genlist: Fixed genlist expandable effect bug when we expand/contract items with many children very quickly.
SVN revision: 70516
2012-04-27 11:08:46 +00:00
Hyoyoung Chang 78c20c9266 genlist : remove useless tabs
SVN revision: 70471
2012-04-25 13:37:20 +00:00
Hyoyoung Chang 22e4c79dbe genlist : clean up formatting
SVN revision: 70470
2012-04-25 13:31:37 +00:00
Carsten Haitzler ca6111b857 thanks to brian wang - check if show item has a block.
SVN revision: 70452
2012-04-25 00:44:16 +00:00
Michael BOUCHAUD db07a49c38 elementary: use FOREACH_SAFE we remove an element in the loop
SVN revision: 70364
2012-04-20 14:31:51 +00:00
Carsten Haitzler 3a7b769a63 use the new escape text set to clear up issues if theme has TEXT vs
TEXTBLOCK items and handling escapes so text is consistend across elm.
fiuxes the fileselector issues kai reported.



SVN revision: 70362
2012-04-20 12:51:10 +00:00
Daniel Juyung Seo c1aab815f3 elm genlist: Remove item from moved_item when an item is deleted and set effect mode to none when the deleted item is an expanded_item.
SVN revision: 70359
2012-04-20 10:50:46 +00:00
Daniel Juyung Seo d133cec514 elm genlist: Fixed genlist crash issue when huge amount of items are expanded/contracted in a short time.
SVN revision: 70358
2012-04-20 10:50:42 +00:00
Daniel Juyung Seo 3663ddc1d0 elm genlist: Use Widget_Data variable for convenience.
SVN revision: 70357
2012-04-20 10:50:39 +00:00
Daniel Juyung Seo 75ee2bb1a4 elm genlist: Use ECORE_CALLBACK_CANCEL rather than EINA_FALSE for animator.
SVN revision: 70356
2012-04-20 10:50:33 +00:00
Daniel Juyung Seo cbddd07a8b elm genlist: Fixed grid segfault issue. Patch by Hyoyoung Chang
<hyoyoung@gmail.com>

On Fri, Apr 20, 2012 at 4:10 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> Dear all,
>
> After introduced flipped mode to genlist, some clearing process is
> added to _elm_genlist_item_unrealize.
> In item _elm_genlist_item_unrealize, item is casting to gengrid item
> or genlist item.
> segfault is occurred in _elm_genlist_item_unrealize at using gengrid.
> this patch moves flipped mode clearing process to _item_realize_cb.
>
> Thanks.
>

SVN revision: 70355
2012-04-20 08:44:48 +00:00
Daniel Juyung Seo efe4997a78 elm genlist: Fixed item selection bug with decorate_all mode. Patch by
Hyoyoung Chang <hyoyoung@gmail.com>

On Fri, Apr 20, 2012 at 5:19 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> After discuss with seoz, i changed to not clean selections also i
> removed the new added internal func.
>
> Thanks
>
> On Fri, Apr 20, 2012 at 4:00 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
>> Dear all,
>>
>> I made a small patch to fix remained selection bug.
>> In decorate all mode, some item selection is not cleared after unset
>> decorate all mode.
>> I added to fix it.
>> And make unselecting common routine to a internal function.
>>
>> Thanks.

SVN revision: 70354
2012-04-20 08:40:13 +00:00
Daniel Juyung Seo 4a1590c6cb elm genlist: Fixed formatting.
SVN revision: 70353
2012-04-20 08:40:10 +00:00
Hyoyoung Chang d80dd9cb7e From: Hyoyoung Chang <hyoyoung@gmail.com>
Subject: [E-devel] [patch] elm_genlist - bugfix at item flipped

I made a small patch about item flipped.
It resolves two bugs

1. flip_set and unset is called quickly, sometimes genlist can't free
flipped data.
it fixed to remove checking flipped status in item unrealize

2. add item unhighlight at flip_job



SVN revision: 70306
2012-04-18 10:43:51 +00:00
chanwook jung 55138d3bd2 From: chanwook jung <jchanwook@gmail.com>
Subject: [E-devel] [Patch][Genlist] fix the bug in _elm_genlist_item_del_notserious

I made a patch to fix the bug in _elm_genlist_item_del_notserious.
If relcount is not 0 or walking is not 0, return.



SVN revision: 70291
2012-04-18 09:07:36 +00:00
Hyoyoung Chang 6be49b9abf From: Hyoyoung Chang <hyoyoung@gmail.com>
Subject: [E-devel] [patch] elm_genlist - some lines indent fixes

I fixed several lines indent.
Also remove useless comments.



SVN revision: 70173
2012-04-13 11:29:19 +00:00
Daniel Juyung Seo 316a8cd712 elm genlist.c: Removed elm_object_item_content_set/unset, text_set hook.
SVN revision: 70153
2012-04-12 15:35:09 +00:00
Daniel Juyung Seo 12da5dc07d elm genlist: genlist/gengrid do not support elm_object_item_part_text/content_set/unset. Use normal callback systems.
SVN revision: 70122
2012-04-12 07:14:21 +00:00
Daniel Juyung Seo c4fc10388c elm list/genlist: Renamed interval text get/set hook name.
SVN revision: 70121
2012-04-12 07:14:15 +00:00
Daniel Juyung Seo f4da9d343b elm genlist: Get the stringlist only when it does not exist. Free the stringlist when we change the item class.
SVN revision: 69946
2012-04-06 07:10:29 +00:00
Daniel Juyung Seo 02082649a0 elm genlist: Renamed internal variables. Patch by Hyoyoung Chang
<hyoyoung@gmail.com>
On Thu, Apr 5, 2012 at 3:13 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> Dear all,
>
> It simple renaming patch for elm_genlist.
> I rename two variables.
>
> deco_all_obj -> deco_all_view
> deco_all_textss -> deco_all_texts
>
> Thanks

SVN revision: 69945
2012-04-06 07:10:26 +00:00
Daniel Juyung Seo f7f801f7be elm genlist: Patch for elm_genlist_item_fields_update. Patch by
Hyoyoung Chang <hyoyoung@gmail.com>
On Thu, Apr 5, 2012 at 3:12 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> Dear all,
>
> I made a patch for elm_genlist_fields_update to selective content
update.
> a genlist item can update any content regardless of its mode.
>
> Thanks.
>
> PS: It assumed my previous patch is applied ([patch] elm_genlist -
> split flip content from item's content)

SVN revision: 69944
2012-04-06 07:10:20 +00:00
Daniel Juyung Seo 676712d8a6 elm genlist: Refactored flip mode. Patch by Hyoyoung Chang
<hyoyoung@gmail.com>
On Wed, Apr 4, 2012 at 9:23 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> Dear all,
>
> in genlist flip mode, a item shares its content and flip content.
> it's split flip content patch.
>
> Thanks.

SVN revision: 69941
2012-04-06 04:14:48 +00:00
Jihoon Kim b7c213af86 elementary: ignore key event of keypad when NumLock is turned on in calendar, diskselector, gengrid, genlist, and player
SVN revision: 69939
2012-04-06 00:56:06 +00:00
ChunEon Park 363a5fa126 elementary/genlist - [E-devel] [Patch][Genlist] removed unnecessary code in _clear_cb
Dear ALL,

If the block that must be removed/freed, it has already removed/freed in
_item_block_del.
So I removed the code in _clear_cb.

Thanks
Joey

Submitted-By-Off ChankWook Jung<jchanwook@gmail.com>



SVN revision: 69929
2012-04-05 08:19:26 +00:00
Daniel Juyung Seo a96e0201c4 elm genlist: Renamed internal variables and functions. Patch by Hyoyoung Chang <hyoyoung@gmail.com>
On Mon, Apr 2, 2012 at 8:44 PM, Hyoyoung Chang <hyoyoung@gmail.com> wrote:
> Dear all
>
> It renames genlist internal variables and functions.
>
> decorate_type -> decorate_it_type
> mode_set -> decorate_it_set
>
> It also includes that a api arguments' naming is changed.
> -EAPI void
> elm_genlist_item_decorate_mode_set(Elm_Object_Item *it, const char
> *mode_type, Eina_Bool mode_set);
> +EAPI void
> elm_genlist_item_decorate_mode_set(Elm_Object_Item *it, const char
> *decorate_it_type, Eina_Bool decorate_it_set);
>
> Thanks.

SVN revision: 69893
2012-04-03 09:56:53 +00:00
Daniel Juyung Seo 7284ea1f45 elm genlist: Renamed internal variables/functions. Patch by Hyoyoung Chang <hyoyoung@gmail.com>
On Mon, Apr 2, 2012 at 8:39 PM, Hyoyoung Chang <hyoyoung@gmail.com> wrote:
> Dear all
>
> It renames genlist internal variables/functions.
>
> decorate_mode->decorate_all_mode
> _decorate_mode_item_*->_decorate_all_item_*
>
> thanks.

SVN revision: 69892
2012-04-03 09:56:49 +00:00
Daniel Juyung Seo ef8998b2e6 elm genlist: Internal variable rename. Patch by Hyoyoung Change <hyoyoung@gmail.com>
On Mon, Apr 2, 2012 at 8:39 PM, Hyoyoung Chang <hyoyoung@gmail.com> wrote:
> Oops sorry.
> Adding attachment patch file.
>
> On Mon, Apr 2, 2012 at 8:36 PM, Hyoyoung Chang <hyoyoung@gmail.com> wrote:
>> Dear all
>>
>> it renames genlist internal variables.
>>
>> mode_view ->deco_it_view
>> decorate_mode_item_realized->decorate_all_item_realized
>>
>> thanks.

SVN revision: 69891
2012-04-03 09:56:44 +00:00
Daniel Juyung Seo d58e04ad9c elm genlist: Changed internal variables correctly. Patch by Hyoyoung
Chang <hyoyoung@gmail.com>

On Fri, Mar 30, 2012 at 5:17 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> I talked with seoz. and agreed with previous naming changing is
insufficient.
>
> so changed like this
> "mode_" -> "deco_it_"
> "edit_" -> "deco_all_"
>
> Thanks
>
> On Fri, Mar 30, 2012 at 3:33 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
>> Dear all,
>>
>> After edit mode naming is changed, some legacy naming is remained.
>> I changed naming to follow API naming changes.
>>
>> "edit_" -> "deco_"
>> and also some explicit edc part names are changed.
>>
>> Some naming are remained as is, I'll fix at next patches.
>>
>> Thanks.
>

SVN revision: 69836
2012-04-02 02:37:05 +00:00
Daniel Juyung Seo 768a4ad35f elm genlist: Reverted Hyoyoung's first patch. He sent another patch
for this change.
Revert "After edit mode naming is changed, some legacy naming is remained."

This reverts commit 5e1aa3c8b0382a0ca471150f4c219cd32dbdbe22.

SVN revision: 69835
2012-04-02 02:36:55 +00:00
Carsten Haitzler 63ae97a5d7 After edit mode naming is changed, some legacy naming is remained.
I changed naming to follow API naming changes.

"edit_" -> "deco_" and also some explicit edc part names are changed.

Some naming are remained as is, I'll fix at next patches.



SVN revision: 69793
2012-03-30 10:34:31 +00:00
Daniel Juyung Seo 4cf83b449b elm genlist: Set long_timer to NULL after it's deleted.
SVN revision: 69789
2012-03-30 09:25:58 +00:00
WooHyun Jung 67f269947b elementary/genlist : set NULL for swipe_timer.
SVN revision: 69788
2012-03-30 09:22:49 +00:00
Daniel Juyung Seo 76b7c58c8e elm genlist: Fixed genlist infinite loop bug.
SVN revision: 69785
2012-03-30 07:28:04 +00:00
Daniel Juyung Seo 8c17d99712 elm: Fixed formatting. Added a space after 'if/while/for'
SVN revision: 69744
2012-03-29 11:09:45 +00:00
Daniel Juyung Seo 6733c92556 elm genlist: Fixed _item_content_set_hook. Use _item_content_unset_hook internally.
SVN revision: 69742
2012-03-29 11:09:34 +00:00
Daniel Juyung Seo 3d15654faa elm elm_object_item: Fixed item part content set hooks.
1. delete old content object
2. check whether new content object is same as old content object
3. rename internal content set hook function
4. elm_widget_sub_object_del will be followed by evas_object_del
5. added some doxygen description.

SVN revision: 69738
2012-03-29 10:08:37 +00:00
Daniel Juyung Seo c1c64fe3ad elm genlist: Fixed flip bug. Patch by Hyoyoung Chang
<hyoyoung@gmail.com>

On Thu, Mar 29, 2012 at 4:56 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> Dear all
>
> I made a patch about flip_realize.
> Currently flip feature uses content_objs, so it should keep its
content_objs.
> However it's lost at _item_flips_realize().
> So i fixed to initialize with its content_objs.
>
> Thanks

SVN revision: 69725
2012-03-29 08:22:26 +00:00
Daniel Juyung Seo 2d2ed8d95d elm genlist: Remove tree_effect_animator on genlist _del_hook.
SVN revision: 69721
2012-03-29 07:19:23 +00:00
Daniel Juyung Seo 09e15ebe04 elm genlist: Fixed tree effect bug. Patch by Chanwook Jung
<jchanwook@gmail.com>

On Wed, Mar 28, 2012 at 3:06 PM, chanwook jung <jchanwook@gmail.com>
wrote:
> Dear all,
>
> I added one line to fix the bug at tree effect. If the item is equal
to
> expanded_next_item, expanded_next_item set to NULL in _item_del
>
> Thanks,
> Joey

SVN revision: 69691
2012-03-28 06:23:18 +00:00