Subject: [E-devel][Patch][ecore_con] Fix invalid curl handle removal by valgrind
Date: Wed, 22 Feb 2012 19:57:36 +0900
Hello,
discomfitor reports bugs by valigrind. I checked it with valgrid and
I found the clues
curl_multi_remove_handle() should not be called when multi handles
being performed. So I removed curl_multi_remove_handle() code from
_ecore_con_url_info_read()
Now, curl_multi_remove_handle() is only called for all easy handles
when a multi-handle ended.
Please review this simple patch.
SVN revision: 68287
Subject: [E-devel] [Patch][ecore_con] Fix return value checking
Date: Tue, 3 Jan 2012 10:01:17 +0900
Hi,
There is invalid return value checking of curl_multi_perform() in ecore_con_url.
Because CURLM_CALL_MULTI_PERFORM is also not CURLM_OK,
CURLM_CALL_MULTI_PERFORM checking should precede CURLM_OK checking.
It's simple fix. Please review this
--
BRs,
Kim.
SVN revision: 66771
post data to be corrupted (as it was never copied into the
ecore con url struct) or could cause crashes if the memory
pointed to became invalid.
SVN revision: 66619
Subject: Re: [E-devel] [Patch][ecore_con_url] Add proxy & timeout set
API
There existed two problems when using ecore_con_url. We cannot set
proxy and set timeout.
So, I added two APIs for solving these problems.
Proxy can be set by setting libcurl option.
Timeout also can be set but It need to add handler for Linux alarm
signal. (Please refer:
http://curl.haxx.se/libcurl/c/curl_easy_setopt.html#CURLOPTTIMEOUT)
So I implemented it by using ecore timer.
SVN revision: 66414
Subject: [E-devel] [ecore_con] Bug fix when data is NULL.
If data is NULL, curl makes length field as -1 .
length filed should be set by 0.
SVN revision: 65006
Subject: [E-devel] Small patch with ecore_con_url.
When I tested with elementary map, there is too many logs on console.
It makes me difficult to distinguish normal logs that I want to debug.
:'-(
It's libcurl's internal log for representing progress bar like this.
-----
downloaded : 343 / 363
% Total % Received % Xferd Average Speed Time Time Time
Current
Dload Upload Total Spent
Left
Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:--
--:--:--
0
downloaded : 343 / 362
% Total % Received % Xferd Average Speed Time Time Time
Current
Dload Upload Total Spent
Left
Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:--
--:--:--
0
downloaded : 343 / 361
% Total % Received % Xferd Average Speed Time Time Time
Current
Dload Upload Total Spent
Left
Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:--
--:--:--
0
downloaded : 344 / 365
downloaded : 345 / 365
downloaded : 346 / 365
downloaded : 347 / 365
-----
So, I want to remove this log.
And I look around ecore_con_url's code.
Then I found solution for it.
SVN revision: 64596
Yunhan <spbear@gmail.com>
On Wed, Sep 21, 2011 at 10:51 PM, Kim Yunhan <spbear@gmail.com> wrote:
> Hello!
>
> elm_map uses Ecore Con with CURL.
> I tested elm_map many times on my device.
> But sometimes UI interaction is held when data connection is poor.
> So I tried to debug and I found that this code lead to hold an Ecore
main
> loop.
>
> ----------------------------------------------
> In ecore_con_url.c
>
> while (curl_multi_perform(_curlm, &still_running) ==
> CURLM_CALL_MULTI_PERFORM) ;
> ----------------------------------------------
>
> curl_multi_perform() is CURL's asynchronous API.
> But above code hold an Ecore main loop.
> When it takes long time in libcurl, UI interaction is delayed.
>
> For example, If you have poor data connection.
> libcurl is trying to resolve DNS in this step.
> But it have to wait until timeout.
> At that time it looks like being locked.
>
> So I write a patch for fixing it.
SVN revision: 63636
Cookie related function documentation is moved, and some additional
comments were added to ecore_con_url_cookies_file_add and
ecore_con_url_cookies_jar_file_set.
SVN revision: 61349
This only affects ecore_con_url_* for now.
Also add docs to the structures used by ecore_con_url, and move them to
the Ecore_Con_Url_Group.
SVN revision: 61159
Mike Blumenkrantz
Carsten Haitzler
Bluezery
Youness Alaoui
Kim Yunhan
Sebastian Dransfeld
Daniel Juyung Seo
Rafael Antognolli
Sanjeev BA
Vincent Torri
Cedric BAIL