There was code to silence errors. Removing that exposed a lot of errors.
I fixed them as well. In general, elm_widget functions should only be called
on elm_widgets...
More of commit 5ac398b156e8fb0aa44c6cfe8a2b113eb7229fbf
There was code to silence errors. Removing that exposed a lot of errors.
I fixed them as well. In general, elm_widget functions should only be called
on elm_widgets...
@fix.
- Reduced the if statement depth.
- Introduced new macro ELM_RECTS_POINT_OUT that checks if the point(xx,
yy) stays out of the rectangle(x, y, w, h) area.
Summary:
Problem: list theme (elm/list/base/default) is an alias of scroller
base theme (elm/scroller/base/default) in which focus_highlight is set to "on".
Solution: Now focus highlight in_theme is set by list item theme.
Test Plan: elementary_test->"List Focus"
Reviewers: seoz, woohyun
Reviewed By: seoz
CC: nirajkr
Differential Revision: https://phab.enlightenment.org/D572
@feature
Summary:
# Added "item,focused" and "item,unfocused" smart callbacks.
# Added elm_object_focused_item_get() in elm_widget
# Added elm_object_item_focus_set and elm_object_item_focus_get() APIs for
# Added one argument in existing _focus_highlight_geometry_get(...,is_next)
This is required to find out previous and current widget item.
# Added a elm_win function _focus_highlight_start() which starts the focus
Test Plan: elementary_test->List Focus , List Horizontal Focus
Reviewers: seoz, woohyun
Reviewers Comments: SeoZ - there are some known bugs. we will actively
fix them in a near future.
CC: nirajkr
Differential Revision: https://phab.enlightenment.org/D532
Summary:
Currently, elm_win was handling focus_highlight geometry of widgets.
Removed elm_win_focus_highlight_geometry_get() from elm_win and now elm_widget handles focus highlight geometry.
This is required to support the focus highlight on elm widget items.
Test Plan: elementary_test -> focus
Reviewers: seoz, raster, woohyun
CC: nirajkr
Differential Revision: https://phab.enlightenment.org/D530
This reverts commit 803553c253bc4ee140a4b447c29ffe35c31288ab.
This also removes the unused enum typedef in the header. only c++
seems to care (or -ansi or -pedantic or something)
Summary:
added broadcast of focus, window activate/deactivate events on a11y bus
Orca screen reader is now able to read elementary application.
Reviewers: raster, seoz, z.kosinski, kimcinoo
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D508
Summary: This new API will allow widget to have its own focus highlight style
Reviewers: seoz
CC: woohyun, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D501
Call the smart callback in the widget infra so that each widget don't need to hook the smart_translate only for the smart call.
This makes reducing duplicated code and supporting language,chagned from all widgets.
- When appending an object to the focus custom chain,
event callback about deletion should be added.
- When a widget is deleted, its focus custom chain should be
managed correctly.
There are elm_widget_theme/theme_set/theme_get functions.
In Eolian these functions will be described as "theme" method and
"theme" property. There is clash here.
So add suffix "_apply" to Eo API for "elm_widget_theme".
ELM_WIDGET_DATA_GET was checking it was the correct class. This is
stupid and wrong (and makes tools rightfully complain) because these
functions are implementations of that class anyway, so that would never
be false.
Functions that outside facing (that is, not called from eo_do) should
use API_ENTRY.
When elm_widget_newest_focus_order_get is called with can_focus_only,
only focusable objects should be the candidates for newest focused object.
But there are cases that unfocusable object add +1 to newest_focus_order.
On the widget creation time, we should not set the theme in the widget infra.
This will cause the corruption of the theme_hook working since the widget is not setup yet.
Also the theme_set() will be applied twice each widget will set the themes right after base widget is created.
Summary: Do not load widget theme for mirroring if smart data creation is not finished.
Reviewers: Hermet, raster
Reviewed By: raster
CC: seoz
Differential Revision: https://phab.enlightenment.org/D428
Being annoyed by different types of eina critical macros - CRI, CRIT,
CRITICAL -, I concluded to unify them to one. Discussed on IRC and
finally, CRI was chosen to meet the consistency with other macros -
ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
Summary: Checked whether object which direction pointed is NULL before getting it's data
Reviewers: seoz, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D95
Summary: Currently if the third argument of elm_widget_resize_object_set, 'Eina_Bool sub_obj', indicates whether a resize object is added to/deleted from the sub object or not. This commit makes the third argument, 'sub_obj', also indicate whether a resize object is added to/deleted from the smart member or not.
Reviewers: Hermet, seoz
Reviewed By: seoz
CC: seoz
Differential Revision: https://phab.enlightenment.org/D268
Summary: Add one more argument, 'Eina_Bool sub_object' to elm_widget_resize_object_set. If the argument, 'sub_object' is set as EINA_TRUE, the new resize object is added to the sub object and the previous resize object is deleted from the sub object.
Reviewers: Hermet, seoz
CC: Jaehyun_Cho, seoz, raster
Differential Revision: https://phab.enlightenment.org/D265
We've countered application's requirements multiple times to they have the object handle from the elm_object_item.
Now we introduce it for their convenient but they should use it carefully.
It prevents applying themes more strictly if it tries to apply same theme.
This increases the performance hugely in case that user applies a specific theme to the window object.
1. Do not need to print the same error message from all the widget codes.
2. Even though elm_widget_sub_object_add() can be used internally, there should be no error message at all.
Elm devs should fix it beforehand.
So it looks ok to print the error message in elm_widget_sub_object_add() to force elm devs to fix it.
3. Got additional code cleanups.
Daniel Zaoui
WooHyun Jung
Daniel Juyung Seo
Tom Hacohen
Gustavo Sverzut Barbieri
Daniel Juyung Seo
Amitesh Singh
Yakov Goldberg
Jaehwan Kim
Carsten Haitzler
U. Artie Eoff
Lukasz Stanislawski
Tae-Hwan Kim
nirajkr
ChunEon Park
Jaehyun Cho
ami
Ryuan Choi
Cedric Bail
Michael Bouchaud
Chris Michael
Shinwoo Kim
Daniel Juyung Seo