Commit Graph

10 Commits

Author SHA1 Message Date
Jaehyun Cho db7ed3dcdd ecore_audio_pulse_ml: Check memory allocation fail 2017-08-08 23:13:47 +09:00
Mike Blumenkrantz 179e89d955 ecore-audio: unset DISPLAY conditionally before processing pulse events
in some cases, pulse events trigger spawning another pulse instance, and
the environment at this time is used to determine whether to attempt an
x11 connection

fix T2599

@fix
2017-06-02 18:23:43 -04:00
Mike Blumenkrantz 1e18cf7057 ecore-audio: defer deletion of pulseaudio timer until after event processing
==27523== Invalid write of size 8
==27523==    at 0x9E855F5: _ecore_time_wrapper (ecore_audio_pulse_ml.c:132)
==27523==    by 0x647E5CF: _ecore_call_task_cb (ecore_private.h:336)
==27523==    by 0x647FB8B: _ecore_timer_expired_call (ecore_timer.c:733)
==27523==    by 0x647F9EE: _ecore_timer_expired_timers_call (ecore_timer.c:686)
==27523==    by 0x647B4CE: _ecore_main_loop_iterate_internal (ecore_main.c:1814)
==27523==    by 0x647998E: ecore_main_loop_begin (ecore_main.c:983)
==27523==    by 0x4E4F676: elm_run (elm_main.c:1099)
==27523==    by 0x12801B: elm_main (test.c:1010)
==27523==    by 0x1280C4: main (test.c:1021)
==27523==  Address 0x20537208 is 8 bytes inside a block of size 56 free'd
==27523==    at 0x4A07D6A: free (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==27523==    by 0x9E858ED: _ecore_pa_time_free (ecore_audio_pulse_ml.c:204)
==27523==    by 0x108DB350: free_events (socket-client.c:109)
==27523==    by 0x108DBA53: do_call (socket-client.c:157)
==27523==    by 0x9E855F0: _ecore_time_wrapper (ecore_audio_pulse_ml.c:131)
==27523==    by 0x647E5CF: _ecore_call_task_cb (ecore_private.h:336)
==27523==    by 0x647FB8B: _ecore_timer_expired_call (ecore_timer.c:733)
==27523==    by 0x647F9EE: _ecore_timer_expired_timers_call (ecore_timer.c:686)
==27523==    by 0x647B4CE: _ecore_main_loop_iterate_internal (ecore_main.c:1814)
==27523==    by 0x647998E: ecore_main_loop_begin (ecore_main.c:983)
==27523==    by 0x4E4F676: elm_run (elm_main.c:1099)
==27523==    by 0x12801B: elm_main (test.c:1010)
==27523==    by 0x1280C4: main (test.c:1021)

@fix
2015-09-30 16:23:55 -04:00
ChunEon Park d65714f520 ecore/ecore_audio: fix timer control logically wrong.
@fix
2015-03-01 17:59:52 +09:00
Chris Michael 5be999e0f5 Get the 'fd' from the handler First (regardless of read or write) so
that it can be used in the below event callback.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-08-06 09:48:21 +01:00
Chris Michael b211a27d67 Init fd to zero (removes compiler warning).
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-08-05 13:16:44 +01:00
Chris Michael 24413bd7ee Actually declare fd at the top of function.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-08-05 12:17:26 +01:00
Chris Michael 76766161d2 ecore_main_fd_handler_fd_get can return -1 so we need to check for a
valid fd before calling read().

Reuse returned fd variable in the callback to save extra function call
to ecore_main_fd_handler_fd_get (since we already acquired the fd
above).

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-08-05 11:46:04 +01:00
Daniel Willmann fe292a34fb ecore_audio: Fix possible memory leak in pulse main loop integration
Signed-off-by: Daniel Willmann <d.willmann@samsung.com>
2013-04-19 13:43:52 +01:00
Daniel Willmann 7255656738 ecore_audio: Add pulseaudio output for eo
Signed-off-by: Daniel Willmann <d.willmann@samsung.com>
2013-04-18 19:14:32 +01:00