Commit Graph

64135 Commits

Author SHA1 Message Date
Xavi Artigas a3d77a648c Typo in comment 2019-10-31 09:48:48 -04:00
Yeongjong Lee 986693e66c eina_array: add paramName argument of ArgumentNullException
Summary:
ArgumentNullException constructor included `message` is
`public ArgumentNullException (string paramName, string message);`

Fix CA2208
ref T8428

Test Plan:
meson setup -Dbindings=mono,cxx -Dmono-beta=true
ninja test

Reviewers: lauromoura, felipealmeida, brunobelo

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8428

Differential Revision: https://phab.enlightenment.org/D10464
2019-10-31 09:48:43 -04:00
Bruno da Silva Belo ac0df9b6c9 csharp:Changing ex access modifier from Errors.cs.
Summary: ref T8401

Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8401

Differential Revision: https://phab.enlightenment.org/D10502
2019-10-31 09:48:27 -04:00
Mike Blumenkrantz d83b755be6 ci: use shell to directly set base_dir for osx builds
Summary: this crashes somehow and is impossible to debug remotely

Reviewers: bu5hm4n

Reviewed By: bu5hm4n

Subscribers: bu5hm4n, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10529
2019-10-31 09:47:56 -04:00
Bruno da Silva Belo ad49f2cde4 csharp: Using Array.Empty Eina.
Summary: ref T8421

Reviewers: lauromoura, felipealmeida, segfaultxavi, YOhoho

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8421

Differential Revision: https://phab.enlightenment.org/D10500
2019-10-31 09:47:53 -04:00
Bruno da Silva Belo 6180473f25 csharp:Using Array.Empty genericmodel.
Summary: ref T8421

Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8421

Differential Revision: https://phab.enlightenment.org/D10501
2019-10-31 09:47:01 -04:00
Bruno da Silva Belo 5655d8bd2c csharp: Changing Count() to Length on eina_value.
Summary: ref T8422

Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8422

Differential Revision: https://phab.enlightenment.org/D10499
2019-10-31 09:46:59 -04:00
Bruno da Silva Belo 4c224287a6 csharp: Using Count eina_promises.
Summary: ref T8422

Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8422

Differential Revision: https://phab.enlightenment.org/D10498
2019-10-31 09:46:57 -04:00
Bruno da Silva Belo d77f0c8c1e csharp: Calling ConfigureAwait on tasks GM.
Summary: ref T8424

Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8424

Differential Revision: https://phab.enlightenment.org/D10497
2019-10-31 09:46:49 -04:00
Bruno da Silva Belo a3234610a9 csharp: Calling ConfigureAwait on tasks Model.
Summary: ref T8424

Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8424

Differential Revision: https://phab.enlightenment.org/D10496
2019-10-31 09:46:48 -04:00
Bruno da Silva Belo 13bac4bfe1 csharp: Calling ConfigureAwait on task eopromises.
Summary: ref T8424

Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8424

Differential Revision: https://phab.enlightenment.org/D10495
2019-10-31 09:46:46 -04:00
Yeongjong Lee a3f84181e8 mono: implement dispose method based on dispose pattern
Summary:
Fix CA1063, CA1816
ref T8400, T8419

Test Plan:
meson setup -Dbindings=mono,cxx -Dmono-beta=true
ninja test

Reviewers: felipealmeida, brunobelo, YOhoho

Reviewed By: YOhoho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8419, T8400

Differential Revision: https://phab.enlightenment.org/D10460
2019-10-31 09:46:41 -04:00
Mike Blumenkrantz a9cb1d40a5 tests/layout: add legacy layout test to verify behavior with legacy size hints
Summary:
this verifies that user-set legacy size hints will be applied accurately during
calc, and that the size of a layout can accurately decrease when its contents min
sizes decrease

ref 95b5731461

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10453
2019-10-31 09:45:15 -04:00
Mike Blumenkrantz 7c8cf4cba2 efl_ui/text_scroller: fix null derefs
Summary: CIDs 1403890, 1396964, 1396945

Reviewers: cedric, vtorri

Reviewed By: cedric

Subscribers: vtorri, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10447
2019-10-31 09:45:10 -04:00
Bruno da Silva Belo 8dff5a992a csharp: Returning only method name iwrapper.
Summary:
GetUserMethods returning only strings,
not the whole method informations.

Reviewers: lauromoura, felipealmeida

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10503
2019-10-31 09:45:08 -04:00
Mike Blumenkrantz 5778274021 elm/code: check save file attrs after opening
ensure that they haven't changed between time of check and time of open

CID 1396966

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10440
2019-10-31 09:44:58 -04:00
Hosang Kim 5e3db3bef8 efl_message: add pending queue for filtering message.
Sometimes message is appended when message queue is walking.
In this case, newly added messages are not filtered.
So I add message pending queue for filtering message.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10459
2019-10-31 09:44:56 -04:00
Yeongjong Lee bd73ee7eee eina_mono: re-throw exception to preserve stack details
Summary:
fix CA2200
ref T8426

Test Plan:
meson setup -Dbindings=mono,cxx -Dmono-beta=true
ninja test

Reviewers: lauromoura, felipealmeida, brunobelo

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8426

Differential Revision: https://phab.enlightenment.org/D10462
2019-10-31 09:44:29 -04:00
Yeongjong Lee caa60fdff9 eina_mono: Initialize UNHANDLED_EXCEPTION inline
Summary:
fix CA2207
ref T8427

Test Plan:
meson setup -Dbindings=mono,cxx -Dmono-beta=true
ninja test

Reviewers: lauromoura, felipealmeida, brunobelo

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8427

Differential Revision: https://phab.enlightenment.org/D10463
2019-10-31 09:44:26 -04:00
Lauro Moura 998ec86132 csharp: Add since information to EoWrapper.cs
Reviewers: brunobelo, segfaultxavi, felipealmeida, woohyun

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10429
2019-10-31 09:44:22 -04:00
Mike Blumenkrantz 3ce02d94c5 tests/ecore: ensure that we attempt to re-set PATH in ecore-file tests
Summary:
if this test failed before for any reason, PATH would be permanently changed
for the current shell and process, which is obviously not what we want
Depends on D10414

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10415
2019-10-31 09:44:18 -04:00
Mike Blumenkrantz 31417093e8 tests/ecore: replace all bespoke strcats with snprintf
Summary:
CID 1400812
Depends on D10413

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10414
2019-10-31 09:44:15 -04:00
Mike Blumenkrantz e649b10b18 tests/ecore: unset app args after app args unit test to prevent invalid reads
Summary:
various internal components in efl access the app args and read them which
will result in invalid memory access since these are stack-allocated strings
Depends on D10412

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10413
2019-10-31 09:44:12 -04:00
Mike Blumenkrantz c680535cff ecore/app: permit resetting app args to uninitialized (zeroed) state
Summary:
this is mainly useful for unit testing, but unsetting values should not be
treated as an error

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10412
2019-10-31 09:44:09 -04:00
Mike Blumenkrantz de54df1f0a tests/eina: use slstr_steal function in slstr_steal test
Summary: CID 1401043

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10404
2019-10-31 09:44:05 -04:00
Mike Blumenkrantz ae1f7c503e tests/spec: free array in multi selectable tests
Summary: CIDs 1405810, 1405807, 1405806, 1405805, 1405803, 1405801, 1403902

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10403
2019-10-31 09:44:03 -04:00
Yeongjong Lee 4abf6d4511 mono: merge namespaces in manual bindings
Summary:
It will enhance readability.
Before
```
namespace Efl {
namespace Eo {
```

After
```
namespace Efl.Eo {
```

Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true

Reviewers: lauromoura, Jaehyun_Cho, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10466
2019-10-31 09:43:58 -04:00
Felipe Magno de Almeida 91b1033a98 cxx: Add license to CXX bindings.
Summary:
Like C#, it will also be Apache 2.0

Depends on D9414

Reviewers: vitor.sousa, woohyun, jpeg, lauromoura

Reviewed By: lauromoura

Subscribers: jpeg, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9418
2019-10-31 09:43:54 -04:00
Lauro Moura 92199b3450 csharp: Add licensing information.
Summary:
C# bindings will be lincensed under Apache Sofware License 2.0.

This commit adds the license text to the licenses folder and a copyright
notice to the binding files.

Fixes T8039

Reviewers: woohyun, felipealmeida, vitor.sousa

Reviewed By: felipealmeida

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8039

Differential Revision: https://phab.enlightenment.org/D9414
2019-10-31 09:43:51 -04:00
Mike Blumenkrantz 4241fa1734 examples/efl_thread: fix oob writes
Summary: CIDs 1403896, 1403895, 1403892

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10395
2019-10-31 09:43:47 -04:00
Mike Blumenkrantz 325359748c examples/ecore: use correct type for getchar() return
Summary:
correct prototype is int getchar(void);

CID 1400794

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10391
2019-10-31 09:43:45 -04:00
Carsten Haitzler 09e343e4ae spaces-- 2019-10-31 09:43:43 -04:00
Xavi Artigas 4af8ae8daa docs: small fixes to Efl.Text 2019-10-31 09:43:32 -04:00
Christopher Michael 83bdf3692e ecore-evas-wayland: Minor formatting fixes
NB: No functional changes
2019-10-31 09:43:29 -04:00
Christopher Michael 718ee59e6e ecore-wl2: Minor formatting fix
NB: No functional changes
2019-10-31 09:43:25 -04:00
Christopher Michael a0bd434e41 ecore_evas_wayland: Fix array step size
Fix bug where eina_array step size was being increased by 10 everytime
a handler was pushed to the array. There is no need to increase array
size by 10 each time we add 1 pointer to handler.

@fix
2019-10-31 09:43:22 -04:00
Christopher Michael 3ba03f2a5f ecore-evas-wayland: Add handler to array
Small patch to fix bug where last event handler was not being added to
the event_hdls array

@fix
2019-10-31 09:43:11 -04:00
Christopher Michael b93b6f300b ecore-evas-wayland: Minor formatting fix
NB: No functional changes
2019-10-31 09:43:09 -04:00
Christopher Michael 1366780806 ecore-evas-wayland: Minor formatting fix
NB: No functional changes
2019-10-31 09:43:08 -04:00
Mike Blumenkrantz 75414d27ce fix various trivial null derefs
Summary:
CIDs 1401081, 1401044, 1400983, 1400960, 1400927, 1400799, 1396946, 1396944,
     1383851, 1383847, 1382211, 1379921, 1379921

Reviewers: cedric

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10452
2019-10-31 09:42:32 -04:00
Mike Blumenkrantz 5d2964af15 efl/io: return EINVAL if null slice is passed for writing
Summary: CIDs 1396996, 1396983, 1396953

Reviewers: cedric

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10451
2019-10-31 09:42:30 -04:00
Mike Blumenkrantz 0296ef2036 tests/ecore_con: clarify pointer usage in ecore_con_url tests
Summary:
this was pretty bizarre

CID 1401029

Reviewers: cedric

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10450
2019-10-31 09:42:27 -04:00
Mike Blumenkrantz a90426ad15 elm/main: fix null deref
Summary: CID 1402697

Reviewers: cedric

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10449
2019-10-31 09:42:23 -04:00
Mike Blumenkrantz 79e6fa20c2 efl/engines: fix null derefs
Summary: CIDs 1402640, 1402709

Reviewers: cedric

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10448
2019-10-31 09:42:21 -04:00
Mike Blumenkrantz 1b4940c773 evas_vg/svg: fix null deref
Summary: CID 1405672

Reviewers: cedric

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10446
2019-10-31 09:42:19 -04:00
Mike Blumenkrantz b0e4a76c6a eina/convert: init endptr in failure case of eina_convert_strtod_c
Summary:
there is not any way to determine that this function has failed other
than to check this pointer, so ensure that it always has a value which
is meaningful in failure cases

Reviewers: cedric

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10445
2019-10-31 09:42:17 -04:00
Mike Blumenkrantz 44ef1dedfb efl/boolean_model: remove misleading null check
Summary:
this is always a pointer to a stack variable

CID 1405799

Reviewers: cedric

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10444
2019-10-31 09:42:14 -04:00
Mike Blumenkrantz 1f0de74bec embryo: don't use sizeof() when strlen() is intended
Summary: CID 1402617

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10411
2019-10-31 09:42:12 -04:00
Mike Blumenkrantz 240c023fd1 tests: fix minor string leaks
Summary: CIDs 1404754, 1401022, 1400965

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10405
2019-10-31 09:42:02 -04:00
Mike Blumenkrantz c6f16224f0 benchmarks/eina: fix possible div by zero in ecore_hash
Summary: CID 1400768

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10397
2019-10-31 09:41:59 -04:00