Hello everyone,
There are two issues with ctxpopup:
- Memory leak: Elm_Ctxpopup_Item is used but not deleted.
- Incorrect callback function: returned object and event_info are list object and item
(should be ctxpopup object and item).
I would like to send a patch to fix above issues.
I also provide the patch for backporting.
Please review them.
Best Regards,
Thiep
Signed-Off-By: Theip Ha<thiep.ha@samsung.com>
SVN revision: 82968
Before the patch, when window of device which has elementary rotates,
the ctxpopup doesn't emit the "dismissed" signal to application.
For this reason, if an application developer wants to make an event using "dismissed" signal when device rotates,
he/she cannot do anything.
But after add evas_object_smart_callback in the function "_on_parent_resize",
this problem is resolved.
That means, whether a device is rotated or not, when ctxpopup disappears, "dismissed" signal is emitted.
So I want you to check this patch.
Thank you.
Signed-Off-By: Bora Hwang<bora1.hwang@samsung.com>
SVN revision: 82918
Subject: [E-devel] [PATCH] elm_index: removed unnecessary lines
I removed some unnecessary lines from elm_index.c
1. in _index_box_auto_fill
_index_box_clear(line 178) does nothing:
if _index_box_clear is called, it means sd->level_active[level] is
false (line 116).
if sd->level_active[level] is false, _index_box_clear returns
immediately (line 60).
2. in _on_mouse_down
3. in _on_mouse_in_access
4. in _autohide_disabled_set
Signal emit is enough.
Filling the box and displaying the box are separated jobs.
I think it's logically consistent to fill the box only when
1) elm_index_level_go is called
2) theme is changed
5. in _level_go
Always clear the box before fill the box.
SVN revision: 82864
On Tue, Jan 15, 2013 at 6:02 PM, SHILPA ONKAR SINGH <shilpa.singh@samsung.com> wrote:
Hi All,
Please find attached bug fix for elm_check - toggle style.
This patch prevents "changed" signal being sent twice in case of
toggle style when check is clicked.
This also fixes few indentation issues in the style.
Change description:
elm_check: Bug fix "changed" signal being sent twice in case of toggle style when check is clicked.
Signed-Off by: Rajeev Ranjan(rajeev.r@samsung.com)
Signed-Off by: Shilpa Singh(shilpa.singh@samsung.com)
Thanks & Regards
Shilpa Singh
SVN revision: 82845
On Sun, Jan 6, 2013 at 2:23 PM, 조재현 <jae_hyun_cho@naver.com> wrote:
Dear all,
Hello. This is Jaehyun Cho.
Now, naviframe emits state signals (e.g. show or hide) for customized text part (i.e. neither "elm.text.title" nor "elm.text.subtitle") which is going to be appended to the item's text_list.
However, if the customized text parts change the text label when the text parts are in the item's text_list, naviframe does not emit state signals for them.
To resolve this issue, I added additional case in _item_text_set_hook to handle the text part which is in the item's text_list. (elementary/src/lib/elc_naviframe.c)
Please review this.
Thank you,
Jaehyun Cho.
SVN revision: 82300
now it supports slides the texts if the label area is smaller than the text width length.
deprecated - elm_label_slide_set()/get()
added - elm_label_slide_mode_set()/get()
SVN revision: 82169
On Sun, Dec 9, 2012 at 11:11 AM, thiep ha <thiep.ha@samsung.com> wrote:
Dear All,
In elementary list, the separator is not correctly set.
I would like to send a patch to correct the list with separator.
I also add an example named "List Separator" to test it.
Please review this patch.
Best Regards,
Thiep Ha
SVN revision: 82040
Dear all,
Hello. This is Jaehyun Cho.
The current version of _item_text_set_hook sends the part signal name to edje_object_part_text_set. (elementary/src/lib/elc_naviframe.c)
To resolve this issue, I sent different arguments to edje_object_part_text_set for each case.
Please review this patch.
Thank you,
Jaehyun Cho.
Signed-Off-By: JaeHyun Cho <jae_hyun_cho@naver.com>
SVN revision: 82030
For now, it supports only one system tray icon per application.
Each instance of ELM_OBJ_SYSTRAY_CLASS is a handler for
the same system tray item. But the API is ready to support
multiple system tray items per application.
Also, since this is a new feature, it only provides an EObject API. So,
if the old style API is still required, please do it.
Patch by: Murilo Belluzzo <murilo.belluzzo@profusion.mobi>
SVN revision: 81747
Subject: Re: Re: Re: [E-devel] [RFC] Virtual desktop window profile
I've attached 4th patch. May the 4th be with you.
ecore patch has been merged with efl and all files are based on r80123.
Thanks & Regards,
Gwanglim
------- Original Message -------
Sender : Daniel Juyung Seo<seojuyung2@gmail.com>
Date : 2012-12-04 01:55 (GMT+09:00)
Title : Re: Re: [E-devel] [RFC] Virtual desktop window profile
It looks ok to me.
Sorry but can you re-generate the patch according to the recent ecore
merge to efl single tree?
Daniel Juyung Seo (SeoZ)
On Thu, Nov 29, 2012 at 12:29 AM, Gwanglim Lee <gl77.lee@samsung.com>
wrote:
Dear Raster and Daniel Juyung Seo,
I've attached 3rd patches and test_config according to your reviews.
These are based on r79782.
[elementary & ecore]
1. "profile,set" -> "profile,changed" - done
2. spaces after EINA_LIST_FOREACH - done
3. variable type - keep
4. author - done
5. removing deprecated marking in patch - done
6. add elm_win_available_profiles_get to test_config for the debugging
purpose - done
7. check whether a given profile is present in an available profiles.
otherwise window profile will be one of the item
in available profiles. - newly added thing to the elm_win
8. merge with EO - done. :(
Any comments would be appreciated.
SVN revision: 80215
v1 is now deprecated (EINA_DEPRECATED) but still there, should still
work and not break any existing app.
v2 is now there as well, all software is being ported to use it
now. Just Enlightenment itself will still ship with v1 and as soon as
we release it will go v2, we have the patches here.
SVN revision: 80110
Subject: [E-devel] [PATCH][ELEMENTARY][BUG Fix] Current Reordering
item is not resizing on genlist resize (e.g On roation)
Please review the attached patch created to fix the current reordering
item
resizing issue.
[ISSUE] Current genlist reordering item is not resizing on genlist
resize
(e.g. On rotation).
Change Description:
In _calc_job call back, the width of reordering item is corrected.
SVN revision: 77992
Subject: [E-devel] [patch][elementary] conformant - use layout focus
next, direction
um.. there would be a reason to not use focus next and direction stuff..
please let me know why the conform does not use those..
if there is no reason, please keep the patch. thanks.
SVN revision: 77947
Subject: [E-devel] [patch][elementary] diskselector - bug fix
diskselector has two bugs.
1. on round enable mode
elm_diskselector_item_append(); does not call elm_box_pack_*() for
over_items and under_items which are added when the display item is
bigger
than 3.
because over_items and under_items is not added, the diskselector shows
just 4 items + half item(NOT 5 items), in case of display item number
is 5
- elm_diskselector_display_item_num(obj, 5); -.
this bug could be found only if u use as following sequence.
a. elm_diskselector_round_enabled_set(obj, EINA_TRUE);
b. elm_diskselector_item_append();
2. on the round disable mode + bigger than 3 display item
even though display item is bigger than 3 on the round disable
mode, only
two blank items are added - left_blank, right_blank.
because of this, the first item could not be selected. means.. the first
item cannot be located in the middle of diskselector.
if u scroll the diskselector to the left-most, then the second item is
selected as below.
[blank] [ 1st ] [ 2nd ] [ 3rd ] [ 4th ]
so if the display item is bigger than 3, more blank items would be
necessary.
include lines to resolve above 1st bug, the patch would resolve
this issue
also.
SVN revision: 77740