This change will hide the cursor once there is an actual change, and
there is a difference between the selection cursors. If there is no
difference, then it is better to show the cursor again.
previously, mousing out of an icon during the pulse animation would
instantly stop the animation. this looks strange and is quite noticeable
when mousing through a bar
There was all the necessary code, except that the default
theme did not implement properly the signal & required data.
There is still a problem though, as the "timeout" smart callback
will be called at the start of the animation, so it's not possible
for an app to hide() or del() at this point (that would get
rid of the animation). But there's no other callback after
the animation ends.
elementary_test -to Notify > "Bottom" illustrates this issue.
Summary:
In D2063, "max_size" data item is added to limit the number of items
to show at a time when hoversel is expanded.
However, it limits the number of items too few, so makes scrollable
function useless.
This patch removes limitation of hoversel size with pixels,
but if it needs, developers can set the limitation yet.
(By theme customization)
Test Plan:
elementary_test "hoversel"
click the second hoversel
Reviewers: DaveMDS, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3223
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
various fixes have occurred over the years to improve proxy rendering.
as a result, this theme, which is apparently the only other user of proxy
edje parts besides deskmirror, was broken.
@fix
too many rels and complexity to track this to a more coherent
message
probably broken since 1.0 since there are zero "noicon" toolbar
tests
@fix
fix T2782
Summary:
elm_hover_dismiss() doesn't hide hover directly, but sends signal only.
It can be translated that "dismiss" do not hide hover only, but handles
some works. (EDC program, callbacks etc.)
However, "dismiss" sends signals after hide hover itself, so following
edje signals are ignored. (Hover cannot be seen already!)
This patch makes hover dismiss delayed while handling edje signal.
@fix
Test Plan: elementary_test hover2
Reviewers: Hermet, cedric
Reviewed By: cedric
Subscribers: woohyun
Differential Revision: https://phab.enlightenment.org/D3068
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Some modifications for hoversel scrollability are applied.
For example,
The logic for generating scroller is changed. (newly added during activation)
If hoversel's contents are larger than hover,they will be resized to fit hover.
If hoversel is moved (by window rotation etc.), scroller will be resized.
Reduandant code are removed from popup for scrollability.
Test Plan:
You can see the sample for scrollable hoversel in second one
of "elementary_test hoversel".
Reviewers: Hermet, SanghyeonLee, cedric
Reviewed By: cedric
Subscribers: godlytalias, Hermet
Differential Revision: https://phab.enlightenment.org/D2926
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Flipselector lose last character when 50 characters showing case.
This defined value will using in snprintf, fetch_str(_edje_embryo_fn_fetch_str).
As you already know, we have to give the location in array for '\n'.
Test Plan: Give the 50 characters for flipselector text.
Reviewers: Hermet, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3064
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
this fixes a bug with horizontal style toolbar items and toolbar code
itself simply emitting the wrong signals that causes 0 height items.
this fixes T2710
@fix
Summary:
When loop is set, the arrows on horizontal/vertical bar
should not be disabled. These arrows show the scrollable direction,
if enabled. Disabled arrows show no more scroll in that direction.
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
Merge branch 'master' of http://git.enlightenment.org/core/elementary
Test Plan: elementary_test -> scroller -> loop in x axis.
Reviewers: raster, Hermet, singh.amitesh
Subscribers: sachin.dev, SanghyeonLee, eagleeye
Differential Revision: https://phab.enlightenment.org/D2953
Summary:
MBE clicked callback doesn't called when user click label, padding area of MBE.
Because of the MBE edc only has the SWALLOW part for internal box. never emit the signal for clicked.
So i added RECT part for bg of mbe.
@fix
Test Plan: Run elementary_test -> execute multibuttonentry sample.
Reviewers: seoz, woohyun, cedric, Hermet
Reviewed By: Hermet
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2821
conformant would ignore min size of content (and propagate min size
to paent widget - eg window). this was just wrong. remove fixed here
(also align is useless as that is a default).
@fix
Summary:
When the scroller size changes by dragging the
corners, the calculations will miss the condition "x+w == x1 + w1".
This is because of format specific computer calculations. So,
improvisation is made in comparisons.
@ fix
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
Test Plan:
elementary_test -> scroller -> scroll to the extreme right (right arrow brightness changes).
Now, drag the lower right corner to increase the width of scroller. Drag the corner slowly to see the issue clearly.
The arrow brightness changes alternatively, instead the hbar is positioned to the extreme right.
Reviewers: Hermet, cedric, raster
Subscribers: singh.amitesh, eagleeye, SanghyeonLee, sachin.dev
Differential Revision: https://phab.enlightenment.org/D2796
Summary:
Currently, hoversel shows all items at the same time, but to limit
the size of contents and make it scrollable is neccesary to some users.
elm_hoversel_scroll_enabled_set/get() API makes the contents of hoversel
scrollable or not.
Test Plan:
The newly added scroll function is enabled for the second hoversel
in "hoversel" sample of elementary_test.
Reviewers: Hermet, raster, herdsman, cedric, tasn
Subscribers: JackDanielZ, cedric, Hermet
Differential Revision: https://phab.enlightenment.org/D2603
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
There is no way to give padding between each items, previously.
So i added horizontal, vertical padding here.
I will add APIs for set, get padding size set, get.
@feature
Test Plan:
Change the horizontal, vertical paddidng value in multibuttonentry.edc
Run elementary_test
Execute multibuttonentry sample.
Add items.
Check the padding between items.
Reviewers: woohyun, seoz, Hermet, raster
Reviewed By: Hermet, raster
Subscribers: raster
Differential Revision: https://phab.enlightenment.org/D2534
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Even user sets empty string here for text, label still packed in box with min size(finger size).
label_set internal logic is not clear before.
ex: object min set, resize check the string length then sending signal, min set again.
so i deleted the signal emit code here, we can handle label show, hide status in code and it's more clear.
Besides "sd->label" is always true all of the case. we need to check whether it's packed or not.
The label will be added to parent's sub object when it's packed into box.
label_set as empty string in adding time also meaningless.
@fix
Test Plan:
Run multibuttonentry sample.
Set a text somthing for it then set an empty string here.
Reviewers: Hermet, woohyun
Differential Revision: https://phab.enlightenment.org/D2841
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
* convert opaque region theme part to SPACER
- add rels for shaded/maximized state
* namespace opaque region theme part
* update opaque region only on pre-render
- fixes race condition between render size and opaque size
ref T2575
Summary: This fix adjusts the shadow spacer elementary when we
maximize/unmaximize a window. When in a maximized state, we do not
have to reserve space for the window shadow. This partially fixes
T2578. I say partially because there is still a little bit of blank
space around a maximized window.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: This patch fixes opaque region setting under wayland in a
more proper/accurate way. This now sets the opaque region to be Just
what is visible (ie: only the dialog).
NB: This does not actually fix T2575 as that problem is inside E itself.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: Elementary does not support toggling of shadows on windows,
but Enlightenment does so we need to use the proper program signal for
that.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: This fix addresses the issue of Elementary's Wayland border
theme not match close enough to E's. Now they are very much identical
with the exception of the program and signal names.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: This adjusts the focus frame of Elementary applications to
more closely match what is done in X11. T2575 says that the focus
rectangle was larger than expected by a few pixels, so this slight
adjustment compensates for that.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary:
Show days of previous and next month on the blank area of calendar.
@feature
Test Plan: See calendar widget on elementary_test.
Reviewers: raster, seoz, woohyun, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2728
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
nearly everything in e is square except for this, which was a holdover from the
b&w theme. the new image looks more coherent with the rest of the square look
image created by me, licensing to match rest of theme images
@feature
someone.. somewhere along the way.. likely a long time ago.. broke
compress mode. likely the addition of the ellipsis value as an
ellipsis position or something related to that broke compatibility,
as this used to work. be that as it may... finding out just where is
virtually impossible, so fix it the simpler way - add elipsis values
Yeshwanth Reddivari
Mike Blumenkrantz
Daniel Hirt
Amitesh Singh
godly.talias
Shilpa Singh
Jean-Philippe Andre
Jee-Yong Um
Woochan Lee
Carsten Haitzler
Hosang Kim
Davide Andreoli
Umesh Tanwar
Chris Michael
Youngbok Shin
Andrii Kroitor