Commit Graph

185 Commits

Author SHA1 Message Date
Hosang Kim 100ca86669 slider: fix slider focus bug
Summary: when slider is focused and slider's indicator mode is not ELM_SLIDER_INDICATOR_VISIBLE_MODE_ON_FOCUS, slider's indicator popup blinked.

Test Plan: elementary_test -> slider -> focus out -> click slider again

Reviewers: seoz, cedric, raster, Hermet, woohyun, CHAN, id213sin

Differential Revision: https://phab.enlightenment.org/D3308

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-11-10 14:31:06 -08:00
Hosang Kim 886fc9fd9e slider: slider should be focused, when slider is handled with mouse or touch event.
Summary: slider is not focused after slider is dragged.

Test Plan: elementary_test -> slider

Reviewers: woohyun, seoz, smohanty, cedric, raster

Differential Revision: https://phab.enlightenment.org/D3057
2015-09-16 10:10:32 +09:00
Jaehwan Kim 0dedfc9248 focus: add the APIs to set the focus next about item.
Add elm_object_focus_next_item_set/get,
elm_object_item_focus_next_object_set/get and
elm_object_item_focus_next_item_set/get.

If the item and object is set at the same time,
the item is preference to object when the focus moves.

This feature is implemented about gengrid.
It will be implemented about ohter widgets.

@feature
2015-09-15 19:53:23 +09:00
Amitesh Singh 69551260bf slider: remove useless code 2015-07-10 21:27:51 +05:30
ChunEon Park 560c3cd8fe slider: compare slider values elaborately.
because of the double type nature,
the comparison is not correct.

we decide the value changes with range of double epsilon to avoid this.

@fix
2015-07-09 15:19:54 +09:00
Avi Levin 2a66feabfb elm_radio, elm_slider: porting evas smart callbacks to eo 2015-07-05 13:05:38 +03:00
Amitesh Singh 7b3a54fbbd slider: call elm_widget_theme_get instead of elm_object_theme_get.
This reduces one function call and make code more consistent
between widgets.
2015-06-29 11:24:34 +05:30
Tom Hacohen 27b72840c8 Adjust usage of eo_constructor() according to recent changes. 2015-05-20 13:03:28 +01:00
Amitesh Singh c714e28f00 slider: use theme of object for popup.
Summary:
@fix

Signed-off-by: Amitesh Singh <amitesh.sh@samsung.com>

Reviewers: raster, Hermet, JackDanielZ

Subscribers: sachin.dev, seoz

Differential Revision: https://phab.enlightenment.org/D2542
2015-05-19 21:02:55 +09:00
Andrii Kroitor 8e61552bc5 elm_slider: fix theme apply
Summary:
using theme of the object instead of default for subparts.
@fix

Reviewers: cedric, seoz, Hermet, raster, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D2370
2015-04-17 16:52:04 +09:00
Sung-Taek Hong 22adafce60 elm_slider: Added elm_slider_indicator_visible_mode_set/get.
Summary: elm_slider: Added elm_slider_indicator_visible_mode_set/get.
elm_slider_indicator_visible_mode_set/get allows individual sliders to have
its own indicator visible_mode.

@feature

Reviewers: Hermet, woohyun, seoz

Subscribers: seoz

Differential Revision: https://phab.enlightenment.org/D1945
2015-03-04 18:45:51 +09:00
Daniel Juyung Seo 263801f018 elm: Remove redundant finger size adjustment.
This is a successor of a54da8aab.
2015-02-23 08:43:47 +09:00
Sung-Taek Hong 94e9434206 elm_slider: modified each slider have its indicator visible mode.
Summary: Added indicator_visible_mode to each slider in order not to make elm_config controlls every sliders.

Reviewers: Hermet, woohyun, seoz

Subscribers: seoz

Differential Revision: https://phab.enlightenment.org/D1887
2015-02-06 21:58:32 +09:00
Daniel Juyung Seo b8e4341c78 slider: Clean up of the previous slider patch.
- This is a first clean up of 65240b5327e5ab1eb8f77835b4729444fe1f02df
- Fix wrong version for since tag.
- Fix indentation and remove trailing whitespaces.
- Make the code more readable.
- Remove a unused variable.
2014-11-29 23:28:14 +09:00
Anil Kumar Nahak 6d1d6dec7c Slider: Added APIs to set/get slider's indicator visibility mode.
Summary:
elm_config_slider_indicator_visible_mode_set
elm_config_slider_indicator_visible_mode_get

The patch will enable the slider's indicator to get

visible always
visible on focus
visible never
visible on slider value change

Reviewers: raster, seoz

Subscribers: sachin.dev

Differential Revision: https://phab.enlightenment.org/D1558
2014-11-29 15:56:45 +09:00
Lukasz Stanislawski 2ca1f8a75a atspi: properly include at-spi headers.
Summary:
Change requested by TAsn. Previuosly AT-SPI headers were kept private
and included directly into elementary source code. From now on,
AT-SPI headers can be included from Elementary.h public header, however
will be marked as beta APIs.

Commit includes following changes:
* include all atspi headers into new elm_interfaces.h header.
* marking all at-spi interfaces methods/properties as @protected.
* wrap all common headers with EFL_BETA_API_SUPPORT.
* make some common APIs visible in lib, by adding EAPI attribute
  (if someone decides to use beta APIs).

Test Plan: out-off tree build with gcc, g++

Reviewers: tasn

Reviewed By: tasn

Subscribers: seoz, q66, kuuko

Maniphest Tasks: T1721

Differential Revision: https://phab.enlightenment.org/D1528
2014-10-17 16:57:26 +01:00
Amitesh Singh 1f28fea220 slider: Removed unnecessary layer set call for popup.
Summary:
Setting layer of a smart member is not required as it would remain
on same layer of slider.

Reviewers: raster, seoz

Reviewed By: seoz

Subscribers: seoz

Differential Revision: https://phab.enlightenment.org/D1447
2014-09-26 02:05:47 +09:00
Tom Hacohen 7629c147eb Eo related: Change according to recent changes in eo_add().
For more info check out a7560dbc61 in
the EFL tree.
2014-09-25 17:39:34 +01:00
Lukasz Stanislawski 09b9ef0bc0 atspi: expose more actions through atspi bus.
Summary:
Main purpose of exposing widget actions and keyboard shortcuts
is to allow accessibility clients to implement alternative methods
of GUI navigation.

Reviewers: z.kosinski

Reviewed By: z.kosinski

Subscribers: seoz

Differential Revision: https://phab.enlightenment.org/D1227
2014-07-25 11:58:16 +02:00
Zbigniew Kosinski 9c3547f270 atspi: Orca is able to read slider value changes
Reviewers: stanluk

Differential Revision: https://phab.enlightenment.org/D1012
2014-07-18 11:47:48 +02:00
Zbigniew Kosinski 9ce23f0004 atspi:Set roles for widgets
Reviewers: stanluk, m.jagiello, raster

Differential Revision: https://phab.enlightenment.org/D930
2014-06-11 11:07:16 +09:00
Tom Hacohen efa41c7d75 Elm: Update code to use the new class names generated by eolian. 2014-06-03 11:54:44 +01:00
Lukasz Stanislawski 21aafc3f2d atspi: AtspiValue interface added.
Summary:
Enables remote value changing on accessible widgets.
Added sample interface implementation for elm_slider widget.

Test Plan: build&install

Reviewers: raster, seoz

Differential Revision: https://phab.enlightenment.org/D784
2014-04-24 18:03:25 +09:00
Gwanglim Lee b7cb75ccb3 slider: fixed build warning
Summary: added EINA_UNUSED to fix build warning

Test Plan: N/A

Reviewers: raster, seoz, Hermet

Reviewed By: seoz

Differential Revision: https://phab.enlightenment.org/D777
2014-04-22 14:32:20 +09:00
Jaeun Choi 200ec7840e slider: apply key binding
Summary: This patch applies key binding to elm_slider.

Test Plan: None

Reviewers: Hermet, raster

Differential Revision: https://phab.enlightenment.org/D761
2014-04-18 13:39:08 +09:00
ChunEon Park bce93b6342 slider - don't send signals multiple times if the multiple key is pressed/up.
since slider popup has the interval for hide animation(may have, may have not)
just checking visible is not enough but this flag is correct.
2014-04-18 12:00:32 +09:00
Jaeun Choi fcd6880b6c slider: removed unnecessary key value check in case of key up event
Summary:
This patch removes unnecessary codes.
There is no need to check key value in case of key up event,
since any other key down event except direction keys will cancel sliding.
Instead, hide popup if the popup is visible at that point.

Test Plan: None

Reviewers: Hermet, raster

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D760
2014-04-18 11:53:27 +09:00
Jaeun Choi f8a26ed1fa slider: code refactoring in widget_event func
Summary:
This patch improves maintainability and readability through code refactoring.
- complete branch statement instead of goto statement
- removed unnecessary codes

Test Plan: None

Reviewers: Hermet, raster

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D758
2014-04-18 11:45:13 +09:00
ChunEon Park 5ab6a7739f widgets - don't handle the events(key,mouse) if the object is disabled.
we can prevent to handle the widget events from the widget infra,
if the object is disabled.

conceptually, disabled object should not be interacted to user input(key, mouse)
2014-04-16 10:59:43 +09:00
Tom Hacohen a5deb548c2 slider: Adjusted to Eo2. 2014-04-10 09:35:02 +01:00
Daniel Zaoui 016bf31358 Eolian: Integration of Slider 2014-03-31 09:08:42 +03:00
Daniel Zaoui e2206a1a22 Eolian: Integration of Elm Widget 2014-03-17 09:03:56 +02:00
zmike daaa801013 @fix slider overlay parenting
this broke stacking and clipping of the indicator
2014-03-09 17:03:34 -04:00
zmike 7fb6ea14c5 @fix broken slider popup hide logic
setting a flag here made it impossible to have any kind of transition animation on the indicator and was a poor workaround for fixing a theme issue
2014-03-02 15:38:42 -05:00
zmike d07c5c7927 @fix slider popup creation with custom themes 2014-03-02 15:04:07 -05:00
zmike 5d33b9af68 move slider track functions up 2014-03-02 15:04:07 -05:00
Jaehwan Kim db23689614 access: Add smart signal "access,changed"
It occurs that access mode is changed.
Application can add this callback for each widget.
2014-02-08 14:05:14 +09:00
WooHyun Jung 0a1179dde4 elm_layout now supports focused/unfocused smart callback
by itself for widgets that inherit layout class.
If it uses elm_widget's, smart callback will be called at the
beginning or smart_on_focus function.
2014-02-06 16:18:57 +09:00
ChunEon Park 39ad0e358e elementary - support language changed callback from a few widgets.
support a language,changed callback if a widget has the text part in default.
2014-01-23 20:07:20 +09:00
ChunEon Park aebdcff513 elementary - use the focused/unfocused string in widget defined.
Now, it will share the strings so that reduce the binary size also user uses it in one way.
2014-01-23 17:27:17 +09:00
Daniel Juyung Seo a4f3074f9c elm: Removed unnecessary null check for ecore_timer_del,
ecore_animator_del, and ecore_job_del.

As all efl public free apis get null as valid parameter, we do not need
to check null. I also removed some null check for other free apis which
were right next to timer/animator/job del. After this job code got
cleaner.
2014-01-21 23:18:16 +09:00
Yakov Goldberg 3379c124df all widgets: change Eo API for "elm_widget_theme()" to "theme_apply"
There are elm_widget_theme/theme_set/theme_get functions.
    In Eolian these functions will be described as "theme" method and
    "theme" property. There is clash here.
    So add suffix "_apply" to Eo API for "elm_widget_theme".
2014-01-21 11:08:29 +02:00
Daniel Juyung Seo fd5c046dfe elm: Changed __UNUSED__ to EINA_UNUSED. 2014-01-06 23:33:57 +09:00
Daniel Juyung Seo e63dd3110a elm: Unified eina critical manro to CRI.
Being annoyed by different types of eina critical macros - CRI, CRIT,
 CRITICAL -, I concluded to unify them to one. Discussed on IRC and
 finally, CRI was chosen to meet the consistency with other macros -
 ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
2013-12-26 13:03:55 +09:00
Daniel Juyung Seo 6d71a23c3a elm lib: removed all the unnecessary empty lines.
being pedantic.
2013-12-15 06:18:35 +09:00
Carsten Haitzler 1c83b8ba6b elm slider - warning removal for unused params 2013-12-02 17:23:19 +09:00
Anil Kumar Nahak d64230de9f [slider] show/hide slider popup
Summary: elementary_test->slider

Reviewers: singh.amitesh, seoz, raster

Differential Revision: https://phab.enlightenment.org/D347
2013-12-02 16:19:53 +09:00
Daniel Juyung Seo a480745321 scroller, slider: fixed wrong changed I made by 6a683df1598a4c3293a33765cc60dd
I caused by c&p bug.
Special thanks to stefan and coverity.
This fixes coverity CID 1128353 and 1128354.
2013-11-15 22:51:10 +09:00
Daniel Juyung Seo b75a880c6c button,inwin,radio,scroller,slider: Do not call smart_activate when the widget is disabled. 2013-11-08 21:49:52 +09:00
Tom Hacohen 2f1e1554e5 Changed Eo class names to be consistent.
All the class names are now of the format: Elm_Type_Subtype_Extra
2013-11-07 11:44:22 +00:00