Commit Graph

64711 Commits

Author SHA1 Message Date
Xavi Artigas 595a066a64 whitespace 2019-12-27 11:45:35 +01:00
Xavi Artigas 858caa21b0 docs:Clarify Efl.Text_Formatter format parameter
Ref T8455
2019-12-27 11:37:43 +01:00
Cedric BAIL 4624b56bed elementary: make sure that our index for the maximum number of object is actually unsigned int bound.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10927
2019-12-27 11:36:59 +01:00
Cedric BAIL 6756485476 elementary: improve focus memory for Efl.Ui.CollectionView.
This patch will make the CollectionView remember at all time the last
focus object and the last item in the list.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10677
2019-12-27 11:36:56 +01:00
Ali Alzyod e583b9159e efl_style: rename enums (background,strikthrough) from enabled to solid_color
Reviewers: woohyun, segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7942

Differential Revision: https://phab.enlightenment.org/D10967
2019-12-27 16:10:24 +09:00
Ali Alzyod 7c71dc4e2d efl.ui.textbox: fix crash when toggle scroll mode
Reviewers: eagleeye, bu5hm4n, cedric, woohyun

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10924
2019-12-27 10:17:17 +09:00
Bruno da Silva Belo cf37047a7c c#: Checking null for parameters.
Checking for non-generated code.
ref T8399

Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D10959
2019-12-26 14:46:16 -03:00
Ali Alzyod 55e9d31569 efl.text.font: rename to efl.text.font.properties
Reviewers: segfaultxavi, woohyun, zmike, bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7855

Differential Revision: https://phab.enlightenment.org/D10966
2019-12-26 18:08:00 +09:00
Ali Alzyod 3bd4f04ec7 efl_text_format: rename tabstops,lingap,linerelgap
Summary: rename tabstops,lingap,linerelgap to have underscore between words

Reviewers: segfaultxavi, woohyun

Reviewed By: woohyun

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7856

Differential Revision: https://phab.enlightenment.org/D10963
2019-12-26 18:01:32 +09:00
a.srour 43bd6ab7ea Efl.Text.Cursor: Add tests for evas_suite
Summary: This patch add tests for almost all `Efl.Text.Cursor` exposed methods.

Test Plan: Using `ninja test`

Reviewers: ali.alzyod, segfaultxavi, woohyun

Subscribers: #committers, cedric, #reviewers

Tags: #efl

Maniphest Tasks: T8454

Differential Revision: https://phab.enlightenment.org/D10950
2019-12-26 17:45:30 +09:00
Ali Alzyod a239fc4a1a efl_text_cursor: movement word start/end
Summary:
This patch will make **efl_text_cursor_move** method, when it is working with **WORD_START** or **WORD_END** If no actual movement happened then return false, and do not fire CHANGE event

for example if cursor at word start, and we call efl_text_cursor_move(cursor, word_start);
1- this call should return false because no actual movement happened. If no actual movement happened then return false
2- this call should not fire CHANGE event for cursor.and do not fire CHANGE event

Reviewers: woohyun, segfaultxavi, cedric, zmike

Reviewed By: woohyun

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8454

Differential Revision: https://phab.enlightenment.org/D10949
2019-12-26 16:05:37 +09:00
Ali Alzyod 84685df233 efl_text_cursor: line jump by fix movement
Summary:
When the cursor is at line beginning of line, and user click "Up" then "Down" on keyboard cursor will position at second character.
If text is:  **occaecat \n mollit**

Reviewers: woohyun, zmike, cedric, segfaultxavi

Reviewed By: woohyun

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8454

Differential Revision: https://phab.enlightenment.org/D10947
2019-12-26 09:55:28 +09:00
Ali Alzyod c008309f78 elm_entry: remove variation sequences as part of glyph when delete clusters
Summary:
This will fix the task:
T8542

Remove variation sequences as part of glyph when deleting clusters, variation sequence is meaningless alone, so they should be removed when deleting

Reviewers: woohyun, bowonryu

Reviewed By: bowonryu

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10956
2019-12-26 06:53:14 +09:00
Myoungwoon Roy, Kim 118e3785ee docs: Fix a typo in guideline about deprecated API
Summary: Fix a typo (elm_textpath_circluar_set -> elm_textpath_circular_set)

Test Plan: Revise documentation only

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10962
2019-12-24 09:24:07 -05:00
Stefan Schmidt 3eef6af97d examples: js: use correct var to display user name
Summary:
screen_name was used to for both displays, user name and screen name.
Fix this typo and make sure the user_name variable is actually used.

Depends on D10886
Reported-By: https://lgtm.com/projects/g/Enlightenment/efl

Reviewers: felipealmeida, ProhtMeyhet, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10934
2019-12-24 09:23:29 -05:00
Stefan Schmidt 9144e4dae7 examples: js: make sure we declare all variables
Summary:
Avoiding local variables to be declared global and shared automatically.

Depends on D10882
Reported-By: https://lgtm.com/projects/g/Enlightenment/efl

Reviewers: felipealmeida, zmike

Reviewed By: zmike

Subscribers: zmike, ProhtMeyhet, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10884
2019-12-24 09:23:22 -05:00
Stefan Schmidt f1144705ec examples: js: ensure we finish all statements with a semicolon
Summary:
JS interpreters seems to be forgiving for these but the majority of the
js code examples already use semicolons. Make it consistent and fix up
the missing places.

Reported-By: https://lgtm.com/projects/g/Enlightenment/efl

Reviewers: felipealmeida, zmike

Reviewed By: zmike

Subscribers: zmike, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10882
2019-12-24 09:23:14 -05:00
Cedric BAIL 7d16c344c1 elementary: enforce container type check for efl_ui_item_index_get and improve documentation.
Summary: Depends on D10927

Reviewers: bu5hm4n, segfaultxavi, SanghyeonLee

Reviewed By: SanghyeonLee

Subscribers: zmike, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8351

Differential Revision: https://phab.enlightenment.org/D10945
2019-12-24 09:20:11 -05:00
Stefan Schmidt 1176bbaa9b examples_check: remove double dictionary
Same thing as two lines below.

Reported-By: https://lgtm.com/projects/g/Enlightenment/efl
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10886
2019-12-24 13:54:10 +01:00
Ali Alzyod 79d95a289a efl_text_cursor: assign source textobject to destination on cursor_copy
Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8454

Differential Revision: https://phab.enlightenment.org/D10951
2019-12-24 17:17:31 +09:00
a.srour ce28963654 Efl.Text.Cursor: Fix line_jump_by return logic
Summary:
From documentation `line_jump_by` should return `EINA_TRUE` if cursor moved, and `EINA_FALSE` if not moved.
But the current behaviour is reversed, so this should fix it.

Reviewers: ali.alzyod, segfaultxavi, woohyun

Subscribers: AbdullehGhujeh, #committers, cedric, #reviewers

Tags: #efl

Maniphest Tasks: T8454

Differential Revision: https://phab.enlightenment.org/D10946
2019-12-24 16:34:14 +09:00
Bowon Ryu a6a44ecb9d evas_object_textblock: remove unreachable code
Summary:
This less-than-zero comparison of an unsigned value is never true..
this condition can not be true.

Test Plan: N/A

Reviewers: ali.alzyod, woohyun, jsuya

Reviewed By: jsuya

Subscribers: jsuya, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10961
2019-12-24 11:36:50 +09:00
junsu choi 1a93a4c2cc evas_vg_cache: Prevent memory leak
Summary: free hash_key pointer

Test Plan: N/A

Reviewers: Hermet, YOhoho

Reviewed By: YOhoho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10960
2019-12-24 10:54:04 +09:00
Carsten Haitzler 9178166e23 ecore-x - fix fallbacks to use capital X in lib name
thanks peter. fixes T8543
@fix
2019-12-24 00:23:44 +00:00
Felipe Magno de Almeida b3cc7d403b eolian: inherit since information from struct and enum to field
Summary:
If a struct or enum field doesn't explicitly sets since information, then since
is inherited from struct documentation if it is available.

Reviewers: jptiz, Jaehyun_Cho, woohyun, q66

Reviewed By: q66

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8359

Differential Revision: https://phab.enlightenment.org/D10948
2019-12-24 07:26:33 +09:00
Yeongjong Lee 5679a5d2a2 eina_mono: make internal classes internal
This hide internal classes..

Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D10912
2019-12-23 15:02:31 -03:00
Yeongjong Lee a56b96d33c eo_mono: make BindingEntityAttribute internal
`BindingEntityAttribute` is used internally to check whether the object is
generated binding classes or not.
API user should use protected `IsGeneratedBindingClass` instead.

Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D10937
2019-12-23 14:59:54 -03:00
Yeongjong Lee b4846c95a2 eo_mono: make Eo.Globals internal
All members of `Eo.Globals` are already `internal`.
It is unnecessary for `Eo.Globals` to be `public`.

Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D10938
2019-12-23 14:56:41 -03:00
Yeongjong Lee 934a93e39f eolian_mono: check extension part/property existence before generate ExtensionMethods
Empty ExtensionMethods class won't be generated.

Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D10954
2019-12-23 14:29:39 -03:00
Lauro Moura 0954e501fd csharp: Property Indexer implementation
Use Indexers to use brackets, eg [i], syntax.

Keys now can be used as following:

var someVal = obj.SomeProperty[key];
obj.SomeProperty[key] = someNewVal;

And for multiple keys:

var someVal = obj.SomeProperty[(key1, key2)];
obj.SomeProperty[(key1, key2)] = someNewVal;

T8384

Reviewed-by: WooHyun Jung <wh0705.jung@samsung.com>
Differential Revision: https://phab.enlightenment.org/D10791
2019-12-23 13:50:12 -03:00
Ali Alzyod ed0572a33a edje_entry: avoid strstr undefined behaviour
strstr behaviour is undefined when passing null to it, we will check if null is passed, then skip.
elm_entry had issue, where crash happened when click on link for example.

elementry_test -> entry -> click on link (crash will happened)

T8535

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10877
2019-12-23 17:43:13 +01:00
Bruno da Silva Belo b90c50ad17 c#: Fixing ca2208 for Eina.List.
Some ca's warning reactivated.
ref T8428

Reviewed-by: João Paulo Taylor Ienczak Zanette <joao.tiz@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D10911
2019-12-23 13:17:04 -03:00
WooHyun Jung 5827fdb3cb Revert "eolian: inherit since information from struct to field"
This reverts commit f349510941.

This patch is causing some "ninja test" errors, so the errors
should be fixed first.
2019-12-23 17:54:21 +09:00
junsu choi 74c60b7887 Elm_Transit: Fix wrong intervention progress value
Summary:
If progress_value_set is called more than once, an error value occurs.
The intervention progress must use progress that
does not apply the previous intervention progress.

Test Plan:
meson_option.txt -> remove json in evas-loaders-disabler option
elementary_test -to "animation view"
Click Play -> Play back -> Play

Reviewers: Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10907
2019-12-23 17:39:35 +09:00
SangHyeon Jade Lee b9b9287454 eolian_mono : add verb unselect on naming helper.
Summary:
currently select is verb and mono name is exposed SelectAll
but unselect is non-verb and mono name is exposed AllUnselect.
to fix this differencies, add unselect in the verb list.

Reviewers: segfaultxavi, Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10952
2019-12-23 16:21:10 +09:00
Hermet Park 46ee203331 ui image: fix scale_method expand behavior.
As efl_gfx_image_expand specification,
it scales the image to cover the entire object area on one axis
while maintaining the aspect ratio though image may become larger than the object.

Thus, this option must work as one of fit_width / fit_height
by detertimining either way.

Previously, it was logically wrong.

@fix
2019-12-23 15:42:17 +09:00
Felipe Magno de Almeida f349510941 eolian: inherit since information from struct to field
Summary:
If struct field doesn't explicitly sets since information, then since
is inherited from struct documentation if it is available.

Reviewers: jptiz, Jaehyun_Cho, woohyun, q66

Reviewed By: q66

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8359

Differential Revision: https://phab.enlightenment.org/D10948
2019-12-23 10:21:31 +09:00
Bruno da Silva Belo 47407478e8 c#: Implement IList to Eina.Array.
ref T8488

Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D10785
2019-12-22 11:31:35 -03:00
Marcel Hollerbach c49880076c efl_ui_item: use signals from the theme and not object
the problem here is that when we are using the signals from the object,
then the edje object itself will receive press/unpress events before
any content that is swallowed into the edje object.

This means, that no clickable content, added to a item could be clicked
without selecting / unselecting the item. Which was a problem.

With this commit the theme is sending signals which are then passed to
the efl.input.clickable mixin, this way, the part is stacked below the
added content, which means, clickable content will not select / unselect
the item anymore.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10892
2019-12-20 10:33:38 -08:00
Marcel Hollerbach 193ae1c14c efl_ui_layout: add API to check out the theme_version
this new API returns the theme version specified in the loaded theme.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10944
2019-12-20 10:33:37 -08:00
Ali Alzyod b9818f566c efl.ui.textbox: rename _disabled properties into _enabled
Reviewers: segfaultxavi, woohyun, bu5hm4n

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8522

Differential Revision: https://phab.enlightenment.org/D10923
2019-12-20 14:10:00 +01:00
Jaehyun Cho 778bef8e60 efl_ui_widget: add description of widget parts
Summary:
Description of the widget parts, shadow and background, is added for
documentation.

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10940
2019-12-20 13:51:04 +01:00
Ali Alzyod 74a8c646bc efl.canvas.textblock: update eo file documentation
Summary: T8460

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10936
2019-12-20 12:47:25 +01:00
Ali Alzyod 8dbc75fdce efl_text_attribute_factory: rename to efl_text_formatter
Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8455

Differential Revision: https://phab.enlightenment.org/D10925
2019-12-20 12:43:00 +01:00
Ali Alzyod 5cf7fa7670 efl.text.style: rename methods/properties and add text_ prefix
Summary:
efl.text.style: rename methods and properties

this change will avoid conflict in the future with other interfaces or class methods.

```
      Efl.Text_Style.text_color { set; get; }
      Efl.Text_Style.text_backing_type { set; get; }
      Efl.Text_Style.text_background_color { set; get;}  //this was backing_color
      Efl.Text_Style.text_underline_type { set; }
      Efl.Text_Style.text_underline_color { set; get; }
      Efl.Text_Style.text_underline2_color { set; get; }
      Efl.Text_Style.text_underline_dashed_color { set; get; }
      Efl.Text_Style.text_underline_height { set; }
      Efl.Text_Style.text_underline_dashed_width { set; }
      Efl.Text_Style.text_underline_dashed_gap { set; }
      Efl.Text_Style.text_strikethrough_type { set; }
      Efl.Text_Style.text_strikethrough_color { set; get; }
      Efl.Text_Style.text_effect_type { set; }
      Efl.Text_Style.text_shadow_direction { set; }
      Efl.Text_Style.text_outline_color { set; get; }
      Efl.Text_Style.text_shadow_color { set; get; }
      Efl.Text_Style.text_glow_color { set; get; }
      Efl.Text_Style.text_glow2_color { set; get; }
```

T8533

Reviewers: woohyun, segfaultxavi, bu5hm4n, zmike, cedric

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10897
2019-12-20 09:58:27 +01:00
Jaehyun Cho e16b32c376 csharp: add documentation of class Efl.Eo.Config in iwrapper
Summary: Description and since efl version of the class Efl.Eo.Config is added.

Reviewers: YOhoho, lauromoura, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10933
2019-12-20 09:45:42 +01:00
Yeongjong Lee e09919ba3f efl_interface: add @since tag for Efl_Model_Children_Event
Summary: @since tag is necessary for stabilized class.

Reviewers: SanghyeonLee, segfaultxavi

Reviewed By: SanghyeonLee

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10930
2019-12-20 17:38:16 +09:00
Stefan Schmidt 55389ccf25 python: remove not needed imports in various python scripts
Should not be much harm but could help to have the minimum imports
needed when used in deployment.

Reported-By: https://lgtm.com/projects/g/Enlightenment/efl
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10885
2019-12-20 09:26:17 +01:00
Jaehyun Cho 8146728c78 eolian_mono: change Constants class to static class
Summary:
Since Constants class contains static readonly values only, the
Constants class is actually a static class.
Therefore, Constants class is changed from public partial class to
public static partial class.

ref T8398

Reviewers: YOhoho, lauromoura

Reviewed By: YOhoho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10929
2019-12-20 14:27:14 +09:00
SangHyeon Jade Lee eb12c77761 efl_interface : stablized Efl_Model_Children_Event
for mvvm publishing, this structure need to be out of beta.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10856
2019-12-19 16:45:18 -08:00