Commit Graph

82 Commits

Author SHA1 Message Date
Lucas De Marchi 5a8a8c9014 Convert (hopefully) all comparisons to NULL
Apply badzero.cocci, badnull.coci and badnull2.cocci

This should convert all cases where there's a comparison to NULL to simpler
forms. This patch applies the following transformations:

code before patch               ||code after patch
===============================================================

return a == NULL;                 return !a;

return a != NULL;                 return !!a;

func(a == NULL);                  func(!a);

func(a != NULL);                  func(!!a);

b = a == NULL;                    b = !a;

b = a != NULL;                    b = !!a;

b = a == NULL ? c : d;            b = !a ? c : d;

b = a != NULL ? c : d;            b = a ? c : d;


other cases:

a == NULL                         !a
a != NULL                         a




SVN revision: 51487
2010-08-21 13:52:25 +00:00
Cedric BAIL ba22eb6af8 * efreet: less warning by Albin Tonnerre.
SVN revision: 51247
2010-08-17 12:03:10 +00:00
Sebastian Dransfeld 7b5e166c85 Check NULL return
SVN revision: 50817
2010-08-04 18:21:20 +00:00
Lucas De Marchi 0a4617ae38 FORMATTING
* Remove vim modelines:
 find . -name '*.[chx]' -exec sed -i '/\/\*$/ {N;N;/ \* vim:ts/d}' \{\} \;
 find . -name '*.[chx]' -exec sed -i '/\/[\*\/] *vim:/d' \{\} \;

* Remove leading blank lines:
 find . -name '*.[cxh]' -exec sed -i '/./,$!d'

If you use vim, use this in your .vimrc:
set ts=8 sw=3 sts=8 expandtab cino=>5n-3f0^-2{2(0W1st0



SVN revision: 50816
2010-08-04 16:57:32 +00:00
Sebastian Dransfeld 08e9824c6e check return value from NEW
SVN revision: 50784
2010-08-03 19:31:44 +00:00
Sebastian Dransfeld 1576311af3 alloc the right amount of mem
sizeof(char) is 1, and sizeof(char *) is wrong for strings

SVN revision: 50782
2010-08-03 19:31:24 +00:00
Sebastian Dransfeld 69d0626265 use alloca for in function mem
SVN revision: 50781
2010-08-03 19:31:14 +00:00
Sebastian Dransfeld a384141abc efreet: Check return value from opendir
SVN revision: 48081
2010-04-17 18:39:13 +00:00
Sebastian Dransfeld 973965f165 efreet: TODO++
SVN revision: 47788
2010-04-06 18:35:18 +00:00
Sebastian Dransfeld 9464e87d74 efreet: stringshare
SVN revision: 47658
2010-04-01 19:31:38 +00:00
Sebastian Dransfeld 4501c577e3 efreet: stringshare
SVN revision: 47657
2010-04-01 19:30:13 +00:00
Sebastian Dransfeld 6d00dc126b efreet: use alloca for local dynamic buffer
SVN revision: 47597
2010-03-30 12:22:15 +00:00
Sebastian Dransfeld 1b6662b2e9 efreet: remove strdup
SVN revision: 47596
2010-03-30 12:22:05 +00:00
Sebastian Dransfeld a44f87390d efreet: benefit from stringshare
SVN revision: 47595
2010-03-30 12:21:55 +00:00
Sebastian Dransfeld 40a5c9a155 efreet: stringshare
SVN revision: 47593
2010-03-30 12:21:33 +00:00
Sebastian Dransfeld 72a79471d5 remove strdup
SVN revision: 47592
2010-03-30 12:21:23 +00:00
Sebastian Dransfeld ac18d14316 efreet: benefit from stringshare
Since both values are stringshared, we can use direct comparison.

SVN revision: 47591
2010-03-30 12:21:12 +00:00
Sebastian Dransfeld 1063df8b9e efreet: stringshare
SVN revision: 47590
2010-03-30 12:20:55 +00:00
Sebastian Dransfeld 6da3c6846d efreet: stringshare
SVN revision: 47588
2010-03-30 11:07:19 +00:00
Sebastian Dransfeld 592ebdcb5b efreet: stringshare
SVN revision: 47587
2010-03-30 11:07:07 +00:00
Sebastian Dransfeld c06492ded0 efreet: stringshare
SVN revision: 47586
2010-03-30 11:06:56 +00:00
Sebastian Dransfeld 3db40c0d97 efreet: fix strdup + stringshare
SVN revision: 47568
2010-03-29 20:14:43 +00:00
Sebastian Dransfeld 4e8ebec3f6 efreet_menu.c: Fix compiler warning
SVN revision: 47469
2010-03-26 05:29:15 +00:00
Sebastian Dransfeld 09dcca28de stringshare
SVN revision: 47178
2010-03-13 18:35:39 +00:00
Sebastian Dransfeld d99f80aff7 Fix compiler warnings
Found when compiling with --enable-tests and --enable-coverage

SVN revision: 46746
2010-03-01 21:43:59 +00:00
Sebastian Dransfeld f72d4f9342 Eet cache for efreet desktop
SVN revision: 46726
2010-03-01 18:16:32 +00:00
Sebastian Dransfeld 0423e1ea99 Formatting
SVN revision: 45865
2010-02-04 09:12:35 +00:00
Sebastian Dransfeld d3419db6cd Ecore_Str.h -> Eina
SVN revision: 45741
2010-01-30 22:13:16 +00:00
Sebastian Dransfeld 04edba1123 Be less strict
Prefer system set menu_file.
Try harder to find -merged dirs which matches the current menu.

SVN revision: 45265
2010-01-17 18:57:49 +00:00
Sebastian Dransfeld 4b33d2e4aa remove ecore_data function
SVN revision: 45264
2010-01-17 18:56:48 +00:00
Sebastian Dransfeld 362ef26c2d remove Ecore_Data
SVN revision: 45218
2010-01-16 13:43:28 +00:00
Christopher Michael 7c0e622466 Make efreet compile again.
SVN revision: 45206
2010-01-16 05:22:24 +00:00
Massimiliano Calamelli bc2a1db660 Added two missing inclusions of limits.h, fix build in NetBSD5
SVN revision: 45026
2010-01-10 22:42:34 +00:00
Christopher Michael 56ec4c946f When using snprintf or fgets, etc, do not use PATH_MAX directly as the size
of the variable...use sizeof() compiler directive (lots of these).

Do not free 'realpath' in efreet_menu if we are going to try and print out
it's value.

If we find 'realpath' in the merged_menus hash, and we are going to return,
then free the realpath variable.



SVN revision: 44699
2009-12-23 20:55:23 +00:00
Vincent Torri 285297dcdd * API break: _shutdown() functions return an int, now
* simplify a bit and fix init/shutdown functions



SVN revision: 42996
2009-10-10 06:19:13 +00:00
Vincent Torri 1403d26dce remoove unused variables
SVN revision: 42877
2009-10-04 22:28:12 +00:00
Cedric BAIL 05126826a3 * efreet: Use eina_log.
Patch from Matthieu.


SVN revision: 42599
2009-09-21 16:36:29 +00:00
Gustavo Sverzut Barbieri 992936af22 Update to match new EINA init/shutdown.
SVN revision: 42301
2009-09-06 22:23:04 +00:00
Gustavo Sverzut Barbieri 3871aed422 free some leaks reported by valgrind in src/bin tests.
SVN revision: 41117
2009-06-20 06:19:48 +00:00
Vincent Torri 1bf086809e * move header files in efree_provate.h to the source files
* fix compilation on Windows XP (not sure that Windows CE port is needed...)

note that, as ecore_exe is not available on Windows, some code have
been disables for that platform in src/lib/efreet_desktop.c. Also, a new Evil
version should be used (not in svn yet)

The compilation on Windows is needed for Ewl (icon and mime)



SVN revision: 40257
2009-04-20 23:20:40 +00:00
Luis Felipe Strano Moraes 37ff2edaff Cleanup of clang's static analyzer warnings for efreet.
SVN revision: 40114
2009-04-16 17:45:57 +00:00
Cedric BAIL 8a8b4ca2d1 * efreet: On STRICT_SPEC don't handle efreet_menu_file.
SVN revision: 39732
2009-03-26 18:02:17 +00:00
Cedric BAIL 81ee186382 * efreet: Use the right macro for the cast.
SVN revision: 39731
2009-03-26 17:56:51 +00:00
Cedric BAIL 7e6af0a5c1 * efreet: Remove ecore_dlist from Efreet.
SVN revision: 39730
2009-03-26 17:54:50 +00:00
Carsten Haitzler 34822db882 menu segv fix! my bad! overzealous freeing
SVN revision: 39653
2009-03-23 13:16:10 +00:00
Vincent Torri 908a722bfa more leak fixes
SVN revision: 39650
2009-03-23 12:19:31 +00:00
Carsten Haitzler ddb11ee846 leaks--! this code is riddled with leaks! really really bad!
SVN revision: 39647
2009-03-23 10:27:54 +00:00
Gustavo Sverzut Barbieri 122566bac4 fix efreet signedness issues.
char is unsigned on ARM and other platforms, force some types to be
signed as they can hold negative values.

By: Albin Tonnerre


SVN revision: 39610
2009-03-21 17:00:55 +00:00
Gustavo Sverzut Barbieri ab2e35127f Fix most compiler & clang warnings.
Left warnings regarding signed and unsigned comparison since
eina_list_count() returns unsigned, can use a cast in this return, but
not big deal for now.


By: Luis Felipe Strano Moraes & myself.



SVN revision: 39260
2009-02-26 22:35:38 +00:00
Cedric BAIL 6978e98dc6 * estickies,
* etk,
	* PROTO/exalt,
	* E-MODULES-EXTRA/diskio,
	* E-MODULES-EXTRA/drawer,
	* E-MODULES-EXTRA/penguins,
	* E-MODULES-EXTRA/slideshow,
	* E-MODULES-EXTRA/mail,
	* E-MODULES-EXTRA/forecasts,
	* E-MODULES-EXTRA/iiirk,
	* E-MODULES-EXTRA/places,
	* e,
	* ewl,
	* ecore,
	* elitaire,
	* entrance,
	* e_dbus,
	* efreet: Here we go, move from Ecore_List to Eina_List.

	NOTE: This patch is huge, I did test it a lot, and I hope nothing is
	broken. But if you think something change after this commit, please
	contact me ASAP.


SVN revision: 39200
2009-02-25 11:03:47 +00:00