Commit Graph

188 Commits

Author SHA1 Message Date
Carsten Haitzler b95ef3801f setuid safeness - ensure if an app that is setuid doesn't do bad things
this makes efl ignore certain env vars for thnigs and entirely removes
user modules (that no one ever used) etc. etc. to ensure that *IF* an
app is setuid, there isn't a priv escalation path that is easy.
2014-01-08 19:46:23 +09:00
Carsten Haitzler c8630c85a1 emotion - broken module loading loagic fixed that fixes gst 0.10/1 deadlock
so firstly the module loading logic in emotion is pretty bad. it
forcible loads into memory (dlopen + run code from) EVERY emotion
module whenever you use emotion anywhere. this is a fat memory cost and
startup cost. it should not ever have done this. so remove that code
and make it explicitly load only the backend requested and fall back
to using what is compiled in (generic by default) and otherwise
generic as a module, then xine, then gstreamer then gstreamer1.
gstreamer1 seems broke - all i see is a black box (no video).

this also fixes a deadlock problem. if you have BOTH gstreamer AND
gstreamer1 modules loaded i get a deadlock inside glib. this seemingly
fixes it as it'll only load the first one it finds, not both (unless
explicitly requested).
2013-12-27 17:18:01 +09:00
Daniel Juyung Seo 76d8532b54 efl: Unified eina critical manro to CRI.
Being annoyed by different types of eina critical macros - CRI, CRIT,
 CRITICAL -, I concluded to unify them to one. Discussed on IRC and
 finally, CRI was chosen to meet the consistency with other macros -
 ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
2013-12-26 12:27:13 +09:00
Cedric BAIL e131580aba emotion: fix Windows compilation. 2013-12-16 17:03:10 +09:00
Cedric BAIL fce52b1031 emotion: revert to fast sed to use the right eina log domain. 2013-12-16 15:25:36 +09:00
Carsten Haitzler 6d5058ee1c emotion - webcam - don't access after free and ensure it is not in list
this should fix CID 1137853 and CID 1137854
2013-12-15 11:31:28 +09:00
Carsten Haitzler 5d6e30fae0 fix fd leak in emotion webcam where fd of value 0 never closed
fixes CID 1039175
2013-12-13 21:26:05 +09:00
Cedric BAIL ca2f9571ab emotion: make webcam initialization lazy and non blocking.
This should fix T648.
2013-12-13 12:44:19 +09:00
Cedric BAIL 96c1d15ac0 emotion: fix potential memory leak when webcam register fail. 2013-12-13 12:22:06 +09:00
Cedric BAIL f6c4513da4 emotion: use emotion log domain instead of eina one. 2013-12-13 11:30:46 +09:00
Cedric BAIL d55164c5a2 emotion: lower warning on webcam access error to information (Not critical anyway). 2013-12-13 11:30:46 +09:00
Carsten Haitzler b07c0a76ce alpha1 release autofoo/build tree work to pass distcheck and actually work 2013-11-04 18:33:35 +09:00
Michaël Bouchaud (yoz) 4ce3e1e72f emotion: add two events to trigger when a webcam is plugged or unplugged 2013-10-09 12:29:04 +02:00
Stefan Schmidt d54bfd7e1d emotion: Avoid leak by also checking for fd being null.
If fd would be null here we would leak the fd handle. Fix the check.

CID: 1039175
2013-09-12 15:26:34 +01:00
Cedric Bail 6c1833246c emotion: fix backend order. 2013-08-01 10:52:41 +09:00
Carsten Haitzler f9f0b717e6 emotion - fix shutdown to ensure all pending async calls are gone too. 2013-07-18 20:00:22 +09:00
Chris Michael 3fb6ef5a83 Fix compiler warnings
- include unistd.h for close function.
- initialize fd to -1 so we can check error condition.

Signed-off-by: Chris Michael <devilhorns@comcast.net>
2013-07-09 16:13:12 +01:00
Chris Michael 5f3a2dd5f6 Don't leak fd handles (ie: leave files open) when checking devices
NB: Fixes Coverity CID1039175

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-09 13:29:32 +01:00
Chris Michael 970a5badd3 Add missing break in switch
NB: Fixes Coverity CID1039372

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 13:44:39 +01:00
Sebastian Dransfeld 336f6ec328 efl: formatting 2013-06-20 13:28:18 +02:00
Cedric Bail d92783d5f7 emotion: rename Emotion_Module.h to emotion_modules.h 2013-05-10 10:48:33 +09:00
Carsten Haitzler ab7bd544f8 emotion - free up engine and stuff on obj del, and let smartdata hang
about for eio stuff. hrmmmmf. cedric!!! :)
2013-03-11 16:54:59 +09:00
Carsten Haitzler dee5e1d85f emotion "fix" - not actually a bug i hit, but a potential one where
xattr change jobs are not deleted on sd free.
2013-03-11 15:53:28 +09:00
Cedric BAIL 1121103ecb emotion: improve portability of Emotion Generic by using EFL more. 2013-02-27 21:10:28 +09:00
Gustavo Sverzut Barbieri 8e9303e1a4 efl/emotion: postpone finding modules as well.
SVN revision: 82680
2013-01-12 05:19:46 +00:00
Gustavo Sverzut Barbieri ae51833bac emotion: reorder cleanup of modules.
SVN revision: 82674
2013-01-12 01:08:14 +00:00
Gustavo Sverzut Barbieri d83b83e10b efl/emotion: delay module loading until they are needed.
SVN revision: 82651
2013-01-11 17:41:53 +00:00
Jérémy Zurcher 5b885ea931 fix segv in emotion_webcam_init and leak in emotion_webcam_config_load
SVN revision: 82650
2013-01-11 17:20:22 +00:00
Gustavo Sverzut Barbieri 356d4f733c efl/emotion: rework module infra, better integration with 'generic'.
Change the module infra and allow one to register using the
description structure itself, saves some work.

Replace module_open and module_close with add() and del(), that are
more descriptive.

Move stuff to init/shutdown where it was a better fit.

Since add() now receives the first parameter being the owning
structure we can create one structure per generic player and they will
merge transparently with other modules, then we can use a simple
algorithm that considers the plugin priority. ALL DYNAMIC!

Future work could be done to load the plugin priority specified by
user from configuration file. But this is not in my plans right now.



SVN revision: 82602
2013-01-11 03:06:42 +00:00
Gustavo Sverzut Barbieri 2fb89cc58a efl/emotion: remove init/shutdown from module, it's a subfunction of open/close!
SVN revision: 82600
2013-01-11 00:37:31 +00:00
Gustavo Sverzut Barbieri 619d6033f3 efl/emotion: remove handle from wrong place.
that handle should live elsewhere, it was a hack.



SVN revision: 82598
2013-01-11 00:31:56 +00:00
Gustavo Sverzut Barbieri 6e963a6118 efl/emotion: start to refactor engine handling.
Removed the engine handling out from smart object, later the module
API will change and we'll be able to simplify many things.

My plan is to allow generic players to register along as regular
modules.



SVN revision: 82597
2013-01-11 00:27:35 +00:00
Gustavo Sverzut Barbieri 6125cd9e87 efl/emotion: move register/unregister.
SVN revision: 82593
2013-01-10 22:17:32 +00:00
Gustavo Sverzut Barbieri 8a4248732a efl/emotion: move module stuff.
* do not abuse emotion_private.h by using that in modules
 * split emotion_module.c to allow more changes later.



SVN revision: 82592
2013-01-10 22:11:07 +00:00
Gustavo Sverzut Barbieri d1341cc826 efl/emotion: move webcam stuff out of main file.
SVN revision: 82591
2013-01-10 21:50:02 +00:00
Gustavo Sverzut Barbieri 517471190f efl/emotion: refactor init/shutdown, load modules from eina_prefix.
* emotion_init() and emotion_shutdown() now exist, let's do our
   initialization from there.

 * smart_add/smart_free will call init/shutdown for legacy apps.

 * use eina_prefix to determine runtime location.

 * use eina_module_arch_list_get()



SVN revision: 82509
2013-01-10 05:48:55 +00:00
Gustavo Sverzut Barbieri 1fbed8d3a6 efl/emotion: use path_max
still needs to change to use eina_prefix :-/



SVN revision: 82502
2013-01-10 03:47:46 +00:00
Gustavo Sverzut Barbieri dfb84c1657 efl: merge emotion.
this one was quite a huge work, but hopefully it's correct.

NOTES:
 * removed vlc generic module, it should go into a separate package.
 * gstreamer is enabled by default (see --disable-gstreamer)
 * xine is disabled by default (see --enable-gstreamer)
 * generic is always built statically if supported
 * gstreamer and xine can't be configured as static (just lacks command line options, build system supports it)
 * v4l2 is enabled by default on linux if eeze is built (see --disable-v4l2)
 * emotion_test moved to src/tests/emotion and depends on EFL_ENABLE_TESTS (--with-tests), but is still installed if enabled.

TODO (need your help!):
 * fix warnings with gstreamer and xine engine
 * call engine shutdown functions if building as static
 * remove direct usage of PACKAGE_*_DIR and use eina_prefix
 * add eina_prefix checkme file as evas and others
 * add support for $EFL_RUN_IN_TREE
 * create separate package for emotion_generic_modules
 * check docs hierarchy (doxygen is segv'in here)



SVN revision: 82501
2013-01-10 03:43:32 +00:00