Summary:
added support of bottom_left, bottom_right, top_left, top_right styles
of notify that are present in default theme
@fix
Reviewers: cedric, seoz, Hermet
Subscribers: reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D1329
this makes the black rect etc. appear instantly even if no effects are
selected for comp - this should cover up lockscreen and other stuff on
suspend/shutdown/resume etc. like fading does. this should fix T1498
if entry has selection, it would be cleared if selection region set is requested again.
because entry cancel the selection area after it reset the selection area.
unfortunately, the selection area is new selection so selection area is gone.
this patch prevent clearing selection and keep the new selection.
@fix
Now both hoversel and button are usable.
This is easiest way to fix the bug. But why it didn't work well even
hoversel inherit button default style?
Revert "button: revert this patch because this patch just broke hoversel."
This reverts commit 3238c8787511aaf69b755760b24f1aa518477d75.
hoversel is now usable. let's fix the button warning message with more
considerations.
Revert "button: add fixed 1 1 in case that text is not used."
This reverts commit efd33ddb5ba51dccaee2734e8a7add18801d9285.
Draggable area could be zero size if user set the panes content size
with elm_panes_xxx_size_set().
In this case, it prints fixed messages.
now, it's gone and i tested with various cases for any side effects.
the engine checks are also broken - but that's a much bigger change,
so this fixes elm config and main code to not do their x11 work if no
DISPLAY env var is set. this is right for a wayland world where you
don't want DISPLAY but WAYLAND_DISPLAY set and used. this fixes
several ERRs that should never have hapapned in this setup.
lots of code unsing ENGINE_COMPARE where it should get the engine from
the ecore_evas directly - it happened to work as we happened to have
apps that have windows only for x11, or wayland etc, but not both in
an app. this was wrong, so remove the engine compare macro and do it
properly. no laziness.
this was yet another thing broken by the mostly-unreviewed and untested widget item focus feature. it's still not completely fixed, since the reorder modes are broken, but at least it works for the general case again
@fix
@fix
moved the user callbacks call at the end of the function, so the user
is able to modify the list without making the code below the call to
fail miserably.
Also improved the Genlist Del test to also include this case.
@fix
To calc the position in a table you need to make the modulo of the col/row size, not the modulo on the x/y value
This unbreak the elm_gengrid_item_pos_get() function that was reporting wrong values
Especially the -fvisibility=hidden would be needed here for our EAPI handling.
I never realised we miss this here but Lukasz Stanislawski pointed me to it
when we wondered why it linked ofr him with missing EAPI but not for me.
I'v compiling and releasing elm like this for a long time now so I don't
expect any trouble but if something strange comes up we can still revert it
before 1.11 final.
Issue reported by Stefan Schmidt. Above atspi function had EAPI attribute
defined in implementation file, however this symbol should not be public in
elementary 1.11.
These headers are installed in the system but not officially supported
as they are considered as internal headers.
The reason why they still need to be installed is that
- they were exposed even in the previous releases.
- they are needed for widget customization (unofficially)
- or it will break ewe.
Special thanks to Stefan for the reporting.
Summary:
Elementary application crashes on startup when it is running with
wayland engine. This crash problem happens while ecore_x_screensaver API
is being called from _win_noblank_eval funcion. Thus we should not call
ecore_x_screensaver APIs if elm win doesn't have X11 window.
Test Plan:
1. build efl and elementary to support x11 and also wayland
1. run weston without xwayland
2. run elementary_test on the weston
Reviewers: raster, seoz, stefan_schmidt, devilhorns
Differential Revision: https://phab.enlightenment.org/D1293
misspelled.
In case someone exports the ELM_ENGINE to be wayland-shm or
wayland-egl, let's handle That case also. Typically it is set to
wayland_shm or wayland_egl but since we check variants of spelling for
other engines also, then let's check it for the wayland engines too.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
As a small fallout from e7dbe063c9c044f072bacafd31ab872f6210788b we now
need to set ELM_DISPLAY with our system has something like $DISPLAY or
$WAYLAND_DISPLAY set. Elm uses that now to find out which window system
to use.
In the case of daing make doc we want it forced to shot even if we run
under X. With ELM_DISPLAY we do that. Thanks goes to raster for the
explanantion and git bisect for pinning it down.
In 540741dd48d0720876a5e68b2aa4aa7a9d79b8a3 one screenshot was
moved into HAVE_CXX_11 guards to allow building with cxx11 disabled.
But in the case of cxx11 enabled we want all screenshots plus this
one so append here instead of redefine.
this deals with an issue brought up today on irc - seemingly rage
asking for accel is causing segvs in vbox with its gl accel subsystem
- the only way to disable this is an env var, and this is unfriendly,
so make config gui and stuff to mess with accel preference to fix this.
Summary:
In case, when ctxpopup content have larger size than parent object, (by height, width or both) was resized popup at the full width or height of parent object size.
@fix
Reviewers: raster, seoz, cedric, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D1266
The -shared option in LDFLAG somehow is poisoning the configure run inside
distcheck. This results in the compiler test getting a segfault and failing.
I would really like to understand why this is needed to be set here manually
anyway. Same for fPIC and dPIC. I would expect that we leave this to the user
compiling the code or the packager. Skimming through the log only brought up
fixing c++11 globally. Not really a commit message that helps me to
understand why this is needed...
Summary: Do not set access info for naviframe prev_btn and next_btn when their access info are already set.
Reviewers: Hermet, kimcinoo
Reviewed By: kimcinoo
Differential Revision: https://phab.enlightenment.org/D1255
The Makefile.am in examples weren't conditioning the compilation of
C++ examples when C++ is disabled in configuration of elementary.
Which made the compilation to fail when --disable-c++11 is
used (in EFL or elementary) on C++ examples.
The example didn't include "elm_interface_atspi_widget_action.h" and
so failed on headers that used the type Elm_Atspi_Action in the
function's prototypes.
Summary:
Main purpose of exposing widget actions and keyboard shortcuts
is to allow accessibility clients to implement alternative methods
of GUI navigation.
Reviewers: z.kosinski
Reviewed By: z.kosinski
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1227
Don't call ecore_x functions unless we are running under an
X11-compatible engine, else we get segfaults in elm_apps.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
better - why?
1. no reliance on fnmatrch headers - have special enums for this so
fnmatch is an internal detail (casefole may not exist)
2. don't leak strduped strings - free them when done
3. have the same code for genlist and grid (dup for now until an
interface makes it the same search interface)
4. improve docs
5. get right @since version
6. use label get func in item class - providing a func won't work when
multiple items of multiple classes exist in the list
As discussed in IRC, the commit that added text_part_set,
text_part_get functions to elm_button are wrong. The correct functions
to be used are from elm_layout: text_set and text_get.
Fixed the example to use these functions that are inherited on
elm_button from elm_layout and fixed the cleanup of childrens
in the parent window by using the del event callback.
Summary: This function allows user to search for item in Gengrid.
Test Plan: elementary_test -to "Gengrid Item Search By Text"
Reviewers: seoz, singh.amitesh, Hermet, raster
Differential Revision: https://phab.enlightenment.org/D1178
- _ev_handler can't know whether elm_win still exists, so changed log style from notify to printf.
In addition, release the callbacks when elm_win is destroyed.
- use elm_sys_notify_send instead of elm_sys_notify_simple_send to show more functionality.
- remove static variables not to print warnings when with more than two test_sys_notify pannel.
Previously I removed -fPIC from example LDFLAGS and CXXFLAGS. Now
I'm adding "-fPIC -DPIC" to configure.ac conditioned to HAVE_CXX11.
This commit fixes 'make check'.
Summary:
This patch is dependent on D1193 and D1136.
It will be pushed after D1193 and D1136 patch.
Reviewers: singh.amitesh
Differential Revision: https://phab.enlightenment.org/D1168
Conflicts:
src/lib/elm_genlist.c
Summary: When item looping feature is on and press up or down key, screen seems to be frozen.
Test Plan: elementary_test -to "genlist focus" -> click item looing enable -> move list up and down
Reviewers: anand.km, seoz, woohyun
Subscribers: singh.amitesh
Differential Revision: https://phab.enlightenment.org/D1193
elm_test_clock.c:15:23: warning: declaration of ‘clock’ shadows a global declaration [-Wshadow]
elm_test_index.c:15:23: warning: declaration of ‘index’ shadows a global declaration [-Wshadow]
Removed portability warnings from Automake.
Removed *.eo.hh from BUILT_SOURCES.
Fixed some redeclaration of variables.
Added datarootdir and datadir to elementary.pc.in.