It cause a error since the pan object does not have any child yet.
And why it should be visible even if it should call evas_object_show after setting child?
Anyway, the line does nothing.
SVN revision: 57683
Subject: [E-devel] [Patch] elm_smart_scroller_child_region_show_internal
In the els_scroller of the elementary, the function
"elm_smart_scroller_child_region_show_internal"
have a problem. If the parameters "x,y,w,h" have the wrong value like
"elm_scroller_region_show(scroller,
-300, -300, 900, 900);", the scroller move the position temporarily.
The scroller seem to jump.
So if the value of the parameter is not valid, it should be changed to
valid value.
The work is applied already in the function
"elm_smart_scroller_region_bring_in".
It should be applied in the function
"elm_smart_scroller_child_region_show_internal" too.
I changed the code like bring_in function.
SVN revision: 57666
[patch] els_scroller - simple bug fix about bar-dragging. by Jae Hwan Kim.
More info:
You can test it in "Scroller" menu of the "elementary_test".
We cannot move the scroller by dragging the bar.
The reason is why the bar-dragging-event and mouse-move-event confict.
When bar is draged, the movement by mouse-move should be freezed.
SVN revision: 57184
Subject: [E-devel] [Patch] els_scroller - Cannot click even if it
reach to end
I have another issue in scroller when the bounce is off.
Scroller cannot be clicked even if it reach to edge and animation is
end.
The reason is why the momentum animation is running even if it reach
end and bounce animation is off.
So I change the code that if it reach the edge in case of bounce-off,
the momentum animation is stoped.
The following is the patch code.
SVN revision: 56580
Subject: [E-devel] [Patch] els_scroller -
elm_smart_scroller_child_region_show
I have some issue in scroller.
Sometimes the scroller move to wrong region when the child get first
focus.
It use "scroller -> layout -> button".
So I checked the code and found a suspected thing in
elm_smart_scroller_child_region_show.
Please refer following pictures.
In the pictures, the rect which be written "x, y, w, h" is the area
which be made with the parameters of
"elm_smart_scroller_child_region_show".
The rect which be written "Pan" is the pan area of the scroller.
If the situation is 1) or 2) and the function is called, the result
have to be 7).
In case of 3) or 4), it have to be 8).
In case of 5) or 6), it have to remain as it is.
Is it right??
But if the situation is 6) and the function is called, the result will
be 7) in current code.
I think it is wrong.
I attached patch code. please find it below the pictures.
1)
---------------
| |
| x, y, w, h |
| |
---------------
---------------------
| |
| |
| |
| Pan |
| |
| |
| |
---------------------
2)
---------------
| |
| x, y, w, h |
---------------------
| | | |
| --------------- |
| |
| Pan |
| |
| |
| |
---------------------
3)
---------------------
| |
| |
| |
| Pan |
| |
| --------------- |
| | | |
---------------------
| x, y, w, h |
| |
---------------
4)
---------------------
| |
| |
| |
| Pan |
| |
| |
| |
---------------------
---------------
| |
| x, y, w, h |
| |
---------------
5)
---------------------
| |
| --------------- |
| | | |
| | x, y, w, h | |
| | | |
| --------------- |
| Pan |
---------------------
6)
---------------
| |
--------------------- <---Pan
| | | |
| | x, y, w, h | |
| | | |
---------------------
| |
---------------
7)
---------------------
| | | |
| | x, y, w, h | |
| | | |
| --------------- |
| |
| Pan |
| |
---------------------
8)
---------------------
| |
| Pan |
| |
| --------------- |
| | | |
| | x, y, w, h | |
| | | |
---------------------
SVN revision: 56579
In this change I also introduced elm_smart_scroller_child_region_set thats used to change the position of the scroller, without actually saving it as a wanted position.
SVN revision: 56284
Revert "Elementary scroller: Fixed an issue in scroller. When a resize happens (or any change for that matter), we should go to the last "asked for" location. This for example fixes an issue with elm_scrolled_entry (and many other widgets) showing "empty regions" on some resizes."
This reverts commit f322bd28101518849c53e6d56b93c206e4129162.
SVN revision: 56282
Subject: [E-devel] [Patch] els_scroller momentum_animator and bounce
animator disabled set/get added
This is a patch for momentum_animator and bounce animator
enabling/disabling
in els_scroller.
I added below api for disabling when the scroller's momentum or bounce
animator need to be disabled in some case.
Eina_Bool elm_smart_scroller_momentum_animator_disabled_get
(Evas_Object
*obj);
void elm_smart_scroller_momentum_animator_disabled_set
(Evas_Object *obj, Eina_Bool disabled);
void elm_smart_scroller_bounce_animator_disabled_set
(Evas_Object *obj, Eina_Bool disabled);
Eina_Bool elm_smart_scroller_bounce_animator_disabled_get
(Evas_Object
*obj);
SVN revision: 55690
Subject: Re: [E-devel] [PATCH] els_scroller
els_scroller has some problems.
First, when the function "elm_scroller_page_size_set" is used and the
scroller is bounced,
the signal "scroll,anim,stop" is not called.
Second, the signal "scroll,anim,stop" is called at the time
"ELM_THUMBSCROLL_FRICTION",
even if the animation of scroller end before the time.
So I changed the code "els_scroller.c".
Patch code is the following.
SVN revision: 55341
Although some widgets are modified in this patch there should not be any visible
change. Actually this patch is intended to fix a Gengrid issue (patch following).
In Gengrid when the items were bigger than the grid itself the scroll would not
work correctly when the alignment was other than 0.0. That happened because the
smart scroller object was assuming the pan origin to be (0,0) and doing some
miscalculations based on that.
SVN revision: 54902
seem to silly fast - scroll speed also now increaese by 1.5x not 2x
and since time extends linearly by left over time from previous scroll
it's less extreme, but still accelerated.
SVN revision: 54733
With a small rectangle swallowed as a base is now possible to make scrollbars
respect the finger size hint. But it just makes sense when thumbscroll is
disabled, i.e, when scrollbars should be dragable.
SVN revision: 54700
out of bounds, that is when the content is finished. In this way
the user note that the content is at the end.
All the others finger-scroll implementation (iphone,android) works this way ;)
This is configurable by the 'thumbscroll_border_friction' config value,
and by the 'ELM_THUMBSCROLL_BORDER_FRICTION' var.
0.0 means: disable the friction
0.5 is the default
1.0 means: maximum friction
I have tested this with every scroller in elm_test and seems to work
well in all the occurence, if you see somthing strange in some scroller
please let me know.
DaveMDS
SVN revision: 54170
Author: Helen Fornazier <helen.fornazier@profusion.mobi>
The idea of the treatment of the key downs events in the smart scroller
is be equal to any widget that use it. But to do this, the smart
scroller must listen to the EVAS_CALLBACK_KEY_DOWN, this will cause a
problem to list, genlist, gengrid, because the event will arrive first
to the smart scroller then to this widgets (because the widgets are
listening the event by event_hook). So, if the scroller treat "Up", the
genlist will not select the item above because this event was already
treat by the scroller.
Now the tratment of the keys was tranfer to the elm_scroller instead of
els_scroller.
SVN revision: 52962
The els_scroller.c:_smart_add() as disabling event propagation on
itself, that way an owner object (ie: elm_scroller,
elm_scrolled_entry, elm_list, ...) was not getting the mouse events it
gets, thus any evas_object_event_callback_add(..., EVAS_CALLBACK_MOUSE_*...)
were not working (effectively breaking tooltips).
Seems that the reason to do so was double-event reporting. It could
happen as the elm_smart_scroller has an event_obj that repeats event,
thus the object behind it, the edje_object, could get and possibly
repeat them as well.
As we are sure event_obj always get the events, but not sure of the
edje, as it depend on user contents, the logic is now changed to stop
propagation of the edje instead (it still processes the events! just
not propagates to elm_smart_scroller).
I hope this patch does not break anything, but please check your software!
SVN revision: 52350
IF we're replacing the pan_obj, then we should disconnect from the old
in order to avoid receive useless callbacks... actually if it is an
external pan object and we die and it does not, we may end crashing
due it calling function callbacks with garbage data.
SVN revision: 52117
2. fixed paged scrollin to work better
3. entry hoveresel is themable separately
4. entry hofersel is extenstible
5. test improvings
SVN revision: 42181
2. add pagination concept to scroller (only scroll by pages)
3. add longpress callback for list + genlist
4. scroller docs and some empty api calls.
SVN revision: 42147
2. add bouncing at ends for scroller and config for it
3. fix quicklaunch to be cserver-freidnly thanks to its fork tricks
4. add signals to scroller when scrolling and hitting edges
5. pants.
SVN revision: 40549
some buglts to clear up though.
fix scroller to scroll only at animator framerate.. using an animator making
scrolling much better.
begin genlist (geeric but complicated) list.
SVN revision: 38979
ChunEon Park
Jae Hwan Kim
Tom Hacohen
Carsten Haitzler
Seunggyun Kim
Rafael Fonseca
Gustavo Lima Chaves
Davide Andreoli
Tiago Rezende Campos Falcao
Nicolas Aguirre
Bruno Dilly
Gustavo Sverzut Barbieri
Christopher Michael
Cedric BAIL
Fabiano Fidêncio
Vincent Torri
Jonathan Atton
Viktor Kojouharov