Commit Graph

59929 Commits

Author SHA1 Message Date
Marcel Hollerbach 7015dc03b4 eina_cxx: use efl_new instead of efl_add
Summary:
parent is NULL, this results in a error. And a NULL object. This fixes
that!
Depends on D7163

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7164
2018-10-16 13:08:21 +02:00
Marcel Hollerbach 0c363c6537 eolian_cxx: PACKAGE_DATA_DIR is completly wrong here
Summary:
its the define for the directory where data is installed in the fs. Not
where to find test data in the tree - TESTS_SRC_DIR is defining the
same - however, with this change we are consistent and i dont need to
change the meson automatic define generation.

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7163
2018-10-16 12:51:35 +02:00
Hermet Park adcaa8b82b devas vg: return default root node if possible.
Summary:

It could return NULL root node
while user expect a valid root node in default
as It did before.

This is a regresion bug from long ago.

@fix

Reviewers: #committers

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7162
2018-10-16 15:07:51 +09:00
Hermet Park 00f889d91a evas vg: fix memory leak.
Summary:
eina array must be flushed when object is deleted.

@fix

Reviewers: #committers, devilhorns

Reviewed By: #committers, devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7160
2018-10-16 12:24:01 +09:00
Marcel Hollerbach 2cb2e6f87c meson: another build break fix
the installation of the header was forgotten which broke app compilation
against meson builds

Differential Revision: https://phab.enlightenment.org/D7161
2018-10-15 22:02:17 +02:00
Marcel Hollerbach bb2b21e55f meson: fix build files size explosion
wayland protocols accidently added generated c source files to the
sources. This lead to every dependency of evas compiling those 5 c
source code files again and again and again. Which is completly wrong.
This commit splits up between headers and c files. which reduces the
build files from over 4K to roughly 3K.

Differential Revision: https://phab.enlightenment.org/D7159
2018-10-15 22:02:17 +02:00
Marcel Hollerbach d3122474d4 meson: link gl_drm to gdm
gl_drm uses that - this was forgotten. Sorry.

Reported by ApBBB.
2018-10-13 12:10:39 +02:00
Marcel Hollerbach d21ddea3da meson: fix build break 2018-10-12 11:26:26 +02:00
Marcel Hollerbach a0562aa066 meson: add buildsystem to ecore_wl2
this was missing. Reported by jf_simon.
2018-10-12 11:15:29 +02:00
Youngbok Shin 32504a8cfa elementary textpath: support legacy APIs
Summary:
Efl.Ui.Textpath was added when we were developing new interfaces.
So, basically, it does not support 'legacy' APIs. ex) elm_textpath_add
But, in Tizen, the legacy APIs had been delivered in old version of EFL.
To reduce maintainning cost between the platforms, this patch will be helpful.
@feature

Test Plan: N/A

Reviewers: Hermet, woohyun, zmike, cedric, herdsman

Reviewed By: Hermet

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7033
2018-10-12 15:42:31 +09:00
Marcel Hollerbach 0270b20378 eo: add log domain to the testsuite
Summary:
when the compiler is instructed that symbols are local by default. Then
the testsuite will fail, due to eo_test_general.c including the
indirection header, which uses the ERR macro, which needs the
_eo_log_dom symbol.
Depends on D7145

Reviewers: netstar, zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7147
2018-10-12 14:59:14 +09:00
Hermet Park 57fd66c4b5 evas image: fix preloading compatibility broken.
Well... Logically, we don't need to request preload again,
If image is loaded already. But somewhow it broke the enlightenment pager
and I need to revert the previous behavior here.

Whatever image is loaded or not, here image requests preload again,
unless it is already on preloading.

This was introduced by babacf41b7269a257065a41a2a4ec7763bada25f.

This fixes enlightenment pager bg non visible issue.
2018-10-12 14:32:20 +09:00
Carsten Haitzler 7d7ce5dee5 Revert "elm config: hide theme and profile config in gui when running in enlightenment"
This reverts commit 0b6aade84d.

Let's not do this as it makes the tool harder to test AND actually
removes vital features even under E. elementary_Config is really meant
as a demo config tool. not a good usable one. Ultimately E should
actually do all the good things in elm config so its just some debug
tool then or one for other non-e desktops to use.
2018-10-11 16:25:06 +01:00
Carsten Haitzler 01109a8c7b glx extns - check client and server extns
in case... client should be a superset...
2018-10-11 16:25:06 +01:00
Carsten Haitzler 76725b2d3b evas gl x11 - add working measure funcs for debugging performance 2018-10-11 16:25:06 +01:00
Carsten Haitzler 0c1eab0cf9 evas cache - avoid a segv...
but this needs mroe digging as to how this state was gotten to to
begin with.
2018-10-11 16:25:06 +01:00
Carsten Haitzler d67e9875c8 ecore_x - add nouveau into the whitelist and clean up so it's a list
it was a lot of if cases before now it's an array with min version
parameters and globs for matching drivers etc. - much cleaner and
neater to afdd things to the whtielist now.
2018-10-11 16:25:05 +01:00
Marcel Hollerbach a82b24aaa8 elementary: shutdown cocoa currently
Depends on D7012
2018-10-11 17:11:36 +02:00
Marcel Hollerbach ba0630afda meson: support older udev systems
Differential Revision: https://phab.enlightenment.org/D7145
2018-10-11 17:11:36 +02:00
junsu choi 93ee5f9d53 efl_ui_win: Move force resize code on first draw
Summary:
In D6165, there was a modification that forced resize_job
to be called using sd-> deferred_resize_job.
Even if we set true in sd-> deferred_resize_job,
it will be changed to false by calling other function to be called.
(sd->deferred_resize_job = EINA_TRUE; ->
  _elm_win_resize_objects_eval ->
  _elm_win_resize_job ->
   sd->deferred_resize_job = EINA_FALSE;)
Eventually _elm_win_frame_obj_update is not called.
There is a case where _elm_win_frame_obj_update can not called in tizen.
For this reason, make sure to call resize_job when first drawing based on D6165.

Test Plan: N/A

Reviewers: eagleeye, zmike, woohyun

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7156
2018-10-11 20:28:13 +09:00
WooHyun Jung b2c26c1875 efl_ui_progressbar: avoid meaningless theme_apply 2018-10-11 19:42:57 +09:00
Hermet Park 9f99ab1eae evas cache: clear up caching locking and reference count.
Summary:
On reviewing, found out some logical problems in evas cache.

ref-drop pair doesn't make sense, proper locking for cache image neither.

Reviewers: raster, #reviewers

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7129
2018-10-11 13:54:40 +09:00
Hermet Park 27fd6a2eab evas: remove redundant internal functions.
Summary:
Since efl object is introduced, magic check is no more used.
Plus, remove redundant object functions interfaces
 - type_id,
 - visual_id,
 - store
 - unstore

Reviewers: #committers, bu5hm4n

Reviewed By: #committers, bu5hm4n

Subscribers: bu5hm4n, raster, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7153
2018-10-11 13:46:37 +09:00
Marcel Hollerbach f51f840b0e meson: do not build deprecated wl & drm
I thought it was enabled per default in autotools, it was not.

Differential Revision: https://phab.enlightenment.org/D7155
2018-10-10 14:38:55 +02:00
Marcel Hollerbach 07b69d3d85 ecore_wl2: fix build break
when i tested this commit i had wayland turned off. Sorry for the noise.
2018-10-10 14:09:24 +02:00
Daniel Kolesa e7b6e55f42 elua: add missing eolian bindings method needed for object casting
This enables updated docgen to work.
2018-10-10 13:57:59 +02:00
Hosang Kim 53b8174fbf eldbus: remove unreachable code.
Coverity doesn't like this unreachable code.
Differential Revision: https://phab.enlightenment.org/D7120
2018-10-10 12:55:21 +02:00
Marcel Hollerbach 0258946f71 meson: add dl to eina
eina uses dlsym. I forgot this.

Differential Revision: https://phab.enlightenment.org/D7149
2018-10-10 12:55:21 +02:00
Wonki Kim 18f9fbc018 elementary: fix a typo on override func of signal_callback_del
there is a logic that forwards a calling to supoer class on efl_ui_layout.
and the logic have a mismatching calling as you could see.
and this patch fixes the typo error.
Differential Revision: https://phab.enlightenment.org/D7151
2018-10-10 12:55:21 +02:00
Hosang Kim 185a1f739b ecore_wl2: fix coverity issue. (Resource Leak)
Module is not freed when eina_module_load is failed.
Differential Revision: https://phab.enlightenment.org/D7152
2018-10-10 12:55:21 +02:00
Bowon Ryu bc9ffbebb0 efl_ui_tab_pager: modified test for regression test
Summary: Fixed randomly generated tab items to be generated sequentially in test code.

Test Plan: elementary_test -to efl.ui.tab_pager

Reviewers: Jaehyun_Cho, jsuya

Reviewed By: jsuya

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7154
2018-10-10 18:05:18 +09:00
Xavi Artigas a6e74bfc8c eolian_suite: Fix reference template for doc
The @ingroup tags were changed in fc3135ce2c.
2018-10-10 10:12:10 +02:00
Hermet Park 1bc57942c0 evas vector: fix typo. 2018-10-10 14:22:34 +09:00
Xavi Artigas fc3135ce2c eolian: use the legacy_prefix to generate the legacy doxygen group names
Summary:
Legacy group names are not consistent (for example, only half of them have the
_Group suffix), therefore this commit does not fix ALL problems related to
EO-generated @ingroup tags not matching manually-generated @defgroup tags.
However, it fixes a great deal of them and the rest should be easier to fix
by hand.

Test Plan:
After running "make doc", some of the EO-generated methods like
ecore_timer_interval_set() which did not appear in the API reference
documentation should be available now.

Reviewers: q66, jsuya, Jaehyun_Cho

Reviewed By: q66

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7148
2018-10-09 15:29:08 +02:00
junsu choi ecc6fe749c ecore_con_legacy: fix coverity issues (use after free)
Summary: for hard failures (highly unlikely), the handle would be deleted and the next use would crash.

Test Plan: N/A

Reviewers: Jaehyun_Cho, zmike, cedric, bu5hm4n

Reviewed By: bu5hm4n

Subscribers: bu5hm4n, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7139
2018-10-08 11:19:53 +09:00
Marcel Hollerbach 347dc66ba9 meson: unify system properties
this unifies the system types into 4 boolean flags
This fixes the fact that meson changed the system string accross
versions.

Differential Revision: https://phab.enlightenment.org/D7144
2018-10-05 13:40:29 +02:00
Marcel Hollerbach 124fbd3fa3 meson: add sizeof checks for meson
this fixes the building for systems where int and long does not have the
same size.

Differential Revision: https://phab.enlightenment.org/D7143
2018-10-05 13:40:29 +02:00
junsu choi 01e6f80e57 elm_genlist: prevent null pointer access
Summary: it->item->block can be null. so add null check.

Test Plan: elementary_test -to "genlist show/bring"

Reviewers: SanghyeonLee, woohyun

Subscribers: woohyun, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7146
2018-10-05 17:13:54 +09:00
Lauro Moura 103ba3668e csharp: Fix missing override keyword
Reviewers: vitor.sousa

Reviewed By: vitor.sousa

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7136
2018-10-04 14:24:03 -03:00
Lauro Moura 4c576e24c7 efl-csharp: Fixing C# examples
Reviewers: vitor.sousa, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7134
2018-10-04 19:15:42 +02:00
Alastair Poole 8974f98b1c eeze: Add buildsystem to list of dependencies.
Summary:
This fixing building E with EFL both using meson
build system. Previously missing symbols, which
this patch resolves.

Reviewers: bu5hm4n, raster

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7142
2018-10-04 12:41:46 +01:00
Jaehyun Cho d03d29f7a2 elm_theme: fix return value when default style fallback is done
To keep backward compatibility, EFL_UI_THEME_APPLY_DEFAULT is returned
instead of EFL_UI_THEME_APPLY_SUCCESS if style is not found in theme and
default style fallback is done instead.

This patch fixes 7353fc1cb8

@fix
2018-10-04 19:21:44 +09:00
Youngbok Shin 038346dce0 eina debug: fix a double unlock issue
Summary:
It was caught by Covertity.
This patch will remove a potential double unlock issue.
@fix

Test Plan: N/A

Reviewers: zmike, raster, cedric, Hermet, eagleeye

Reviewed By: eagleeye

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7137
2018-10-04 18:58:04 +09:00
Youngbok Shin 75296e32df elementary entry: apply scale to all edje objects
Summary:
When an entry is scrollable, its resize object is scr_edje.
So, to apply scale properly, elm_entry needs to apply scale
to its entry_edje, too.
@fix

Test Plan: Apply scale to scrollable entry

Reviewers: herdsman, woohyun, cedric, eagleeye

Reviewed By: eagleeye

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7140
2018-10-04 18:53:36 +09:00
Lauro Moura 7cb0770d04 csharp: Temporarily disable missing docs warning
Summary:
Too many warnings about missing docs in generated code makes difficult
to see "real" warnings.

Reviewers: vitor.sousa, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7135
2018-10-04 10:09:40 +02:00
Marcel Hollerbach 22d7cd1243 meson: install compat ethumb_client.pc file
in autotools this was not having the same naming convetion than in meson
right now. This installs a duplicated .pc file, so the one with the
different name can be dropped at some point.

Fix terminology compilation.

Differential Revision: https://phab.enlightenment.org/D7132
2018-10-03 18:07:44 +02:00
Jérémy Zurcher c68ac6c1b7 meson : fix eina/meson.build
issue : when running 'ninja clean' 'buildtype' option is set to 'custom',
patch : set specific options for 'debug' and 'release',
        set default options for any other value of 'buildtype'
Differential Revision: https://phab.enlightenment.org/D7131
2018-10-03 13:07:10 +02:00
Marcel Hollerbach 46d464e5bf here comes meson
a new shiny buildtool that currently completes in the total of ~ 4 min..
1 min. conf time
2:30 min. build time
Where autotools takes:
1:50 min. conf time
3:40 min. build time.

meson was taken because it went quite good for enlightenment, and is a traction gaining system that is also used by other mayor projects. Additionally, the DSL that is defined my meson makes the configuration of the builds a lot easier to read.

Further informations can be gathered from the README.meson

Right now, bindings & windows support are missing.

It is highly recommented to use meson 0.48 due to optimizations in meson
that reduced the time the meson call would need.

Co-authored-by: Mike Blumenkrantz <zmike@samsung.com>

Differential Revision: https://phab.enlightenment.org/D7012
Depends on D7011
2018-10-02 17:22:50 +02:00
Marcel Hollerbach 70ecf1056b ecore_cocoa: stop leaking init counts 2018-10-02 16:22:07 +02:00
Alastair Poole 1566861ace macOS: make eina_environment_tmp_get() work as elsewhere.
On macOS the tmp file path always terminated with an additional
separator, causing issues when making file name comparisons.
For example, the Eio test suits would hang due to this.
This patch trims any trailing path. When joining paths
with eina_environment_tmp_get, macOS should behave
similarly as on other architectures.

Differential Revision: https://phab.enlightenment.org/D7128
2018-10-02 16:14:47 +02:00