Commit Graph

126 Commits

Author SHA1 Message Date
Chris Michael 3cc4efaf50 Fix doxy typo/grammar
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-09-26 12:16:10 +01:00
discomfitor 42fb964592 ecore-x xlib errors now only print when sync is enabled
I give up. people continually complain about these and submit them as crashes, so now they're only visible if you set ECORE_X_SYNC. the next step is an #ifdef ISCOMFITOR.
2013-08-25 17:15:19 +01:00
Mike Blumenkrantz 5e8e8aec7d print error when ecore-x shm check fails 2013-08-07 08:36:46 +01:00
Chris Michael 585ad86480 Patch from Phoenix Kayo <kayo@illumium.org> to fix
ecore_x_selection_parser functions for mozurl.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-08-05 07:44:50 +01:00
Chris Michael aa75297381 Add #ifdef ECORE_XRANDR around the edid functions.
NB: Cannot really happen for 1.8 (as --disable-ecore-x-randr has no
effect), but really these should have been ifdef'd from the start.

NB: IMO, Don't think a ChangeLog is really needed for this....

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-08-01 15:18:01 +01:00
Chris Michael 55094c9eb0 Set Crtc info->outputs and info->possible to NULL initially.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-26 07:06:58 +01:00
Chris Michael 3e9edcd539 Fix typo
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-25 13:32:06 +01:00
Chris Michael 551610fa41 Guard against allocating 0 outputs and 0 possible outputs.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-25 13:09:34 +01:00
Chris Michael 8aef3fa98a Guard against trying to allocate 0 outputs.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-25 13:08:18 +01:00
Chris Michael f287fd33a7 Trap for number of crtcs < 1 so we do not try to allocate space for
zero crtcs.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-25 12:32:49 +01:00
Carsten Haitzler e945f0d196 ecore-x: fix randr query when noutputs is 0. 2013-07-24 19:22:31 +09:00
Mike Blumenkrantz ea7bc3f670 revert e7862929e4
the ECORE_X_SYNC environment variable exists to make ecore-x debugging synchronous.
printing X errors as they occur is useful for application developers; errors should not
be silenced just because they are inconvenient or plentiful.
2013-07-19 09:02:33 +01:00
Carsten Haitzler e7862929e4 ecore-x: make error prints DBG not ERR so we don't get spammed
because an error with no idea where it came from since its async is
pretty much usless noise. if you want this to be useful you literally
need to do an xsync every x call and be able to get backtraces... the
xsync then would be inside ecore-x. and of course this would be so
nastily slow that you need to make it an option at build...
2013-07-19 09:23:11 +09:00
Mike Blumenkrantz 464dd4f206 disable ecore-x trace debugging...whoops 2013-07-18 06:24:50 +01:00
Mike Blumenkrantz 60111ce8ca add ECORE_X_SYNC env variable for xlib backend 2013-07-18 06:17:40 +01:00
Mike Blumenkrantz d77d9134f8 delete e pixmap atom based on atom pixmap atom, not pixmap 2013-07-18 05:21:07 +01:00
Mike Blumenkrantz ad7933670f ecore_x_pixmap_free no longer fails when passed 0 2013-07-18 05:21:07 +01:00
Mike Blumenkrantz 23795d1733 add ECORE_X_ATOM_XDND_DIRECTSAVE0 2013-07-17 08:44:22 +01:00
Mike Blumenkrantz 3e45bbecf6 print ecore-x xlib errors when they occur 2013-07-17 08:43:38 +01:00
Carsten Haitzler c6309b44b2 fix clang sizeof complaint 2013-07-16 19:58:01 +09:00
Carsten Haitzler d07a30fa25 fix clang sizeof complaint 2013-07-16 19:57:13 +09:00
Carsten Haitzler 604fac4166 ecore-x: vsync_animator_tick_source_set fail if drmWaitVBlank fails 2013-07-16 19:39:10 +09:00
Mike Blumenkrantz c3916df200 clamp size to ximage size for ecore_x_image_get to prevent BadMatch errors 2013-07-15 09:37:54 +01:00
Mike Blumenkrantz b67be2ee25 add error messages to ximage function failures 2013-07-15 05:19:23 +01:00
Chris Michael 207ad636fe Avoid potential divide by zero error.
NB: Fixes Coverity CID1039437and CID1039438

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 14:55:14 +01:00
Chris Michael 7bf6ba1f67 Add missing free(data) reported by jeyzu. Thanks ;)
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 14:22:20 +01:00
Chris Michael f880ef9045 Remove erroneous copy/paste of data free
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 14:04:29 +01:00
Chris Michael 45a2296218 Fix memleak reported by Coverity and replace an XFree call
NB: Fixes Coverity CID1039276

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 12:41:00 +01:00
Chris Michael 0701304205 Fix memleak reported by Coverity and replace some XFree calls with
just free.

NB: Fixes Coverity CID1039275

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 12:39:48 +01:00
Chris Michael d7600cfbee Fix memleak of window_prop_property_get
NB: Fixes Coverity CID1039274

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 12:34:28 +01:00
Chris Michael a01ce5e409 Fix memleak of window_prop_property_get
NB: Fixes Coverity CID1039273

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 12:30:34 +01:00
Chris Michael e33391ef56 Replace XFree with just free.
NB: XFree calls 'free' anyway, so this saves us a function call

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 12:28:15 +01:00
Chris Michael d7193f2830 Fix memleak reported by Coverity
NB: Fixes Coverity CID1039272

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 12:27:40 +01:00
Chris Michael 0d12ab48be Fix memleak spotted by Coverity: ecore_x_window_prop_property_get can
allocate space for 'data'. If we return before using it, then free
'data'. If we use it later for XGetAtomName, then we can free if After
we have gotten the atom names and sent the event. (NB: XGetAtomName
will allocate it's own space for the returned name, so this is safe).

NB: Fixes Coverity CID1039271

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 12:24:21 +01:00
Chris Michael 5969c97f7a Fix memleaks reported by Coverity: ecore_x_window_prop_property_get
allocates space for 'data'. We need to free that if we are going to
return before using it.

NB: Fixes Coverity CID1039270

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 12:17:58 +01:00
Chris Michael aea9e86eb4 Fix several memleaks reported by Coverity
NB: Fixes Coverity CID1039268

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 12:12:48 +01:00
Chris Michael 4ea1ea5bf4 Fix memleak spotted by Coverity
NB: Fixes Coverity CID1039267

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 11:58:15 +01:00
Chris Michael 02f545ecc6 Fix memleak. If we error out here, then we should free the data
returned from window_prop_property_get (as that does an allocation).

NB: Fixes Coverity CID1039266

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 11:47:13 +01:00
Chris Michael e6088e2361 Fix memleak reported by Coverity: If we are going to error out when
getting window netwm types, then free any atoms returned by
prop_atom_list_get.

NB: Fixes Coverity CID1039265

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 11:44:23 +01:00
Carsten Haitzler 9e459ef9d6 fix new ecore_x_pixmap typedef clashes in ecore_x 2013-07-08 17:15:11 +09:00
Chris Michael 2a1b993162 Fix "Allocation size mismatch" reported by Coverity (short version: we
declared our 'roots' variable as Ecore_X_Window, but were allocating
as 'Window').

buffer_alloc: "malloc(num * 8UL)" allocates memory.
CID 1039601: Allocation size mismatch (SIZECHECK)
5. incorrect_multiplication: Allocating a multiple of 8 bytes to
pointer of type Ecore_X_Window, which needs 4 bytes.

NB: Fixes Coverity CID1039601

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-07-08 09:00:45 +01:00
Shinwoo Kim daca686168 [ecore_x] add accessibility support - enable, disable 2013-07-03 13:13:32 +09:00
Chris Michael d263e31c7f When getting crtc info, fill in missing "rotations" field so that the
value is initialized.

NB: Spank Spank whoever did this ... oh wait, that was me :( Ouch !!

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-06-27 10:46:34 +01:00
Deon Thomas 67df5b4ad1 Ecore DPMS Function to get the current dpms power level 2013-06-26 08:32:42 +09:00
Mike Blumenkrantz fbd09e2562 add support for text/x-moz-url DND operations 2013-05-29 13:46:11 +01:00
Chris Michael 1d58f5ff1d Don't allocate space for a mode name unless the nameLength is greater
than 0.

Signed-off-by: Chris Michael <devilhorns@comcast.net>
2013-05-24 18:25:53 +01:00
Mike Blumenkrantz ab079ae1a5 move ecore-x fd handler creation to after ecore-x init has finished so we can ignore more x events during startup 2013-05-22 10:15:37 +01:00
Chris Michael afff55eec5 Fix memleak in ecore_x_randr_crtc_settings_set.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-05-21 14:32:25 +01:00
Chris Michael bc31a55bda Add ecore_x_randr_config_timestamp_get to return config timestamp that
XRandr has currently.

NB: needed for some updates/fixes to randr dialog.

Signed-off-by: Chris Michael <devilhorns@comcast.net>
2013-05-11 16:30:38 +01:00
Chris Michael 559b1b3301 Add missing ecore_x_randr_crtc_info_free function to xcb.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-05-08 10:07:53 +01:00