Summary:
Below are the test cases to reproduce the exisiting issues with focus or feature enhancement
1. Focus cut for the first/last item by scroller.
2. Focus animation on the last item.
3. Focus goes out of view point while scrolling.
4. Focus moves but the area of focus does not change.
5. No focus highlight on widget items.
6. No animation on widget item.
7. No focus movement between widget to widget items.
Reviewers: seoz, woohyun
CC: singh.amitesh
Differential Revision: https://phab.enlightenment.org/D502
Summary:
Issue: If application has to preselect an item, or change item properties by customizing theme
there is no option provided for the same.
Solution: Add item_signal_emit_hook.
Signed-off by: Shilpa Singh <shilpa.singh@samsung.com>
Test Plan:
Send a signal to item and verify UI
Elm_Object_Item *item = elm_colorselector_palette_color_add(cs, 133, 100, 255, 255);
elm_object_item_signal_emit(item, "elm,state,selected", "elm");
Reviewers: seoz, Hermet
Reviewed By: seoz
CC: govi
Differential Revision: https://phab.enlightenment.org/D504
Summary:
Currently, focus highlight comes on the widget's geometry. Elementary does not have option to provide the focus highlight on widget's part.
This patch provides the option to provide focus highlight on the widget's part.
e.g. data.item: "focus_part" "part";
The focus highlight would come on part's geometry instead of widget's geometry. This patch only works on widgets which uses
resize_obj.
Reviewers: seoz, woohyun
Differential Revision: https://phab.enlightenment.org/D499
- Added enabled_filed_count to avoid loop in _elm_datetime_smart_sizing_eval().
sizing_eval is called many times but field_count is only changed when called
_reload_format().
- Moved redundant if statement out of the loop in _field_list_display().
- Removed redundant call from _elm_datetime_smart_add().
_field_list_arrange() is called in _reload_format().
- Moved focus2, focus3 from test_focus2.c to test_focus.c
- Renamed "Focus 3" to "Focus Hide/Del".
- Renamed "Focus Custom" to "Focus Style"
- Renamed test_focus3.c to test_focus_custom_chain.c
When moved to root(/) and typed something in name_entry,
ok button sent //something as as data of "done" signal.
This patch checked current path string not to concatenate two slash.
Summary: Fix a bug with finding the proper geometry when reporting anchor
interaction. It's easy to see in entry anchor2 test in elementary_test
when clicking on the lower border of the anchor.
Anchor geometries are relative to the textblock object. The problem was
that this was accounted for using the edje object's geometry instead of
the textblock geometry thus causing an offset.
Reviewers: JackDanielZ, tasn
CC: seoz
Differential Revision: https://phab.enlightenment.org/D436
TAsn: Commit message edited by me.
New icon for the E module as discussed on T427, I'm not
really happy by all the bits but its a good start. Also put
in the inkscape svg mockup file.
Thanks to ragecryx that draw the base icon!
We already know some apis are just wrapping the internal widget apis.
Iternally we don't need to call the external apis that have additional object validation checking.
This breaks elementary_config (open it and you'll see the weird bugs on
the top left corner). Please fix it and recommit as needed. I have no
time to dive into naviframe and see what this patch is meant to be
doing.
This reverts commit e3784b68e01849a99e06f31e02192ffb19d1275c.
MAX and MIN are defined in a couple of places and they was already
defined in elm_priv.h. So use elm_priv.h's one.
I also moved CEIL to elm_priv.h that can be used in another places.
Some widgets override the widget translation but it didn't inherit the base widget's function.
Becuase of it,The language changed won't be properly called in the widget tree.
Now it fixed it.
Call the smart callback in the widget infra so that each widget don't need to hook the smart_translate only for the smart call.
This makes reducing duplicated code and supporting language,chagned from all widgets.
click.
Summary:
Focus highlight was not visible on first click on a widget with focus_highlight enabled on the window.
This happens because on first click, the "elm,action,focus,show" signal was emitted before setting focus highlight edje object as theme object of elm window.
In this patch, moved the _elm_win_focus_highlight_visible_set() call after focus highlight edje object set as theme object of window.
This fixes T774.
Test Plan:
elementary_test->focus then click any widget. Focus won't appear for the first time.
Reviewers: seoz, raster, woohyun
Maniphest Tasks: T774
Differential Revision: https://phab.enlightenment.org/D462
It looks like ctype.h is included in some other headers by luck but it
is recommended to explicitly include the necessary header.
Confirmed by glima as he commented this out.
Summary:
Previously, previous view was hidden by evas_object_hide.
However, this method is no longer correct because size calculation of naviframe causes evas_object_show.
Now, previous view is hidden by emitting signal to naviframe theme and clipper hides the previous view.
Reviewers: Hermet
Reviewed By: Hermet
CC: seoz
Differential Revision: https://phab.enlightenment.org/D484
- When appending an object to the focus custom chain,
event callback about deletion should be added.
- When a widget is deleted, its focus custom chain should be
managed correctly.
ecore_animator_del, and ecore_job_del.
As all efl public free apis get null as valid parameter, we do not need
to check null. I also removed some null check for other free apis which
were right next to timer/animator/job del. After this job code got
cleaner.
Summary:
fileselector_button and fileselector_entry should have almost same interfaces with fileselector.
Previously , we exposed them individually such as elm_fileselector_is_save_set().
Instead of adding the same APIs three times, we can reuse one fileselector's API using Eo interface.
This patch introduced fileselector interface and applied it to elm_fileselector.
Reviewers: seoz, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D475
If edje_object_part_text_get gives different text from original one,
length of text can be changed. So the last position of tmpbuf should
be calculated again refering to the current text to be returned.
This is a successor commit of 64fd5a825b24591aedb9cac695d03f5b4d867442.
Window show call triggers all smart objects' smart calculation and in case of
X11, XMapWindow() is called directly.
Also moved resize of window accordingly.
Amitesh Singh
nirajkr
Jaehwan Kim
Daniel Juyung Seo
ChunEon Park
Ryuan Choi
Daniel Juyung Seo
Carsten Haitzler
Mike Blumenkrantz
maxerba
Daniel Hirt
Davide Andreoli
Tom Hacohen
Cedric BAIL
WooHyun Jung
Jaehyun Cho
Jihoon Kim
Youngbok Shin