Commit Graph

64146 Commits

Author SHA1 Message Date
Xavi Artigas 5299a65d45 Silence mono warning in tests
../src/tests/efl_mono/Model.cs(35,13): warning CS0219: The variable `veggies' is assigned but its value is never used

This was driving me nuts... Am I the only one seeing these things?
2019-10-28 15:12:35 +01:00
thierry1970 2f5e2de8c4 efreet : Check that the file has a protocol in efreet_desktop_command_file_process()
if a path has a '/' character in it before the ':' character then it
should be treated as a local file which contains a ':' character in
its name

Reviewers: devilhorns, zmike

Reviewed By: zmike

Subscribers: zmike, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10409
2019-10-28 09:07:13 -04:00
Xavi Artigas 07bca58d6d Typo in comment 2019-10-28 09:40:33 +01:00
Yeongjong Lee eb676e47af eina_array: add paramName argument of ArgumentNullException
Summary:
ArgumentNullException constructor included `message` is
`public ArgumentNullException (string paramName, string message);`

Fix CA2208
ref T8428

Test Plan:
meson setup -Dbindings=mono,cxx -Dmono-beta=true
ninja test

Reviewers: lauromoura, felipealmeida, brunobelo

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8428

Differential Revision: https://phab.enlightenment.org/D10464
2019-10-25 19:21:30 -03:00
Xavi Artigas 08d7d2b064 Efl.Ui.Text: Fix Text Cursor composition
Summary:
This is a temporary fix while Text is being revamped.
Efl.Ui.Text internally composites Efl.Text_Cursor (through some other interfaces)
but this was not being advertised in the EO file.
This caused no trouble to C but was preventing C# from using the Cursors API
(because C# relies on the EO composites section).

On top of this, the cursor_new() method has been removed, since it was redundant.

Test Plan:
Builds and passes tests, and C# is able to do things like:
```
Efl.TextCursorCursor cursor = screen.GetTextCursor(Efl.TextCursorGetType.Main);
screen.InsertCursorText(cursor, str);
```

Reviewers: lauromoura, cedric, tasn

Reviewed By: lauromoura

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10465
2019-10-25 18:07:55 -03:00
Bruno da Silva Belo 31be3b6a5d csharp:Changing ex access modifier from Errors.cs.
Summary: ref T8401

Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8401

Differential Revision: https://phab.enlightenment.org/D10502
2019-10-25 17:40:40 -03:00
Cedric BAIL 4329b88df4 evas: disable Eina Cow Garbage Collection on dynamic content.
Summary:
Dynamic content are likely to trigger an image state change at pretty
much every frame. This lead to unecessary attempt by Eina_Cow to
deduplicate/cleanup data that are changing all the time. This reduce
memory consumption in Expedite tests that in some small amount. The
gain get bigger the more animation you get on screen. There might be
other potential gain for heavy animated case.

Reviewers: zmike, Hermet, bu5hm4n, smohanty

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8302

Differential Revision: https://phab.enlightenment.org/D10532
2019-10-25 15:45:14 -04:00
Marcel Hollerbach a380a4275a elm_interface_scrollable: correctly honor looping over
Summary:
when looping is enabled, we need to ensure that the correct arrows are
enabled.

ref D9906

Depends on D9908

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9917
2019-10-25 14:07:26 -04:00
Marcel Hollerbach ace64dafea elm_interface_scrollable: correctly emit the signals always
Summary:
our default theme defaults to show everything, the code here assumes
that everything is hidden by default, this fixes all this.

fix T4918

Depends on D9907

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T4918

Differential Revision: https://phab.enlightenment.org/D9908
2019-10-25 14:07:21 -04:00
Marcel Hollerbach 72525c77da elm_interface_scrollable: correctly handle bouncing
Summary:
if bounding is enabled, those values can get smaller and bigger than the
max value.

ref T4918

Depends on D9906

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T4918

Differential Revision: https://phab.enlightenment.org/D9907
2019-10-25 14:04:46 -04:00
Marcel Hollerbach a23b545249 theme: redo scroller theme of elm
Summary:
this was a little bit weird. There was a script that did what we already
do in C and pass it on via signals, however, there was also somewhere a
bug in this script, the arrow was not getting enabled, even if the
position is not completly max and not completly min, the problem here
was that the numbers that are passed to edje are not 100% correct (I
think they got somehwere on the way casted to an int).

With this commit we just use the signals from c in the theme and replace
the theme, this should also make everything a bit easier on the
mainloop, as a single movement of the scroller does not schedule 10
timers anymore.

ref T4918

Reviewers: zmike, eagleeye, woohyun

Reviewed By: zmike

Subscribers: zmike, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T4918

Differential Revision: https://phab.enlightenment.org/D9906
2019-10-25 14:04:40 -04:00
Mike Blumenkrantz 6abba55b5c ci: use shell to directly set base_dir for osx builds
Summary: this crashes somehow and is impossible to debug remotely

Reviewers: bu5hm4n

Reviewed By: bu5hm4n

Subscribers: bu5hm4n, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10529
2019-10-25 13:33:41 -04:00
Bruno da Silva Belo fee91831cb csharp: Using Array.Empty Eina.
Summary: ref T8421

Reviewers: lauromoura, felipealmeida, segfaultxavi, YOhoho

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8421

Differential Revision: https://phab.enlightenment.org/D10500
2019-10-25 14:23:14 -03:00
Bruno da Silva Belo 5844ab4320 csharp:Using Array.Empty genericmodel.
Summary: ref T8421

Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8421

Differential Revision: https://phab.enlightenment.org/D10501
2019-10-25 14:23:12 -03:00
Bruno da Silva Belo e17213a09b csharp: Changing Count() to Length on eina_value.
Summary: ref T8422

Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8422

Differential Revision: https://phab.enlightenment.org/D10499
2019-10-25 13:17:05 -03:00
Bruno da Silva Belo 68eefe1872 csharp: Using Count eina_promises.
Summary: ref T8422

Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8422

Differential Revision: https://phab.enlightenment.org/D10498
2019-10-25 13:16:57 -03:00
Bruno da Silva Belo 827a301131 csharp: Calling ConfigureAwait on tasks GM.
Summary: ref T8424

Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8424

Differential Revision: https://phab.enlightenment.org/D10497
2019-10-25 11:28:55 -03:00
Bruno da Silva Belo c0f3febccf csharp: Calling ConfigureAwait on tasks Model.
Summary: ref T8424

Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8424

Differential Revision: https://phab.enlightenment.org/D10496
2019-10-25 11:28:45 -03:00
Bruno da Silva Belo 882a2d4ec4 csharp: Calling ConfigureAwait on task eopromises.
Summary: ref T8424

Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8424

Differential Revision: https://phab.enlightenment.org/D10495
2019-10-25 11:28:39 -03:00
Yeongjong Lee 69261251a7 mono: implement dispose method based on dispose pattern
Summary:
Fix CA1063, CA1816
ref T8400, T8419

Test Plan:
meson setup -Dbindings=mono,cxx -Dmono-beta=true
ninja test

Reviewers: felipealmeida, brunobelo, YOhoho

Reviewed By: YOhoho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8419, T8400

Differential Revision: https://phab.enlightenment.org/D10460
2019-10-25 11:02:50 -03:00
Mike Blumenkrantz bcf27e35a2 tests/layout: add legacy layout test to verify behavior with legacy size hints
Summary:
this verifies that user-set legacy size hints will be applied accurately during
calc, and that the size of a layout can accurately decrease when its contents min
sizes decrease

ref 95b5731461

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10453
2019-10-25 09:54:19 -04:00
Mike Blumenkrantz 3638b632c8 efl_ui/text_scroller: fix null derefs
Summary: CIDs 1403890, 1396964, 1396945

Reviewers: cedric, vtorri

Reviewed By: cedric

Subscribers: vtorri, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10447
2019-10-25 09:54:19 -04:00
Bruno da Silva Belo 1adb765879 csharp: Returning only method name iwrapper.
Summary:
GetUserMethods returning only strings,
not the whole method informations.

Reviewers: lauromoura, felipealmeida

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10503
2019-10-24 19:25:35 -03:00
Yeongjong Lee 6231d5f252 efl_ui_relative_layout: change child, target parameter type to Efl.Gfx.Entity
child, target should be graphical object.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10401
2019-10-24 08:07:52 -07:00
Mike Blumenkrantz cdacc790f7 elm/code: check save file attrs after opening
ensure that they haven't changed between time of check and time of open

CID 1396966

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10440
2019-10-24 08:07:50 -07:00
Hosang Kim b2ee3ad748 efl_message: add pending queue for filtering message.
Sometimes message is appended when message queue is walking.
In this case, newly added messages are not filtered.
So I add message pending queue for filtering message.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10459
2019-10-24 08:07:49 -07:00
Yeongjong Lee b8ba39f4cb eina_mono: re-throw exception to preserve stack details
Summary:
fix CA2200
ref T8426

Test Plan:
meson setup -Dbindings=mono,cxx -Dmono-beta=true
ninja test

Reviewers: lauromoura, felipealmeida, brunobelo

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8426

Differential Revision: https://phab.enlightenment.org/D10462
2019-10-24 18:34:30 -03:00
Yeongjong Lee 1158775084 eina_mono: Initialize UNHANDLED_EXCEPTION inline
Summary:
fix CA2207
ref T8427

Test Plan:
meson setup -Dbindings=mono,cxx -Dmono-beta=true
ninja test

Reviewers: lauromoura, felipealmeida, brunobelo

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8427

Differential Revision: https://phab.enlightenment.org/D10463
2019-10-24 18:34:30 -03:00
Lauro Moura f33183ba04 csharp: Add since information to EoWrapper.cs
Reviewers: brunobelo, segfaultxavi, felipealmeida, woohyun

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10429
2019-10-24 18:49:23 +02:00
Mike Blumenkrantz 59ad959e85 tests/ecore: ensure that we attempt to re-set PATH in ecore-file tests
Summary:
if this test failed before for any reason, PATH would be permanently changed
for the current shell and process, which is obviously not what we want
Depends on D10414

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10415
2019-10-24 18:23:14 +02:00
Mike Blumenkrantz 30f6c12cbf tests/ecore: replace all bespoke strcats with snprintf
Summary:
CID 1400812
Depends on D10413

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10414
2019-10-24 18:23:11 +02:00
Mike Blumenkrantz e05311a99a tests/ecore: unset app args after app args unit test to prevent invalid reads
Summary:
various internal components in efl access the app args and read them which
will result in invalid memory access since these are stack-allocated strings
Depends on D10412

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10413
2019-10-24 18:23:03 +02:00
Mike Blumenkrantz f5e9af8c67 ecore/app: permit resetting app args to uninitialized (zeroed) state
Summary:
this is mainly useful for unit testing, but unsetting values should not be
treated as an error

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10412
2019-10-24 18:20:34 +02:00
Mike Blumenkrantz fdb931fb6e tests/eina: use slstr_steal function in slstr_steal test
Summary: CID 1401043

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10404
2019-10-24 17:55:17 +02:00
Mike Blumenkrantz 896f234b25 tests/spec: free array in multi selectable tests
Summary: CIDs 1405810, 1405807, 1405806, 1405805, 1405803, 1405801, 1403902

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10403
2019-10-24 17:46:52 +02:00
Yeongjong Lee 11a00e406c mono: merge namespaces in manual bindings
Summary:
It will enhance readability.
Before
```
namespace Efl {
namespace Eo {
```

After
```
namespace Efl.Eo {
```

Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true

Reviewers: lauromoura, Jaehyun_Cho, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10466
2019-10-24 17:19:43 +02:00
Felipe Magno de Almeida a3ade15d5a cxx: Add license to CXX bindings.
Summary:
Like C#, it will also be Apache 2.0

Depends on D9414

Reviewers: vitor.sousa, woohyun, jpeg, lauromoura

Reviewed By: lauromoura

Subscribers: jpeg, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9418
2019-10-24 10:40:16 -03:00
Lauro Moura 40a980174b csharp: Add licensing information.
Summary:
C# bindings will be lincensed under Apache Sofware License 2.0.

This commit adds the license text to the licenses folder and a copyright
notice to the binding files.

Fixes T8039

Reviewers: woohyun, felipealmeida, vitor.sousa

Reviewed By: felipealmeida

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8039

Differential Revision: https://phab.enlightenment.org/D9414
2019-10-24 10:10:56 -03:00
Mike Blumenkrantz 408102427f examples/efl_thread: fix oob writes
Summary: CIDs 1403896, 1403895, 1403892

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10395
2019-10-24 14:52:16 +02:00
Mike Blumenkrantz fbb8d83373 examples/ecore: use correct type for getchar() return
Summary:
correct prototype is int getchar(void);

CID 1400794

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10391
2019-10-24 14:40:33 +02:00
Carsten Haitzler 39ba1b79d4 spaces-- 2019-10-24 13:13:29 +01:00
Daniel Kolesa 079b1f05b1 eina: remove eina_config.h.in
This is never actually used since meson generates eina_config.h
from scratch. Apart from the byteswap checks done in the previous
commit, all of the other things already seem to be done by meson,
so just remove it.
2019-10-23 15:51:34 +02:00
Daniel Kolesa 84251f9f00 eina: unbreak byteswap checks
For one, eina_config.h.in is never used by anything since meson,
so doing any checks in it and expecting them to work is wrong.
Byteswaps are one place where this is the case, so move the
checks back in their appropriate place.
2019-10-23 15:51:08 +02:00
Xavi Artigas 69b1b1cc3e docs: small fixes to Efl.Text 2019-10-23 10:15:30 +02:00
Christopher Michael dedeb77b02 ecore-evas-wayland: Minor formatting fixes
NB: No functional changes
2019-10-22 10:59:29 -04:00
Christopher Michael b5c30bfbbe ecore-wl2: Minor formatting fix
NB: No functional changes
2019-10-22 10:42:54 -04:00
Christopher Michael 68b107ff59 ecore_evas_wayland: Fix array step size
Fix bug where eina_array step size was being increased by 10 everytime
a handler was pushed to the array. There is no need to increase array
size by 10 each time we add 1 pointer to handler.

@fix
2019-10-22 10:12:51 -04:00
Christopher Michael f7fdb9c7f6 ecore-evas-wayland: Add handler to array
Small patch to fix bug where last event handler was not being added to
the event_hdls array

@fix
2019-10-22 10:11:24 -04:00
Christopher Michael 520b844f4a ecore-evas-wayland: Minor formatting fix
NB: No functional changes
2019-10-22 10:06:23 -04:00
Christopher Michael ea2b24b182 ecore-evas-wayland: Minor formatting fix
NB: No functional changes
2019-10-22 10:04:01 -04:00