This implements scrollable interface in elm_panel so that users can drag open/close panel.
Tap & hold on the edge and panel handler will appear.
Left scrollable panel is implemented in elementary_test > Panel Scrollable.
@feature
Summary:
The bug was there when reorder mode and sd->horizontal mode is enabled but item_loop_enable
is not set, then also the loop was occuring with right key event.
Test Plan: elementary_test -to "gengrid 2"
Reviewers: raster, seoz, eagleeye, SanghyeonLee
CC: seoz
Differential Revision: https://phab.enlightenment.org/D1121
This implements scrollable interface in elm_panel so that users can drag open/close panel.
Tap & hold on the edge and panel handler will appear.
Left scrollable panel is implemented in elementary_test > Panel Scrollable.
@feature
Summary:
The focus of genlist was coming out of genlist's viewport area on resizing(shrinking).
This is fixed in this patch.
Test Plan: elementary_test -to genlist5, elementary_test -to fileselector
Reviewers: seoz, singh.amitesh, nirajkr
Differential Revision: https://phab.enlightenment.org/D949
Summary:
If item loop is enabled, the item moves infinitely in
horizontal manner (from right to left and from left to
right).
Need to implement:
-for reorder mode and horizontal mode.
@feature
DEPENDs On D841
Test Plan: elementary_test -to gengrid2
Reviewers: seoz, eagleeye, SanghyeonLee, raster
CC: seoz, raster
Differential Revision: https://phab.enlightenment.org/D842
Conflicts:
src/lib/elm_gengrid.c
Summary:
Previously there was no focus_direction & focus_next.
These functions are added in filesector winset for currect focus movement inside the winset.
Test Plan: elementary_test->"fileselector"
Reviewers: raster, seoz, nirajkr, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D913
Summary:
By using this API, we can do region show & bring in concurrently.
This needs some tuning more because some main layouting logic in map
needs to be modified to support more smooth animation.
I will spare my time to do that later.
@feature
Reviewers: Hermet, raster, stefan_schmidt
Reviewed By: raster
CC: Jaehyun
Differential Revision: https://phab.enlightenment.org/D887
Summary:
This function allows user to search for item in Genlist.
It takes four search parameters:
1. pointer to function to get text of the item. It could be the same with item's
get_text function. This parameter is added to let user use the specific search key
and to avoid problems with setting item's text, that is not constant.
2. pointer to the item from which search should start.
3. search pattern.
4. fnmatch() flags.
To check it's usage the new test is added to the elementary_test (Genlist Item Search By Text)
Reviewers: cedric, seoz, raster
CC: reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D566
Summary:
When gengrid item is reordered or deleted, gengrid didn't update item's position.
This Patch update item's position when item is placed. if middle of item deleted,
every item after the deleted one, will re-postion on _item_place function, so they
will be update there position well.
Test Plan:
modify test_gengrid grid_sel fuction to print there position. so when item selected,
they print there position and it works fine both horizontal and vertical.
Reviewers: bluezery, seoz, raster
Reviewed By: raster
CC: Hermet, chinmaya061
Differential Revision: https://phab.enlightenment.org/D855
Summary:
elm_entry_context_menu_disabled_set API is called to wrong entry.
It should be called to "en2" that added for testing the API.
@fix
Test Plan: 1. elementary -to entry7
Reviewers: woohyun, seoz, tasn
Reviewed By: seoz
CC: herdsman
Differential Revision: https://phab.enlightenment.org/D852
Summary:
Calculating the coordinate of the object to retain the focus with in view port.
Earlier focus was moving out of view port.
Test Plan:
elementary_test-> "Focus 3". Enable the Focus Auto scroll bring in and use
keys to move focused item.
Reviewers: raster, seoz, singh.amitesh, nirajkr
Differential Revision: https://phab.enlightenment.org/D822
elm_config_focus_auto_scroll_bring_in_enabled_get/set()
->
elm_config_focus_autoscroll_mode_get/set()
The main reason is that bring_in_enabled_get/set() APIs are too restricted
and thus not flexible. I got more requirements for the focus autoscrolling
such as none, wholely visible not just bring_in and show. So it is correct
to add mode_set/get() APIs for the focus auto scrolling.
Thanks god, we've found this before the release :)
@feature
Summary:
The sending data used # character, it is not compatible with other apps, so we should change it.
Change sending data to use newline character to be compatible with other apps, able to correctly drag to other apps like EFM, chrome, ...
Reviewers: JackDanielZ, seoz, raster, woohyun
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D751
Summary:
The basic idea is from Abhinandan Aryadipta and I implemented this in
upstream.
Special thanks to JackDanielZ for eolian madness.
@feature
Reviewers: JackDanielZ
Differential Revision: https://phab.enlightenment.org/D803
Summary:
This is based on bb1e8afd.
@feature
Test Plan: elementary_test->"Gengrid Focus"
Reviewers: seoz, raster
CC: seoz
Differential Revision: https://phab.enlightenment.org/D702
Summary:
- Added two APIs elm_gengrid_reorder_mode_start/stop
- Add two smart callbacks
- "item,reorder,anim,start" - This is called when a gengrid item movement
has just started by keys in reorder mode.
- "item,reorder,anim,stop" - This is called when a gengrid item movement just
stopped in reorder mode.
@feature
Test Plan: elementary_test->Gengrid Focus
Reviewers: raster, seoz, SanghyeonLee
CC: seoz
Differential Revision: https://phab.enlightenment.org/D723
- Added 'unselected' callback to reveal multiselect bug.
- Passed 'gengrid' directly instead of passing 'api' structure and using it indirectly.
- Added more box to make the GUI cleaner.
- Removed unnecessary comments and added more important comment.
Summary:
problem:
1. open window socket
2. open window plug
3. close window socket
4. open window socket
5. SEGV
there was invalid timer deletion due to dangling pointer.
@fix
Test Plan: elementary_test -> open window socket -> open window plug -> close window socket -> open window socket ->SEGV
Reviewers: raster, seoz
Reviewed By: raster
CC: seoz
Differential Revision: https://phab.enlightenment.org/D699
this adds a hand1 sample cursor theme/image so the theme can find
cursors, (more should be added later), and now actually makes the elm
cursor handling properly set the cursor and update the hotx/y as
needed by tracking the hot swallow object. this relies on a fix in efl
as well.
When focus highlight animation is enabled, focus highlight can be
resized only by animator inside edje. So, if there is no animation
by some reasons, focus highlight just keeps its original.
@fix
Added a more complex glview example to the elementary test.
- the gears lighting matches the original glx gears example.
- Added a background image to show that Glview works well with existing
ELM winsets.
- Added 5 gears and buttons to increase/decrease gear teeth
Summary:
If item loop feature is enabled, item is moved infinitely.
1. add new widget api - item_loop_enabled
2. add smart event using new config - elm_list.c
3. add demo - test_list.c/list_focus
Reviewers: seoz, woohyun, raster, jaehwan, Hermet
CC: singh.amitesh, c
Differential Revision: https://phab.enlightenment.org/D619
Summary:
It is implementation of focus_direction method for gengrid widget.
We need it in our project. We must service focus by
directions and we want to use gengrid widget. Additionally we must
support changing focus by keyboard (TV remote).
Unfortunately gengrid hasn't default implementation to present its
sub-objects as candidates for focus direction.
Our solution can search for focusable sub-objects (from realized items)
and change then focused and last selected variables in gengrid. If this
candidate wins then object will receive focus.
Reviewers: cedric, raster
CC: raster, seoz
Differential Revision: https://phab.enlightenment.org/D449
Summary:
Also
- corrected the code for getting the toolbar item from the list.
- added a test for it.
Test Plan: elementary_test -> "Toolbar Focus"
Reviewers: seoz
CC: seoz
Differential Revision: https://phab.enlightenment.org/D653
- Added focus highlight enable/disable option.
- Added a button to set the focus to 2nd item after 1.5 seconds.
- Added a button to select the 2nd item after 1.5 seconds.
- Removed unnecessary frame and lable for the test.
Added two buttons.
1. focus 3rd list item by elm_object_item_focus_set() API after 1.5 seconds.
2. select 3rd list item by elm_list_item_selected_set() API after 1.5 seconds.
- Use elm_genlist_item_class_new/free.
- Use elm_app_data_dir_get() instead of predefined PACKAGE_DATA_DIR.
- Created more internal function for the readability.
- Added comments for panels.
- Moved codes around for a better readability.
- Removed unnecessary code.
Summary:
There is no dnd test for format types except ELM_SEL_FORMAT_TARGETS.
This patch adds a test for other formats, so that we can test more about dnd.
Reviewers: JackDanielZ, seoz
CC: seoz
Differential Revision: https://phab.enlightenment.org/D617
Summary: Added example to show the last character of entered password
Test Plan: elementary_test <search scrolled entry>
Reviewers: singh.amitesh, seoz
CC: seoz
Differential Revision: https://phab.enlightenment.org/D610
This fixes the following build warning.
test_focus.c: In function ‘_focus_highlight_clip_disable_changed_cb’:
test_focus.c:682:90: warning: unused parameter ‘event_info’
[-Wunused-parameter]
@feature
Summary:
# Added "item,focused" and "item,unfocused" smart callbacks.
# Added elm_object_focused_item_get() in elm_widget
# Added elm_object_item_focus_set and elm_object_item_focus_get() APIs for
# Added one argument in existing _focus_highlight_geometry_get(...,is_next)
This is required to find out previous and current widget item.
# Added a elm_win function _focus_highlight_start() which starts the focus
Test Plan: elementary_test->List Focus , List Horizontal Focus
Reviewers: seoz, woohyun
Reviewers Comments: SeoZ - there are some known bugs. we will actively
fix them in a near future.
CC: nirajkr
Differential Revision: https://phab.enlightenment.org/D532
@feature
Summary:
1. Added "item,focused" and "item,unfocused" callbacks for widget item since
VIEW(item) is a elm layout.
2. Added sd->box into focus chain to enable the focus movement on widget items.
Test Plan: elementary_test -> popup -> "popup-center-title + items + 3 buttons"
Reviewers: seoz, woohyun
CC: nirajkr
Differential Revision: https://phab.enlightenment.org/D563
Before
elm_tooltip_move_lock_set()
elm_tooltip_move_lock_get()
After
elm_tooltip_move_freeze_push()
elm_tooltip_move_freeze_pop()
elm_tooltip_move_freeze_get()
we're likely to use the freeze rather than lock among the entire apis.
it's already discussed in the mailing list.
Summary: since to control the rotation of application windows by WM, already added related feature in Ecore_Evas. Added related API for it.
Reviewers: raster, seoz
CC: gwanglim
Differential Revision: https://phab.enlightenment.org/D542
Added API:
void elm_label_slide_speed_set(Evas_Object *obj, double speed);
double elm_label_slide_speed_get(const Evas_Object *obj);
This work is based on the previous reverted commit by nirajkr, thanks!
I hope this will fullfill his requirement, please let me know of
any problems.
Summary:
Currently we do not set the speed of two label same
This patch fetch the information of the previous
label to set it to the next label to match the speed
of the previous label
Reviewers: seoz, raster
Reviewed By: raster
CC: singh.amitesh
Differential Revision: https://phab.enlightenment.org/D531
This test is full of TextBlock bugs, just to name a few:
- The window height is wrong, it seems to take the max height as
the win was less large, try resizing to min width to understand what I mean.
- the backing on the em tag is not working.
- the underline colors are wrong.
- popping the style should remove the double underline.
- push/pop on the stack seems not to work as expected: If you push twice
you should need 2 pop to return to the normal state.
Summary:
Developer can use this API for the case when he/she wants ctxpopup not to hide
automatically when parent of ctxpopup is resized or language is changed.
Default value of "disabled" is EINA_FALSE. So if user sets "disabled" EINA_TRUE
and parent size changes, ctxpopup recalculates its size and position.
Since size of bg is set when setting parent only, it should be resized again.
Reviewers: Hermet, seoz, thiepha, raster
CC: c
Differential Revision: https://phab.enlightenment.org/D510
This commit add the following new tags:
title, subtitle, bigger, big, small, smaller, code, comment,
string, number, brace, type, class, function, param, keyword,
preprocessor, line_added, line_removed, line_changed.
Tags has been unified in 3 new utility macros:
COMMON_TEXTBLOCK_TAGS, ENABLED_TEXTBLOCK_TAGS, and DISABLED_TEXTBLOCK_TAGS
to avoid repeating too much in the theme.
Also a new test is in: "Entry Style Default" that show all the new styles.
Docs will follow soon.
SUMMARY
Item should remain selected once pressed.
When one item is selected other items should be unselected.
No special behavior on long press, item gets selected on mouse up.
APIs added are to get current selected item and to programmatically
control the selection/unselection of an item.
This is patch D515 (had to do by hand).
Summary:
Summary:
Issue:Colorselector adds default palette items by reading colors
from config, application do not have any way to get that color list.
Solution: API added to get the palette's item list.
Signed-off by: Shilpa Singh(shilpa.singh@samsung.com)
Test Plan:
Test Plan: Create a list pointer and call palette_items_get API to get
the list of color items. Change the color of any item to confirm
whether the list has been returned correctly.
Eina_List *list = elm_colorselector_palette_items_get(cs);
Eina_List *list2 = eina_list_last(list);
Elm_Object_Item *color_item = eina_list_data_get(list2);
elm_colorselector_palette_item_color_set(color_item, 0, 0, 0, 255);
Reviewers: seoz, Hermet, raster
CC: govi, myoungwoon
Differential Revision: https://phab.enlightenment.org/D503
Summary:
"_genlist_renew(gl, "default"); " was trying to get the data
" check = evas_object_data_get(obj, "check"); " before
it's set by " evas_object_data_set(gl, "check", check); "
Test Plan: elementary_test < then type genlist item styles >
Reviewers: seoz, singh.amitesh
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D518
Summary: This new API will allow widget to have its own focus highlight style
Reviewers: seoz
CC: woohyun, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D501
Summary:
in case of GTK, it provides API to select a region of text (gtk_editable_select_region).
However, there are only API to select all or none in EFL.
This API will provide the way to select a region of text.
Test Plan: elementary_test > entry3 > press 'Region' button
Reviewers: woohyun, tasn, id213sin
Reviewed By: tasn
Differential Revision: https://phab.enlightenment.org/D520
Summary: Icon is an internal object of button. There is no need to call evas_object_show() for icon widget.
Reviewers: seoz
Differential Revision: https://phab.enlightenment.org/D517
Summary:
Below are the test cases to reproduce the exisiting issues with focus or feature enhancement
1. Focus cut for the first/last item by scroller.
2. Focus animation on the last item.
3. Focus goes out of view point while scrolling.
4. Focus moves but the area of focus does not change.
5. No focus highlight on widget items.
6. No animation on widget item.
7. No focus movement between widget to widget items.
Reviewers: seoz, woohyun
CC: singh.amitesh
Differential Revision: https://phab.enlightenment.org/D502
Summary:
Currently, focus highlight comes on the widget's geometry. Elementary does not have option to provide the focus highlight on widget's part.
This patch provides the option to provide focus highlight on the widget's part.
e.g. data.item: "focus_part" "part";
The focus highlight would come on part's geometry instead of widget's geometry. This patch only works on widgets which uses
resize_obj.
Reviewers: seoz, woohyun
Differential Revision: https://phab.enlightenment.org/D499
- Moved focus2, focus3 from test_focus2.c to test_focus.c
- Renamed "Focus 3" to "Focus Hide/Del".
- Renamed "Focus Custom" to "Focus Style"
- Renamed test_focus3.c to test_focus_custom_chain.c
Summary:
fileselector_button and fileselector_entry should have almost same interfaces with fileselector.
Previously , we exposed them individually such as elm_fileselector_is_save_set().
Instead of adding the same APIs three times, we can reuse one fileselector's API using Eo interface.
This patch introduced fileselector interface and applied it to elm_fileselector.
Reviewers: seoz, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D475
This is a successor commit of 64fd5a825b24591aedb9cac695d03f5b4d867442.
Window show call triggers all smart objects' smart calculation and in case of
X11, XMapWindow() is called directly.
Also moved resize of window accordingly.
fileselector_button initialize inwin mode using the configuration.
Fixed wrong information about default value in API documentation.
In addition, fixed test_fileselector_button.cpp not to show wrong information at initial time.
Summary:
To support naviframe title transition effect, naviframe title enabled APIs are applied.
To remove the duplicate functionalities, naviframe title visible APIs are deprecated.
Reviewers: Hermet
Reviewed By: Hermet
CC: seoz, raster
Differential Revision: https://phab.enlightenment.org/D426
- Handled the deletion of image object correctly. Do not overuse/misuse
evas_object_data, it will make code less readable.
- Cleaned up button click callback. sharing one function for different
buttons is not a good idea in some cases. Just split the callbacks.
- Removed unnecessary evas_object_data_set().
Summary: Minor change to make code a little simpler.
Test Plan: elementary_test -to accessibility
Reviewers: seoz, singh.amitesh
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D456
Summary: These APIs allow to enable/disable a tooltip to move with respect to mouse pointer
Test Plan: elm_tooltip_movement_lock_set(), elm_tooltip_movement_lock_get(), elementary_test -to tooltip
Reviewers: singh.amitesh, seoz, raster
Reviewed By: raster
CC: raster
Differential Revision: https://phab.enlightenment.org/D369
Using the elm_scrollable_interface_content_viewport_resize_cb_set in
scrollable entry widget. this only happens in mobile profile when you
drag the content with your finger left/right when the content is
smaller than the gap between icons.
This accepts D187
Summary:
Add "rejected" smart callback.
Applications using the *filter_accept_set didn't know when the input was rejected.
This smart callback can provide a simple information to applications.
Reviewers: woohyun, tasn, seoz
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D413
Summary:
Now, application developers can decide whether files and directories to show in
fileselector view.
Reviewers: seoz, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D416
Summary:
Currently the focus was only on popup-content and popup-action area.
New API elm_layout_content_swallow_list_get() which returns the list of
swallow parts.
Test Plan: elementary_test -to popup. click on "subpopup + X button"
Reviewers: seoz, raster, woohyun
Reviewed By: raster
CC: nirajkr, aryarockstar, kashish
Differential Revision: https://phab.enlightenment.org/D375