The swallow part was properly renamed and namespaced, so reflect that
in the code. Also force a edje object recalc before moving the magnifier.
Reviewers: raster, cedric, Hermet, tasn
Reviewed By: cedric
CC: seoz
Differential Revision: https://phab.enlightenment.org/D286
Signed-off-by: Cedric Bail <cedric.bail@samsung.com>
wayland.
This also unifies some of the code between X & wayland wrt copy/paste.
This is part of a larger copy/paste fix for efl/elm wayland.
Previously, copy/paste would not work via keyboard shortcuts. This
series of changes fixes that issue (wrt elm_entry anyway).
This also adds addtional copy/paste support (wrt efl wayland),
including support for various mime types (text/plain, elm-markup, and html).
Signed-off-by: Chris Michael <cp.michael@samsung.com>
This features permits execution of more than one set of functions during
DnD.
Delete function API has been modified to give the developer the
possibility to remove a specific set of functions.
Summary: Add one more argument, 'Eina_Bool sub_object' to elm_widget_resize_object_set. If the argument, 'sub_object' is set as EINA_TRUE, the new resize object is added to the sub object and the previous resize object is deleted from the sub object.
Reviewers: Hermet, seoz
CC: Jaehyun_Cho, seoz, raster
Differential Revision: https://phab.enlightenment.org/D265
feature did not build (missing the matching ecore_imf code) so I had
to revert it from EFL, which means this needs to be reverted also.
Revert "Add elm_entry_input_panel_show_on_demand_set/get()"
This reverts commit 3fc38ccc41d9b61efb4b5a8db08ea8290182bb7a.
_elm_entry_smart_signali calls edje_object_message_signal_process for processing the pending messages.
Because Edje can’t changes size or position of parts immediately when it receive a signal without this.
Multiple popups (anchor hover and hoversel) are showing in following cases:
- Run elementary_test with Mobile profile --> Entry Anchor
+ click on anchor to show hover, then press menu key
+ right click on anchor
and vice versa. Avoids some warnings in clang and it helps see that
these are actually different types.
Signed-off-by: Daniel Willmann <d.willmann@samsung.com>
I splited ELM_SAFE_FREE refactoring patches. One commit per each file as recommended.
For the detail, please refer 3072dab12f12fe83fb5a628d15efd5cded11787f.
There are pros and cons but this
1. reduces human mistakes.
2. enhances readability.
3. enhances code quality.
4. removes future bug.
5. was adopted from enlightenment.
This is not all. I will work on enhancing elementary more and more.
When we call elm_entry_markup_filter_remove() with internally defined filter callbacks,
it doesn't work. So we need a one of pointer for saving the address of data.
10 Elm_Entry_Filter_Limit_Size lim;
11 lim.max_char_count = 20;
12 lim.max_byte_count = 0;
13 elm_entry_markup_filter_append(en, elm_entry_filter_limit_size,
&lim);
14
15 elm_entry_markup_filter_remove(en, elm_entry_filter_limit_size,
&lim);
16 lim.max_char_count = 50;
17 lim.max_byte_count = 0;
18 elm_entry_markup_filter_append(en, elm_entry_filter_limit_size,
&lim);
In this code, we expect to see the filter of entry will be renewed.
But elm_entry_markup_filter_remove() doesn't work.
Because, markup_filter does not hold the address of data when we use
the filter callback which is defined in elm_entry.c
_filter_new() in elm_entry.c
You can see that _filter_new allocates new pointer and names as lim2.
lim2 is saved in data of _Elm_Entry_Markup_Filter. So the address of
data doesn't equal to the input data.
item click.
This patch adds callback for copy/cut context menu item click,
so that application developers can add their own processing for
copy/cut item click event.
1. Do not need to print the same error message from all the widget codes.
2. Even though elm_widget_sub_object_add() can be used internally, there should be no error message at all.
Elm devs should fix it beforehand.
So it looks ok to print the error message in elm_widget_sub_object_add() to force elm devs to fix it.
3. Got additional code cleanups.
Issue: Currently There is no possibility in entry to get currently
selected context menu items contents i.e., Label, icon etc:- due
to this issue a separate callback has to be added per item or the
item's contents has to be sent in data.
Fix: This patch fixes this problem by sending item pointer as
event_info and providing APIs to access the item pointer. This fix is
very useful for applications which add their own context menu items to
entry's context menu.
Signed-off by: Shilpa Singh(shilpa.singh@samsung.com)
Smart data is already initialized so we do not need to re-initialize them if the value equals to 0, NULL, or EINA_FALSE.
Sometimes re-initializing smart data explicitly is needed for readability. So there are left overs.
SVN revision: 82228
+ elm_access_object_register();
+ elm_access_object_unregister();
+ elm_access_text_set();
+ elm_access_text_get();
+ elm_access_cb_set();
These APIs are to use edje part, evas object as an accessible object.
and do not create access object, because access object would be created at run time.
This is different with internal API _elm_access_object_register();
SVN revision: 81659
On Mon, Nov 19, 2012 at 9:33 PM, thiep ha <thiep.ha@samsung.com> wrote:
Dear All,
I have seen that if there is no selection in an entry, the copy/cut menus are still shown in entry.
(Example: double click at the end of entry or on an empty entry).
I modified source code to not show copy/cut menus in above scenario.
I also removed the redundant checking condition for showing copy/cut menus.
Please review this patch.
Best Regards,
Thiep Ha
SVN revision: 79545
WARNING: I don't believe this is the proper bug fix for an uninitialized
memory access, but I really don't know this code enough. Tasn if you could
look at it when you have time.
SVN revision: 78511
This can happen on window deletion scenario:
the parent object is elm_widget_sub_object_del()ed BEFORE it gets
evas_object_del()ed, so its children won't reach the window anymore.
SVN revision: 77206
hooks.
The former is now issued for all scrollables, with the behavior it had
before, and the latter is a new virtual base function, with a default
implementation leading to values matching the old case where one
didn't implement the hook.
Please help me test if everything is OK -- it seems so, here.
SVN revision: 75904
Subject: [E-devel] [patch][elementary] * access *
Series of of pathes from kim shinwoo. looked good to me - so in they
go, finishing off some more access mode to be more complete.
SVN revision: 75415
Subject: Re: [E-devel] [Patch] [elm_entry] New APIs for user style
Thank you for your comments.
I would like to send you the modified patch.
Followings are my modification:
- Add my part to ChangeLog, AUTHORS files as Raster's comment.
- Add const to the parameter of elm_entry_text_style_user_peek and
example for pop and peek to test_entry_style_user as Daniel's comment.
SVN revision: 71557
text in "elm.text". This is because wd->text is updated by edje's
signal callback. I'll think more about removing all codes wd->text.
With my opinion they are useless.
SVN revision: 69948
It's currently kinda hackish, but this can't be nicely solved without some
really needed (anyway) features in smart object callbacks. In the meanwhile
it's nice and working.
Thanks to WooHyun for the catch.
SVN revision: 69324
Subject: Re: [E-devel] suggest new api for elm_entry's copy & paste
behavior
I deprecated old apis(elm_entry_cnp_textonly_set/get) in this patch.
Please review this patch once again.
SVN revision: 68679
Subject: [E-devel] [patch] elm_cnp - revise apis
Date: Tue, 28 Feb 2012 15:11:12 +0900
Dear all.
I made a small patch about revise cnp apis.
It changed argument orders of apis to consistence and make elm widget centric.
now all cnp api's first argument is a elm widget.
It breaks api compatibility. so elementarychanges is needed to update.
thanks.
SVN revision: 68491