Commit Graph

7586 Commits

Author SHA1 Message Date
Jaeun Choi 69ddd5b7f5 multibuttonentry: change key up callback into key down callback for consistency
Summary:
Every elementary widget's action is triggered by key down event except multibuttonentry.
There's no reason why focus move and deletion should happen on key up in multibuttonentry.
This patch modifies _layout_key_up_cb into _layout_key_down_cb.

Test Plan: None

Reviewers: raster, Hermet, seoz, jpeg

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D755
2014-04-18 11:33:43 +09:00
Daniel Juyung Seo c1613811e7 spinner: Fixed broken focus movement by direction key.
This was broken by c9755bd3c828bcd2453a50542331b201089a7160.
2014-04-18 04:25:43 +09:00
Lukasz Stanislawski c30b49ecaa config: fix crash when finding key bidings
Summary: Crash occured when config was reloaded and hash data become invalid.

Reviewers: raster, seoz, Hermet

Differential Revision: https://phab.enlightenment.org/D750

Signed-off-by: Cedric Bail <cedric.bail@free.fr>
2014-04-17 19:46:25 +02:00
Daniel Juyung Seo a3d9569910 button: Renamed internal variable of button smart data to match with
actual API.
2014-04-18 01:26:01 +09:00
Jaeun Choi 099fbbc79f spinner: apply key binding
Summary: This patch applies key binding to elm_spinner.

Test Plan: None

Reviewers: Hermet, raster

Differential Revision: https://phab.enlightenment.org/D752
2014-04-17 16:03:48 +09:00
ChunEon Park 58ea3efa5d ctxpopup: dimiss ctxpopup if escape key is pressed.
rahter than just hide of the ctxpopup, dimiss will be much better for usability.
because press "Escape" is closed to "Cancel" meaning conceptually.
2014-04-17 15:51:37 +09:00
Jaeun Choi e88c793425 ctxpopup: apply key binding
Summary: This patch applies key binding to elc_ctxpopup.

Test Plan: None

Reviewers: Hermet, raster

Differential Revision: https://phab.enlightenment.org/D754
2014-04-17 15:41:50 +09:00
Jaeun Choi bde04f61e9 ctxpopup: sd->box null check and event_flag set for previous and next focus move.
Summary:
The original code was missing
- null check of sd->box
- event_flag value set
for previous and next focus move.
@fix

Test Plan: None

Reviewers: raster, seoz, Hermet

Differential Revision: https://phab.enlightenment.org/D753
2014-04-17 15:23:00 +09:00
Jaeun Choi f2bb1364e8 spinner: fixed odd behavior of the spinner
Summary:
when multiple key down is coming while increase/decrease the spinner values,
the speed acceleration will be reset by the new key down.

Instead, it stops the increase/decrease the spinner values behavior.

@fix

Test Plan: None

Reviewers: Hermet, raster

CC: seoz

Differential Revision: https://phab.enlightenment.org/D749
2014-04-17 11:51:51 +09:00
Ryuan Choi ed8969e557 elm_web2: Implement select popup interfaces 2014-04-17 00:34:41 +09:00
Ryuan Choi 2a9cd79e6d elm_web2: Implement several interfaces
- elm_web_bg_color_{get|set}
- elm_web_zoom_{get|set}
2014-04-17 00:34:41 +09:00
Jaeun Choi bdf2c672ec spinner: unified two functions with different name and same functionality
Summary:
This patch unifies two functions with different name and same functionality:
_val_inc_stop and _val_dec_stop into _spin_stop.

Test Plan: None

Reviewers: Hermet

Differential Revision: https://phab.enlightenment.org/D748
2014-04-16 20:58:37 +09:00
Jaeun Choi edeea1eb96 flipselector: apply key binding
Summary: This patch applies key binding to elm_flipselector.

Test Plan: None

Reviewers: Hermet, raster

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D745
2014-04-16 17:29:16 +09:00
Jaeun Choi 8b8a4b6922 gengrid: apply key binidng
Summary: This patch applies key binding to elm_gengrid.

Test Plan: None

Reviewers: Hermet, raster

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D744
2014-04-16 17:29:16 +09:00
Jaeun Choi fc491c7c6c genlist: apply key binding
Summary: This patch applies key binding to elm_genlist.

Test Plan: None

Reviewers: Hermet, raster

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D743
2014-04-16 17:29:16 +09:00
ChunEon Park 5044b58cfb flipselector - don't say warning.
set EINA_UNUSED for unused argument.
2014-04-16 11:05:02 +09:00
Jaeun Choi 9d571ef5a4 web: apply key binding
Summary: This patch applies key binding to elm_web.

Test Plan: None

Reviewers: Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D740
2014-04-16 11:03:14 +09:00
ChunEon Park 5ab6a7739f widgets - don't handle the events(key,mouse) if the object is disabled.
we can prevent to handle the widget events from the widget infra,
if the object is disabled.

conceptually, disabled object should not be interacted to user input(key, mouse)
2014-04-16 10:59:43 +09:00
Jaeun Choi 40704d6d43 win: apply key binding
Summary: This patch applies key binding to elm_win.

Test Plan: None

Reviewers: Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D741
2014-04-16 10:38:34 +09:00
Carsten Haitzler cb397f09fc win - add ELM_ACCEL env var to set acel method that is preferred
@feature
2014-04-15 18:41:39 +09:00
Jaeun Choi 48a4a4add7 video: apply key binding
Summary: This patch applies key binding to elm_video.

Test Plan: None

Reviewers: Hermet, raster

Differential Revision: https://phab.enlightenment.org/D738
2014-04-15 16:09:12 +09:00
Jaeun Choi 2411bf5c62 toolbar: apply key binding
Summary: This patch applies key binding to elm_toolbar.

Test Plan: None

Reviewers: Hermet, raster

Differential Revision: https://phab.enlightenment.org/D737
2014-04-15 16:07:52 +09:00
Jaeun Choi 840e1fa07f slideshow: apply key binding
Summary: This patch applies key binding to elm_slideshow.

Test Plan: None

Reviewers: Hermet, raster

Differential Revision: https://phab.enlightenment.org/D736
2014-04-15 16:07:41 +09:00
Jaeun Choi 10fb0a3f30 photocam: apply key binding
Summary: This patch applies key binding to elm_photocam.

Test Plan: None

Reviewers: Hermet, raster

Differential Revision: https://phab.enlightenment.org/D735
2014-04-15 16:07:17 +09:00
Jaeun Choi 660591102a radio: apply key binding
Summary: This patch applies key binding to elm_radio.

Test Plan: None

Reviewers: Hermet, raster

Differential Revision: https://phab.enlightenment.org/D734
2014-04-15 14:54:58 +09:00
Jaeun Choi d8d53f4268 map: apply key binding
Summary: This patch applies key binding to elm_map.

Test Plan: None

Reviewers: Hermet, raster

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D733
2014-04-15 14:52:06 +09:00
Jaeun Choi 3449c44221 image: apply key binding
Summary: This patch applies key binding to elm_image.

Test Plan: None

Reviewers: Hermet, raster

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D732
2014-04-15 14:49:35 +09:00
Jaeun Choi 71149158e2 popup: apply key binding
Summary: This patch applies key binding to elc_popup.

Test Plan: None

Reviewers: Hermet, raster

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D731
2014-04-15 14:47:19 +09:00
Jaeun Choi 16dd06bb8e player: apply key binding
Summary: This patch applies key binding to elm_player.

Test Plan: None

Reviewers: Hermet, raster

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D730
2014-04-15 14:46:39 +09:00
Jaeun Choi e6d6066581 hoversel: apply key binding
Summary: This patch applied key bindiing to elc_hoversel.

Test Plan: None

Reviewers: Hermet, raster

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D729
2014-04-15 14:40:38 +09:00
Jaeun Choi 530fcf2d8c fileselector: apply key binding
Summary: This patch applies key binding to elm_fileselector.

Test Plan: elementary_test > fileselector > check key events

Reviewers: Hermet, raster

Differential Revision: https://phab.enlightenment.org/D728
2014-04-15 13:58:01 +09:00
Jaeun Choi fbcadfd87a list: apply key binding
Summary: This patch applies key binding to elm_list.

Test Plan: elementary_test > list > check key events

Reviewers: Hermet, raster, seoz

Differential Revision: https://phab.enlightenment.org/D727
2014-04-15 13:13:57 +09:00
Jaeun Choi 872a1de3c9 key binding infra change for modifiers
Summary: This patch makes key binding support multiple and inverse modifier set.

Test Plan: None

Reviewers: raster, Hermet

Differential Revision: https://phab.enlightenment.org/D717
2014-04-14 19:47:52 +09:00
Ryuan Choi 5514493f31 elm_web2: Fix build break with latest EFL
Followes Eo2 changes.
2014-04-14 14:53:28 +09:00
Daniel Juyung Seo cfef2a2a12 toolbar: Initialized some internal variables.
This fixes coverity CID 1199658, 1199659.
2014-04-13 02:00:33 +09:00
Daniel Juyung Seo 11ad4e125d scroller: Initialized some internal variables.
This fixes coverity CID 1199657, 1199622, 1199621, 1199620.

@fix
2014-04-13 01:58:43 +09:00
Daniel Juyung Seo a3a3766845 widget: Initialized internal variables.
This fixes coverity CID 1199625 and 1199626.

@fix
2014-04-13 01:44:22 +09:00
Ryuan Choi 9a5bd0a139 elm_web2: Fix build break.
There are some missing implementations whith elm_web implements
but elm_web2 didn't yet.

This patch just added dummy implementations to fix build break.
2014-04-12 05:24:01 +09:00
Daniel Zaoui 72ffb466e5 Menu: Fix warnings. 2014-04-11 09:39:48 +03:00
Jaeun Choi bf7db13385 removed unnecessary field in key binding
Summary: No need to check ev->string if use ev->key instead of ev->keyname.

Test Plan: None

Reviewers: raster

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D714
2014-04-10 19:29:37 +09:00
Carsten Haitzler 610ad7f44c FIX TOMS BREAKING OF ELEMENTARY! 2014-04-10 18:18:21 +09:00
Tom Hacohen a7c5d02257 Adjust code to use the slightly different Eo2 API.
With Eo2 you can return values directly without the need to use a pointer
(use the C return).

For example:
eo_do(obj, elm_object_text_get(&text));
becomes:
eo_do(obj, text = elm_object_text_get());

@feature
2014-04-10 09:49:22 +01:00
Tom Hacohen 61ae26094d atspi: Made some protected functions protected.
They should be protected and they break compilation if they are not. I'm
pretty sure much more functions should be protected, but this one
definitely.
2014-04-10 09:39:32 +01:00
Tom Hacohen 5332716a59 win: Adjusted to Eo2. 2014-04-10 09:39:31 +01:00
Tom Hacohen 3737cf6140 widget: Adjusted to Eo2. 2014-04-10 09:39:31 +01:00
Tom Hacohen 140f53c05e web: Adjusted to Eo2. 2014-04-10 09:39:31 +01:00
Tom Hacohen dfbffe96de video: Adjusted to Eo2. 2014-04-10 09:39:31 +01:00
Tom Hacohen 0ccbff2cea toolbar: Adjusted to Eo2. 2014-04-10 09:39:31 +01:00
Tom Hacohen 12e4804c06 thumb: Adjusted to Eo2. 2014-04-10 09:39:31 +01:00
Tom Hacohen 0cd7e0e3d2 table: Adjusted to Eo2. 2014-04-10 09:35:02 +01:00
Tom Hacohen 416568b1f5 spinner: Adjusted to Eo2. 2014-04-10 09:35:02 +01:00
Tom Hacohen 849b770160 slideshow: Adjusted to Eo2. 2014-04-10 09:35:02 +01:00
Tom Hacohen a5deb548c2 slider: Adjusted to Eo2. 2014-04-10 09:35:02 +01:00
Tom Hacohen ada45ffbd3 separator: Adjusted to Eo2. 2014-04-10 09:35:02 +01:00
Tom Hacohen 0a7dbcff47 segment control: Adjusted to Eo2. 2014-04-10 09:35:02 +01:00
Tom Hacohen cbf43225f1 scroller: Adjusted to Eo2. 2014-04-10 09:35:02 +01:00
Tom Hacohen 9d713b52f2 route: Adjusted to Eo2. 2014-04-10 09:35:01 +01:00
Tom Hacohen df61db71d6 radio: Adjusted to Eo2. 2014-04-10 09:35:01 +01:00
Tom Hacohen 6749d72f24 progressbar: Adjusted to Eo2. 2014-04-10 09:35:01 +01:00
Tom Hacohen bc14ce0f6c prefs: Adjusted to Eo2. 2014-04-10 09:35:01 +01:00
Tom Hacohen 84b86621a0 plug: Adjusted to Eo2. 2014-04-10 09:35:01 +01:00
Tom Hacohen 610c42428b photocam: Adjusted to Eo2. 2014-04-10 09:35:01 +01:00
Tom Hacohen 372c73a1ef photo: Adjusted to Eo2. 2014-04-10 09:35:01 +01:00
Tom Hacohen 4ac24b6953 panes: Adjusted to Eo2. 2014-04-10 09:35:01 +01:00
Tom Hacohen 9bab556ac3 notify: Adjusted to Eo2. 2014-04-10 09:35:01 +01:00
Tom Hacohen 9503941d9a menu: Adjusted to Eo2. 2014-04-10 09:35:01 +01:00
Tom Hacohen 9404d296f8 mapbuf: Adjusted to Eo2. 2014-04-10 09:35:01 +01:00
Tom Hacohen d4108660a8 map: Adjusted to Eo2. 2014-04-10 09:35:01 +01:00
Tom Hacohen 8f65677fff list: Adjusted to Eo2. 2014-04-10 09:35:01 +01:00
Tom Hacohen 601b1a0695 layout: Adjusted to Eo2. 2014-04-10 09:35:01 +01:00
Tom Hacohen a1280cb26f label: Adjusted to Eo2. 2014-04-10 09:35:01 +01:00
Tom Hacohen 55c7d0aeeb inwin: Adjusted to Eo2. 2014-04-10 09:35:01 +01:00
Tom Hacohen de9c5486f6 interface scrollable: Adjusted to Eo2. 2014-04-10 09:35:01 +01:00
Tom Hacohen a1cc384635 interface atspi component: Adjusted to Eo2. 2014-04-10 09:35:01 +01:00
Tom Hacohen 19b2a1d3dd index: Adjusted to Eo2. 2014-04-10 09:35:01 +01:00
Tom Hacohen 687762a344 image: Adjusted to Eo2. 2014-04-10 09:35:00 +01:00
Tom Hacohen 16291edbc2 icon: Adjusted to Eo2. 2014-04-10 09:35:00 +01:00
Tom Hacohen 1ced9dd543 hover: Adjusted to Eo2. 2014-04-10 09:35:00 +01:00
Tom Hacohen 0d989232a1 grid: Adjusted to Eo2. 2014-04-10 09:35:00 +01:00
Tom Hacohen e411454696 glview: Adjusted to Eo2. 2014-04-10 09:35:00 +01:00
Tom Hacohen e15f80074e genlist: Adjusted to Eo2. 2014-04-10 09:35:00 +01:00
Tom Hacohen e8d0f9bb14 gengrid: Adjusted to Eo2. 2014-04-10 09:35:00 +01:00
Tom Hacohen 489fbbcc99 frame: Adjusted to Eo2. 2014-04-10 09:35:00 +01:00
Tom Hacohen 8bb57aff47 flipselector: Adjusted to Eo2. 2014-04-10 09:35:00 +01:00
Tom Hacohen a3a295eaaa flip: Adjusted to Eo2. 2014-04-10 09:35:00 +01:00
Tom Hacohen 3a6e755963 entry: Adjusted to Eo2. 2014-04-10 09:35:00 +01:00
Tom Hacohen f51643bad3 diskselector: Adjusted to Eo2. 2014-04-10 09:35:00 +01:00
Tom Hacohen 766aa30a4c dbus menu: Adjusted to Eo2. 2014-04-10 09:35:00 +01:00
Tom Hacohen 5d838bf6dd dayselector: Adjusted to Eo2. 2014-04-10 09:35:00 +01:00
Tom Hacohen 0130522f8c datetime: Adjusted to Eo2. 2014-04-10 09:35:00 +01:00
Tom Hacohen 2cc529dfb1 conformant: Adjusted to Eo2. 2014-04-10 09:35:00 +01:00
Tom Hacohen 1c51dbce13 colorselector: Adjusted to Eo2. 2014-04-10 09:35:00 +01:00
Tom Hacohen b39519aa12 cnp: Adjusted to Eo2. 2014-04-10 09:35:00 +01:00
Tom Hacohen 5ea9873316 clock: Adjusted to Eo2. 2014-04-10 09:35:00 +01:00
Tom Hacohen 9a623e21b1 check: Adjusted to Eo2. 2014-04-10 09:35:00 +01:00
Tom Hacohen 9fe8786032 calendar: Adjusted to Eo2. 2014-04-10 09:34:59 +01:00
Tom Hacohen 099ddbf0a4 button: Adjusted to Eo2. 2014-04-10 09:34:59 +01:00
Tom Hacohen ddd37d7e24 bubble: Adjusted to Eo2. 2014-04-10 09:34:59 +01:00
Tom Hacohen d616bc4828 box: Adjusted to Eo2. 2014-04-10 09:34:59 +01:00
Tom Hacohen 7623c27feb atspi bridge: Adjusted to Eo2. 2014-04-10 09:34:59 +01:00