Commit Graph

114 Commits

Author SHA1 Message Date
Jihoon Kim 591db71120 ecore_imf/xim: Fix memory leak
64 bytes in 1 blocks are definitely lost in loss record 152 of 258
   at 0x4C2AB80: malloc (vg_replace_malloc.c:296)
   by 0xC786A77: ??? (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
   by 0xC78747B: _XimDecodeIMATTRIBUTE (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
   by 0xC77A7EF: ??? (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
   by 0xC767771: XGetIMValues (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
   by 0x113CFE09: ???
   by 0x113D08F7: ???
   by 0x83DD329: ecore_imf_context_client_window_set (ecore_imf_context.c:240)
   by 0x530779D: _edje_entry_real_part_init (edje_entry.c:2937)
   by 0x5311C20: _edje_object_file_set_internal (edje_load.c:1079)
   by 0x5328665: _edje_object_efl_file_mmap_set (edje_smart.c:438)
   by 0x775BD3A: efl_file_mmap_set (in /usr/local/lib/libefl.so.1.18.4)
2017-03-03 10:12:30 +09:00
Jihoon Kim 777b9beb23 ecore_imf/ibus: Fix memory leak allocated by ibus_bus_new 2017-03-02 10:19:53 +09:00
Chris Michael e6b26d2279 ecore-imf-wayland: Reduce calls to set_cursor_rectangle
Avoid calls to zwp_text_input_v1_set_cursor_rectangle if we do not
need to. Previous code here would always call this function even if
the cursor rectangle was in the same position. Now we set a flag on
the cursor_location field to let us know that it needs updating.

ref T5226

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2017-02-28 10:22:58 -05:00
Chris Michael f877c46ad8 ecore-imf-wayland: Remove duplicate header include
wayland_imcontext.h already includes this header, so no need to
re-include. Also add missing (void) to function declaration

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2017-02-28 09:28:24 -05:00
Chris Michael 6d4357d943 ecore-imf-wayland: Formatting fixes
NB: No functional changes

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2017-02-28 09:16:22 -05:00
Jihoon Kim 82188e12b5 ecore_imf/ibus: fix memory leak 2017-02-28 11:24:39 +09:00
Jihoon Kim 73ff3e07a2 ecore_imf/ibus: Fix memory leak 2017-02-27 21:32:07 +09:00
Jihoon Kim a1da126220 ecore_imf/wayland: Fix memory leak in immodule
==1321== 156 bytes in 1 blocks are definitely lost in loss record 7,687 of 9,703
==1321==    at 0x4847E64: calloc (vg_replace_malloc.c:623)
==1321==    by 0x92EA7E9: wayland_im_context_new (wayland_imcontext.c:1094)
==1321==    by 0x92E66DD: im_module_create (wayland_module.c:132)
==1321==    by 0x4D521E7: ecore_imf_module_context_create (ecore_imf_module.c:152)
==1321==    by 0x4D51EF7: ecore_imf_context_add (ecore_imf_context.c:141)
2017-02-27 21:31:07 +09:00
Derek Foreman 05124250c5 ecore_imf/wayland: Auto generate wayland text-input protocol
Needed to do some fairly invasive changes because naming conventions
changed since we checked in the header.

Also, since I'm done converting protocol, change the gitignore to
use wildcards for wayland protocol.

This fixes a long standing bug in text-input binding and restores
previous OSK behaviour.
2017-01-18 13:21:01 -06:00
Jihoon Kim 5bb9294966 ecore_imf: remove unnecessary exported symbols in immodules
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
2017-01-09 10:22:58 +09:00
Carsten Haitzler a5489d322b ecore imf - xim module - fix domain check to be be gteq 0
minor correctness fix.
2016-11-17 18:41:31 +09:00
Carsten Haitzler 67246cddcb ecore imf - ibus - fix destroy/disconnect handling that crashes
restart e or have ibus input get destroyed and come back... the ibus
module will do bad things to its pants... because the wrong things
were passed to the signal callbacks... this fixers that along with
ensuring a freed string ptr is NULL.

@fix
2016-07-30 01:42:15 +09:00
Carsten Haitzler b94a7b5cb4 ecore-imf - remove usueless checks for context - CID 1351451
useless checks for ic in code. fix
2016-07-24 18:44:15 +09:00
Carsten Haitzler 9527240d74 efl - fix lots of little init/shutdown pairs that are wrong
i've fixed almost all the eina init/shutdown pairs to do the right
thing now... except one (ecore_shutdown) with comment inline where
eo_shutdown is not called. if this is called we are in crash land.
this needs further inspection.
2016-07-04 21:30:34 +09:00
Carsten Haitzler 072674dbe2 efl - ecore c+ ecore-imf - fix odd case input when faking a real event
so ibus module for ecore-imf likes to send an x event back to
ourselves faking a key... this works unless we are looking at
modifiers that make make for odd combos with keysyms turned into
keycodes. so actualyl use the correct original keycode plus state
unless we are having to explicitly send a keysym from ibus core.

this fixes T3703

@fix
2016-05-27 23:57:30 +09:00
Jihoon Kim 2b8d93a5d1 ecore_imf: Add multiline hint in input hint
@feature
2016-05-18 15:21:12 +09:00
Jihoon Kim 988fe37232 ecore_imf/wayland: Change sequence to call preedit changed and end callback
preedit changed and end callback should be called before commit callback
2016-05-17 08:34:17 +09:00
Jihoon Kim 8c1776d177 ecore_imf/wayland: Fix bug language changed event is always called 2016-04-18 14:51:46 +09:00
Li Zhang 7ad6c34a2c Add ECORE_IMF_CALLBACK_DELETE_SURROUNDING
Change-Id: I0e1ab14736a3d3849becb7cbeea81fe7b61053b7
2016-03-29 20:17:13 +09:00
Jihoon Kim 161883291c ecore_imf/wayland: fix IME flickering issue when input_panel_hide and show is called sequentially
Change-Id: Ieafa9cd921cc8d68c64af6b72404ef52e7bbf724
2016-03-24 20:46:15 +09:00
Jihoon Kim ce17d5d987 ecore_imf/wayland: use default preedit style
Change-Id: Iffb2d450923bbde191c4928253f133b13608a8e8
2016-03-21 19:51:31 +09:00
Jihoon Kim 662389f39b ecore_imf/wayland: send cursor position before requesting to show 2016-02-12 10:18:05 +09:00
Jihoon Kim af8bf0ddbc ecore_imf/wayland: Fix not to show IME in touching entry after hiding IME 2016-02-12 09:36:41 +09:00
Haifeng Deng 4b777ec184 ecore_imf/wayland: Fix IME hide -> show issue in case of focus-out and then focus-in
Change-Id: I1d3d7023dbd10b78f510380ff3c46087228f9180
2016-02-04 14:28:29 +09:00
Jihoon Kim a57d301f2a ecore_imf/wayland: do not check input panel enable in show or hide
Input panel enable is already being checked in ecore_imf API.
2016-02-04 13:59:09 +09:00
Jihoon Kim 584a5a32a2 ecore_imf/wayland: support to set prediction allow mode 2016-02-04 12:00:45 +09:00
Jihoon Kim b1336a27c1 ecore_imf/wayland: notify language changed 2016-02-04 11:58:03 +09:00
Jihoon Kim 7564d49a83 ecore_imf/wayland: Add support to get input panel language locale 2016-02-04 11:56:13 +09:00
Jihoon Kim 478433f0cf ecore_imf/ibus: fix indentation 2016-02-04 08:44:49 +09:00
Jihoon Kim 5b30f95e62 ecore_imf/scim: fix uninitiazed value issue detected by valgrind 2016-01-27 18:31:26 +09:00
Chris Michael 1b12e8598a ecore-imf-wayland: Remove trailing whitespace
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-12-03 12:02:40 -05:00
Chris Michael bc7a45ffe2 ecore-imf-wayland: Use ecore_wl2_display_window_find API function
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-12-03 12:02:40 -05:00
Chris Michael cc29eb432e ecore-imf-wayland: Disconnect display when we close the module
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-12-03 12:02:40 -05:00
Chris Michael da260bd5a5 ecore-imf-wayland: Port ecore_imf_wayland to use Ecore_Wl2
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-12-03 12:02:40 -05:00
Carsten Haitzler 14d5fde2d7 ecore imf - fix modules that are x11 based to only load in x11 and in wl
use env vars to determine module init for ecore-imf so you don't have
things like e locking up trying to init scim when running in wl mode.
do the same for ibus and xim modules too. do the inverse for wayland
imf module but here add also the check for ELM_DISPLAY that wasn't
there (like it is now in the other modules) so it is only initted on
wayland.

@fix
2015-10-31 11:40:05 +09:00
Seunghun Lee 261f083c4e ecore_imf/wayland: Add NULL check for text_input_manager.
Summary: this patch fixes crash caused by accessing the text_input_manager in wayland_im_context_add().

Test Plan: N/A

Reviewers: jihoon

Reviewed By: jihoon

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D3176
2015-10-15 14:16:56 +09:00
Amitesh Singh 073d735d48 ecore_imf: ibus - remove logically dead code
fixes CID: 1261460
2015-10-02 01:17:31 +05:30
Daniel Kolesa 6d9fd9b47e eina, ecore_imf: fix uninitialized field warnings 2015-07-23 10:02:25 +01:00
Jihoon Kim bae1c701ba ecore_imf/wayland: Add NULL check before accessing 2015-06-16 16:28:16 +09:00
Jihoon Kim b8bcc35f7a ecore_imf/wayland: support on-demand show mode
In on-demand show mode, input panel will be shown in case of only an user's explicit Mouse Up event.
It doesn't request to show the input panel even though the Input Method Context has focus.
2015-06-09 14:30:07 +09:00
Jihoon Kim 15814ccccb ecore_imf/wayland: support input language mode in wayland text input
@feature
2015-05-28 13:13:25 +09:00
Jihoon Kim 7240a71d33 ecore_imf/wayland: support input hint in wayland text input
@feature
2015-05-28 11:35:05 +09:00
Jihoon Kim 85166a0c73 ecore_imf/wayland: support password mode in wayland text input
@feature
2015-05-28 10:05:11 +09:00
Jihoon Kim c5f0eea83d ecore_imf/wayland: support autocapital mode in wayland text input
@feature
2015-05-27 14:39:37 +09:00
Jihoon Kim 21106fd5f0 ecore_imf/wayland: support feature to change layout of virtual keyboard 2015-05-20 18:47:58 +09:00
Jihoon Kim 82bb9c9c1e ecore_imf/wayland: hide input panel explicitly in focus-out handler 2015-05-19 19:19:54 +09:00
Marcel Hollerbach c77812d8b0 ecore_imf: init wayland before using wayland calls.
Summary:
ecore_imf: init wayland if wayland env var exists

Otherwise ecore-wl functions could return some invalid values. The env var check to avoid error messages.

@fix

Reviewers: Sergeant_Whitespace, devilhorns

Reviewed By: Sergeant_Whitespace

Subscribers: Sergeant_Whitespace, cedric

Differential Revision: https://phab.enlightenment.org/D2253
2015-04-21 10:06:39 -04:00
Jean-Philippe ANDRE 0ef41604e8 Ecore: Use calloc() to initialize Ecore_Event_Key fully
Some fields (eg. data) may not be properly initialized.
Use calloc() instead of malloc() will ensure proper initialization
even if we add more fields.

These fields (data) would even be passed down to Evas as
Evas_Event_Key_Down for instance.
2015-03-25 15:34:23 -07:00
Jihoon Kim 2c8fbb81a8 ecore_imf/scim: Fix logically dead code in scim module
CID 1261449

@fix
2015-01-10 09:27:10 +09:00
vivek 2da804f616 ecore_imf: Add null check condition in ecore_imf module
Summary: Fixed null pointer dereference issue in ecore_imf module

@fix

Signed-off-by: vivek <vivek.ellur@samsung.com>

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: raster, cedric

Differential Revision: https://phab.enlightenment.org/D1813
2015-01-08 08:34:21 -05:00