Hello everyone,
There are two issues with ctxpopup:
- Memory leak: Elm_Ctxpopup_Item is used but not deleted.
- Incorrect callback function: returned object and event_info are list object and item
(should be ctxpopup object and item).
I would like to send a patch to fix above issues.
I also provide the patch for backporting.
Please review them.
Best Regards,
Thiep
Signed-Off-By: Theip Ha<thiep.ha@samsung.com>
SVN revision: 82968
Revert "elm bin: Use convenient utility function elm_win_util_standard_add() instead of elm_win_add() + elm_bg_add(). This is for normal style (ELM_WIN_BASIC) window."
This reverts commit 31b24a0edb0028528d7c859070e03236ba42867b.
SVN revision: 69847
Subject: Re: [E-devel] [Patch] elc_ctxpopup, add restacking feature
I have attached example code for checking restacking feature of ctxpopup.
Please review the code and give any feedbacks. Thanks.
SVN revision: 67037
Subject: [E-devel] [Patch] elc_ctxpopup, add restacking feature
I have attached two files, one is the patch(*.diff) for adding
restacking feature to the ctxpopup.
The other is test example(*.TEST_EXAMPLE). You can test on the
elementary_test > ctxpopup > "Ctxpopup with user content"
And click the button which is labeled "Enlightenment". Then label will
overlap the ctxpopup.. The ctxpopup will raise in a little time.
Please review the patch and if there is no problem, please throw the
test example away! :-)
SVN revision: 66415
structure.
'canvas' and 'output' are same. So we need to deprecate one of them
later(may be evas 2.0 or so.) After I discuss this with raster, I've
got to use 'canvas' not 'output'. So I fixed elementary codes.
SVN revision: 60268
Subject: [PATCH] elc_ctxpopup
Here code is for the ctxpopup.
Since the functionalities of ctxpopup are somewhat different,
I'm trying to overwrite the ctxpopup code entirely first.
The main reason is,
Original ctxpopup could determine it's size and position by itself.
Of course, upstreamed version supports this. But it can not be reduced
it's
size
And it supposes the arrow position to center of box edje.
Basically,
This version calculates it's box size first then find available space
from
the it's position.
The origin position of the box is not expected, it finds the available
positions.
But if there is not enough space to be shown, then it finds a best
direction
to be shown again.
In this case, it reduces it's size also as to be shown entirely.
Since the ctxpopup supports scroller, the reduced box could show the all
items also.
(The point is ctxpopup should know the size of total items...)
I'm not sure the upstreamed version could cover the above scenario,
If then, I need to modify it first.
(fixed some minor formatting issue too)
SVN revision: 56021
Jean-Philippe Andre
Daniel Juyung Seo
Daniel Juyung Seo
ChunEon Park
Tom Hacohen
Gustavo Lima Chaves
Vincent Torri
Mike Blumenkrantz
Daniel Juyung Seo
Kim Shinwoo
Mike McCormack
cnook
Carsten Haitzler
ChunEon Park