Commit Graph

130 Commits

Author SHA1 Message Date
Mike Blumenkrantz 6d33a125c4 colorselector: support "changed,user" smart callback
this allows users to avoid getting callbacks from api calls
2015-04-05 16:01:50 -04:00
Daniel Juyung Seo cce206ff53 colorselector: Check return value of elm_layout_theme_set as other widgets do.
This fixes coverity CID 1273969.
2015-03-04 20:59:36 +09:00
Andrii Kroitor 67068df957 elm_colorselector update
Summary:
elm_colorselector: replaced entries with spinners
elm_colorselector: extended styling support
elm_colorselector: changed colors alignment in palette

Reviewers: Hermet, reutskiy.v.v, tasn, cedric, seoz, raster

Reviewed By: reutskiy.v.v

Subscribers: reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1513
2015-03-03 20:07:50 +09:00
Tom Hacohen e2dcfa64ae Fix code to conform to recent Eo changes. 2015-02-23 17:16:21 +00:00
Daniel Juyung Seo c982744473 colorselector: Remove unnecessary pointer redirection.
Elm_Colorselector_Data pointer is already there.
2015-01-22 07:39:34 +09:00
Jee-Yong Um a83e01cad3 elm_colorselector: Fixed to make palette_box have proper height
Summary:
palette_box had stretched height exceeding its items size.
Now it will have proper height fitting to own items.

Reviewers: Hermet, Jaehyun, raster

Reviewed By: raster

Subscribers: raster, Hermet

Differential Revision: https://phab.enlightenment.org/D1840
2015-01-12 13:36:55 +09:00
ChunEon Park 625a299e4a colorselector: memory leak fix in _color_bars_add
Summary:
this function is called at least twice: in _smart_add and every time _theme_apply is called.
so we need either correctly free sd->cb_data or reuse it

@fix

Reviewers: seoz, cedric, raster, Hermet

Subscribers: reutskiy.v.v

Projects: #elementary

Differential Revision: https://phab.enlightenment.org/D1841
2015-01-07 11:42:08 +09:00
Jee-Yong Um c890310c01 elm_colorselector: Fixed to get proper min size with picker only mode
Summary:
Fixed to make colorselector have proper min size
when colorselector is in ELM_COLORSELECTOR_PICKER mode

@fix

Reviewers: Hermet

Subscribers: Hermet

Differential Revision: https://phab.enlightenment.org/D1832
2014-12-30 13:11:50 +09:00
Jee-Yong Um 17552b42b8 elm_colorselector: Fix layout broken in ELM_COLORSELECTOR_ALL mode
Summary:
Fix layout broken in ELM_COLORSELECTOR_ALL mode
due to missing part for layout sizing evaluation

@fix

Reviewers: Hermet

Subscribers: Hermet

Differential Revision: https://phab.enlightenment.org/D1802
2014-12-23 09:50:52 +09:00
Jee-Yong Um 8357725dc3 elm_colorselector: fix not intended duplication
Summary:
When colorselector widget is added, there are two align set command on palette_box part,
but that for picker part is omitted.
Apply elm_box_align_set function to picker part correctly.

@fix

Reviewers: Hermet

Reviewed By: Hermet

Subscribers: Hermet

Differential Revision: https://phab.enlightenment.org/D1790
2014-12-19 14:28:15 +09:00
Daniel Juyung Seo fb4b67afb5 hoversel, popup, colorselector: Optimize eo item usage.
Remove unnecessary pointer reference.
2014-11-25 21:54:26 +09:00
Daniel Zaoui b01d01528a Object Items: remove casts that are no more needed.
It includes casts to Eo, Elm_Object_Item and to specific items data.
This belongs to the cleaning phase of the object items porting to Eo.
2014-11-12 12:03:57 +02:00
Daniel Zaoui e1d7009ff3 Elm Colorselector Item: Migrate to Eo 2014-11-12 11:56:02 +02:00
Daniel Zaoui a9b13f7633 Elm Widget Item: Migrate to Eo
Since we want to support legacy inheritance mechanism, code is not
finished and will have to be cleaned when all the items are ported.
2014-11-12 11:52:10 +02:00
Lukasz Stanislawski 2ca1f8a75a atspi: properly include at-spi headers.
Summary:
Change requested by TAsn. Previuosly AT-SPI headers were kept private
and included directly into elementary source code. From now on,
AT-SPI headers can be included from Elementary.h public header, however
will be marked as beta APIs.

Commit includes following changes:
* include all atspi headers into new elm_interfaces.h header.
* marking all at-spi interfaces methods/properties as @protected.
* wrap all common headers with EFL_BETA_API_SUPPORT.
* make some common APIs visible in lib, by adding EAPI attribute
  (if someone decides to use beta APIs).

Test Plan: out-off tree build with gcc, g++

Reviewers: tasn

Reviewed By: tasn

Subscribers: seoz, q66, kuuko

Maniphest Tasks: T1721

Differential Revision: https://phab.enlightenment.org/D1528
2014-10-17 16:57:26 +01:00
Tom Hacohen 7629c147eb Eo related: Change according to recent changes in eo_add().
For more info check out a7560dbc61 in
the EFL tree.
2014-09-25 17:39:34 +01:00
Lukasz Stanislawski 09b9ef0bc0 atspi: expose more actions through atspi bus.
Summary:
Main purpose of exposing widget actions and keyboard shortcuts
is to allow accessibility clients to implement alternative methods
of GUI navigation.

Reviewers: z.kosinski

Reviewed By: z.kosinski

Subscribers: seoz

Differential Revision: https://phab.enlightenment.org/D1227
2014-07-25 11:58:16 +02:00
Tom Hacohen 1bcdadb52e Eolian classes: Fix according to namespace changes in efl. 2014-06-30 17:52:16 +01:00
Zbigniew Kosinski 9ce23f0004 atspi:Set roles for widgets
Reviewers: stanluk, m.jagiello, raster

Differential Revision: https://phab.enlightenment.org/D930
2014-06-11 11:07:16 +09:00
Tom Hacohen efa41c7d75 Elm: Update code to use the new class names generated by eolian. 2014-06-03 11:54:44 +01:00
Daniel Juyung Seo 8ffbf246f4 elm: fixed trivial formattings.
Just found them while reading codes.
2014-05-10 23:44:27 +09:00
ChunEon Park 5ab6a7739f widgets - don't handle the events(key,mouse) if the object is disabled.
we can prevent to handle the widget events from the widget infra,
if the object is disabled.

conceptually, disabled object should not be interacted to user input(key, mouse)
2014-04-16 10:59:43 +09:00
Tom Hacohen 1c51dbce13 colorselector: Adjusted to Eo2. 2014-04-10 09:35:00 +01:00
Jaeun Choi 837fc28ed4 calendar, colorselector, diskselector: fix build warnings
Summary: This patch fixed build warnings in calendar, colorselector and diskselector.

Test Plan: make

Reviewers: Hermet

Differential Revision: https://phab.enlightenment.org/D685
2014-04-01 22:22:02 +09:00
Jaeun Choi 121f5446c7 check, colorselector, calendar, diskselector: apply key binding
Summary:
apply key binding to 4 widgets
this revision is only for reviewing
I'll send 4 seperate patches after review is done.

Test Plan: None

Reviewers: Hermet, seoz, raster

Differential Revision: https://phab.enlightenment.org/D678
2014-04-01 11:10:25 +09:00
Daniel Juyung Seo c8309645ed elm: Fixed shadow variable build warning.
declaration of 'access' shadows a global declaration
2014-03-23 02:05:18 +09:00
Daniel Zaoui 9a240dfedc Eolian: Integration of Color Selector 2014-03-20 15:19:49 +02:00
Daniel Zaoui e2206a1a22 Eolian: Integration of Elm Widget 2014-03-17 09:03:56 +02:00
Ryuan Choi 7c4288548b colorselector: Do not add custom palette color to the palette of config
Summary:
elm_colorselector_palette_color_add() clears the palette if config_load is true.
It means that this API will add paletter color only for this colorselector object.

Fixes T786

Test Plan: Added elm_colorselector_palette.

Reviewers: seoz, raster

Maniphest Tasks: T786

Differential Revision: https://phab.enlightenment.org/D557
2014-02-17 21:26:14 +09:00
Jaehwan Kim db23689614 access: Add smart signal "access,changed"
It occurs that access mode is changed.
Application can add this callback for each widget.
2014-02-08 14:05:14 +09:00
Shilpa Singh 9151befe0d Colorselector: Item Selection/Unselection logic changes and corresponding API additions.
SUMMARY
Item should remain selected once pressed.
When one item is selected other items should be unselected.
No special behavior on long press, item gets selected on mouse up.
APIs added are to get current selected item and to programmatically
control the selection/unselection of an item.

This is patch D515 (had to do by hand).
2014-02-08 13:33:58 +09:00
Shilpa Singh b2d43d4cf4 Colorselector: Palette_items_get API added.
Summary:
Summary:
Issue:Colorselector adds default palette items by reading colors
from config, application do not have any way to get that color list.
Solution: API added to get the palette's item list.
Signed-off by: Shilpa Singh(shilpa.singh@samsung.com)

Test Plan:
Test Plan: Create a list pointer and call palette_items_get API to get
the list of color items. Change the color of any item to confirm
whether the list has been returned correctly.

Eina_List *list = elm_colorselector_palette_items_get(cs);
Eina_List *list2 = eina_list_last(list);
Elm_Object_Item *color_item = eina_list_data_get(list2);
elm_colorselector_palette_item_color_set(color_item, 0, 0, 0, 255);

Reviewers: seoz, Hermet, raster

CC: govi, myoungwoon

Differential Revision: https://phab.enlightenment.org/D503
2014-02-07 23:35:13 +09:00
WooHyun Jung 0a1179dde4 elm_layout now supports focused/unfocused smart callback
by itself for widgets that inherit layout class.
If it uses elm_widget's, smart callback will be called at the
beginning or smart_on_focus function.
2014-02-06 16:18:57 +09:00
Daniel Juyung Seo 5a787bf58a Colorselector: Item_signal_emit_hook added.
Summary:
Issue: If application has to preselect an item, or change item properties by customizing theme
there is no option provided for the same.
Solution: Add item_signal_emit_hook.
Signed-off by: Shilpa Singh <shilpa.singh@samsung.com>

Test Plan:
Send a signal to item and verify UI
Elm_Object_Item *item = elm_colorselector_palette_color_add(cs, 133, 100, 255, 255);
elm_object_item_signal_emit(item, "elm,state,selected", "elm");

Reviewers: seoz, Hermet

Reviewed By: seoz

CC: govi

Differential Revision: https://phab.enlightenment.org/D504
2014-02-04 00:32:05 +09:00
ChunEon Park 39ad0e358e elementary - support language changed callback from a few widgets.
support a language,changed callback if a widget has the text part in default.
2014-01-23 20:07:20 +09:00
ChunEon Park aebdcff513 elementary - use the focused/unfocused string in widget defined.
Now, it will share the strings so that reduce the binary size also user uses it in one way.
2014-01-23 17:27:17 +09:00
Daniel Juyung Seo db5fe2581d elm: Removed unnecessary null check for evas_object_del. 2014-01-22 10:54:52 +09:00
Daniel Juyung Seo 43533a2fb9 elm: Removed unnecessary null check for eina_stringshare_del. 2014-01-22 10:54:45 +09:00
Daniel Juyung Seo a4f3074f9c elm: Removed unnecessary null check for ecore_timer_del,
ecore_animator_del, and ecore_job_del.

As all efl public free apis get null as valid parameter, we do not need
to check null. I also removed some null check for other free apis which
were right next to timer/animator/job del. After this job code got
cleaner.
2014-01-21 23:18:16 +09:00
Yakov Goldberg 3379c124df all widgets: change Eo API for "elm_widget_theme()" to "theme_apply"
There are elm_widget_theme/theme_set/theme_get functions.
    In Eolian these functions will be described as "theme" method and
    "theme" property. There is clash here.
    So add suffix "_apply" to Eo API for "elm_widget_theme".
2014-01-21 11:08:29 +02:00
Jihoon Kim 7d6e81c09f elm: replace 0 or 1 with EINA_FALSE or EINA_TRUE 2014-01-08 08:23:58 +09:00
Daniel Juyung Seo fd5c046dfe elm: Changed __UNUSED__ to EINA_UNUSED. 2014-01-06 23:33:57 +09:00
Daniel Juyung Seo e63dd3110a elm: Unified eina critical manro to CRI.
Being annoyed by different types of eina critical macros - CRI, CRIT,
 CRITICAL -, I concluded to unify them to one. Discussed on IRC and
 finally, CRI was chosen to meet the consistency with other macros -
 ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
2013-12-26 13:03:55 +09:00
Carsten Haitzler bffa4d013d colorsel - allow widget to re-wrap smaller of resized down with palette on 2013-12-17 09:13:54 +09:00
Daniel Juyung Seo 6d71a23c3a elm lib: removed all the unnecessary empty lines.
being pedantic.
2013-12-15 06:18:35 +09:00
Daniel Juyung Seo 8a0159df4f elm: long waited seasonal trailing whitespaces removal!
This is a ceremony of elementary 1.8 release!
2013-12-02 19:43:46 +09:00
Daniel Juyung Seo 5567837cf5 button,check,colorselector,diskselector,flipselector,image,radio,toolbar: fixed formatting of smart_event functions before working on it.
Now they look more consistent.
2013-11-13 09:54:37 +09:00
Carsten Haitzler 475e48bc7c colorsel - dont free up palette CONFIG except when clearing palette. 2013-11-08 15:42:31 +09:00
Tom Hacohen 2f1e1554e5 Changed Eo class names to be consistent.
All the class names are now of the format: Elm_Type_Subtype_Extra
2013-11-07 11:44:22 +00:00
Daniel Juyung Seo d22076681b elm: Fixed formatting about smart_event check for code consistency.
- Made it look clearer.
- Removed unnecessary local variables.
- Keep the code sequence consistent.
2013-10-28 23:30:12 +09:00