Read my comment in the email, and we even talked about it on irc. The
current call to "mainloop iterate" is hacky, Jihoon is already working
on an alternative solution.
SVN revision: 59734
When elm_entry_entry_set() is called, the preedit text in the entry should
be cleared. ATM, it doesn’t works so.
This patch will resolve this problem.
When ecore_imf_context_reset() is called, the preedit text in the immodule
will be committed by calling ‘ecore_imf_context_commit_event_add()’.
ecore_imf_context_commit_event_add puts the event in ecore event queue, so
it will be processed in the idle state of ecore loop.
According to this mechanism, commit text is inserted later, so I use
‘ecore_main_loop_iterate();’ for inserting the commit string instantly.
SVN revision: 59732
We don't really need or use the coordinates anywhere, we just saved them
and worked hard on maintaining them, but didn't really use them.
Now we only calculate them in the one specific case where we actually
need them. This speeds things up and also means the layouting may not be
called in some cases when there's no need to layout.
SVN revision: 59520
Subject: [E-devel] [PATCH] bug fix : preedit text was commited when
shift key was pressed
ATM, preedit text is commited when shift key is pressed.
This patch file is for solving this bug.
SVN revision: 58887
Subject: [E-devel] [PATCH] bug fix in : "cursor, changed" signal is
not emitted when the content of entry is removed
I found the bug that "cursor,changed" signal is not emitted when the content
of entry is removed.
Let's assume the cursor position is equal to 10.
In this situation, elm_entry_entry_set(en, "") is called.
The content of entry is removed and the cursor position is equal to 0, but
"cursor,changed" signal is not emitted.
This patch is for solving this problem.
In addition, it lets the input method module know the cursor position using
ecore_imf_context_cursor_position_set API
in case that _edje_entry_set_cursor_{start, end} is called.
(Raster: actually it should always emit changed. not check pos at all.
technically pos could be the same BUT cursor moved on screen due to a
reformat). :)
SVN revision: 58886
Subject: RE: [E-devel] One bug in _edje_key_down_cb func (in
edje_entry.c)
I found one bug in _edje_key_down_cb func (in edje_entry.c)
When I input "Backspace" in an entry object, _signal_cursor_chagned_func(in
elm_entry.c) is not called.
This is because the following code in _edje_key_down_cb func (in edje_entry.c)
is not called.
if ((evas_textblock_cursor_compare(tc, en->cursor)) && (!cursor_changed))
_edje_emit(ed, "cursor,changed", rp->part->name);
Why not called ? Because ~ evas_textblock_cursor_compare(tc, en->cursor)
returns 0.
(i.e. old cursor and current cursor have the same position information)
I think old cursor should keep its position without any updating.
But in evas_textblock_cursor_char_delete() func, called by _backsapce func
(in edje_entry.c) -
old cursor's postion is updated as the current position.
SVN revision: 57199
Passing the correct data to _edje_entry_imf_event_delete_surrounding_cb and _edje_entry_imf_retrieve_surrounding_cb
Fix indentation.
Patch by Jihoon Kim.
SVN revision: 54365
Entry widget has not processed the key event of keypad such as KP_Left,
KP_Right, KP_Home, KP_End, and so on.
In this patch, those key events is processed.
SVN revision: 54359
Fixed formatting issues.
Fixed typos.
Fixed clearing of selection when pressing a key in a software keyboard.
Patch by Jihoon Kim and small adjustments by myself. Thanks a lot.
SVN revision: 51897
Apply badzero.cocci, badnull.coci and badnull2.cocci
This should convert all cases where there's a comparison to NULL to simpler
forms. This patch applies the following transformations:
code before patch ||code after patch
===============================================================
return a == NULL; return !a;
return a != NULL; return !!a;
func(a == NULL); func(!a);
func(a != NULL); func(!!a);
b = a == NULL; b = !a;
b = a != NULL; b = !!a;
b = a == NULL ? c : d; b = !a ? c : d;
b = a != NULL ? c : d; b = a ? c : d;
other cases:
a == NULL !a
a != NULL a
SVN revision: 51487
Tom Hacohen
Carsten Haitzler
Jihoon Kim
Jihoon Kim
Daniel Juyung Seo
Brett Nash
WooHyun Jung
Vincent Torri
Christopher Michael
Lucas De Marchi