kimcinoo
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
11,016 Commits 487 Branches 154 Tags 426 MiB
Commit Graph

901 Commits

Author SHA1 Message Date
ChunEon Park 09252cf55f genlist: code clean up 
highlight item with one entry.
 2015-01-15 23:01:00 +09:00
ChunEon Park 7a4cffb1d8 genlist: guard the item deletion problem. 
this exceptional code prevents the deletion of the item
in the middle of the callback.
 2015-01-15 22:42:46 +09:00
ChunEon Park 08772d8792 genlist: fix the access of the invalid items. 
still, there were case item or genlist is cleared in the user callback.
don't access the cleared items if they are requested deletion.
 2015-01-15 22:42:14 +09:00
Mike Blumenkrantz 8414d626d4 genlist needs to also highlight items on keyboard select 
this should probably just happen in _item_select() to avoid future incidents

ref T1986
 2015-01-14 15:19:48 -05:00
Mike Blumenkrantz a102155889 Revert "genlist: fix a crash when deleting a item in selected callback." 
This reverts commit c80b24baf815e35c160bf0dbe8ecae6ea247aef8.

this broke the selection callback completely and makes every genlist app unusable.

please, please, please, please, I'm seriously begging you hermet, do ANY amount of testing before making further genlist commits.
 2015-01-14 14:41:50 -05:00
ChunEon Park 24c56e5a0a genlist: fix a crash when deleting a item in selected callback. 
if user deletes the item in the callback,
current function(_item_select) would be corrupted.
just leave the callback call in the last of the function.
 2015-01-14 23:30:43 +09:00
ChunEon Park 6aaca793a7 genilst: fix regression bug added in 0e7d521151ba93f3b5955caaf9b906e160ab6057 
some logic of deleting item were duplicated.
this fixes fileselector crash issue.
 2015-01-14 23:21:32 +09:00
ChunEon Park 9cd1e83c24 genlist: set missed item reference. 
this missing would cause crash of the genlist when it's items are cleared.
 2015-01-14 22:07:00 +09:00
ChunEon Park 3be81fa24c genlist: fix a crash of genlist group tree example. 
don't corrupt list pointer.
we can clear items more simply.

Thanks ya-kov for reporting.
 2015-01-14 22:04:26 +09:00
ChunEon Park ab0e050102 genlist: recommit 1879cc39258c63c24f0abcff56558b1f1b60167a with correction. 2015-01-12 10:00:04 +09:00
Yakov Goldberg 89133c8f58 Revert "genlist: use eina bool" 
This reverts commit 1879cc39258c63c24f0abcff56558b1f1b60167a.

  Hermet, please check this commit it makes Fileselector crash,
  looks like you inverted the values: 1 should be EINA_TRUE.
  I recommend you to use Exactness to run all the tests automatically.
 2015-01-11 16:59:50 +02:00
ChunEon Park 95494c3a98 genlist: remove unnecessary null check. 2015-01-10 17:47:14 +09:00
ChunEon Park 42dc29b87b genlist: revert 6f177e5db01553276058235a81cbfcc9b2cd4e23 
this broke decoration item text. reverted.
 2015-01-10 17:27:48 +09:00
ChunEon Park 8e2647ea16 genlist: send decoration active signal to view item. 
emit signal to view item to do something additional.
 2015-01-10 16:58:45 +09:00
ChunEon Park 8cd8ea50cb genlist: fix regression bug. (T1986) 
newly added in 2955ebc5dd01fbfb5a3286b724c8a40915864ad8
 2015-01-10 16:44:38 +09:00
ChunEon Park 20a933e044 genlist: code refactoring. 
clean up decorate_item_realize() function.

use macro and remove old debug code.
no actual logical change.
 2015-01-10 14:14:57 +09:00
ChunEon Park 2f66bfc417 genlist: clean up genlist_smart_del() func. 
removed unnecessary calls.
 2015-01-09 23:27:33 +09:00
ChunEon Park 91d42b500d genlist: if the item was selected, then skip item_select() procedure. 2015-01-08 23:58:11 +09:00
ChunEon Park 54b221703b genlist: simple code clean up 
no logic change.
 2015-01-08 23:54:37 +09:00
ChunEon Park 8c5231ca80 genlist: use eina bool 2015-01-08 23:41:29 +09:00
ChunEon Park 5cdcdf5c71 genilst: descriptive comment++ 2015-01-08 23:37:06 +09:00
ChunEon Park e7ab25d3ce genlist: remove internal callback usage. 
there were multiple ports for item procedures.
one port is enough.
 2015-01-08 23:23:44 +09:00
ChunEon Park a045ca8289 genilst: get rid of lazy deletion. 
delete genlist item directly.
instead, remove the bunch of code that was related to lazy deletion.

we can success, if we clean up the resources and callback calls properly.
here i only found item focus callback that (may) required the lazy deletion.
 2015-01-08 23:07:39 +09:00
ChunEon Park 59b32785e1 genlist: send signal to deco_all_view additionally. 2015-01-08 19:50:52 +09:00
ChunEon Park 293c5dbb13 genlist: +warning 2015-01-08 19:49:39 +09:00
ChunEon Park 6a92dc4058 genlist: make up lack of behaviors in item_disable 2015-01-08 19:47:14 +09:00
ChunEon Park 51cca32085 genlist: replace to internal call 2015-01-08 19:45:17 +09:00
ChunEon Park 6f293dcf5f genlist: +parent validation check 2015-01-08 18:10:12 +09:00
ChunEon Park 94f530fca9 genlist: code refactoring. 
there are 2 variables that has same purpose.
cut off one dependency.
 2015-01-08 17:55:11 +09:00
ChunEon Park a87021aba0 genlist: fix crash issue. 
"selected" list has the eo list, not elm_gen_item.

this is side effect caused while on refactoring genlist.
 2015-01-08 11:13:02 +09:00
ChunEon Park b92ba5eeaa genlist: add more arguments validation checks 2015-01-07 18:12:33 +09:00
ChunEon Park accdefce6f genlist: + parent validation check 2015-01-07 15:49:19 +09:00
ChunEon Park 2dd465215e genlist: code refactoring. 
type check than boolean(to be removed)
 2015-01-07 15:20:45 +09:00
ChunEon Park 4e8f373b7c genlist: use simple macro 2015-01-07 15:18:01 +09:00
ChunEon Park 34732967eb genlist: null check++ 2015-01-07 14:39:34 +09:00
ChunEon Park 115bfee81f genlist: clean up missing resources in genlist_clear() 2015-01-07 14:38:25 +09:00
ChunEon Park b34df7d58c genlist: cancel multi selected items. 
cancel multi selected items if the multi-select mode is canceled.

@fix
 2015-01-07 14:10:18 +09:00
ChunEon Park 57bf376c91 genlist: refactor code. 
select/unselect items by using common select function.
 2015-01-06 20:20:19 +09:00
ChunEon Park 0e939442d0 genlist: use macro as possible. 2015-01-06 15:50:30 +09:00
ChunEon Park 1b2401849a gelnist: unswallow makes sense. not smart member del. 2015-01-06 15:46:35 +09:00
ChunEon Park fa6e06a450 genlist: keep the item class as given argument. 2015-01-05 22:17:12 +09:00
ChunEon Park b79e3e4ffa genlist: Fix genlist index get bug 
Because not all item block have "max_items_per_block" number of items in it's block.
So the calculation is not correct when items are added & removed in each block.

Anyhow, we need more efficient way for this API because genlist uses inlinst.
 2015-01-05 20:43:58 +09:00
ChunEon Park 3695c3c0b3 genlist: add some comment in code. 2015-01-05 20:21:26 +09:00
ChunEon Park a898ca295f genlist: use macro as possible. 2015-01-05 15:56:27 +09:00
ChunEon Park a831b625b9 genlist: use ELM_NEW 2015-01-05 15:55:39 +09:00
ChunEon Park e608c88448 genilst: unselect items if the genlist select mode is display only or none. 
make it behavior same with elm_genlist_item_select_mode_set()

@fix
 2015-01-05 15:42:22 +09:00
ChunEon Park a0b170c2a3 genlist: unselect item if the select mode is display only or none. 
@fix
 2015-01-05 15:37:41 +09:00
ChunEon Park 28ac4ffe65 ggenlist: code refactoring. 
don't do anything if same mode is applied.
 2015-01-05 15:03:37 +09:00
ChunEon Park f3efe45e5e genlist: remove useless deco texts. 2015-01-02 20:18:24 +09:00
ChunEon Park 30a74e27da genlist: + null check 2015-01-02 20:04:55 +09:00