That needs to be done in other way.
Revert "From: Kim Shinwoo <kimcinoo.efl@gmail.com>"
This reverts commit 9d6e461366a0eb208d75b0a1fb5c0c822b761c71.
SVN revision: 75836
Subject: [E-devel] [patch][elementary] diskselector - select option,
disabling auto selection. datetime - show even number of items
by default, an diskselector item which is right in the center of
diskselector is selected automatically.
and if the item style emit elm,action,click signal, the item is selected
also.
so there would be a case that item select callback is called by two
ways.
one is clicking the item,
the other is locating item right in the center of diskselector (if
number
of displayed item is odd, then after scrolling the selected callback is
called always).
because of this reason, datetime module always set number of displayed
item
to even number.
to resolve this issue, i add a api to enable or disable default
behavior -
the auto selection - that can be found on the attachment.
moreover the second attachment is for datetime module, now the
datetime can
show even number of items.
SVN revision: 75820
Wayland windows.
Remove x11, wayland, and local bits from cnp init.
Fix up elm_cnp_init to not need an object anymore.
Add missing function prototypes for the wl functions.
Add an init counter for the wl cnp init function so we don't end up
with multiple event handlers.
SVN revision: 75816
Hi All,
Please find attached elc_naviframe bug fix patch.
Change description:
Generic text parts and content parts signals not sent hence UI not coming properly issue fixed.
Thanks & Regards
Shilpa Singh
Signed-Off-By: ShilpaOnkar Singh<shilpa.singh@samsung.com>
SVN revision: 75803
Hello all,
In elm_index.c, _item_del_pre_hook calls _item_free, where it->letter
is not set to NULL after eina_stringshare_del.
This will cause invalid access later on. The attached patch fixes the
problem, which is reproducible in my code before the fix.
Please check if this makes sense.
I am sorry that I was unable come up with a simple test app to
demonstrate the problem.
Thanks in advance.
Brian
Signed-Off-By:Brian Wang<brian.wang.0721@gmail.com>
SVN revision: 75723
Hi,
Attachment to the mail is elm_segment_control patch.
Change Log:
1. Generic Text support to segment items.
2. Generic Content support to segment items.
Signed-Off-By: PRINCE KUMAR DUBEY <prince.dubey>@samsung.com>
Thank you,
Prince
SVN revision: 75719
the wayland engines).
The focus handler which traps key events needs to listen for
ISO_Left_Tab also (which is what xkb reports for Shift+Tab).
SVN revision: 75618
NB: This is done because of the way slider handles the popup (indicator).
It is not getting trapped in the evas functions (or rather, the popup
falls through the traps there) so framespace is not accounted on the
popup, resulting in improper popup position when run in wayland.
NB: This is the only widget known to need this.
SVN revision: 75546
evas_object_resize call.
Not sure if this was a fat-finger c/p issue, or just plain
blindness/stupidity. How this remained in code for so long
without anybody seeing it is beyond me.
SVN revision: 75544
impl that manages copy & paste within a single process... this is an
example of how to implement cnp for another system and as well covers
fb cnp.. so terminology in fb has cnp work now :)
SVN revision: 75533
Previously, if you clicked the icon animation test if would appear to
fail as the window was being created with a 0 size (and never
resized). This just makes sure that the window gets resized to
"something" so that it will actually show up (rather than a user just
blindly clicking the test and wondering why nothing is happening).
SVN revision: 75525
Subject: [E-devel] [Patch] elc_multibuttonentry resize patch.
Currently, there is a problem in the logic of getting the size in the
MBE's
box.
For each line, the height of the line is calculated according to the
biggest
item's height
and is applied to the box size, but problem occurs when the newly added
item's height is larger than the one before.
For example, when the entry is located in the front of the last line,
the line's height is determined by the entry.
When the button is added by the user's input at this state,
because button's height is larger than the entry's height
I have modified each line to have the equal height.
SVN revision: 75453
Dear, all
I've attached a patch that fixed the memory leak.
There is not a free() in _del_hook().
Please review this patch.
Sincerely yours,
Jihyeon Seol
Signed-Off-By: JiHyeon Seol<jiheyon.seol@samsung.com>
SVN revision: 75439
Subject: [E-devel] [patch][elementary] * access *
Series of of pathes from kim shinwoo. looked good to me - so in they
go, finishing off some more access mode to be more complete.
SVN revision: 75415
- swallow: do not use magic constant '12' and assume it was prefixed
with 'elm.swallow.';
- text: use part name and now always 'text'
SVN revision: 75338
the case of resetting the wayland cursor image. Fixes ticket #1293.
Increase the size of the event rects on the border theme to allow for
easier resizing.
SVN revision: 75313
Basically, we will remove the frame when going into fullscreen, and
readd when we leave fullscreen. When we remove the frame, then during
window redraw the appropriate fullscreen size will be calculated.
This allows proper fullscreening.
SVN revision: 75294
text into it. Not sure who the brain surgeon was that thought using a
box here was a good idea, but their surgery license should be revoked ;)
SVN revision: 75258
Since effect is hardcoded as page, instead of using the selected
for interaction (using radiobuttons), it is better to make it clear.
SVN revision: 75227
set it all the time themselves for read-only use outside. :) if uw ant
this u have to accomplish this another way. eg table with genlist PLUS
invisible rect obj at the same cell spot (0, 0, 1x1). and make the
invisible rect have a min size hint. table takes care of using the
"constraints" of both rect and gnelist then for sizing. :)
SVN revision: 75044
next/prev item - needed to add a feature to scrolelr (and accidentally
also to scrolled interface too :)) to make this work. now works.
SVN revision: 74969
1. on shutdown it calls lots of selected callbacks as it delets items
- wrong.
2. segv waiting to hapen due to list management (brian wang report).
SVN revision: 74956
Delete requests where not being called when the frame close button was
pressed. I know this is not the 'ideal' fix (which is why I left
myself a FIXME here), HOWEVER the Ideal fix would mean breaking the
Feature Freeze (and potentially API), so I will wait until freeze is
over for that. For now, this fixes the 'bugger' in a non-instrusive way.
SVN revision: 74946
resizing.
Previously, we only changed the mouse cursor when the border frame was
actually clicked. Now we can change it when the mouse moves over the
border/frame areas (like in X11). This adds a callback from the edc to
know when and where the mouse moves (with respect to the frame border
only). (IE: When the user moves the mouse over the bottom portion of
the border, the edc will let us know and we can change pointer
accordingly).
SVN revision: 74925
and "focus-out"."
This reverts commit 1bb12050b9785d47e102b4a3633210316d408f0d.
Conflicts:
ChangeLog
NEWS
Cedric, this is just wrong. The *on_focus* smart function of the base
widget is now the central place to handle focus in/out events.
I'll fix the spinner in sequence.
SVN revision: 74853
Widgets having internal panning objects won't have so fancy inheriting
schemas for those very objects, but they should be fine with
re-defining their own, if they want/need and overwriting it in their
smart_add()s.
SVN revision: 74682
item style "full" will have a single SWALLOW part that covers the
whole item. This is great when you have more complex visual that do
not fit a standard style yet you don't want to create your own style
for it.
SVN revision: 74665
Subject: [E-devel] [patch][elementary] ctxpopup, focus-chain
i'd like to raise an issue about focus chain on the ctxpopup. the focus
would go around only in the ctxpopup. (IMHO, raster keep the previous
popup
patch. so definitely!!)
but.. first of all, current ctxpopup does not have focus_next(). even
though there is focus_next(), it is not work properly,
because the parent of ctxpopup would be a widget which does not take
care
of sub objects in the focus_next(); such as elm_list.
(every widget can be a parent of ctxpopup, if the widget is enough
size to
display ctxpopup. thus the elm_list can be a parent of ctxpopup also).
anyhow, to resolve this issue, the patch uses event() of
elm_widget_event_hook_set().
the ctxpopup item is equal to the elm_list item. but the focus chain of
elm_list does not work properly.
generally, we use 'Tab' key to move focus, but elm_list uses the
(up,down)
arrow key moreover it is not a focus.
if you want to check this patch, it would be better to use
ELM_ACCESS_MODE=1.
SVN revision: 74650
Subject: [E-devel] [patch][elementary] dayselector - focus chain, and
about accessibility policy.
dayselector does not work in focus cycle because there is no
focus_chain().
because dayselctor is a child of Elm_Layout_Smart_Class, so it is
enough to
use focus_chain() of layout.
and.. very carefully..
i'd like to raise an issue that currently visually impaired person
should
be obliged to click(tap) quickly two times to activate widget such as
button, check.
the implementation to check 2nd click in elm_access is great. but one
single click is enough to activate button or change state of elm_check.
moreover some widgets like dayselector which has customized style for
elm_check does not work properly, because they do something at signal
'mouse,down,1'.
SVN revision: 74649
Subject: [E-devel] [patch][elementary] naviframe - focus chain, access
i have attached a patch to fix focus chin issue when the item title is not
visible. and to add accessibility feature.
SVN revision: 74646
NOTE: This improve calendar performance quite a lot, but a better improvement
would be to populate the object when we really need it. I don't know how to
do that in current Elementary source code. Reason for another expected massive
improvement is that every time you set a property on an Elm_Calendar trigger
a populate and that one is costly (Around 6 populates call per Elm_Calendar in
our code example, meaning doing it could give us a 6 times boost...).
SVN revision: 74553
Subject: [E-devel] [patch][elementary] popup - focus chain,
accessibility
you would be in rush because of freezing.. but there is still hot. -_-;
i'd like to raise an issue about focus chain on the popup. The focus would
go around only in the popup. (IMHO)
but current popup gives a chance to get the focus to other widget which is
not in the popup.
please check the attachment which has accessibility feature also and give
your opinion. thanks.
SVN revision: 74467
initializing text parts first. Patch by Bluezery <ohpowel@gmail.com>
On Thu, Jul 26, 2012 at 2:29 PM, Bluezery <ohpowel@gmail.com> wrote:
> Hello,
>
> This patch make genlist free their text parts when each item is
unrealized.
> Before this patch, the item is just cached when an item is unrealized
> and the text part is freed and set by other text when the cached item
> is realized.
> This improves scrolling performance with very long text because this
> can reduce needless edje size recalculation time.
> Please review this patch.
>
SVN revision: 74413
This fixes "elm - genlist decorate all mode on and scroll - garbage
items left around."
Note: Do not manipulate swallowed items. Unswallow it first then
manipulate it.
SVN revision: 74412
Subject: [E-devel] [patch][elementary] popup - getting proper geometry value]
current popup does not give proper geometry value,
evas_object_geometry_get(popup, &x, &y, &w, &h) gives 0, 0, 0, 0.
the patch resolves it, but it would be not a good way to get geometry
value. which is the best way to set obj->cur.geometry.x(y,w,h)?
please enlighten me. thanks.
SVN revision: 74409
- fixed theme to look less like an arse:
- overlap theme is translucent
- naviframe title visibility toggle is now animated
- item pop/push animation now applies to title area as well
- icon without title label is now centered (see Naviframe 2 test)
- title label and subtitle are now centered among the free space, should not overlap buttons anymore.
- title will use a font-size range, trying to not overlap buttons anymore.
- title will use ellipsis, trying to not overlap buttons anymore.
- prev/next buttons do not have a fixed min/max size anymore
- emit signals elm,state,title_label,show and elm,state,title_label,hide
- by default the previous button label is the title of the previous page
however by using a regular elm_button with an icon and long label
exposes a bug with button theme. And there is a conceptual issue: if
the previous button label is too big, it will look horrible. We should
have a maximum size that, if reached, should have ellipsis. This
should be a different elm_button style, with
elm/button/base/naviframe/back_btn/default being an alias to it.
SVN revision: 74403
back button now uses standard icon "arrow_left", and provides a "Back"
text that should be translated with the application.
Then we can define the elm/button/base/naviframe/back_btn/default as
an alias to the default button. If a theme wants it could still
provide an alternative button. IOW no breaks.
SVN revision: 74399
In real world it's very likely you're flipping to something, back or
front, not randomly flipping around based on one button.
I'd say we should deprecate the elm_flip_go().
SVN revision: 74360
whenever we "go" flip while flipping, we'll enter an inconsitent
state. We should detect where to flip and flip back if required.
Test: go to "Flip" test, click "1" button twice, before the first
animation ends.
SVN revision: 74359
Please review this patch I don't know the intention why did someone add this flags on mouse up in scroller.
Anyhow I tested and works fine.
SVN revision: 74334